From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023114.outbound.protection.outlook.com [40.107.159.114]) by lore.virtuozzo.com (Postfix) with ESMTPS id 37C3B80E7E for ; Tue, 3 Nov 2026 14:05:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kOTr4HDNNBC0tgb6/MbamfgbO/N2dIZmLm/jSdnMGs6KmgsQGr1GDkn4WHk3YcRntuS1UPiw9M7+YpkLgy0jcnDDvaBsjAfBZpSje4upfmFyQtGWQlmggSE8eY3BqwqXHMtGCh9EbapX+uDxHWp0f2vR89/FFCbHQE74w10DJLlOaPIaG8YX5lL3HqprdFbp/+bVBEPKrr7YBWoWueHquLboaEXzqWaxKEX5VckoQJKsSBAuulvsdqWI6XYLHbkxTol75Og0C8v0NIOJLHPH6geVbdOF4l70+7E9KXgTHeRn6kO4/1sEccFpqrUswFrB9SWyydFd5Ie5+28pbqjdvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAom55P6MMNUYBBwjRtZrYakDCDtuzmrynvZOXFohuo=; b=SmIpXSgUjjrdqp4lTDVQDCqxTljoqWnypd/S66KybnwyDKNuC69WeUOXN9kS6UfK7s8YVk0iXfFfXydGAPnQJlNSxTE/4AkoIShbVnxtnJ7VtC4DZ50h6R3+CR56T0ZuPc9FctzUpYvOwlhlsyLjcUPmgKVgIHKpFD0/ruYhgiVfsHpzQrqUZHzXUTN2LuAjj0KcJ+rYXJ4uFCKyy6oYT8i4uCt95R+CkoLzpHGlPwTXFCrBYHBjCDa/4zEBtC6IDLMc2dmGcHSE2b1rXXEIXJZ1ylgR20uP8FS7vykGj5KItAPUmCMHXMmWGHMBCGft5htyrw7eEbTA8lAgXh0HYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oAom55P6MMNUYBBwjRtZrYakDCDtuzmrynvZOXFohuo=; b=VHpYT6cRSM0d9L10uTzm2rAldVvF7gdHUkkQ2n24sgKwYrb8JlfSRZr5WImzJnVprXyJOvr75328oOOI1o0uWbZwnuXTydhd9MKNMJLYUy94ipId0wnuCKLYrmB9LfA5gc1bZCmMrcrgo7OdCZnVr0NnFULfApODe0bNr62BcMk= Received: from PR1P264CA0089.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:345::16) by PAWPR08MB9615.eurprd08.prod.outlook.com (2603:10a6:102:2ef::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:05:51 +0000 Received: from MI3PEPF0000855F.eurprd05.prod.outlook.com (2603:10a6:102:345:cafe::81) by PR1P264CA0089.outlook.office365.com (2603:10a6:102:345::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:05:50 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF0000855F.mail.protection.outlook.com (10.167.240.27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:05:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714750; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=/HvZW1fe4+lcuL4bA5N7xGxdGLzHwx342g3FIuw+58Q=; b=lrG7xWbTRfV6bzGKoy/53Qkvy5w+BcyDBwQmtt5ahSCCw+6OiiuX5rpERiTlEaC3 Bcbk0kPp6O/Imo0wo2PmRZa6V/wlXqxfNSbuZuPak/ZDSR/Q4ytUG32MA+hZY0Z/Js1 9AUbD31LpjiKYWYJ9Clrm74A+qq+5knFjuBp3xLfEamDd5ZMpJwp3sY7F+URBDNkaUi JukllOTbzGYKI8lj4DBT3fc2aOs7I1bO+Cxir99ve6jvJ+Qu24o1Ezz2JFi4cBkE25r ZnfwD/6LAyGcjg7JPHjvB3OkU2NSm2pGWhTgZzGBa6gHWOzoy85cBJJWJDIgLuNpktU emPeHGqhuw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714750; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=/HvZW1fe4+lcuL4bA5N7xGxdGLzHwx342g3FIuw+58Q=; b=nmpxiwFR5DpnWJ1BnppTVEu2HZX8lmNP4PIc68+AO/QcGuXqvxkblzmJdKR2z/GA 9OIPOvVlJ92fThnOmke+RxIcl8zu4l8vwGRhzQwyd7ZgwwEnNFyvUjPuE2ByG/iEWC3 IQMTuuLI24MPvdDZxtTSBfk5GwQ0vYFDaRI9SlLA= Message-ID: <010701a1a1bb0365-6faaf151-2541-4a83-bf38-936a5e528d93-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 10/35] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-10-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-10-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:05:50 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855F:EE_|PAWPR08MB9615:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: bc244b49-fdae-4198-7b29-08df39b39132 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|48200799018|9140799003|376014|32142699015|5063699009|261021121427099003|260925021911599003|260925022911599003|260925021311599003|4143699003|56012099006|261028144727099003|261026140227099003|261022105027099003|261022075727099003|261026121527099003|261009223027099003|10067099003|16102099003|55112099003|18002099003|22082099003|261102123227099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: LsWyZ9Fagzi/44HfVynY/i1pFC5HZB721UoDhMVvXXAJjAhYztqJkKvMKhqobuBNLyfnoYBI71oYMIrKaFs7/PscyTZDuzCkZQlwTHOAHz9BQsjbN6D82eBIxJwshbn0TNdrfS23oOlN3rFaFBYPgA6cDHWli8kKZWt0MGdMuC3p5i9OHH3Rrbr1o+Yyhg/eZOyRBTecLDYTeZPKcWZioj7GrlpZAYUAuKcT3suSpCgWLeh5NqyofyUHTTkyvc1y7/9EmVPxaUmFUFMBawgEk0p7+CYKl5Cx3QME+PFFzCsLhrqGbFdBNI+6KL82KVGI49D/Ocfmfn+OVg0zzrAe7ypYVkJO6jRZHurxblmdTFDkGdWgaapsajV4c0foKmv1ll3apgRmHmaXY+9U+rvmrKOvt5xqcKsh3+d89qfTicf+HcRjZDl3CAxHdarLdKgQ+PZKCMLPkxzdFJ7Cw95a3IakPGv541NzUTUqd1Mx/H3tINe0n5l7m2rxq2rEA1j4GljtuePHEkFvDuvVuwforYXYUy0T1dv1eUv8lGlGyQC71GN2ZsQeLhbdY+Ou3VvfZ/5ZMUOBAZDYrAcN5mkdSYswDHSvt8waLTjl/e0vvMYjLdp78/rcMg2OQ2bCmuzWsBY5PUD1OKkD2K3uWZwMU586NoqVkkUrT5SzzAVWoGGsD74YRGk1TLLE6HXDrITa7qlE34HiWreWpwo6SEeUtMAnq68YU6Z4LmKDqvLWpWAHPo0TXzlLZxyHfbwYGMQDmqsBQjvUxAu9kxe/HQ0DOaT0YMG4MU1Sj1zONKFFq099J2LkY13/VcGTfaVC9qriBYHO07BP7DJitSP5WOD8S2JoT/McfSHkHhShQmlZhBUfG0XQEvIXpQFYdH7dRDoFzB87ypDO7YSftdS4sIFdnSUaKBlv4EoLapEzYA/sWQY= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(48200799018)(9140799003)(376014)(32142699015)(5063699009)(261021121427099003)(260925021911599003)(260925022911599003)(260925021311599003)(4143699003)(56012099006)(261028144727099003)(261026140227099003)(261022105027099003)(261022075727099003)(261026121527099003)(261009223027099003)(10067099003)(16102099003)(55112099003)(18002099003)(22082099003)(261102123227099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rd0+mcw0YG3rD/NaabAtaI66ADiUDw9gzqTVR7qDxm88ckjc1ffrWBuKT2THdeh9uquk3dP6JhyUjhk+rzeGZIHYh+bND0NQh4cbYq7kiYaezMYXY+aHQNueQvrNaXPzQvL8lE07Dn1X2XBpjfX1gyXlC/2C2Ay7yZlKwbiLzzsoZp7ZGQFSeSjkz1RxpwDgH/HblkvhXa3WVeUdnuuwNmsTBn1f0DsujXK217l/76RLJQRQB4VPVIItTqAzo41liJOWQq46Fa2EHunHvCb0RaS8gQmFFNubrAwkiN7zYd6VSXLdRNjSnFtyMGNf19Sk6yWdkvSGMOKODor7CyYH4gGCR0lnaexlRgt+qpbzGbzP0NvO+9Pnvk16kAIhvZDAkiZegEFQ5Ru7IKUu5ODY8whi1Qla9orII9QuZ+NFhXLxiXVGMiXmDLWSF+s7vPIa X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:05:50.7056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc244b49-fdae-4198-7b29-08df39b39132 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855F.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9615 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D10