From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1bb9146-c99e8568-22c0-490b-8c70-4ec0dd36c6e3-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023111.outbound.protection.outlook.com [52.101.83.111]) by lore.virtuozzo.com (Postfix) with ESMTPS id A69308045D for ; Tue, 3 Nov 2026 14:06:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iKRvJaewYbT8Eq3yjQH0X0JNjAfSqnw+6bEWaVuvEVU52wHWPZI6nztxHxizQ3x/UmBVPerav1NpM5UaVwqrb5vWAHK1iirO/lOWS/lOo3I4p6k4hY2ynHdobxpK4wZkCcRLiYMJDowETITkvpyiujVmk1n2maAhHDvM803WJou9v3YLKtDf1LVrTwprhEGGJSKA7OjMMOqaM1VhO1WpIzpErfuAc2FP2qwnDi+hg3nQtL9fGAZHXSrhPneQG3+aB4x0XYB9l+Uj6DORo26a99KoWhs1fRDmuzBBE8Rvo3sjI62cnBt3ltmHoILxRyrhMnEhV9e0vqSBc+Qp9mgI1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKK42VZITXSBpPIUinboLm9SgdI50/2FDDu5IvRa4E0=; b=XoVfiKpgg+hH6++Lb1u006KtO8FdLXMWUqCC+jR4OmBguK8QWYZGUBjEadUhHapgR2ceofRq4x/eq2Re/mMGqfaS+QRNCtduMEjb0Oo4xDSJymlC1AS8PcCuE3QjCR/Armx2ljBOhq2/IbIeHXpWKKQhUIQytSjf3ERsRir96o2MC/gTycIxHDoIng72O4FFW/O05cigBOVNpXMnw2U036Up5bZL/rrNC8Pi67NqTr5YBZnB1H15WkrYs5Fq2g4OnbJB4yL0GAU1J9XxY82meXzm1A2xV5gkxuT3a6z7YteIr02p8v+RKleg3+3sfRV9pWDJQLZmZwZebjDciy6v1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKK42VZITXSBpPIUinboLm9SgdI50/2FDDu5IvRa4E0=; b=jg5RYDnNXhZkeE9awfEb4FeDMNl+1LzBVQZclROB4yH2+b8pY5VhP1YyYDL1Aaj7lSw/u4ZpkYTzNSLjT+eaVcLinyN6kcqMMtk7/1yhMwLDpZL7Dod0nr3Z/nGjCEh9Ehm+PaRtQ08RbmtzhSfhFvf3SkTWx74vStSxb/KcVxo= Received: from CPCP307CA0006.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380::8) by AS8PR08MB8086.eurprd08.prod.outlook.com (2603:10a6:20b:54b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:06:27 +0000 Received: from CPH1EPF0000052B.eurprd05.prod.outlook.com (2603:10a6:380:0:cafe::53) by CPCP307CA0006.outlook.office365.com (2603:10a6:380::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:06:27 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by CPH1EPF0000052B.mail.protection.outlook.com (10.167.241.166) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:06:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714786; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=h6Ddb+TaUjXWpI1yZo9eJN+hoSv/5faJnPW8SHWQsqw=; b=S4ny3Ukykw8SOORtn6966AHc1mhStvuc2rWYDzwD6beBM5VocxCpYjegmQk/clwT jIByc5RNOJKTf1x0Fnqtmu05VfHSLK9R6WTeXZN+Co6Xcc397zI/8jA3nNLb3n5lXn3 xhxkohhd92Kz0dUt6HF6BzoBL4U4ifwtiRmFD3ltwxL78T1/IK9BH6FKMWWCNmL2aUT cFJMKB8xy70eUFS7xVbww536QO+HLmQeVYpoGpxi9rwNt5e64aSJrlsv/zX4Srbs/H3 lQepk4aCAaxm8uu9tVhxgxLns14QxWzdstvcNilMywuUrFRYGuojbuXWhaoWqtYc4x0 IXeVtZLWAQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714786; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=h6Ddb+TaUjXWpI1yZo9eJN+hoSv/5faJnPW8SHWQsqw=; b=jkT+zJeSs3i5QA6eRd9JO+mclZVVA4qXo7uI1XaSQnWHotP+X/vNeLE5bxQEQ6MC DfaZ8TLEkiPAOR2o6qNH6N3JIRHZIjbBihLngRMBCSJWOCYJhIPj++ZOucpKEv5JDEl HJY/PJND+WSAKxkEcdZb71YgqATDtHmVQ0/znEU0= Message-ID: <010701a1a1bb9146-c99e8568-22c0-490b-8c70-4ec0dd36c6e3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 12/35] vfio/pci: Fix information leak in vfio_rom_read() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-12-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-12-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:06:26 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF0000052B:EE_|AS8PR08MB8086:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a8dd75d4-128f-4e9f-49db-08df39b3a6e5 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|61400799027|48200799018|32142699015|376014|9140799003|56012099006|261021121427099003|4143699003|5063699009|261009223027099003|261028144727099003|261022105027099003|261026140227099003|10067099003|16102099003|18002099003|22082099003|55112099003|261102123227099003|5113699003|6133799003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cGVjMjJqQmQzbXlGRGw2T3Z1cG5nUFVqMFpOdWFsbXFVWEJVZTEwVzVodDJw?= =?utf-8?B?bFdvZkF6OWFCNWxVSDFSY1FPQW9EYTUrSVlMR3NuZG1OakZXc3JESlBhMmRO?= =?utf-8?B?dXZWNmljNk1LZUVOc1lqSXcwRy95Z1IwTXArYllYbWR2QUdtWjdMeVF3RTYv?= =?utf-8?B?WWZoY3JhZzUzN2FpTU1YRkI3N0NSMjhzU3NESkVXSGYyQkhYeFU3V0xZV2Ra?= =?utf-8?B?aVF3c0dDNzUzODFNSSt3aWlBMjBoWFF4MFp6SXZQdnVLUnNsZ01TNk1CMlBY?= =?utf-8?B?L0poamNOT1lhL2w4d0MvWGZyRGtEY1c3SGEvelJxdVR6RDcvZWpTakxoVDd6?= =?utf-8?B?dmdtOHNzbjhkR0I4OFROS1lCZHlpeVJxYzUvVGNFckpVN0VtV2kzVlBWeWJ4?= =?utf-8?B?S1N5VVM4SXpVK0JjZTlXY0l1cUs5MnpMeUQ5Y3dhMFhSRWU1anpWSUFxTTh5?= =?utf-8?B?dkFaT1c1cHEyUUxWZGhKS1orWlVPWm9VQkVPaGtVN0ZEcXFRQTFjSDFsWU9Z?= =?utf-8?B?Rkh4dHZDU0todE1JZ0hhb1hsZW9XUHRYd3FuYWpYcHplcmgrdkV2bDdSNVBB?= =?utf-8?B?SERtMGFxSm41dDE1cjVvQWU5S2U4VnZzSnh6K1piNFQyaHdzM0crUWhlM0h1?= =?utf-8?B?cW1uYzRrRU5wSlNFTlg5WTRCNVJGYXYwTnJvdmt2ZHcxcDhzZDhpSjkvMEZH?= =?utf-8?B?SUZlVGtna2paWld4V1FlQnNlZ3dRem95eVZubkpicXcwVzNaS1JyVzNsbFk0?= =?utf-8?B?Y21CZmdWQVdSS1dRYVJKOFQ2TXo2cElBTXR4THJyZUtDekEvTXhzZkJIZmxx?= =?utf-8?B?bkZsZklhc3FxMUNSZ2lQWHFFRHhBRmdmSjhKRFhiekRQSnpxT1BTZzU0WDlG?= =?utf-8?B?NndGYm9xMVBxRDROZEUvZkxYMnFHa3ZpMkxMdS9rSmIyamptQkFCcXJMQlhm?= =?utf-8?B?Zjh0ek1tUXBMc2hzWjloVGNWRTdaVUc0VGVJRmVjNGErTldLMHYyTk5PWlVs?= =?utf-8?B?dVRuckx5ZWk4RWNrUlZUck9yTU9EalNGblBXeGlVYWZtb1lJYlhGeTZSTG0v?= =?utf-8?B?SkhqdEZTdiszY0FVYXRIWFlOZU4wWndrZXdpRjBhYzdzRm8vUVlsYmQvMDM1?= =?utf-8?B?ajRiMVJOQk9zdGR2bmU4SW92eHhGc3h1dWdaK0pQVzVndXFRajZHM2xuWDk3?= =?utf-8?B?aVZNMWptcjZvNHByU29BTW1RMjRBVDVseVFQVzBZY1hZN0F6bUtKTE5UUzZw?= =?utf-8?B?MUFONmNVMnRlL25ZWDI0Zkl5K2lickx5OGdXWWhIY1JhNUlvdXRKQ1oxT0xO?= =?utf-8?Q?ASA5L5cWpGZzI=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(61400799027)(48200799018)(32142699015)(376014)(9140799003)(56012099006)(261021121427099003)(4143699003)(5063699009)(261009223027099003)(261028144727099003)(261022105027099003)(261026140227099003)(10067099003)(16102099003)(18002099003)(22082099003)(55112099003)(261102123227099003)(5113699003)(6133799003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0IRBUGSQyxcNL8ApRX0xptsy1YU6NnT+Obx0GematRc8pOjPzQmLSv0twUuYt4l3ecmQkgYqOmkeVrTzwBq2KfX1LTqtdlrf5Gt4zeR3gJuatdeN1q0K8U1lz/VcvlshIaUU+q5VRG0T5U5cFmw7BUGyg3xLF/YkwVEPqv65bU+ai3EIPFZbmzaCO7p2xhrdMwhO/yU2IHq+wH/OaU8ziiTUIlw1B2aN7S0Bj8COW7U8KVznAIWKDy2/tR4REwkGnVfRmzcXX0qw07F0+Bm84/MMA18PM1KTf1PTIllfp1WEMbDwgrMmuxPSZogSsVeqNg5vUnFUnrVz2bol0/jeLlvtKSPj33aqxRsSWon6XZ+8GYcvlTdp7UnT7NiHfAJH7+Nt359JbqLkCeleJD6JWVx8wT/Pf9ccmWYHRa+N5tH/dM+t7+TIzdcraR1Jg5wg X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:06:27.1007 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8dd75d4-128f-4e9f-49db-08df39b3a6e5 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000052B.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8086 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D12