From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021089.outbound.protection.outlook.com [40.107.130.89]) by lore.virtuozzo.com (Postfix) with ESMTPS id DAB858017D for ; Tue, 3 Nov 2026 14:07:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q2/CU6vwinNG7MZqqE3Y0iddq99HRblpUvxLXrLSJtgdBF4tlMSJDSXIEvmnuf3QbRg9BO2MpCpXg6ZVDsi7Yuq7nNA3cd53mOqKAx80V0yNZEnpAnG4HAspzGfVZR7foHwYSFRNt9R7Se5Q/C6KRg6fTRDAyie5E+2aif/Ow6dUWJKUjxeKvcMF2g+w4QPHnzz/GCjfbtCPO57KWmQSsxlBsaUwmUhpDBBBSUUEC6036Sz0Sc1/EoLRIA5hnJXAm2uLdP3H8FscGMeEewRI0/pxZyTYa0Zm+dNYjMI0A8dL/MtXP1+e2DjBBjSUVn2ge7cD0Q7zobym9fcEmSKs/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G0JuomZZfahwZt5PrVb2BgUeiLfWtGnIJnekVjOAODU=; b=EwCkZTDw8xa/dWCkHIDCMypTv9++oHDGdxvn/wEgq8WU7sUdvo5yhMBmpiC1vDgblQxOx/SSFvcaAbhXipM8QQToV++YNMiSyJgWwNENr6P3K8rDI9AZMQYRVrmTXdfU/HcufmljC/FAbWn0YCLJ1vzw66oAl8Rx1EOwrbr1pZkmlmkwkbyJ+GyNFQt8+Gf8v3AgehR53aFWah2Ai1Mf6YpgcN9aakeBJEIfmiG3tI6MHYW/3rEaocB3Mk/94cHhmcvFMiKAf4ob1uJ3PyVCK7PfzBL7LoGh7BJDOawmFDtPYjg1VapsYOs1pGzGc45N5IPbjJwZ5yyNZjUdge/qfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G0JuomZZfahwZt5PrVb2BgUeiLfWtGnIJnekVjOAODU=; b=oRdwjbDHjZcvInQZ+fRMmqgMiKZw/Si7GrlJ0lVtX3oMUaxFRf3Yh07KtaxW/Tcdll2A6iGfy1kUR5TDoUbVWEbOO83nOJWXFBp8CGyrXY8EHmNXmEOgYgU6GxilRbgSymju1cspqOTyiJ1RYkjsDiuWLFmmgzp4uq4+N0szMxg= Received: from PA7P264CA0185.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:376::13) by DB4PR08MB9310.eurprd08.prod.outlook.com (2603:10a6:10:3f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:06:59 +0000 Received: from MAD0EPF000008C2.eurprd05.prod.outlook.com (2603:10a6:102:376:cafe::a5) by PA7P264CA0185.outlook.office365.com (2603:10a6:102:376::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:06:58 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MAD0EPF000008C2.mail.protection.outlook.com (10.167.241.198) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:06:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714818; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=DACibuFr73A9AAps/K4NU+W21ChGOXs9TLT36IaVYVE=; b=JrK3XMlhHRQYwuVRCPuD5pCcT2Vj+SC3IKhl04MaWrdnWcG4/BG2bVgpQ/udi/Uy Ikdoj43dBpYO56yoB5qLvz4JIASqQv2vkC4oAJHxenAz1tA88Z96IFLdGzakC7ayZ1o +EBHVEgR3yG7aBxURh8NcRX8/O2zImMrmd5HppinLL9UBbyoyWHIP0/JZ/SaMkcQ2au XQjSsoS9WhICfbKPPzlc805R7krRq9vxP9pVOD1p/TWvNqTwaCm90YloPLZhgWCRSu1 ZvRmgr4hae2sOyxeilKCnuUvXTrATxZ9DSVB3oiMV/m78korPMjUzNhJNJEVu+ThBuX b3zL3Cnw9Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714818; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=DACibuFr73A9AAps/K4NU+W21ChGOXs9TLT36IaVYVE=; b=eLpWJMgNCqDqeZ3oY/n9B1ClVhQ+gFC1K0VKzMD/XaYbJlTTxUK/U93y5OvPGGn1 qvUg1cHSSyvG/FoSGd3U/aXL5C1nx0eQEru4+v0U9hUfSaAniZ5ARKx4zdIpSAxaUi9 U3RkmhWWj7ib9KfMuXTub/cW0l4t3CVjjFeKcA1s= Message-ID: <010701a1a1bc0ba4-654a2fc5-be2a-4c5a-8157-58990c4dd246-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 13/35] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-13-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-13-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:06:57 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008C2:EE_|DB4PR08MB9310:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: eb702078-cd79-4e15-7e5f-08df39b3b99e X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|9140799003|32142699015|376014|61400799027|261021121427099003|261022105027099003|261009223027099003|261028144727099003|261026140227099003|4143699003|5063699009|22082099003|16102099003|18002099003|261102123227099003|5113699003|4113699003|55112099003|13003099007|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: 9ZjHL1fa31GyjdO98MroLdiQfv+3F5QxMdREZiDGoE6zrloiiCOIf62qjnskc6Nh5m2UgLSr+8FqHzzDEdzFQkwH8kBvp3xXOw8bLrkCQNSaaVlt+bIBYwlkqna2SS9uoSLEJlvlPv3MXOMQ33g74cOKwIKN484xtW+Uiih4vl544beJAhivaC9nNfZoxUxdSc3t2aVgBJ61wZ94tl6gpMdA5nN/7k5QWG2jYUdqpFXJM8IsT/UXgrU5OuehB5v6ZatlZ2QfWuFtO9eU3pdYywta7/he/g+dgy0rlJ6Z/n7SdS0LPE1jHbjxn5f2SmUFSSKXlOxzlL0oOP56EpF+saaqi865bCRtYP4krEssFHocMrs9wUo4PNpWZJUXuELBUTK+NXBS6J1LgM9pMrh8sajhkzErFk+9cDODI4PromnAayEqbXv8HZsMg5N4VcwgSiLKJM2OfLWi8L+xSpq6jGSC2N1f0OzteNuZlVwqYxQoKw/H5ZY92WYELLgjMR8JU+f1d1Jo+tYmdaNPv1YRjQCiwBcP+C6H5wulluhyVPlIzaEOmjqvjhmV+Sl1nSKZkf3NQmPAuFgO2RQlAaomil3lrbtQUKBgAGtsb7HYZADrOx0sOLDYahO/dKx/WavsnuqH+QsdFD2iaXI8xGQbSVP0qEG7RNsEmGN/lFCkvX/t+dSYShBELqSTwE+K/9lMoramoJaLy8fLNBvT8vGWRMf+ocH4JXIm+nw/t8bEmMkwgdhkSez+fAVPg/yVIpBT59jo0IO1XU0gPwEUAZ4UUVlSKlsHry38HfBgNXdi0sHtIHU6mFXYf6c+S/8puKlNoGAqH0CXnyHhdhrak86AyIiAYkEIxDJe3hEyTirIQjZ6pM4dxrhfplr5i7cqiKgO X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(9140799003)(32142699015)(376014)(61400799027)(261021121427099003)(261022105027099003)(261009223027099003)(261028144727099003)(261026140227099003)(4143699003)(5063699009)(22082099003)(16102099003)(18002099003)(261102123227099003)(5113699003)(4113699003)(55112099003)(13003099007)(56012099006)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fPyj+vOGTwKaX5aREu/LhxFOVmnNMrFncWgkYQ81xYuFtvXGnpYbIGIj3bYAuBTnJPvvqyDOVxkPu8y6ygQD9elSUelY6Fpew+W6Awuq/ywYjfyo11IBj4cAKQI0j8A4HEUCWpZfqyDRdnRjdOeOiokmot00JeKnWDVD+oJSGPPFR+fHUYY9kWJsoEjmXBvPDAUj/2Hoz6fBjFWtNZEtxmnziRw+sLnU3XC/l7NOtQQP9XeDpX56VZeiYmPRZjNNZPQRpdTmZPsLTYYCRJbnMQNFoe9Zf39uXiquyHkCDciJ0JixpDc++CR5f9fi4TUHTXN7XSs4tDu4Tat+YrCHhJ1wbaNryab0yBRrgxuMv1YX+8wjw+eh9YNFqkHd8FBfms6mDyX9hDUZ7aeqEJ9+Ao4ZicSZGvLw9UUgH1riCDeu7XQhQigbA6lWar/tfwyK X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:06:58.4574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb702078-cd79-4e15-7e5f-08df39b3b99e X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008C2.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9310 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D13