From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1c032fb-630b2fe3-cf8b-4486-8ca7-1a12eaa24659-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023128.outbound.protection.outlook.com [52.101.83.128]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6226D8017D for ; Tue, 3 Nov 2026 14:11:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ni13Y9EiaOoA3gqAKQmGz28s3y4mpQGnoXg66WZ2bhENQCOjEj8IWYHfpg+ywPCGdUwsKgVrm4kiaFK2GNyRJfRnc9G8KGLIw3NOK1844CmPk2DxbBmEng8tU5Fuzsy4I+IzCaGcsEKRNhnu/EL7iUnOJKrWqbZkgIvddbUDDCoATWstZq7cuhldH3decq6SR4VUdkaB/ArKaoxX08z7WeanXZX/lnjubB/CnoGBa8yMovZETen8ovCHvexrfq981miM4UyX/QcnMxKH1GobZRLbbMTdxoTGTUrp3McTgMU50M8mSQRaTPn/ZNIc59Qd3lkU0pzBgYWUYJktff0VYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNQBeWjT5G5jB8MFuuOcPY5IPRNtONJMPUqEYzLj9T8=; b=tCBixt2h0OEWvZvIa3twC4oCV8P8CZ1FwC1mdOGmKEa1QRv6ZqMnOL0gb4m3Qo3f1OtEmIWua81MHeerPfwR6sSigX6gnE7m2s5YzzkUiapRrMxWrnPnDcQRij7SFCKFKiXMuc+6OnPjrOkdBH/3+2W/HEsKLEWiLlhzuF0787gCVxuG3jDOi4WTc0+pUPegl8A2Md5cMSgWZmVmNMA4u7zDRMgODK4JKGDK1tKp96mDzWXEjdUuXzHZRFAuigyfbWGb6N6MW0Dj8ZMkda+QkEbBtTp9e56MpMxi86bxM07GRlg39NzzgoQgSBBOz5ucXIweiB3Tpl9iiItfGjLWLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNQBeWjT5G5jB8MFuuOcPY5IPRNtONJMPUqEYzLj9T8=; b=Gyued0/DzGAX60onpKI6Q376EFlF2rGXITlueA7t4sdkpy9SH2DG5E3eWkSaawzyu3HGpYcEXf8VGXM8Ogx9uJ1A8fTD8AvqXSwM44k7qJ3H/QgNbqqbyTQFQcNY6Ib37+YACuVI6sre6FH1CbNH3aw19AkGFdZbxR5UTjkUmQc= Received: from PA7P264CA0427.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:37d::11) by GV1PR08MB8619.eurprd08.prod.outlook.com (2603:10a6:150:83::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:11:31 +0000 Received: from MI3PEPF0000855C.eurprd05.prod.outlook.com (2603:10a6:102:37d:cafe::96) by PA7P264CA0427.outlook.office365.com (2603:10a6:102:37d::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.7 via Frontend Transport; Tue, 3 Nov 2026 14:11:30 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF0000855C.mail.protection.outlook.com (10.167.240.24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:11:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793715090; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=2pazIzQXK5AxDsoBoXjpT1eZ+mnXZXIqKoU5WIjOwyk=; b=b4BmHCGQVwgLHi8tLkn8lP5HVjd54LKKuwTnDtQXhEAjXRqLW7pLOz1v60mNwWg+ UIua3WZdFjheu/Ew3OFWK4DrW7FY4aaonT6SS89DfDSgpkWYuijUMXCdrfl+2x/DcFM F3w/FYt3n09mFOCdYy1nYOAOBEYsiQH6OeEh6hRg8keTuI06+sbnJIFo03kZ7M+TnFG iQoFcxHNo4V6R3ALADvj9gm/0h1vCPF6LeaXP37UDwLvcIXvowONHGw6Ua5KCG8OVkq /bc9EkAnJ2C0Aj5wKH4Sd7kovPu6UqeJfHeWdgxPYZatrMIgTIUK5rh0sr5S8CgF4IM LZTEs26jtA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793715090; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=2pazIzQXK5AxDsoBoXjpT1eZ+mnXZXIqKoU5WIjOwyk=; b=jfHyqu7H7Acvb4IwcKztf306Kw4QLllku2IqEUnrZSWdbfSWqLCe68ReEzPyKPO9 v7zAqRQkuARTiFf6r5Ptp+90h3FNm7W9Y1z8sIchDhaZuju4coGChRTaYV+z7ddoTzY Mpu39bxheYxMz6/fnVETU9XzOCK/f9aM+Jamxum4= Message-ID: <010701a1a1c032fb-630b2fe3-cf8b-4486-8ca7-1a12eaa24659-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 17/35] migration: Fix regression of passing error_fatal into vmstate_load_state() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-17-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-17-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:11:30 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855C:EE_|GV1PR08MB8619:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8f712dbe-5657-4156-510f-08df39b45bce X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|48200799018|9140799003|376014|32142699015|5063699009|261021121427099003|4143699003|56012099006|261028144727099003|261026140227099003|261022105027099003|261022075727099003|261026121527099003|261009223027099003|10067099003|16102099003|55112099003|18002099003|22082099003|261102123227099003|5113699003|4113699003|6133799003|13003099007; X-Microsoft-Antispam-Message-Info: z4y+f8GHodxqC+AMi/RfqDSk6Axy1b+9g4pwQ4yRgX/IdQB5gdmfMHJos08kHjQP1v0xaxEeU75bBMuFQShdUcw1V//Va/OrPYe7PyilSS0n0Hi6Xr12PfhOrIFhpNiAjDGgbJbX8AeLJeOOH2XN2sfUK8V4cdSMQbqDv0sriAf+qI6bhgKNuwApa4nt+Vc98k6RC5PpH3bp5aX5i+I9tBC54B4M1BKVNDm89OprY7CNkJ3WlFKStWx6M0bCiHmqn6gkkPE3QmAZbUIUmAYvA4HLu0kOM5dQE/hekit4BEZDh+z/mkWj3vMwFOTbPq0YAeNl0cle0Cwl+riJmGmZB9uAAsS1W33WtUUxUtuUsQs+MIfF2zaGE4IvOg7svfvphRayaHJPiBvFCUdjwlClfv2RXP0mw605leHHunyZmvoxkeIynqowzhMb6mL3SZFD4lnkSLTU6keTuoFFcOCCmLkyafBtfiA0Cc+iuVViyG6xqbbABAM2QA3wCZBi5jklrhjG4OF2qpKCUUQw66YwMl1ZKD+QLgNJ04MrikvhgQGpFrq0w8RFDb2NlLF0UqNu396C68okkWlUX2YggssurAm8IAyBm/VtbY8Q8++m7yS/wd4KAWB83UWZXANdbQxSQBVK27hQ4S4g2lPETn3ZARv7EHpXU0Typ1SYpGhjqfytmEhXQ4nxwYUO/JX/Ls3jD9xgIBH/3i2eSCv+ntVkllYOKh87UfCuid8EV7MQZVyt9zJNpXdN7vxYQvS6ouks4VvRbVvktAaCalZ02h2w5BVBDYW3xRWQsa2W6OYVECp+7zBFs80T6BP0sjzZzjay06Q49q9jUYd4tZMevvTFgaAxKpvO+lybw5QNNECPnZ5NnmyLrjNwek8JJZeMSUt+QTFXmWTwEVEUgaiF+Pe0uwfYGWVAQ17Y6h3QMYmOoBY= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(48200799018)(9140799003)(376014)(32142699015)(5063699009)(261021121427099003)(4143699003)(56012099006)(261028144727099003)(261026140227099003)(261022105027099003)(261022075727099003)(261026121527099003)(261009223027099003)(10067099003)(16102099003)(55112099003)(18002099003)(22082099003)(261102123227099003)(5113699003)(4113699003)(6133799003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i1kHtVVS/meDxn5v/+CTf279BzZDeYY1fbZYhYb8F98a9EddJ4p0IXQJrztQhNcIpigUaOD/ifWei5auOuLj+X6j/iepu0st++/Ri3mHm0LEeIkIq0FwlrpGkdvPjQF0CVT9TBFKmE+AQhiImOGfJVfEiGqDEbAgwF0TFaFXOYo8CyFKRj5+/jydtQSMSXB38RohZzLybHAv1b85AuXX0wTBhh4v3QSuZfaZ2zoP08W3ZO0YU96lhZCP++/GFiE3biBgUCheQztWhicGSu2DbrhGsiWlRGxVnTjuluGJJwENH0BZNWjzfTBsm71+h0/o2HdSe8LFMZwSilnTYLhhTu7hRu+xgBiZJR8YCubz8ZCkThhpFgRKPYMI9tRrOC3UL7At6B2sG5TpASg7kibMY3OEYQFoiBmLl/U0bZKBuARoA5hxVi9EiiBOu9gH7bqN X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:11:30.6181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f712dbe-5657-4156-510f-08df39b45bce X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855C.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8619 > From: Arun Menon >=20 > error_fatal is passed to vmstate_load_state() and vmstate_save_state() > functions. This was introduced in commit c632ffbd74. This would exit(1) > on error, and therefore does not allow to propagate the error back to > the caller. >=20 > To maintain consistency with prior error handling i.e. either propagating > the error to the caller or reporting it, we must set the error within a > local Error object instead of using error_fatal. >=20 > Reviewed-by: Cornelia Huck > Signed-off-by: Arun Menon > Reviewed-by: Akihiko Odaki > Link: https://lore.kernel.org/r/20251028-solve_error_fatal_regression-v2-= 1-dab24c808a28@redhat.com > [peterx: always uninit var ret, per Akihiko] > [peterx: touchups on line ordering, spacings etc.] >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 986c3292c6b8, > adapted for the hci-dev base, which predates the upstream commit > bcb536cabe10 ("error: Kill @error_warn"): virtio_gpu_load() has no > 'err' local there yet, so it is declared here. >=20 > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D17