From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1c0975f-84a014b1-1dfc-420c-aba4-580048841395-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023134.outbound.protection.outlook.com [40.107.162.134]) by lore.virtuozzo.com (Postfix) with ESMTPS id 47F0480E7E for ; Tue, 3 Nov 2026 14:12:00 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z4zWAummqoV2SVkBiWDn9kMDRWQ+ixd6gDEXm4uP02IjKtYWV2FJHtr3WI+s923aB7TRNw9WUmKkGkeAsThKeTHS42FjO588NXlQAxlVwj1mVQdvH+6WezkIDfOa+fiErnuKqik156v8DcELG6QcX9k+W3mAxfzGeDsFcQNkkMyJMlFMB6C5CYAHlc4EzAki3MTdCJqtxWmt3nEbYUys7Pr9UD7+CnoKML2KIJpGY5+cHv1rUJ9N+xBr7+mjwRaE3rLA4vCfhFq6nyRBVSel2SeS24b/7rGnwkH+A2V3C2haqsXhX8xT77B9dY6mZeZ9vEpklZW1sB65SsjVykpIuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=88o6FXhznBArDn/xYlSb+uLcYFW0slZu/oWyXqJnZO8=; b=eLTMEgwNbLkY9SHdWVgn1eus6CVBN7uk9OnbMv2XpTQD1pf2MNau0iCAVfLD4JP+jRP+g/YQ8tmAtXeqogFTvkhjy39v8pROEgHpHqY0zvSsDx2ktKZB1QdRg/ofRsZVtYn7kXO1diYpHqlcJbJL0IUs+gBRkrGomR65byjMm7VUwo278iAB0qNOLfE/2uVxKa8KD8EDlIskRMdkPG6MvoTellAR7f0HNL+McGVXW4bqXJ9AvUtqGBG2wd4eTLIhg67VqusXkdnj0XRr48JYNC3r9v3cDCEBxNRzGA2yJfPSXlPG9P5kT/LYACsIcoqFPBKNuRUKxp7h20ow8M7H0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88o6FXhznBArDn/xYlSb+uLcYFW0slZu/oWyXqJnZO8=; b=RvEEBfRr/RTeBpNUMWH/gVGOJoNIfk/6emsWSsjYu0LWdy1QIU2R9ES58HVDvKd1YK0tLAP9/KmMFtIx66A9d2G/YrYwxw83pdMoT0UZPRueuYAiRutMD5tBqsU2f4N814iLJ7i3pVN4EyyEefZ1LGfa4+ad7Mxw8dTpWTwzPDY= Received: from DU2PR04CA0172.eurprd04.prod.outlook.com (2603:10a6:10:2b0::27) by GV2PR08MB11692.eurprd08.prod.outlook.com (2603:10a6:150:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:11:57 +0000 Received: from MAD0EPF000008B0.eurprd04.prod.outlook.com (2603:10a6:10:2b0:cafe::10) by DU2PR04CA0172.outlook.office365.com (2603:10a6:10:2b0::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Tue, 3 Nov 2026 14:11:56 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MAD0EPF000008B0.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:11:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793715116; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Gp0+8Er8skcCakjyBDHhtXKFkZHVbAe28UHlzWaaI+Q=; b=YdS/GW7+DaDP5rURFmddRammYUg1EEoCR5RefjOc8Ybvm4Q4rM+j1tUDLWv8CPEJ UGzQHQxams7tv4deJkqVp6KkWczKV6BFTtKRdPSCYRjQgVhu9jQsPa0Ztlj4TyP7/Id VM5Q8gmLGL3TsHITIkkMdVWRFs22xEqn6ZwY/fw6N1Ud3K5EFXzc68RAc2iItp96Iq8 WeMpwpEhbbwbfuh3C8PtnvEVIAm9i2UlktcQO+NlIvZ8R+ce2I9Llj6OhYkjQTqstet aYMASjBnL5zR1jRTqEg/AF9VtBI5eKIa2Dc3AQtoZMngYSBrwmilHEgncMzrwBHXDDt gT//pwmQ2w== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793715116; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=Gp0+8Er8skcCakjyBDHhtXKFkZHVbAe28UHlzWaaI+Q=; b=VzwAdScJR51Ti0FXZ8AecGu2PAxvcGjFV6+SWMIB4EKnpZlYDBkU+aSCngyspCC9 eqpjwjI6xL2ApgmwvsYh3wa5vRXTXxlQQTQvdFslgDW/fXUXVFYdDwkNlaHyeRdNmjs VrfMaW7SDtmpJCpo0L4pJty8AGzNWUnGp6EK3Xoc= Message-ID: <010701a1a1c0975f-84a014b1-1dfc-420c-aba4-580048841395-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 18/35] migration: vmstate_save_state_v: fix double error_setg To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-18-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-18-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:11:55 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008B0:EE_|GV2PR08MB11692:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 31cdacff-17a7-407d-e70e-08df39b46b2e X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|48200799018|376014|61400799027|4113699003|5113699003|10067099003|16102099003|22082099003|261102123227099003|18002099003|55112099003|13003099007|56012099006|4143699003|261022105027099003|261021121427099003|261009223027099003|5063699009|261028144727099003|261026140227099003; X-Microsoft-Antispam-Message-Info: bFXq8qul56SDpKS3vxIGRZ+CWTv7jKa1PKyYcfSCgxnXxUmKYK87W7h0HUG7ZVeUUCjUQUS7Bo//VPtoFj4Otfp7UDFsuHodSyC2SHK961fBXbRK3IOJsN0CtJGX9Zd36PtuEoNc8wSCcGgSe34Mmc9dl60J965BNQI3eVx1y1UKW0NSHBJlWK1QLDr65/8tfg4Glicw0Q0hw/wYkuRPrUEaBKRzmpOyymXnnuRf2UTMEPZcglojAKWF9r/HXwZtJq/zFP8uddhT7Jv52J4e+A18VKlUw+DGr0Wnx3PJbo4YIK/W6DD4oayfvAiuAh1XX3ShpEl6aWHJa+GkM9arsTpP7VC2tSZ7Maw91ksTWCnto9ewvEP89V5L/M6h4yDOq8AvyZj5kw0zSkeyjMIhkizJ/1v0TFXbd2R+ayTiM9ZtgKoTTxRNuoXoZntSrO8+2jPRdn/RoLlK9MtI34XWm3tAHbw8B2L/Fc4rkbifVcj3dIndo4XGZ07U7Hi9GDP5FXGlMF/mLktB9EVFJ+jQeLI0ytCm+v4ZYHTmVjOEzO+SKpzSmkmJss5/CM8mOki6KNVBk9hzbVRPBdsyT6LA0exJNZvthzRJ6LrA+OqbLKzYIW7T8RHWeXCx9b9OK3voPQkCsrWYpPuwBKjygSI/A4jE1ym3+TTtZHwKGJxldcSt7XTf2dDrhjdy6oaJroudXROO6aFA1neZtegQU/MZgto0otYSCgTMl48cu/DrPmuVs9nLBRXGZpswvP+KLvx85CwrpyIVCIuTR1CUEkNi0NjwYPsYvlxXCn+G12ORy/3qQw48lcZQvLCAcnKs65nSf/3a3DXZcA275Js6DC2ZWMfNavFbM1PiBEii/HC2nL5p0r2dh6JUwYfl9d9maMwT X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(48200799018)(376014)(61400799027)(4113699003)(5113699003)(10067099003)(16102099003)(22082099003)(261102123227099003)(18002099003)(55112099003)(13003099007)(56012099006)(4143699003)(261022105027099003)(261021121427099003)(261009223027099003)(5063699009)(261028144727099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wJOPivS9pQHT6uVREyrNZmNEXs0ounFhysBdxoMwImqzRWWerlEvMXnWF3MvxwyvuG2phZCPg2i1OJEk0JxfDueIpk0XI/eqvGqm0DcHlbOhxu83kVw3VFf/W6GspenT0MnmU/4iaEoAygvP9dFuOv+Eok2+MEpn/IaHY6mPA6Gm1aYnSESWdFSKBfakYFVLcR5MOLVOwO2DZgCo67IZ1uQpvQvCmTjVhJj20Hy8Mv20MaPA1iHF6BRYu6QPpXKLAh5qqUP9dNIQ/BXO4InyF6ulOihvE1gyqVA+rteGEMDThhMZR/DyUhi5YwKbZ1RSLlHQlR9kcMcE68j8S/eCBk/F4PpE47BfgEYP35KfXYtL0rS/15p1JUu2AsQ6Ky3LYILRUDlQjezHyYi8tIvqgdRdp/eaNWrRMpI1uTMfBCQy0imBRVwmPiAVph+zSjNy X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:11:56.4063 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31cdacff-17a7-407d-e70e-08df39b46b2e X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B0.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB11692 > From: Vladimir Sementsov-Ogievskiy >=20 > We may call error_setg twice on same errp if inner > vmstate_save_state_v() or vmstate_save_state() call fails. Next we will > crash on assertion in error_setv(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit d41ce10d0f5a. >=20 > Fixes: 848a0503422d043 "migration: Update error description outside migra= tion.c" > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Fabiano Rosas > Reviewed-by: Peter Xu > Link: https://lore.kernel.org/qemu-devel/20260304212303.667141-2-vsements= ov@yandex-team.ru > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D18