From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1c282a9-8d12d88c-1558-40c1-9dc6-bad743f8019a-000000@eu-central-1.amazonses.com> Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020076.outbound.protection.outlook.com [52.101.84.76]) by lore.virtuozzo.com (Postfix) with ESMTPS id 29C2F8045D for ; Tue, 3 Nov 2026 14:14:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hd09pHO1+tRQGr77GY+9Pa6D+KtrSmZld3VQR8FTatDzFtNHCUcGaqqM14+tTm5uv66z3/W1TtIiirArExHeKbOxNSRfaYguahpYobC9Yt4VI7RyjIjFxODzAcEHzDRZLvVrylypBwJSB8x6BmXgrMnAjTMAmKSEAUJCJ2MfHAjvyWXs4nbyY/xLw5m7ido8T/f0AJd7wLHVCLcmlCU5k9X1mW6/B03vUJZGH1saxQyAmyt4XIgAoNlyL6UVh2kB2HPpUVag4qFYm0Q6os20pYelRyXnDhFtNsJbytWIFPGohXcIT+zDeZ3iNLcnhT3Gy0ULEYSxfdDfeoYdwyOKlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMLLLNzEu6+zHpf73m9SnL2ObasAEUp+70R3CuEY3KM=; b=exreEv39YWQ3iixzuGXsYkOolVQVlFee8qae1bgIk5xjCJ0RtmjdvHJ4HSUg1ki/wrFZlzD9xB9UxrvgCK1mbzFb7CBzL2lIz2BYiDt/xM1w/tEOHF08gLRvzm00sr1H6tvL4vlV/ujUOBuaffajY5qXDlnC5n54OyjpZ6ej+xPd2GmN+HdGRvYYtNMrxWIgi5uL2nU6PsSKFq77mF1aKUBt/23abwfc7ML89+swa6pWeevDtOML0YcX+ojAIQuTvjrZtb7DqwDkSbtfxK+Ti+0Eos+YhXxRO+lpBmdtYpGO3IxDYbASrjrekUQ3+L5dP+WICUIoko8ZH9ItAzPA9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMLLLNzEu6+zHpf73m9SnL2ObasAEUp+70R3CuEY3KM=; b=QeHdxQQr79+4Ocgj1IUKExmbQJUenKS/KxYLkRd/KeLpjA17xdyK0iMD+EZrG5Spjc9FFUsKVZqywQqdoyWyo/9ilER9EAUUeOnPSTT6pV4DpjJ8fhWGlqjlIWu/lHgmh1OvJ01Q8NlgZb4Mb/VG9vapgcC8ozyWgvHP8YEyczk= Received: from PA7P264CA0211.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:374::7) by AS8PR08MB6312.eurprd08.prod.outlook.com (2603:10a6:20b:298::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Tue, 3 Nov 2026 14:14:02 +0000 Received: from MI3PEPF0000855A.eurprd05.prod.outlook.com (2603:10a6:102:374:cafe::29) by PA7P264CA0211.outlook.office365.com (2603:10a6:102:374::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:14:02 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF0000855A.mail.protection.outlook.com (10.167.240.22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:14:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793715241; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=l623ngIXk5WUztAM+4D/WBBK15KMbcpwZyH10Wzvosg=; b=tsu3IklYG7iRBDQdqrww6ppTeR1clQzXh1MW9I5Lox6Fh++gwHi/GVmBfrGKfIaq CGUDSBVQ5DzdjFELfCZswnIXvogSR2OHWI45WG5AjXyWmxbefrG2v+yw5AdWKfoLsVM nRYjchYiof1CuUkx0DYsk5NtF7+7AUieXWHBfnlAT4bIZMZ1fZjuRayHZh2ZG/9jxSN h3FL7Ok6l+dg1k4qC9COHCL99i0g6KL7U/x7tcmZmT9ejyFPNZ0km/C9ly6mYCCGxA5 4UtvhvI6uQtGjQmYezrsK0VC+R+D0tUK7+4X8+TsVnIyRNpvWusngu5sgzyRrzYVPsy yMqEh8mKYg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793715241; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=l623ngIXk5WUztAM+4D/WBBK15KMbcpwZyH10Wzvosg=; b=n8M8sYc8CRCRhSV0ZjYXh/Bb35hnudvCrwBU/CD6650gljUWJlSw6KoCF8dy3a54 kZpeftA2U6puhY6UqnU5SNuQawhGzL9rk2E34nD9HeJYXxko1u9wZ/H0v3sAbQY0L8s iIv68Hp+eCfsH5Ym68ncgvSlKyTfOR/un7R51FU0= Message-ID: <010701a1a1c282a9-8d12d88c-1558-40c1-9dc6-bad743f8019a-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 20/35] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-20-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-20-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:14:01 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855A:EE_|AS8PR08MB6312:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 55c2e551-23dc-4dc0-78a0-08df39b4b61a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|376014|48200799018|61400799027|32142699015|4143699003|56012099006|5063699009|261028144727099003|261009223027099003|261022105027099003|261021121427099003|261021123027099003|261102123227099003|261026140227099003|261026121527099003|10067099003|55112099003|22082099003|18002099003|16102099003|5113699003|4113699003; X-Microsoft-Antispam-Message-Info: BZNvmtQeA5dgV8IE1LjYyfB/r/LURYYTap7reuf6nxyPkwGZOMNPMzbWM3GrQDAxpNs3uA3G1qVYcAuAnRCkMmAuxp7IQdXCX4k7XoUwdkcCSwKs1IyggvsUCRAEGEMpL3Sy5N6opE0B1NIslHE1pri5ocS0I+k6VXOxdC5AW6WGdSK9AFMHQUet40dPdrjVC+JPpgvkwcqbuFgOvsaCXNgQAE+Zepq9jJbY7pLoV2sj+y5VFzhQMYYJvx+e9xYPGQ0+vXueGSa5qMpzd6kIjqfmh78tGAQE7o7tqEAC0cN/5K++0rVzH2ryq0SsQEZsE7qgo+62+P+EEDAwvEeXg67rD8RTgAeni+9Kjzbnb4oS94C0ByvZHTuPYsS/4+aWjx1nLiFU2W/xZIpmPjMlbC0KcCfRGaUlHtcv71Xk5/rHpyjTm3BWZGpHaaT8WHO6m9KYVIwsulyl8bJnvIGbm0TWehzvKLzyGuS9FYkcMYgx19VEueT2y/W6NiqVyfakiiVkbrJHm1NTA1rkMNxosalt3D7FQ85C5ukRUYjUZlBRRmqs9SkrMkZ7p9NbPdalGgezQ38PyuiDAB5Nz0yXF4/0HZxE5tCAn/v2kZVBbxoqA4vfvTWCNmcmLRRhUBDlx+qHfn3o8UumUn2WPYH2KnhTgh1lfRekpGbI7hzaVmalVGKqaM/YjEjaK79zJWPEeoSaSFZM+fU11AwbGVzs2DcIxRzAUNxBQaOZ2OfAJXBwgT8zjvoSDM5Noks2Ijz/4ye1YjCs2rdZMmsFTnm9lMquxNF8Z2+0rygUtnXJTDpbgKPSAzLE+p45aUGlFmh3BdppAf5dKJ0VyFzZroSu28aZ52vT3uswUl5xmmW8WXyAxqtXWFjkGmJZVJ24UG4x4oC1Mj7EV3nfKTfNDG204nC2X2wqyr7nMoJ6RmCcaXcgoY3BLtD6sWa4x58MXhEJ X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(376014)(48200799018)(61400799027)(32142699015)(4143699003)(56012099006)(5063699009)(261028144727099003)(261009223027099003)(261022105027099003)(261021121427099003)(261021123027099003)(261102123227099003)(261026140227099003)(261026121527099003)(10067099003)(55112099003)(22082099003)(18002099003)(16102099003)(5113699003)(4113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MRZCXnU95iTr7j+EgTSEikaKm4oZLNsBeqsTk+g2ge32Ql1ruwNJ8zvZaO22iU1zX2wA5facLYCqIfRLZdyLc0mHRFYAuupfFT90gpO4cWYYJknhtmqGZY1NMJm2uV8NRe84mni1p3yt7PcTvZmua1TfszkrlDFUmmLq/4sMt/e3bwUpYiLmDXgLHyIPpRkqgTG6RsrHPVyHjUaeqGrZZqWwA6HBDvz++4YpqA47MVq4T0NT1AB3IpJL//GYozPvsdwMD6h0MqSM46F547782KsAL3Hvfqet6EeNq5aN6ZqAwBj8nEcryvDcpMbSo00/Qm3+kvUpZz2pvJY+I8swSt8UTUoXr2Ac1hoN7YxE3t6cDGxcJxn4VTalQlIHtAi7cPAzI46QOArTnucnLUCMyoyhZRmoD6vJHqafsMeIxF9zkzaOZ3C1Yj464zFCo9FS X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:14:02.1176 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55c2e551-23dc-4dc0-78a0-08df39b4b61a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855A.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6312 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D20