From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1c486f7-7fde264d-bfbf-401c-a6fd-2c9a6a8cb7a5-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023129.outbound.protection.outlook.com [52.101.83.129]) by lore.virtuozzo.com (Postfix) with ESMTPS id D177E80E7E for ; Tue, 3 Nov 2026 14:16:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q3yOGMDNYSmsmzIXC63qjECsTyWu5QCffteQ5aD5e3jHCp99F3t/DSF5DO06XFuqg3SxGfv9xLMxr1rkFy15AaNWAwhQh9paTHHvZPhc35oticGWfuABB2kJoU5GKOYdDhvqm3zd5jo1B4bnxY0OA0JVHcz9+41TN2kaZN5tNxyTvayszK7q5NK3mRZ3kYeMLzKKdjdvGfi+fAdHf5wAw0sogCVIzUgd8gOVhhTroIGkhTnSBGC20muDGRltxLxY8U8YE3U85XY87sq5kpd9BPW3izGY96iAnnYIo6Lm7G5MKf15J7Est4j2tCLcP1vSBp6C7Ty/3FtXKZnn9CTFXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nzXKAwX6lgLQDps5cFn6jZz/Klv9fl37j4e0RWzMoEE=; b=Zod2BRUAzu2nI+oezHhndoPRrPCYnxp3sfb3tfWsuxeSrpouS1b73dqBhiavr63UpX95AAIcI9wdJHcSGqme9SVZg6qOBj5CFomqoRJuIbVq0mvIor2qWn7CtOE2Nhh8r38WhgTVskdTguFCTfBkMGE7q4AE6LFNJySoyYaa7D+A1kpU/V6GYC655AkDwe3Ck26F2eNViiQvPg5Xr41TzUCQ41Bq24M6+Jfht984Gib4blb1C1sePqYsqqRohHVG62FQl+QfwHsRJtHq8j6mafPfFN7mU6KrwPW8I1yMtP3o5063e/Y+ZSw18fJSwFtZyMA322pgmlAIy/Qj3WY2+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzXKAwX6lgLQDps5cFn6jZz/Klv9fl37j4e0RWzMoEE=; b=MTnsATd1Q1tNGnSVoEZWwUXPhj2f+KFmNgHJQBDFY/2ArqCp6C/vVBOCcJzARLCDWWp4gh6vcxZ/MVY+iNrQB6n18E9m7srfrHJ30sJw3RLOikDt3gI1y+Lm1660sJ6LbzLMr01R4GB9JR6wizlAGpNL76HNmuBsASgEQkXwbxA= Received: from AS8PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:20b:127::23) by DBAPR08MB5720.eurprd08.prod.outlook.com (2603:10a6:10:1a1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Tue, 3 Nov 2026 14:16:14 +0000 Received: from AM7PEPF00000054.EURPRD83.prod.outlook.com (2603:10a6:20b:127:cafe::6f) by AS8PR04CA0138.outlook.office365.com (2603:10a6:20b:127::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Tue, 3 Nov 2026 14:16:14 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AM7PEPF00000054.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.2 via Frontend Transport; Tue, 3 Nov 2026 14:16:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793715374; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=nzXKAwX6lgLQDps5cFn6jZz/Klv9fl37j4e0RWzMoEE=; b=NDuXLwUu9CCl/CxyEgLiHvFbFE4hE1r/PECvkJtNrUxBElZbPtKlA0IEEaOlkT9T Dz/1+VdG1ua+UW6bjA4ynAOGYNMoo/hmMFPCS6SjR1kE0sK8yZK20MzJvZ/oqKKiU8G fH0cQb5MXi+aSWKRaiy95rAzYmrf9kpA1keiYEg7Av/MdM+f1x6YUPAUv6zQCCGZYSM C3/cvih/+TFRdGRo5nVpensBiNwfK5AXT7NPk3nyq1MN8aPV66OLiEncdoEoc3aJH02 8BHLKUt+bcAVaGWckQx+R4dgviZ14temuEe+Lx3QLYnUKWF/Xm3p9nPd+TdXt/ZdIo3 IkUwqWoxhA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793715374; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=nzXKAwX6lgLQDps5cFn6jZz/Klv9fl37j4e0RWzMoEE=; b=BVtSlThw1Cgn7KAMvnAdOdtKmeu2BrlWzrOlsbAwwe0VvVHUdSf1TvCDRPghcWzZ 9F0vB5LODKC2rGfwZ19N+m/AsX2LpfhKjt8y5dmmPvG8ej9RFO4MaG6hqxmvPWEP4ea J9lwAczeo3ICXRyFeD/G/8XxBHdJ4sbdDboNaKg8= Message-ID: <010701a1a1c486f7-7fde264d-bfbf-401c-a6fd-2c9a6a8cb7a5-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 22/35] migration: Fix crash on second migration when cancel early To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-22-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-22-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:16:13 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PEPF00000054:EE_|DBAPR08MB5720:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5b409f25-87a3-4c10-4025-08df39b504dd X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|9140799003|376014|48200799018|61400799027|32142699015|4143699003|56012099006|5063699009|261009223027099003|261022105027099003|261022075727099003|261028144727099003|261026140227099003|261026121527099003|10067099003|55112099003|16102099003|22082099003|18002099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: Qkt549tIkHjULoEEJcYgsRsRY/j3L2m3FtR0oCb5ETRN+bqIqgt0zmn6iDqyjIKfRr1M608u0Lc4C9zlXCLzZbSHOSWmDaTSUZyEa8xbrbgOK6C8Wqe5j4L5pdKbkULoRbMWCH/SMTMfv5bhMI7Wkv3f8g+OOi23cojZWUQAQLPbguC3UIAF9APyDxfckg4ZcAyk4aT66aaz6O38pcO38Lyf75TDyXPs/QIWH38IQa4FMvx/33JxUMqfOGB9AvSeRDJ0tQSDakP/rdCbK5LdUkm37BMg32Vco3IM3X2WtOB3mWTVPKsN0fYNfXLQbxN0jLGgnavKVg/OaHJSrLAF7O8bVSZsr7MGU+JUYf1gWbtzF6d1YuTIrdFk8S3ZUzi2GnMCMW7N4eumNxw48rtjLCN3OhwxuBdCKVoiD+XP6dnukmDHQPs3ppv/vphcMxVrOk6M3JI4YFuzuRSQAbHrnT2rhvceTy0+tTysimAwIZjlWaYOW54tGGvw3DGmALCFhG/Csx38FQHXwA1UQd+/jZquGZAvV9Dry9WRh3JxC/Dta+crXbwHB2Lu0LN4YsNMYOgixf/Rgv2hWoAaxNwBpG/FMRgJ7ZlfNV4Cg+I8+Wa1iWVDZcHRaLT4xZZG6/phzvouN/Fb6mAQ1MedhcK+fgDYG+iRC0Vsb08cYdvIRNhJFcRyhJp2bQWLgqsGMjg0+tJiQtZdf2kFdQya2T79hKDEYGgP722EASoMF9A8JNl6Hi43GYIOHIwwDFdqp1sQEf7i9Bgk4MubOyIo4YTi7Crwn4q6VDn5m1CiYXUOikZwF9kb6eeOjil+1ksPgR9tSSLr1FlI1tJj4dCJhDSGG70Yr7XvZYHiB8pjMS1qekRDnsn6ehBmT08TfLIxftnJZWDvQ4kvEbzJIO6XJSW/hdrDM7gVHNnqEfwXzUUv60rB6rHfeYRpctt6UIv80bnA X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(9140799003)(376014)(48200799018)(61400799027)(32142699015)(4143699003)(56012099006)(5063699009)(261009223027099003)(261022105027099003)(261022075727099003)(261028144727099003)(261026140227099003)(261026121527099003)(10067099003)(55112099003)(16102099003)(22082099003)(18002099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /o31UFCzRkNDa369MQ9ENLPhN8eM/7JOW+6ysFO93XwposhQHpRds/EIEFJnc2xdSwJvU5BSBA6ThAVzAjaucWESjsBQg+l9cYZtRq9dnS0EJQ7nr0Tj3x8AkY579E1SOjBB6TChqI2JdoNrBNccmrbH6td3HF5OkMcH7ivEd8+Y2/DvNw5Zw4KmYDHoZ6Jm5iDbhhnX2JjFznpdz9CGJ/WCqLYWUYBf8/8LpVEemZbGAxhyj9+0Vor6p1hkdxGoL0jQLkNbda7jN35I6kC2luoS5zAPqBEuOqykBQSOQqMmAMQjasQBbVoHE4tMjkdTDnYuM7PEO186KGoEOHahSe6qJ0VilSmoYCko0AZB5tWUXmekv9XECrsMulw9cdZ5+A7O1N64jMFOrhJPv8Jpxgkm6oTZDs92X0BJMz/0Md4HuqkfxmP+cSP8ckcSew1t X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:16:14.2734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b409f25-87a3-4c10-4025-08df39b504dd X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM7PEPF00000054.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5720 > From: Peter Xu >=20 > Marc-Andr=C3=A9 reported an issue on QEMU crash when retrying a cancelled > migration during early setup phase, see "Link:" for more information, and > also easy way to reproduce. >=20 > This patch is a replacement of the prior fix proposed by not only switchi= ng > to migration_cleanup(), but also fixing it from CPR side, so that we track > hup_source properly to know if src QEMU is waiting or the HUP signal. >=20 > To put it simple: this chunk of special casing in migration_cancel() shou= ld > not affect normal migration, but only cpr-transfer migration to cover the > small window when the src QEMU is waiting for a HUP signal on cpr > channel (so that src QEMU can continue the migration on the main channel). >=20 > [ ... ] > Reported-by: Marc-Andr=C3=A9 Lureau > Tested-by: Fabiano Rosas > Reviewed-by: Fabiano Rosas > Link: https://lore.kernel.org/r/20260421175820.302795-1-peterx@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D22