From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a31ab226-2be47477-7bec-4095-a41f-1191f49e6283-000000@eu-central-1.amazonses.com> Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021116.outbound.protection.outlook.com [52.101.70.116]) by lore.virtuozzo.com (Postfix) with ESMTPS id AD7E08017D for ; Tue, 3 Nov 2026 20:30:02 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BApGpGrTnf1GZvMsq3U/lQrAqvdo0kXRKvNbFMwEDQMql1UCohAhmmn1pfOk5hk9XxuENfuZwgwWB4HTHBo/LZ95OzKPCjRPK/1YQKVDkqR1tFDnEy+R8RxmuvTJWlVpVTrh/+SqD33TvykyUN8EIMMHkcyZjXh3oDca3RBrO8VePgTlf+vJF0aluIujOVCuhF8Qy+XSBO6wJ8HsVVk/5fyDVMdMaV2T4bD5vL5HjOP946rdsRH3MCvZ6cGATJDLa5hTY3KIxNwQEhaJ+V6NJI2zw9kf7Kovb2O9MrDlHw3s94jQ6tVyAbuflGGeNmR5zeFvs0uu7P8m+9rcV6LKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sk3Q6268ASGPiQmeNCxkQN5EQO8XKs6uGMRzmvs8QHA=; b=T68ZF22eNRCuQ50OHKVz/rD+xrmwWsz7TqgEAqZMfG6H77o23b3jFxHgYj2R9hYOfTh9rNsAwenLARVrj3vE/7273AfTP2zAHY1Lr5Vs4cwlLjZm83V8DYEBMCyOYUOhvhDKaQFzWcxMGP1GsE0xzZbdsZQxGVdrLJUiZ/1j94ksMojyJ+KQlg4waDyuCsR5UvFbuuPkRAhYe9B+wiJ8IM/N9N7AEDia/nuVzHp3vTVrkPVCBJIRwojABJgSGt4obqaYQL3dPsHa+KF65HtxTjAk8rUQjwEli+AXgQxfqEH6gO3YVmcGlmt98XOrOvD+XX66ByryLcxWCTokqUBVNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sk3Q6268ASGPiQmeNCxkQN5EQO8XKs6uGMRzmvs8QHA=; b=Sb6CARor7BGmoi8qhZFW/uZ+61wlLiUHw8GfvKXR1l5E94rKITI+HcZYAJiOMISr67cMV9GfuZGKXfGCJiAVq0Ha+gHoTlCNBwssS3QWbYgll95JznTqeXwpbe2QLEthDM1KOMGg/gm2Y6tv//2+wyOsIhgdu57TQStTDarZa5c= Received: from AS9PR06CA0510.eurprd06.prod.outlook.com (2603:10a6:20b:49b::35) by DU2PR08MB10039.eurprd08.prod.outlook.com (2603:10a6:10:49d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 20:29:59 +0000 Received: from DB1PEPF000509F8.eurprd02.prod.outlook.com (2603:10a6:20b:49b:cafe::68) by AS9PR06CA0510.outlook.office365.com (2603:10a6:20b:49b::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 20:29:59 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509F8.mail.protection.outlook.com (10.167.242.154) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 20:29:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793737798; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=LGJSNMmFqItIZDnhvcPbl7j/hDqBzO2SqPgBla0YBag=; b=Ma30w10T/q+bkaKu6+fmTU3vwYV2L0S8OIiRb5AtoKGE93VCyCPEs/3bUG8k5cJM fRrbAFHlKhxaB29uI8T+lT+0jhkcCkgfqgM5ARMY6G1MTZDv8RcYejyeXdwWsTzLuKx unoJarlsFFW3r6qfu3XHNwxR1+aA9/NuLtlXlWZVnnWZRnw8lAWsATYxq3I8pPSJ7sf DupVeAFhB0vilsmYjFyAod6mclk+FgMvobhOFE4JDp2wBF36qayMcNXkCDAEk1iN+Rw RmJET1Kdu6EnalPyulMm+tK0pbdGz1t/qM7gwY0ERGMTIRwPN2c+L+GPvvAsUEzlMYQ Dh4WkUeFRA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793737798; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=LGJSNMmFqItIZDnhvcPbl7j/hDqBzO2SqPgBla0YBag=; b=Zz3D6JFLgfzXePOVd0W8HAvIAt+244X5b+bPLkiTyiT3cjs8XNu1p2ElAReGqoUk lHuappdD7YmCDa/j+P9/hYCjrQB7HN462Udjr7jmbDvuG9RIU4qMj+N4ebNN8M0gxvS d2fjmCeT1QyiE1Yk7AO2qVMdubYpu5fLsw+cmnCI= Message-ID: <010701a1a31ab226-2be47477-7bec-4095-a41f-1191f49e6283-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-8.0/hci-8.1] i386: hide la57 at fresh start for named CPU models too #VSTOR-153243 To: andrey.drobyshev@virtuozzo.com, "Denis V. Lunev" Cc: svt-core@virtuozzo.com, den@openvz.org In-Reply-To: <20261103202710.976429-1-den@openvz.org> References: <20261103202710.976429-1-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 20:29:58 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509F8:EE_|DU2PR08MB10039:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 91103914-09af-451a-7627-08df39e93adc X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|9140799003|32142699015|376014|48200799018|61400799027|6133799003|4113699003|5113699003|10067099003|22082099003|16102099003|261102123227099003|55112099003|18002099003|13003099007|56012099006|5023799004|261022105027099003|261022075727099003|261021123027099003|261021121427099003|261026121527099003|261009223027099003|5063699009|261028144727099003|261026135527099003|261026140227099003; X-Microsoft-Antispam-Message-Info: 5oddvHKxZoZX9vDW0H90moeT5LUfRwz2UGOQDHlJlH5rw16INqATiTgFJZu509SY1KBkpXlqEcPiqXSsd6FnoZm3gYWV6l3yM4/APIjPk/+ShZsA5UuDL7B5pdg+dABb8HwoTOMHFuebbuZRITixHnpUrPgUTRXctxG0cDvijB5K8CkEk0g6R+96nnKlrDEsEQbX5DSX6T2H2e6baX5Zb9Dt1vUiIDk3sWXY6JZw3361hg1Ryws3TB79twy3FyNNrbPS1fN5MTY2JLdP8HVnC5MqfcwKQneUrQY8B2qBdnwmwnc8DPVl5Z8C8O+t6F6fR3A1BJGNnZ3glzr6EwdqT0s/Ay/lvsLH2JTM7thvK2oiwtMRgugFA68ETjvVQjlzjLJxIVCbyUwtasPqPqKWQMxQNLjk6Q6fJ3geWgXoqHdjZLOOqH5eZM3i2D8Oip9Uewhxwhqi2sjo2exvPu9xwho1eza7nVRruV6XrYwaDQ3X6mRiOCTikPiOmzEXMMYnyj2rmgtnuC+yOxSpRrmRIQNQqM1RkN8M6V4HpAgUTCUauxcrB/eH7UVCHT9YnBYVzP1+EMHrpmLW39p42lxApQJlepN0KUiQFU4emKbTPmH99h9jag25jDRCxDeCRwYDyBmb/jYKTVaJwWOo78dPzuSnQPfvP6m0me084ef0GaXwxZFAqHcPMVKtese2bVQeCX7PVA5kDtfSK/Pf/HbZVTK7+BEMwt2SUKXbxyfrv8Iv9pa3hV8L+Om0TWoEktXf2fikYrlJVx6mnaoAmRo5TtrQZkNIz+GqkcivwxC9f/b1tamCy4fweFF8/uXHQ9qrhRTr5QBCYldWq4IH5PJh9OFZVFujJRbqfye3TAF2WLXSqLm5ln2lMTLiX4BNKXG7 X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(9140799003)(32142699015)(376014)(48200799018)(61400799027)(6133799003)(4113699003)(5113699003)(10067099003)(22082099003)(16102099003)(261102123227099003)(55112099003)(18002099003)(13003099007)(56012099006)(5023799004)(261022105027099003)(261022075727099003)(261021123027099003)(261021121427099003)(261026121527099003)(261009223027099003)(5063699009)(261028144727099003)(261026135527099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s/d7n9lQkDyyMb5bShOp9jJ+C4KSqo5KFIGRT0EzP7BYxTHCxe2xMAbJgDzY00a4LyGrl9vSsn1rFigX0m1NV6DgoJdQet2JImjJI8Qm4SoVIFMX0fu4Yk9LGYQf2Oc9aPP1xzm5+70BlTLMmKZkVcGf/Kk+8/pkkbIQa7Uw4lTBiLgDp0Od1/4+a4vi/38zwpgzfzrE6i8sLOJIyivsDlpqQAm78oaEiXNKRBso4yJ+dS33UBiaUMvA7vN41dKu9LG9ucpFXe4J8OTnFfcnk2Yd1FW59M6J0CEp/1+l6yFrrWc53ZNBS4CvWBd7s6wDOYdhPCepn2eYucVwjTX5NqWZfDTFehrsWG5FXq58HsbfTMSUfycUuBk9F+RZjMTbTLv9a+Vjs9TsnTwbeQGc/cRY4WVaJNmu8kA/ShAOsm7OlJLdtIAmRJ5eh7yriwqP X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 20:29:58.6707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91103914-09af-451a-7627-08df39e93adc X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F8.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10039 Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] i386: la57 hidden on fresh start for named models is not carried= to migration destination - [Medium] i386: x-no-la57-on-start now makes named-model CPUID depend on s= tart vs incoming -- commit 6ee769c61c235f2703ce2d8c401e08535fd3d5ed Author: Denis V. Lunev i386: hide la57 at fresh start for named CPU models too #VSTOR-153243 This extends x-no-la57-on-start so that la57 is hidden on a fresh start for every CPU model on the affected Virtuozzo machine types, not only for "-cpu host". The bit stays visible if la57=3Don is given explicitly, and on incom= ing migration. > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 8d2ce279a725..e22fafeaef09 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -9116,8 +9116,7 @@ static bool x86_cpu_hide_la57(X86CPU *cpu) > { > CPUX86State *env =3D &cpu->env; > =20 > - if (!cpu->no_la57_on_start || !X86_CPU_GET_CLASS(cpu)->max_features = || > - !kvm_enabled() || > + if (!cpu->no_la57_on_start || !kvm_enabled() || > !(env->features[FEAT_7_0_ECX] & CPUID_7_0_ECX_LA57) || > (env->user_features[FEAT_7_0_ECX] & CPUID_7_0_ECX_LA57)) { > return false; [Severity: Medium] Can the guest-visible CPUID differ between a fresh start and an incoming migration for named models now? With the max_features check removed, x86_cpu_hide_la57() applies to every model that carries la57 (Icelake-Server, SapphireRapids, GraniteRapids, EPYC-Genoa, EPYC-Turin) when la57=3Don is not given explicitly. The result still ends with: return !runstate_check(RUN_STATE_INMIGRATE); On a fresh start this returns true and x86_cpu_realizefn() strips the bit: if (x86_cpu_hide_la57(cpu)) { mark_unavailable_features(cpu, FEAT_7_0_ECX, CPUID_7_0_ECX_LA57, NU= LL); } On the destination, the runstate is INMIGRATE, so the function returns false and the model's default la57 is kept. The same command line then gives a different CPUID depending on how the process was started. Nothing in QEMU records that la57 was hidden on the source. x-no-la57-on-start is a plain bool property that pc_vz_10_0_compat sets statically with { TYPE_X86_CPU, "x-no-la57-on-start", "on" }. So a VM started fresh with la57 hidden could see la57 exposed after live migration, save/restore or snapshot restore, unless the management layer writes la57=3Doff on the destination command line. The commit message says "libvirt records the filtered la57 as disabled in the live definition for check=3D'partial'". Is the same true for named models used with check=3D'none' or check=3D'full'? The commit message does= not say, and the code does not show it. The hotplug branch compares against first_cpu, so could the same mismatch appear there too? Also, existing VMs that deliberately use an la57-capable Intel named model will change their guest-visible CPUID on cold start after the QEMU update, without a new machine type. The commit message acknowledges this for the Intel models. Finally, the patch notes say this has not yet been run on an LA57 host. Has the migration, save and snapshot behaviour for named models been checked? --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026110320271= 0.976429-1-den@openvz.org?part=3D1