From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a703cf52-f2a7e637-04ad-4849-a09e-872723c2d909-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023084.outbound.protection.outlook.com [40.107.162.84]) by lore.virtuozzo.com (Postfix) with ESMTPS id A097580E7E for ; Wed, 4 Nov 2026 14:43:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fomP1wfGzMJNsUwjBZCQrxi5xJueY4GA4iLDdK7eSryl0HByJbIaPEc9HbYXjTBxDMzDvOyEHpughsEBODRh0wZUSl9q0a6vOX7IXFrhlXTsl/pHg4uPSvJ7imlvMM2/CksHzZs3B5Dao8I1HixlukWJ+sBYS6fzS5LurlPKbEbusKTlZcz/IssLR3NYJd1v43pMLuZfBzpXfDdggRs2ak5LpA1ncECT7ET8V4bUOJTa5XonTTsuA6JttpYhqcRlFCRXUqDEE2iSp7xs9B0kITXDshRPO1pQaiIS3I3CtKCsSE39Wfc6lCjnRMvtYf3kjT+IVmItiZHXrJhz53Ufhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w9rB5nKkYCgHhFzFwMnp7SjIVVl+CxEJGQX35OVFpys=; b=D+sflnXrEC1QZIO0Ba0uXnGdPagK4Pibf0YZ5vUy7v3430if8UWLRIeQAgXdotyhpABoXvNERqn7jz4nM+veQj96pzQ52VF0+dZBuAYQjIflEtUiwb81burFw9QS5Lu9pnGtSIxcroD/Uo14iTCcusecyQA79qkcF/8g6nOZpxL4iry7lr7qK1r6TPAPNNhblBCXwxrntdysmZZjFL3/8lT/D6F91dZAwodYkAYvDQvsIH+Th2Afw+w4AatbK7xp5D+tNZXRgSLWkFlemoitto2eEGbRfwlFSk9dk8ReDVkddTPMSApxmxKXWaWyil6KqGReejyOWRoEO34JNEu2og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w9rB5nKkYCgHhFzFwMnp7SjIVVl+CxEJGQX35OVFpys=; b=orsiRGNhwzfLXEty3YINCQDkiHAS8QhCG6VtECx5srbLGns4sjT+6I9HsrQ9zFMwXFpxYTyz5wY4F8QdDhqIrogEZEjUD7roUJYfNd/JcSzM9HTDUqzA1Bbnvcv3kc81t+X9g4/9x1BiVOsT3H71dFfm1kpUm9z7+h14UOl2fQs= Received: from DUZPR01CA0207.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::9) by DB9PR08MB7868.eurprd08.prod.outlook.com (2603:10a6:10:39f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Wed, 4 Nov 2026 14:43:30 +0000 Received: from MA3PEPF00000407.eurprd04.prod.outlook.com (2603:10a6:10:4b6:cafe::10) by DUZPR01CA0207.outlook.office365.com (2603:10a6:10:4b6::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.10 via Frontend Transport; Wed, 4 Nov 2026 14:43:28 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MA3PEPF00000407.mail.protection.outlook.com (10.167.241.152) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Wed, 4 Nov 2026 14:43:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793803407; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=nYuCRt578YbMWjDIRvE+Z3W+Xduy+QwqJWKAIb8DEFY=; b=E5CzQund1YVYkH2yuo62u9w3ahM7ZTU510GVPc7Hq5zuWNm8Q5ZToZPdiUKxAOpf UkmllPCqh8VGr4Cv5fmRxd57wv0gruPuYRKuaYwLLDcauDwEwAmiIdn/0gairNNXtbQ ZMpIhQpjsuGQoGJSEMLVJSE/kaHYthbCZgE2wBiKCCmTLdRfjOOCpD7XlKvl4FehZPM OYMlWWp8QtJPCOJL11w/h2uM+1UU/vnv+DU6gtgoro7AOMQskSYdcOvH4BD+/Jh/Xxo r0KX28QcTMis+mxKqHZ942XDfXMnAIaf+4savMriUoaxAje/smLCZZBB3pdhAEB/bij Bdc7ho+E5Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793803407; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=nYuCRt578YbMWjDIRvE+Z3W+Xduy+QwqJWKAIb8DEFY=; b=au6jCE+OipNya/05eOl5rBtzjvgq86eEcFffO3DwV4Kb+/8RvkiMuytySWfaXnNX h1iCY/ucUdJT8UiD1FBJkcfvkS/LF7x+iMG+GwwJPKfU3nqjHIAz+GMeGDLofYTB1Ct 8hT3uogM8BwcdEXvxmCEvfeqU7A4TilOrfQ7HcO0= Message-ID: <010701a1a703cf52-f2a7e637-04ad-4849-a09e-872723c2d909-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-dev 1/2] qcow2: do not clear the dirty bit when reopening a read-only node #VSTOR-140073 To: andrey.drobyshev@virtuozzo.com, "Denis V. Lunev" Cc: svt-core@virtuozzo.com, den@openvz.org In-Reply-To: <20261104144113.1587724-2-den@openvz.org> References: <20261104144113.1587724-1-den@openvz.org> <20261104144113.1587724-2-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 4 Nov 2026 14:43:27 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.04-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MA3PEPF00000407:EE_|DB9PR08MB7868:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 75371538-8741-4248-ca3b-08df3a81fceb X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|48200799018|376014|9140799003|61400799027|4113699003|5113699003|10067099003|22082099003|16102099003|18002099003|55112099003|13003099007|5063699009|4143699003|56012099006|261028144727099003|261021121427099003|261026121527099003|261026135527099003|261022075727099003|261026140227099003|261009223027099003|261102123227099003|261022105027099003|261022115727099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aThNMlRFSGdmUkFOSjNKTHdRM2N5ZXVqazNzMzNNcjRySVRud3FzakYzcU5x?= =?utf-8?B?SWxyMkxvWXhGcDRXb2xkL09OSEZTVzhPWWlua1NiNUhPaEpqYTlrMDFRMjdG?= =?utf-8?B?YkhPbGRESXBVd0ZWZTNHa3ByeFpaY3JBcFhjMjJQZER0R3F3VENubjVqeHNH?= =?utf-8?B?TjFxcExBL1luVUk2dG5GLzlNbjlocjBJb1cvUkY3Q2xnRGdlUlcwcXpmdko2?= =?utf-8?B?UVB0NmdhTUlTWDVzSFhjbjBwa0JBaWlwQzUycVRYek5DQzh1WlF1RHpqUkhr?= =?utf-8?B?VWJpdnNIV0RaQU1SaTRVR3BoSm1hdCt3aVhVcCtGdE1OYXdGZVROR1JyVjY5?= =?utf-8?B?NTJlR1VVbVBBVkovWU9aNEdaMzZJelVUekdkVjV0Q1JoYlc0SFVNcHF2YVRK?= =?utf-8?B?cHkxQ1FwekFyWDhiMWRPQlV3UTVIMHdBbjBLbnI4bzY5Zy9YTUgxejJST2FU?= =?utf-8?B?T2JiWE9tNDVCa0ZsK1lMSC96WS9QeEVBcHBnZzBZdGN5c0o0VGYwb0JWM2I4?= =?utf-8?B?QmR5RnVvN005VzFYcEU2ODZSUlA3UjZVU3hxUVJETm1DRzJuMjdqYTIydXBx?= =?utf-8?B?WHUzdnEyQXRpMHJqUlZXeEZONC9acmJySkR6MWpHYVFvVG9TOFBBSnpXa0cy?= =?utf-8?B?Y3FCQmI5UnJtNThzTlM0ZFNLcHZhYnF3cFlmSjRYYWM0Uk03SkpXNXpGeElY?= =?utf-8?B?cnY3ZFQwdVdvdlI4Z2N1QXVJdG9VSDNmbVNRYmNtTlpZWUd0NFd6NzE0eDhy?= =?utf-8?B?c2VXbzJNbnhZL1h6REJJaVB3SUNaYStReTJ1NCt4UDlLYk9YS2xQVWgxbDBH?= =?utf-8?B?UnVPaWlQSVNxc2lMZDlYSVk1WFdETjk2ZDJJL2x5Rk55THFwVU5wbXBVTFh6?= =?utf-8?B?K1BFR3NTc0I5cDBXTE9GWHdiazk4bGROVFk2dnRBQmJhdTlSQy92TTZYSXVy?= =?utf-8?B?cldhaE1qT3E0ZlBKbkh1RmttMXBldWI4azc2S1o3VmxsVnR3WG0xUDJpRDJ1?= =?utf-8?B?Y0tnU2VrSElFSHkrbjhxK1NhTGlDU0JGZ0JFQ2Y4MVV4ak1NV3pjamVOZnht?= =?utf-8?B?MWt1SjN4aThkNnF0MTFzV2NiQXdQVEs4VjVOd1Z6UWh4Sys0WlQxVWtKMjA1?= =?utf-8?B?cU5qTFovcllmUFI4RTlxQ0tSNU1TRlJZM2xtdTBnSjhFdzczQVVDR2lEMnpZ?= =?utf-8?B?NUw5VUF1Q0lNS1pFZDZsTFoyZE03ZTU5RTd0a0pudFpwVjVjOC92NTdxckUw?= =?utf-8?B?QlpPbnVVemhBZHM5OTVMOWg3R0tMdzNIUEV0ZFBmUi80K2FNSFQ0b1A0Sm9C?= =?utf-8?B?Lzg4VW1XY2RuRU1ranVZNmFTclhUenpHLzFPMzhmZWZSTDVsclNMYk5FRGh1?= =?utf-8?B?MW9rSUZFYTBKaFE9PQ==?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(48200799018)(376014)(9140799003)(61400799027)(4113699003)(5113699003)(10067099003)(22082099003)(16102099003)(18002099003)(55112099003)(13003099007)(5063699009)(4143699003)(56012099006)(261028144727099003)(261021121427099003)(261026121527099003)(261026135527099003)(261022075727099003)(261026140227099003)(261009223027099003)(261102123227099003)(261022105027099003)(261022115727099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VU1Ufhzsct/azTqLefGkrjNKtxamoH+eGpD4y7gZz+wzMFbJR7OIEQit6ijmciFy0iFj7PQn3/pVC1xx5+DFsna64xoI+U2bYuJ5LsPigVepIJcqGsCqpYE2F44J++jyG3+VU6XFI2KolyW8j8UoGNj2brMTgkqjTFtPG7YDcQvvYdmOedgs8gRsj78mqTW3dz+09B+FN9YhBWpJXk+g1jXtKDZIBC6MV4gr+xuT8SsThlAr9og+2orWTISnQ41e5Xvfzhp1BrC4oPl54JF9c/YClCvN3Mb3RYvCkuZe0pijL682sO/6DRnnt6f/7oN12NiIXWhxN6GWQ/oI7uzk9vytwwY0fl7ARqk5azzlPjRWAVw5GyRZClrFeNoRKjyVw5DaGSw7j0Qb7q6XWeYwNuVdIhqG8TTC9SyH+T1nIJitp644P8X+0ZhHnfPSbIUO X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2026 14:43:27.7465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75371538-8741-4248-ca3b-08df3a81fceb X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MA3PEPF00000407.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7868 > From: Denis V. Lunev >=20 > qcow2_reopen_prepare() clears the dirty bit whenever the node is > reopened read-only, with an unguarded header write. A read-only node > can still be dirty, inherited from an earlier writable session, and it > holds no BLK_PERM_WRITE to resolve that. A read-only to read-only > reopen of a dirty image therefore fails outright: >=20 > $ qemu-io -r -f qcow2 dirty.qcow2 <<< $'reopen -r\nquit' > qemu-io: failed while preparing to reopen image 'dirty.qcow2' >=20 > Where the file node below is writable the write is not refused early, > and bdrv_co_write_req_prepare() aborts on its BLK_PERM_WRITE assertion > instead. >=20 > Clear it only for a node that is writable now, the predicate > qcow2_do_open() already uses for the repair. bdrv_is_writable() also > excludes an inactive node, whose header must not be touched either. >=20 > Signed-off-by: Denis V. Lunev > Reviewed-by: Andrey Drobyshev > CC: Kevin Wolf > CC: Hanna Reitz > CC: Andrey Drobyshev > Cc: qemu-stable@nongnu.org > Message-ID: <20260824133729.1141990-2-den@openvz.org> > Reviewed-by: Kevin Wolf > Signed-off-by: Kevin Wolf Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026110414411= 3.1587724-1-den@openvz.org?part=3D1