Re: [PATCH hci-dev 2/2] block: reject a reopen of an unusable node instead of crashing #VSTOR-140073

[no-reply@sashiko.virtuozzo.com]

> From: Denis V. Lunev <den@openvz.org>
> 
> qcow2_signal_corruption() drops bs->drv, so a node can lose its driver
> at any time and a reopen has to expect that. Both ends of the path
> assume otherwise:
> 
>   $ qemu-io -c "read 0 64k" -c "reopen -r" corrupt.qcow2
>   qcow2: Marking image as corrupt: Cluster allocation offset 0x1200
>   unaligned (L2 offset: 0x40000, L2 index: 0); ...
>   Segmentation fault
> 
> bdrv_reopen_queue_child() dereferences bs->drv while descending into
> the children the node opened itself, and bdrv_reopen_prepare() asserts
> on it. commit_clean() reopens the base of a commit job back to
> read-only, so a base which goes corrupt under the job arrives here too.
> [ ... ]
> CC: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> Cc: qemu-stable@nongnu.org
> Message-ID: <20260824133729.1141990-3-den@openvz.org>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261104144113.1587724-1-den@openvz.org?part=2