Re: [Devel] [PATCH hci-8.1 v2 1/4] dm-ploop: fix pio submission racing with the suspend and resume of a cmd

[no-reply@sashiko.virtuozzo.com]

> From: Denis V. Lunev <den@openvz.org>
> 
> ploop_submit_embedded_pio() tests stop_submitting_pios and then takes a
> ref on the current inflight_bios_ref index without deferred_lock. A cmd
> sets the flag and flips the index under that lock and then waits only
> for the refs of the old index, so:
> 
> - a pio that passed the check before the flag was set takes its ref on the
>   new index or on the already killed old one. The cmd does not wait for
>   it, and it runs while a merge, notify_merged, resize or delta index
>   update rewrites the BAT levels and deltas[];
> 
> - a pio that saw the flag set is added to llsuspended_pios after resume
>   has cleared the flag and drained the list. Nothing drains it until
>   the next cmd, the request never completes and a dm suspend of the
> [ ... ]
> https://virtuozzo.atlassian.net/browse/VSTOR-152985
> Feature: dm-ploop: ploop target driver
> Reviewed-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
> Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261104185519.1870488-1-den@openvz.org?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel