From: no-reply@sashiko.virtuozzo.com
To: "Denis V. Lunev" <den@openvz.org>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] net/ip6_gre: fix a host panic deleting ip6gre moved into a CT without ipgre
Date: Thu, 5 Nov 2026 14:43:16 +0000 [thread overview]
Message-ID: <010701a1ac2a005e-4574879e-0197-46fe-a5e8-74e480b74c86-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261105141726.2594661-1-den@openvz.org>
> From: Denis V. Lunev <den@openvz.org>
>
> ip6gre_init_net() frees the ip6gre_net of a netns whose VE lacks
> VE_FEATURE_IPGRE. Only the fallback ip6gre0 is netns_immutable, so the
> host can move any other ip6gre tunnel into such a container with
> "ip link set t6 netns <CT>". ip6gre_dellink() looks ign up in
> dev_net(dev) and reads ign->fb_tunnel_dev, so the node panics when
> container root deletes the tunnel or when the container stops and
> cleanup_net() deletes it:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000410
> RIP: 0010:ip6gre_dellink+0x37/0x60 [ip6_gre]
> default_device_exit_batch+0x8e/0x110
> cleanup_net+0x27a/0x490
>
> Take ign from t->net, the netns the tunnel was created in and is hashed
> in, as changelink, uninit and the ioctl path already do and as upstream
> does since commit b7c0d393e108 ("ip6_gre: Unlink ip6gre_tunnel_unlink()
> from ->dellink()."). The fallback device cannot leave its netns, so the
> fb_tunnel_dev comparison keeps its meaning. ip6gretap and ip6erspan have
> no ->dellink and are not affected.
>
> Fixes: 46c13c45f25a ("net/gre: Consider VE_FEATURE_IPGRE on new net creation")
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153615
> Feature: ve: per-CT features management
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261105141726.2594661-1-den@openvz.org?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-05 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:17 Denis V. Lunev
2026-11-05 14:43 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1ac2a005e-4574879e-0197-46fe-a5e8-74e480b74c86-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.