All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: "Denis V. Lunev" <den@openvz.org>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 2/3] ext4: discard the balloon on FITRIM
Date: Tue, 10 Nov 2026 22:35:39 +0000	[thread overview]
Message-ID: <010701a1c79a471d-b999ab4e-104e-4256-bb3b-3c9392c2434f-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261110222756.3236854-3-den@openvz.org>

> From: Denis V. Lunev <den@openvz.org>
> 
> The balloon holds file system space that never carries data, but its
> blocks are allocated, so ext4_trim_all_free() never discards them, and
> inflating the balloon is a plain fallocate() that does not discard
> either. Once the balloon is inflated over blocks that held data, e.g.
> on an online shrink after files were removed, the device below keeps
> them allocated: a ploop or qcow2 image keeps host disk space the
> container can never use, and compaction, which is FITRIM, does not give
> it back.
> 
> Walk the balloon after the free space in ext4_trim_fs() and discard its
> unwritten extents that fall into the requested range. The walk goes to
> the end of the extent tree, as fallocate() with FALLOC_FL_KEEP_SIZE can
> leave extents past i_size. Physically adjacent extents are merged into
> [ ... ]
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-153590
> 
> Feature: fs/ext4: fast online shrink support
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261110222756.3236854-2-den@openvz.org?part=2


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-10 22:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 22:27 [Devel] [PATCH hci-8.1 v2 0/3] ext4, xfs: " Denis V. Lunev
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 1/3] xfs: release the balloon inode when xfs_balloon_get() refuses it Denis V. Lunev
2026-11-10 22:31   ` no-reply
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 2/3] ext4: discard the balloon on FITRIM Denis V. Lunev
2026-11-10 22:35   ` no-reply [this message]
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 3/3] xfs: " Denis V. Lunev
2026-11-10 22:36   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1c79a471d-b999ab4e-104e-4256-bb3b-3c9392c2434f-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.