From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1d00715db-79285f5c-ce4a-4f48-bff2-eabe308e609c-000000@eu-central-1.amazonses.com> Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022121.outbound.protection.outlook.com [52.101.66.121]) by lore.virtuozzo.com (Postfix) with ESMTPS id 351CF803F6 for ; Thu, 12 Nov 2026 13:51:34 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L4wS96l3NsHrmqu8V1SUbDG78rqf5LIyfBAlf+M7SxDqRQao3be1IdmEgMr2R/ntxSCvjlu0prno+8URrUUqpJniCwendZLV9GfQp9Ufs6FZ73/XZEPpgDp2IwVFsdPFnb26SMEHV2w7lE7CtAFttbetFC7uCQEktPqZj4rmempxGk6IY63i1Ay22tuWv7aige8c13v0iTCiw1umMhO8e/ztLTnXIcX8rx1anF8c+yT76UJyYJhO8uf6+eTfKHM++3TcKcqnqfktL9+oVmXysUuCRYBrG1pIMv3tG5WzkDJMJKJ1ZE+87+zrG6Qyx7SeSmZDb3MAXtt1ixbDx+jXmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uGVgyFN1yXNA3a6eFWXMs/onr99YF/9nv677vUyu4Pk=; b=I1TY5EUZX7seY0zNNBVH20ybnRUKp1ZA02dbnspifeTVADD8KuC4xt8qqY1W7HlDERuPac4VB2gwCSI5pxH8Q3z7TIxTa+orp+2ideRqvNBfwrYt9VavxMdKE3Y9IIzRet5onOjQcH/zq+dWba6znAD0OstDwaJXsVsk/lb7kT7yw5LwfX00v726yoR7YzN1D7UEuS9KNBWU/s8v9N3d50XrleNhj18VMMoZP7MfuNZ1tN4+WRj749aozo3rft+upVKI2ajycUXmWgpMmjQ/iMfBiMifxwW0r4JO1Cejk/CNSh4NMm5DQU5l+fnZLRpiaez4PWPz3ppb0XhQlKyyUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGVgyFN1yXNA3a6eFWXMs/onr99YF/9nv677vUyu4Pk=; b=Cp6VgLT/AkvnXu0d+B4qRvvFw3n+ytXivRrYKk2aOq0bmQ0t+/GUQqzWhnXtnSL7N08muo0GqvhcjW3LtGhE0+VEWQ8b9US3nJ89couqb41H3JuU5NG6qUb5xquLz3UZk73N1fLTbf09zeona8+XEN16MHbeUKh27nQKJQyATOI= Received: from OL1P279CA0006.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:12::11) by GV1PR08MB10404.eurprd08.prod.outlook.com (2603:10a6:150:16f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Thu, 12 Nov 2026 13:51:29 +0000 Received: from WA1PEPF00009B3D.eurprd05.prod.outlook.com (2603:10a6:e10:12:cafe::a) by OL1P279CA0006.outlook.office365.com (2603:10a6:e10:12::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.10 via Frontend Transport; Thu, 12 Nov 2026 13:51:28 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by WA1PEPF00009B3D.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Thu, 12 Nov 2026 13:51:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1794491487; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=mStcwo7qaB6Qfqc5vKjcm08WkOFiArN+g6PPHlfHIN0=; b=McNMK3Il0NaRgQEsQtIBMpgPz2jEVNrLO3oTF0V5j/bvFWvplyvo6O+k70YXOavT CzrYFJwv7/vdz8VYUBer9Vael5IETrGnlP91dBjiDS+1KgBYVwM3c0reN/fVT/JWxe1 CvQFHD5QhktSttcKA13mR+SUlaKWe1Mr2OYc0giR8DuEqfrnnW/Oa6g9+hpuikeKbeC ECjrdu8qGGRV85xX9XsKCk0ekpRww+iNgXXCKPAAl2UBE+6mcJUAtXG8LPT/2/SUE0i 4RToC3ZEj2tJPJawMgFH57VAOvCt2JsmR5G6OH7NZC9muKEuKVzvKpwedbX0o07nPNN DAAKAM8PvQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1794491487; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=mStcwo7qaB6Qfqc5vKjcm08WkOFiArN+g6PPHlfHIN0=; b=RHbpJQMYzAiZ3oUQ5k1Vyva/x9nVlSrkdWyKnDF3tREstv7h6H2j4YrhBNT1ySx7 X/nYt2tHMx308hdMLPfcDWLqx174dBhxU0zzBp6pWcCT0dAOsMq4Pous0Dp+XGphH4g KoEW6QQD9hWnmBbuNJr751Vmc65BnjDCFHl0kMcI= Message-ID: <010701a1d00715db-79285f5c-ce4a-4f48-bff2-eabe308e609c-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-dev 1/1] hw/ide/atapi: fix abort on CD-ROM reads past LBA 2^31 #VSTOR-154795 To: "Denis V. Lunev" , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org In-Reply-To: <20261112134758.646697-2-den@openvz.org> References: <20261112134758.646697-1-den@openvz.org> <20261112134758.646697-2-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 12 Nov 2026 13:51:27 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.12-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: WA1PEPF00009B3D:EE_|GV1PR08MB10404:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 4b669d94-6bcd-42d2-77c5-08df40c40cfa X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|9140799003|376014|48200799018|32142699015|61400799027|10067099003|4143699003|5063699009|56012099006|261022105027099003|261028144727099003|261026135527099003|261026140227099003|261021121427099003|261102123227099003|261009223027099003|55112099003|22082099003|16102099003|18002099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dmc2dVVWR28rd2dldlR4SzhDbHBERXRUb3ppZmJDekg5czZKVUNnTXRpaTYv?= =?utf-8?B?cisyd0toZTY4MFNmZVFZN2k4WWtsV2Z3RjhTMWVHR2JsSUVzVUhiWFBLQjZN?= =?utf-8?B?T2d0L1ZhcGlvZGdzUmRIRmxtcERtWlhldmVMNVRpZ2p5eVlQTGVkOWl4bTJU?= =?utf-8?B?cUt4QndwZDVON3FqYjhoL0toV2pzT3FjM1dGUzN6bVVBVmNjMjNqZnZ2ajI1?= =?utf-8?B?RnBCMEs3OGhQcEZrZmVBcVI2SXltcGRaVStRL3hDZWtXSFVJTkNnay9LdWxt?= =?utf-8?B?ZFo1aW9TdVpGVHVrai8wdE12YUVVcWY1QjJYTVhKQ2gzN3RDWjNPQ0x3cUs5?= =?utf-8?B?SWRHRUE0aE9pRHFkV1h5MFc1WGlQN3V6NFA0UlpPQXQ5NHNWYllpbTQvcTFz?= =?utf-8?B?Y0xoT1JpRzAxWnNGd0xDcm1jOTVnbWdWaC9zZHUwcmN1Y1BIWm1jWlFqREw3?= =?utf-8?B?U2Q4QkRpYkdmdDNMRFZvdHovU0pMbFBUc3hpeHZBb2ppNHJMK0twKzNTMTZE?= =?utf-8?B?bHlFcm1CeGJuenV1UFhPTEJZL3phOXJ0QWc0dFdqVVN1VFVnblFDcWZXRUpO?= =?utf-8?B?RnI5L3lUU3U5aVUrVEpETEgrMGM2d0E5Z2hPaUN6VnVuU3RlT1grU2c3WXB3?= =?utf-8?B?Wk5qYnU1cEl4QXNvVmxmR3BMVFZpV2pCMTVvaEhLRVlUbGo5WkYwclpJVDQ1?= =?utf-8?B?NHZMdG5FSTJoUUdwUkNWQzlsWnZMcGp1eURibGZvTUloYU9zL1pZZklFa2lV?= =?utf-8?B?d1JWNitsNVAxQUMzWlFpK041cDAwT0QxckFuZDZBQ295eFFVKzJxNk15aHBF?= =?utf-8?B?TVd2b2ZuUXR0MllOL0tqQkJyQzhJbDJuUVAzdHM4L0xjSHh6RHpTdFJQdkVt?= =?utf-8?B?UUpQclBad2NrcGRTekVudFh0UnhadmxhMG1EUnlyZmo0YURoYXc1RHg5eVlY?= =?utf-8?B?M1NteHdBTE5RMDNKUE1xbVJ6SW5KR1dTaHo4VHFrYU0wRHAxa1FlbUVpY2ty?= =?utf-8?B?TkcwZ1p4NUlSRjhXQjl2bWhDVEFCUXVkaVlod0lnQ2kydEw2MWduQ2pHa09Q?= =?utf-8?B?QUdqMmhWMlFiTjJmaFFlTVBCMlArdGJGSTc5bW43VWc5bWMyN0Q2NFZyR3la?= =?utf-8?B?ZVN5NklWMUZ4UDllU1Y0S2Rmekx0bU12R1ROeFp0S0o4WlZESHU4NitocGZr?= =?utf-8?B?c1BaTU9iekw5YnNGeHhEQVdnMnp6Zk1VNzFPV0s3QW50aHpRYUljRjltdWIx?= =?utf-8?B?OFA2bTVUSm45SXBRV1Bsait0WHNJeXlBajJ5TjBWbUhWWFVWVDZqZVNKZU1l?= =?utf-8?Q?5yEsKdx6M1gDU=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(9140799003)(376014)(48200799018)(32142699015)(61400799027)(10067099003)(4143699003)(5063699009)(56012099006)(261022105027099003)(261028144727099003)(261026135527099003)(261026140227099003)(261021121427099003)(261102123227099003)(261009223027099003)(55112099003)(22082099003)(16102099003)(18002099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EeC2GuoxM6FkLuWbQVNshNIfHOnbA7kB+rgFaC39rkNUV/NPEq4QDGaQZupWPRnHN/ohKzYfWNkNvMsgmv47FFsVtqiMnHR+b0PaDjWTU1YCsNivn7tFeKT0Eq579mvgm9+dABEOZFwjELs/HF4u0h6MhJ9u/ngMfGnWR6CPPMquluwksHwS9qiXRSVkAM05j2pmgPkK0J+LNsWZQy7sS1q3BGE5lMGLWN1Q5bToDkgva7iYYqP8g8jLOgipKz3dpDULVZakz9j9WPWrxpMNKtmfm+G3Ixjc59K/ItGlGQNbgTiPE9TgllVDCuMv7KQO/6lPm3CBnF92o2qlNmsGBxXRTgcFgrj4+9uTMo2+ZoP6lImcUCkS9szZ+6ujUg+VDqARqgWwX2R8RIFU7tyAeDwXZ8LK1c/FpF6n8hHoGjj9b/kYJ/P7JhkF7ReXipAl X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2026 13:51:28.4108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b669d94-6bcd-42d2-77c5-08df40c40cfa X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: WA1PEPF00009B3D.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10404 > From: Denis V. Lunev >=20 > cmd_read() and cmd_read_cd() check the 32-bit LBA from the CDB against > the medium size, then pass it to ide_atapi_cmd_read() as an int. On a > medium larger than 4 TiB, a read at LBA 2^31 or above passes the range > check, turns negative and trips the assertion: >=20 > hw/ide/atapi.c:315: ide_atapi_cmd_read_pio: Assertion > `0 <=3D lba && lba < (s->nb_sectors >> 2)' failed. >=20 > Reading the last sector is enough, e.g. a UDF anchor probe, so the > guest aborts QEMU just by looking at the disc. >=20 > Pass the LBA as uint32_t, which is what the CDB carries, and widen > IDEState.lba to int64_t so it holds every valid LBA and keeps -1 as > the "not a sector read" marker. The field is not migrated. >=20 > Fixes: b8d7f1bc5927 ("ide: atapi: check logical block address and read si= ze (CVE-2020-29443)") > Signed-off-by: Denis V. Lunev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026111213475= 8.646697-1-den@openvz.org?part=3D1