From: no-reply@sashiko.virtuozzo.com
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>,
khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] drm/amdgpu: free the buddy allocator when dmem region registration fails
Date: Mon, 16 Nov 2026 03:45:52 +0000 [thread overview]
Message-ID: <010701a1e276188f-1099b5d6-460f-4295-9335-b528cd5dc1bc-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116033832.26787-1-mirian.shilakadze@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdgpu: Fixes tag cites ffbc4c6f4d0b, not in baseline
history
--
commit 6e9e31d0a13bdda4472b468f1406f2c15cf25c56
Author: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
drm/amdgpu: free the buddy allocator when dmem region registration fails
When drmm_cgroup_register_region() fails in amdgpu_vram_mgr_init(), the function now calls drm_buddy_fini() before returning the error. Previously the buddy allocator initialised just before was leaked.
> drm/amdgpu: free the buddy allocator when dmem region registration fails
>
> Since commit ffbc4c6f4d0b ("ms/drm/amdgpu: Fix init ordering in
> amdgpu_vram_mgr_init()") the dmem cgroup region is registered after
> drm_buddy_init(). When drmm_cgroup_register_region() fails,
> amdgpu_vram_mgr_init() returns without drm_buddy_fini(), so a probe
> failing there leaks the buddy allocator.
>
> Free it on that error path. Upstream does the same in commit
> bd4f284df04d ("drm/amdgpu: Wire up dmem cgroup reclaim for VRAM
> manager"), which also wires up dmem reclaim and is not taken here.
>
> Fixes: ffbc4c6f4d0b ("ms/drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init()")
> https://virtuozzo.atlassian.net/browse/VSTOR-154845
> Feature: fix ms/drm
> Signed-off-by: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
[Severity: Low]
Does the Fixes: tag name the right commit? ffbc4c6f4d0b is not in the baseline history, so the tag and the "Since commit" sentence do not resolve on this branch. The commit already on the branch that moved drmm_cgroup_register_region() after drm_buddy_init(), and so opened this leak, is 6221d6dc707e ("ms/drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init()"). Should both references be changed to it?
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116033832.26787-1-mirian.shilakadze@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 3:38 Mirian Shilakadze
2026-11-16 3:45 ` no-reply [this message]
2026-11-16 16:03 ` Konstantin Khorenko
2026-11-16 16:03 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e276188f-1099b5d6-460f-4295-9335-b528cd5dc1bc-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=mirian.shilakadze@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.