All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] ms/eventfs: Use list_add_tail_rcu() for SRCU-protected children list
Date: Mon, 16 Nov 2026 14:45:21 +0000	[thread overview]
Message-ID: <010701a1e4d1dc41-f80498fc-defb-4bcb-baff-176696b340f2-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116144143.624802-2-eva.kurchatova@virtuozzo.com>

> From: David Carlier <devnexen@gmail.com>
> 
> [ Upstream commit f67950b2887fa10df50c4317a1fe98a65bc6875b ]
> 
> Commit d2603279c7d6 ("eventfs: Use list_del_rcu() for SRCU protected
> list variable") converted the removal side to pair with the
> list_for_each_entry_srcu() walker in eventfs_iterate(). The insertion
> in eventfs_create_dir() was left as a plain list_add_tail(), which on
> weakly-ordered architectures can expose a new entry to the SRCU reader
> before its list pointers and fields are observable.
> 
> Use list_add_tail_rcu() so the publication pairs with the existing
> list_del_rcu() and list_for_each_entry_srcu().
> 
> Fixes: 43aa6f97c2d0 ("eventfs: Get rid of dentry pointers without refcounts")
> Cc: stable@vger.kernel.org
> Link: https://patch.msgid.link/20260418152251.199343-1-devnexen@gmail.com
> Signed-off-by: David Carlier <devnexen@gmail.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> [ adapted scoped_guard(mutex, &eventfs_mutex) block to explicit mutex_lock()/mutex_unlock() pair ]
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 1801ce6ce6f9f1df134987e6bc47d28c1ebe9a51)
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-154848
> Feature: fix ms/tracefs
> 
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116144143.624802-1-eva.kurchatova@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-16 14:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:40 [Devel] [PATCH hci-8.1 0/2] ms/eventfs: RCU handling fixes Eva Kurchatova
2026-11-16 14:40 ` [Devel] [PATCH hci-8.1 1/2] ms/eventfs: Use list_add_tail_rcu() for SRCU-protected children list Eva Kurchatova
2026-11-16 14:45   ` no-reply [this message]
2026-11-16 14:40 ` [Devel] [PATCH hci-8.1 2/2] ms/eventfs: Free the eventfs_inode after an rcu grace period too Eva Kurchatova
2026-11-16 14:45   ` no-reply
2026-11-16 17:02 ` [Devel] [PATCH hci-8.1 0/2] ms/eventfs: RCU handling fixes Konstantin Khorenko
2026-11-16 17:02 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e4d1dc41-f80498fc-defb-4bcb-baff-176696b340f2-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.