From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/2] ms/mptcp: fix subflow bitfield misuse
Date: Mon, 16 Nov 2026 15:00:27 +0000 [thread overview]
Message-ID: <010701a1e4dfb1ac-4a4b3dc7-cb44-4b31-8814-2f543b77586d-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116145652.625598-3-eva.kurchatova@virtuozzo.com>
> From: Paolo Abeni <pabeni@redhat.com>
>
> The subflow status bitfield is protected by the subflow socket lock,
> with one notable exception: the `close_event_done` bit is actually under
> the msk socket lock protection.
>
> As reported by Clashiko [1], flipping the latter bit may corrupt other
> entries in the same bitfield.
>
> Move the `close_event_done` outside the bitfield, in a 32bit hole.
>
> Link: https://lore.kernel.org/178959153492.22033.1944011998010756543@kernel.org
> Fixes: d82809b6c5f2 ("mptcp: avoid duplicated SUB_CLOSED events")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Link: https://patch.msgid.link/20261013-net-mptcp-misc-fixes-7-3-rc8-v1-2-932c9b182fc7@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> (cherry picked from commit 7538fa33bb2f66b8b809ff39d58308be48e197a0)
>
> Rebase note: this tree has neither the "closing" nor the "resetting"
> subflow flag, nor lent_mem_frag, so __unused grows from 9 to 10 and
> close_event_done goes after fully_established.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-154927
> Feature: fix ms/net
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116145652.625598-1-eva.kurchatova@virtuozzo.com?part=2
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:43 [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport mainline fixes Eva Kurchatova
2026-11-16 14:43 ` [Devel] [PATCH hci-8.1 1/2] ms/mptcp: do not reschedule the RTX timer for fallback sockets Eva Kurchatova
2026-11-16 15:02 ` no-reply
2026-11-16 14:43 ` [Devel] [PATCH hci-8.1 2/2] ms/mptcp: fix subflow bitfield misuse Eva Kurchatova
2026-11-16 15:00 ` no-reply [this message]
2026-11-16 17:03 ` [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport mainline fixes Konstantin Khorenko
2026-11-16 17:04 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e4dfb1ac-4a4b3dc7-cb44-4b31-8814-2f543b77586d-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.