From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request
Date: Mon, 16 Nov 2026 15:46:56 +0000 [thread overview]
Message-ID: <010701a1e50a4015-68e31abe-8594-4ae9-b5a3-204d161835b1-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116154119.2979718-5-alexander.ivanov@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dm-qcow2: bug-fix commit lacks a Fixes: trailer for the
unconditional timer rearm
--
commit f6ae30bd65b89326d336e21edcc9fd1610542f23
Author: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> drivers/md/dm-qcow2: arm the hold timer only for the first held request
>
> Every held request rearms tgt->held_timer, so while new requests keep
> failing the held ones are never retried. A guest that keeps writing to
> a full disk is enough to postpone the retry indefinitely.
>
> Arm the timer when the held list turns non-empty, so the held requests
> are retried a fixed period after the first of them failed.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-152175
> Feature: dm-qcow2: block device over QCOW2 files driver
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
[Severity: Low]
This reads as a bug fix: the unconditional mod_timer() came in with the original ENOSPC handling, and a guest that keeps failing writes can postpone the retry forever. Should this carry a Fixes: tag, for example:
Fixes: 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events")
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116154119.2979718-1-alexander.ivanov@virtuozzo.com?part=4
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 15:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:41 [Devel] [PATCH hci-8.1 0/9] dm-qcow2: support the werror/rerror policies for vhost-blk disks Alexander Ivanov
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 1/9] drivers/md/dm-qcow2: cancel the event work and ENOSPC timer in the destructor Alexander Ivanov
2026-11-16 15:46 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 2/9] drivers/md/dm-qcow2: always resubmit delayed ENOSPC requests in presuspend Alexander Ivanov
2026-11-16 15:45 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 3/9] drivers/md/dm-qcow2: rename the ENOSPC delay list to a held request list Alexander Ivanov
2026-11-16 15:45 ` no-reply
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request Alexander Ivanov
2026-11-16 15:46 ` no-reply [this message]
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 5/9] drivers/md/dm-qcow2: report held requests with an IO_ERROR uevent Alexander Ivanov
2026-11-16 15:49 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 6/9] drivers/md/dm-qcow2: add the resubmit and fail_held messages Alexander Ivanov
2026-11-16 15:48 ` no-reply
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 7/9] drivers/md/dm-qcow2: add the error_policy table argument Alexander Ivanov
2026-11-16 15:52 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 8/9] drivers/md/dm-qcow2: requeue held requests on a noflush suspend Alexander Ivanov
2026-11-16 15:51 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 9/9] drivers/vhost/blk: fix a hang on release after the vhost worker is killed Alexander Ivanov
2026-11-16 15:56 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 17:24 ` [Devel] [PATCH hci-8.1 0/9] dm-qcow2: support the werror/rerror policies for vhost-blk disks Konstantin Khorenko
2026-11-17 9:03 ` Alexander Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e50a4015-68e31abe-8594-4ae9-b5a3-204d161835b1-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.