From: no-reply@sashiko.virtuozzo.com
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>,
vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com,
Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v6 3/5] ve: Defer ve creds drop until ve is completely destroyed
Date: Mon, 16 Nov 2026 16:14:07 +0000 [thread overview]
Message-ID: <010701a1e523243d-a01ec23e-fbf3-4932-baef-dc0e0e6278cd-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116-ovl-use-orig-ve-v6-3-7cfb41c8c973@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ve: stale 've isn't running' comment in netlink_ve_capable()
after init_cred change
--
commit 0ce43e99309aa75e8847e7c9d6dca465801086bf
Author: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
ve: Defer ve creds drop until ve is completely destroyed
The patch moves put_cred() and the init_cred = NULL store out of
ve_drop_context() and into a new ve_drop_cred(), which ve_destroy() now
calls. This keeps ve->init_cred alive while a dead VE still has users, such
as an overlayfs superblock.
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 6de4dcba2283..68c3d5288ba7 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -395,7 +395,7 @@ bool ve_capable(int cap)
> rcu_read_lock();
> cred = ve->init_cred;
>
> - if (cred == NULL) /* ve isn't running */
> + if (cred == NULL) /* ve isn't started */
> cred = ve0.init_cred;
[Severity: Low]
This isn't a bug, but the same NULL-init_cred fallback in
netlink_ve_capable() in net/netlink/af_netlink.c still says "ve isn't
running". Since init_cred now stays set after the VE stops or dies, and NULL
means only that the VE was never started, should that comment be reworded
to match?
The commit message also doesn't say that capability checks against a dead VE
no longer fall back to ve0.init_cred. That looks like the intended effect, so
could it be mentioned?
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com?part=3
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:06 [Devel] [PATCH hci-8.1 v6 0/5] Fix kernel crash in overlayfs Vladimir Riabchun
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 1/5] ve: Remove STOPPED state Vladimir Riabchun
2026-11-16 16:10 ` no-reply
2026-11-16 16:25 ` Vladimir Riabchun
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 2/5] ve: Introduce override_ve/revert_ve helpers Vladimir Riabchun
2026-11-16 16:12 ` no-reply
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 3/5] ve: Defer ve creds drop until ve is completely destroyed Vladimir Riabchun
2026-11-16 16:14 ` no-reply [this message]
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 4/5] ovl: Keep creator VE in overlayfs superblock Vladimir Riabchun
2026-11-16 16:13 ` no-reply
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 5/5] ve/overlayfs: Override VE together with creds Vladimir Riabchun
2026-11-16 16:19 ` no-reply
2026-11-16 16:52 ` Vladimir Riabchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e523243d-a01ec23e-fbf3-4932-baef-dc0e0e6278cd-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=vasileios.almpanis@virtuozzo.com \
--cc=vladimir.riabchun@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.