All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>,
	Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.2] fs: forbid freezing and thawing file systems from a Container
Date: Tue, 17 Nov 2026 14:02:37 +0000	[thread overview]
Message-ID: <010701a1e9d11853-080fc7e6-f704-48bc-b898-4a0627f92631-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117-ct-fsfreeze-v1-1-23272094ba36@virtuozzo.com>

> A Container can freeze a file system it mounted itself, since
> ioctl_fsfreeze() and ioctl_fsthaw() only check CAP_SYS_ADMIN in
> s_user_ns. That is a bad thing to allow:
> 
>   * Processes on top of a frozen file system hang in the kernel, so
>     CRIU can neither ptrace attach nor freeze them and the checkpoint
>     fails.
>   * CRIU does not dump the frozen state anyway, so after restore the
>     file system comes back thawed although it was frozen on the source.
> 
> Nothing vital inside a Container is known to need it, and most file
> systems a Container sees are not freezable at all. So keep the
> existing check and return EPERM for FIFREEZE and FITHAW when called
> from a Container.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-155592
> 
> Feature: ve: allow various syscalls in CT root userns
> Suggested-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> Signed-off-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117-ct-fsfreeze-v1-1-23272094ba36@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-17 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:59 Vasileios Almpanis
2026-11-17 14:02 ` no-reply [this message]
2026-11-17 14:08 ` Pavel Tikhomirov
2026-11-17 14:55 ` Konstantin Khorenko
2026-11-17 14:55 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e9d11853-080fc7e6-f704-48bc-b898-4a0627f92631-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    --cc=vasileios.almpanis@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.