From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020086.outbound.protection.outlook.com [52.101.84.86]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4927B803F6 for ; Tue, 17 Nov 2026 17:41:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QcilkiAQfMYKSLM9PVmvWOPqzRIffQiobSu4tB/Y3ukqzRIYQe3qedZpeCf9ZPPKozvW8XOUvI1ydCbUELMBSldiIFPZHgOrLJOa3kmxQ13Gql7qsgLrb19UGMYZLZXS4QJRBtKiyS9fh9KH/V0SXxLWfmlGLdOTEw5PhDLs0KvYLheDraDJvdogpjza8EXFQG43DZnJZrNM7/JOzzTwrrCpR6mb6M2UeJDIINkyjxvitCs1/f2+mVCR4Cnrudh82G/qQInJVzXxASzQkCjCg73Qz6/weHWLKtXV8x+PyAsBmSSuaOZji/3KjZLpA7oFfgWCB9Hkc/nixfSR8tNpMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vKxEGJ9mtcH0zUIUnG3BmuBU/Dg+dOhHUbbOQ0P89x0=; b=K+lzTpTupK2YtDvO67SM5q+BErIOFv1pOu67/HY6BI0qKF02rQ9cqWQ8koWNApQhHXob1A1sfSOPXM858vdoNnL55BgIMZ2t/FqK2bHvHKsyLI3lofwHNIUYGLOT7KShn3GfnML2JZRliA05GICkmnsXLblFBFA+RdWjgt12wKUlJt80KQwFhRyzwfz5dRV+vLl3gp6lyztN7t/nTLlPmnW7ifXtUJsurRAqujKoiLKWS2+JzVDDwCywwaJlCCtxuJOpcnSMwbD5k/cirjgghCeTK/VXbcsvWX7PJhHhrBP3hF+Vlg8NuHBMM7Y53SCNaozC674LI4VYzZMoyC/bSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vKxEGJ9mtcH0zUIUnG3BmuBU/Dg+dOhHUbbOQ0P89x0=; b=JeRIMPe+MQyB4pjEq1o5bexySB7bnzCMcvmMXsko768IvIXakNXYrvrl15myaNzhMfW14vhoXv5OCfMvqbJPfwoqEu3y51ArxmjjwH8ooZvNF10YACHSbYgYq8bhgikYy5CX/kaFB/qCBwtaalnX/Z6vKoYHX0eP0hTmEE2KxAM= Received: from AS4P195CA0050.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:65a::8) by DU0PR08MB9418.eurprd08.prod.outlook.com (2603:10a6:10:421::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 17:41:33 +0000 Received: from AMS1EPF00000093.eurprd05.prod.outlook.com (2603:10a6:20b:65a:cafe::73) by AS4P195CA0050.outlook.office365.com (2603:10a6:20b:65a::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.13 via Frontend Transport; Tue, 17 Nov 2026 17:41:32 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AMS1EPF00000093.mail.protection.outlook.com (10.167.242.90) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Tue, 17 Nov 2026 17:41:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1794937292; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=vKxEGJ9mtcH0zUIUnG3BmuBU/Dg+dOhHUbbOQ0P89x0=; b=hsKQNKNkXdTUlUbRsfmap76BH1NTsFF0udtHs5clVXWaOyvZhmTPWjr4xIvpk2P+ l5nS9P8bEGnwX+aiYEP7rqopfl0PlnVTe188FzEjH9PNDY2nhpIpoKJO2KFO1K6qQOQ uXKcx0TVhrf2cxV7eIDwYKsowurl2pddMqhBqQMV5RlWWkU0EPfH3feVLFq2UUOVjSQ SbTKB6H1kyIA4Lw5UbkVwjZOBna8Mh6apxVWNfbfc36lG7WRyooL6PELAzz49sesKA1 b9CMEeccMP8Rlzf1dta9P88kt3rYIQ0JckPfL8gQ7VuBvMqr/X6iqCyNhOnhOH+hvF4 HQF3LLIGAw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1794937292; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=vKxEGJ9mtcH0zUIUnG3BmuBU/Dg+dOhHUbbOQ0P89x0=; b=Z7bvGDGZbxUAy4CLtttTq1cM+nFKzzCJ1NnTWJKQlSIrb/8k9fINVYLE1HOReUzG MJirhN6U27zH7rb8+rSWO+bFlMlmqfQtSokGbXsQyInYYr9toOk2s03Tl8lJPaWVOOf Kfvz2cLxWyQDRflHXPZ15H8/Eqo0+ltiJAZlA2oM= Message-ID: <010701a1ea99860d-03af8592-9e49-4cf2-bd85-351b15818844-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-8.1 v6 3/7] vhost-blk: use a local vhost_dev pointer in start and stop To: Alexander Ivanov , andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com In-Reply-To: <20261117173734.3225443-4-alexander.ivanov@virtuozzo.com> References: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> <20261117173734.3225443-4-alexander.ivanov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Nov 2026 17:41:32 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.17-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000093:EE_|DU0PR08MB9418:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3c70a312-dec6-41be-db83-08df44d204fb X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|376014|48200799018|61400799027|18002099003|22082099003|16102099003|5113699003|4113699003|55112099003|13003099007|5023799004|4143699003|56012099006|261022075727099003|261026121527099003|261028144727099003|261021121427099003|10067099003|5063699009|261026140227099003|261009223027099003|261102123227099003|261022105027099003; X-Microsoft-Antispam-Message-Info: LEwL4w0DXvFQoaLxETZAcWqiWtKCA8h86YF06O57BBTEgBWzM5zU0mzKqvtCwNYLLTAqa6qyFczh5BZfpfQhTfPHj0jql6nCHR2mXA7Rpft4IAzDGveGCyPzdRYLaUsq8odjao6+uk989lbeVxnHirFVmt8ar23aTJGzxmPR2rFyB4i7t5jtqg34Xw1PL9bTFmuibC7MfrfnrAzyYYp7r6V8Z0cY+WeCjAEFU4w//cN4nr+ayx+0WsoWHq3O65Gw16u75LYgOvHX8xGqH/Gb40KHoNBI4FmwMG/1IyZQv2KDC9MNyM0dp0nGNUFEKGRA7QiencAHrTlN5gmhM3e26ziNFpV/eqQxQVmHE+XgfT2oBM5Hjo1TRTmLK0w8z/MyExQfodTUDp+QNxl9wEkHoTGInSoCa74nmEOedKFYovoB4s/ITZkUj3L7OcB5jI7YTTDjg4c1L15N5Fud9/sR2t3Bzgp5lDIttvPD4PkMRcU1xOWbKi/ujAwocfdduZAywl+fE/bqHarvFNkT2sgf/IBFpkSx1aRUQ8JyQzNJlgyJeWdnxvt3qfISk2AyKbvPXx59l5yIjyDCArGHDpcYKtnxdJh9K0p69AsyeAUnZ+GzQ4+bgNhQElweuuGbpV/2ZAGGD0Kn4PMQNo4iAvOHn4AWNbVqrxEqeBRHfBdPWmxB3YPp4VYNXw9ZPm3ct0GxHdOwSDAa1T2G6h+nV1+YJocOaKn6FmrAMqlkS6dahLjz3tHpV07T9TSUnIdUF2BNcLsnO30r3YlU5gZxflUyC/GEnE6MvtZbn0Bh7uO5x+/ClPfF694MWCQlm5Daf/DyBkr4Q1btJdYD1Ui5b8mxKA== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(376014)(48200799018)(61400799027)(18002099003)(22082099003)(16102099003)(5113699003)(4113699003)(55112099003)(13003099007)(5023799004)(4143699003)(56012099006)(261022075727099003)(261026121527099003)(261028144727099003)(261021121427099003)(10067099003)(5063699009)(261026140227099003)(261009223027099003)(261102123227099003)(261022105027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: clfReXtGGvSaDZEG+ixo1jZoGWnN5o8N94QAuwS0NIhtoSsb5rzxECq/tdY7Pyp9xS0mwljTBIetKa0qQcbAQ4rNum3R0/iLH3x5lWsZa/aRkQ0JVGakDiO/CUSSTrtkccV9BlG4UBf1aFQ+nBmcqwsGgxOHgS6BEAqww2KwB4z0hfebFoUIpOLhQZLGg8oLFRFr+thSBwRSvUYMywZuwyQ57u3mubfBsYGtX6cD1fZxJLMHyKSAVD2qMCwuOquh7DUqHsr0EWHnBnLGYBYL5BV9Rp+G7F0i5UDwsrimftDnH89QbelFRUwJeesyqd8Upb+mL+c/xQaaVddPzOA1nN6n+a9dUNQyGplBNv9jDg3YhnwWk99ri8W7FraU2A/+iJHbSJEvZQ/TMjF4TosWtM6tyYFpSjJpfsrzt+9AbCxTn4fz8jk1AZUzJaC5F/Y6 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 17:41:32.6722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c70a312-dec6-41be-db83-08df44d204fb X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000093.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9418 Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] vhost-blk: Fixes: trailer on a no-functional-change refactor -- commit 0d672950c3904c71a55c82c916f27588ac3348b7 Author: Alexander Ivanov vhost-blk: use a local vhost_dev pointer in start and stop This commit adds a local struct vhost_dev pointer, hdev, in vhost_blk_start= () and vhost_blk_stop(). It replaces the open-coded &s->dev and s->dev. uses with hdev. > vhost-blk: use a local vhost_dev pointer in start and stop > > Take &s->dev once into hdev in vhost_blk_start() and vhost_blk_stop() > instead of spelling it out at every use. No functional change. > > https://virtuozzo.atlassian.net/browse/VSTOR-107537 > > Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") > Signed-off-by: Alexander Ivanov [Severity: Low] Should the Fixes: tag be dropped? The message says "No functional change", = and the diff only introduces a local alias for &s->dev. Commit 0ff3cb5ff28f= ("block: add vhost-blk backend") merely added the file, and nothing it int= roduced is being repaired here. With the tag present, stable or downstream backport tooling may select this= cosmetic cleanup as if it were a bug fix. --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026111717373= 4.3225443-1-alexander.ivanov@virtuozzo.com?part=3D3