From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9B4848015C for ; Fri, 11 Sep 2026 17:20:08 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68BHHhY5004384; Fri, 11 Sep 2026 20:17:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68BHHhY5004384 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CcHS2zsc" Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68BHHeqf004380 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 11 Sep 2026 20:17:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68BHHeqf004380 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-86bb318386dso594758b3a.1 for ; Fri, 11 Sep 2026 10:17:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AKwUvBx8dhqD1SmIxbgTwxtqmv7JaKPPjuqOBCj8aRpBHDbViZ4Pi+7l2Z3khUhr1dzwDQwTFknynQ==@openvz.org X-Gm-Message-State: AFuF++le2TaRBciIaHyW9p7NlEImpSAN0fTchega1pVqFN2cXQ2WWIz/ 6cNfuxQfHMGdpT3RVx/SVw5C7dSJg5fKbIwnk0EA9vXiDZ5PF7pn73+9C9mHzGremdhugSTlVFB FL2QLh/0qU+B29R3aTAKp2PIHrzQeNJSy9Ov/Kz7WxsaF0FDeQ+kYyg== X-Gm-Gg: AYBFou0CKE7vHkt6YXPVJQFgOa3tzVBN0EJhyuVc4A7LJ6kR9GkiFa9EqPJFbe7gkwz 8O3SHpU/0k6JESbMUrM1fMeKVzVEEVk1ZkFbX1qbdyZVxcPqKUOtBJAnu4FZooWoXtVlBHnCssk 2bR4s/1WaixRsuOa8BY3ubKCgWwQyJFuWgBoURm56YQfpFkHhFQ5rWUYRObwpNZzv6ytwx+dI32 y0sJiWUs5v7LVqYK2Uog1eQy8FhR+brqXk+LRwdtUCAZe41SvJWwGU881jLTazmJIabT3k23so3 eysYwISjcGbTzaU8leY00+UgFWuxAFbxeG8uoa23ZpYpaDS46zFgsm+XBKjn/0cMRnAxOaGtvKX RUXZlb2JgPU3sCatT4FdKv11PX1ICgAyn6l2093UG3oVmRFXVCmwCw8NzdDY1KCvTnhV75csSZu MkZI+PdhdliWcAQzwnTsz0xflARalYhm04sQ8g X-Received: by 2002:a05:6a00:c1c6:20b0:86c:52fd:fbdf with SMTP id d2e1a72fcca58-86c52fe0a64mr1119529b3a.20.1789147059601; Fri, 11 Sep 2026 10:17:39 -0700 (PDT) X-Received: by 2002:a05:6a00:c1c6:20b0:86c:52fd:fbdf with SMTP id d2e1a72fcca58-86c52fe0a64mr1119445b3a.20.1789147058527; Fri, 11 Sep 2026 10:17:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1789147058; cv=pass; d=google.com; s=arc-20260327; b=bG3J2ntl4LH+GoHey5eHtCcb4xsHmIW+wRfudb0tePVtGbzdgBbobyoyLCgsgny+Wp y5A7JatL4jSF3IMib8KjjmV90HK4qyrdgTO0l24WiJThnXfek8Gm+OurSh4gIqB2XsY5 Oonq1OxKlWmt52DEzYrdA7ct74HAPcsLfMQZbjTv32rziWQ7FiyFatTKIRPzvlxfIb9t fGKkEYM/VjsGH4gde23yo0LGb7RW4naoQLJJiYZHmA0ldRLQfHrM7vnp4Wx0xEsjeT5K cO89OWNp7MnJ3FfO1AF+UCW0i7MdbIsm3OzITu2Md2OZY8JdD5YrrUId6nkXa5EjMzke UZQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=pzKktmP+8F8g3KPqfKyCa/eUkucWuyQ/EYEFeZC+elk=; fh=JElik/xo2VLwrDzoxP83djEKPD6+ZjyGMXkIgNOckzE=; b=hm035EmMAg/Wm2ZJ5vR82ObjhCgnbCfO1qgjjZ3CiJGz6l4dz0QDCbmMVeEg3lSm3u AOJ10BRLN5ljnTEkl8od2a9Hki0peRcnMeSpsTi7oqZOHE/sz9Mfe9+ui1IPVgs2Alub 7FKGmtA3Mxj0oHqYPAHW2DW/QddMHrKlE8m+hpSrJlIuZYLQsz/Xb8b7cKRBmWrT1jU8 Dmj+D50s99G++g3PZZzjrTWB47zOjn1lyb32iekCwuL7GFidkJlDK8RlrQ5vbU1qnkAb dyR2e+4y1jITZpCZhlWdsLP1RmBXWiWxlAwf6tEvHjhBz87sFyjtXj9hXCWaaFS/hF2R P3LA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=CcHS2zsc; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-cc4c6622d39si4962049a12.197.2026.09.11.10.17.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 10:17:38 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=CcHS2zsc; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wrpYaXu2BHjUXHp84yllG3y0JwXbOekI1zgHlxfBVb5NiEo7OIzRAoywuAc7H6MYlX8F7UsZ6xMgheeVWg3iJiBFJ7jqfl9JfiNUg7BlUm22Nolo9rUSOsRZz0k/NMt50h2OiaL6Cg3oNWbL84mD+KL0VF4wsoHLZJ04mjS6gf0Q+yknZENyj8N6mYV2larp6odOBOp4StxjiXizccvh/22d+IDPSqv15/1zWu211/tMD9NBUS9CPBD0ptqS8Sx5vj5Y4c4i3gL0jkkjF3nXQZtq2XN9WwRItQ2OjBitz1EoBJ4wSwK39Eb5I+ZbCIzn76tY8QQex0zdwMd3aoP6JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pzKktmP+8F8g3KPqfKyCa/eUkucWuyQ/EYEFeZC+elk=; b=xniKaW88QKlVdlHVszipHT1zsvSG3zXDCEj+gPU6+01tQhkvFiLlDxnGYO4UQ6Epofprq0dIqWZ+NPzd7Qq7207wJTgC5s4COwhymfzFMYRLNW+EYa0hWcHxufJZUVTgdn0team4aFINuGxrpNe8N8xtjNoQ2gkvnvaX+u8WGOmQ/txwfbp5SaBEtqEl2C/E9BDtfwH7qlqvCJE6HcD53qzAFACxuFi9bVzcRbeVqPMWlNzbNpDEnOXn8RO3WqjWxLC9JmipbVgF9Fh1FpI+6ye3VnrKFCG1ilVpAqBsV3qUN2sA7sUGnLrzAmk0NWkmaCqEarhK6HijWRN/iU5t3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pzKktmP+8F8g3KPqfKyCa/eUkucWuyQ/EYEFeZC+elk=; b=CcHS2zscqLlEQKlDjgJ9FJw8rkf0SgWcl4ZGM6EceFxDnSqcAmzqZLwLsSgl/E5DTc6/RFQyVRFyYajoKcjjn2Zu8OzuVE+I2lmhOY8nTkh+TSbEXO4eXdPVOnz4PryDT2TMogwfZQwcT+dYd/VgvuLE7fCtaEKp/uCvsa1WnkdnDPrvnZxKxASvo+eukwZmSWxFEwpPus7+qEuxpPvRKQHHzp2ppKE32v3siPbBE4jxaycqoE9cSi58ANY4kbqdeKNZ0CnnTSBhxrw8Ti/lczV6XAFgR+Hy1DvREmMdhKfhDkz9So6xAvY38HNJCsjBsHYDWKG53dqtNMStUa9MHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DU0PR08MB8470.eurprd08.prod.outlook.com (2603:10a6:10:406::17) by VI3PR08MB517319.eurprd08.prod.outlook.com (2603:10a6:800:37b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Fri, 11 Sep 2026 17:17:34 +0000 Received: from DU0PR08MB8470.eurprd08.prod.outlook.com ([fe80::3db0:9d70:4641:5f47]) by DU0PR08MB8470.eurprd08.prod.outlook.com ([fe80::3db0:9d70:4641:5f47%4]) with mapi id 15.21.0406.005; Fri, 11 Sep 2026 17:17:34 +0000 Message-ID: <06933256-8f8f-4e69-bd52-2ef7a0de1b97@virtuozzo.com> Date: Fri, 11 Sep 2026 19:17:32 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , Vasileios Almpanis , OpenVZ devel list References: <20260911161054.2251394-1-khorenko@virtuozzo.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <20260911161054.2251394-1-khorenko@virtuozzo.com> X-ClientProxiedBy: VI1PR06CA0221.eurprd06.prod.outlook.com (2603:10a6:802:2c::42) To DU0PR08MB8470.eurprd08.prod.outlook.com (2603:10a6:10:406::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8470:EE_|VI3PR08MB517319:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a480691-0043-42a1-0cf8-08df102891bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|6133799003|10067099003|22082099003|56012099006|5023799004|18002099003; X-Microsoft-Antispam-Message-Info: hYDvR/jyxHuBL6ustDDf1etYiVQMsJSTbv2Tdn98TU2JVcDAni7AbqUV4YKqkQq3/wS7SVMe0YG9DwgBO3W/KlcOV8VJBGSM4gjTWz/YbJYMA8FV9dodeT6iKmdMfZV7SQMiz96HrfWMwNBryiK7TqTlNdxJg+VyCel/pwqNBYV2+eT75CM7eZSxHwRRKjZLCfTGzgMov+a1pyY/SNrOHc7sSLIaWGHeeFfcjfv8w6usgvkjnCtSC37MQyQM44puuWc9ZU0adOQ9nFVTPZCGUBA4Bed2R/lNoiVPytFn7CDBoQuOMJqfBn+2ZHhNB0vsIEUV9X5qVadctLaCQdGjtK/En9b37U7EXX36REEGRHq4ym2oBNJ/JfBh8f1d/ErVBb2ETINBz5L+O99nXwytI3U5kZqRKAW3MucHKx5gGgpEbDmddaasYaelPSsPgoKCzRQCqLHPavNdhkSe8D6UbL8+g5aA9VfzLYpx4uX3dnav6+tZ3tsTIi1ICd81klk2WlUuwUmUWYVnAktWqqpK2ox7CG4nncFjm3KuxhKILuN1aEz4bdVWJxtypnX14j9vLlcLMgCbcnewJQVaDfxa6hFrP1w/7HwOzokYFFWLn80CXom3II7iSoJ/rl80XKW8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8470.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(6133799003)(10067099003)(22082099003)(56012099006)(5023799004)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDJSd1BkYnlBQjl1M0RrQVZaejNZeU4zTWNkYXFmcDU0MSs4M2hlZ3BpZzBN?= =?utf-8?B?aTVScU1KZmpYdXRBbmdVc2k0Nyswb3JNNzVnaXFUaGQwaHV2NmwvM2NWbjZa?= =?utf-8?B?bmZTZExxT3Z1U01SWHJOVWhnZzhISGZyRUNONlg0RDVPdXlUM3ZFVDc0SUp3?= =?utf-8?B?eTI0SVZtcXdXTGdqWmhtbGkzUWZDU2wvYUF5MU83UDhNSThIUEtPRmxNbTNP?= =?utf-8?B?WDhCV3JLR3dlOEpVVjlyUjVWYkl2Ym5vTEI0dnY3QXhoTUZIZ1BPTmlnelNp?= =?utf-8?B?Z2c1NTA3Qi9wQ1ZoQW5LdmhJNWl2dVNqdGhjZ2xJeC9ESWVsYW53UEt2a0pX?= =?utf-8?B?MlIvUkp0d3RqSFJQSFJKNjlpU2syYyswdTJRWHFIL3VWOXlwWm9lcWdmNkUz?= =?utf-8?B?Mjl1d3VqZUFuS01XUk9LZnVHdlhtWDNPNmVlQWx6cDlPZ29vM3dZYmt0R2NP?= =?utf-8?B?N091Lzl4SE94NUdjRG1rS0ZRcEZwb3lRaU1ab2dubHpUT1EzSzh5ODZ5NHFl?= =?utf-8?B?ZVFQTzIzdFZyL08rQTJJOXdQMnNsQlVDNHpQVnVSaXI0QnlqREl0UmExUnpz?= =?utf-8?B?a1AyOGNvR1RCUEwrcjNDNjRZREVaZnVjeklkK3Q2TitIeURvbTFSek05WHo3?= =?utf-8?B?d1pRc3pFNTBaMUVDbXZYVU9yVlcvZmhOb09adTVQeFpvRTkvTkROcVZhUzE5?= =?utf-8?B?ZTBGUy9mRGpNTVFHZVFQOVRCeUg4YVRnNGpZS1dxaXJMZ1YwcmNPSExKYWcv?= =?utf-8?B?TUl3VWpraFVrRkFmaUlob2x2cVFLSE9rVExEcktiQTVyUlNzMTFvazN4anJV?= =?utf-8?B?S0poa0JJTjVwbVdXYnB4cDk4ZmQ3TnBLdm13ZWNKM2hNWm1Ec2RKMjlTQnFG?= =?utf-8?B?ZnJncDJ6V0lQQU12a0lNYm9qdWFCZzBxN0p6d0VtdEo0MHNQdFB4bFBZcnps?= =?utf-8?B?Nk9nUG5MNnZUbDYzNlRGT09wOTFSMktFOXdjanZncXF5KzlWdlZUNjJ1Z20z?= =?utf-8?B?SWt2bENYbU9CZXlneERBVkFGRkxsL09aT3lZaDlhYjZNN1BycWlPUm1YMFZj?= =?utf-8?B?UWFTaUNZODd3K2R3T291aHMzWkx5RUk2VGZmVGFPeDl2VHpQYmZraG1CVnRU?= =?utf-8?B?Wm1xWGd2bnY3MjM4bWN0anljL0VsbEFFdGthcEJoemlHcXBvYklXNGQ3R0Q1?= =?utf-8?B?bWwvc1lnd0IrNW4xRDkwWnNWazZlQkdHazdXWHdoL2Q0M3ZuaERNcTUwUWJp?= =?utf-8?B?YzBLWlJSZTczWnhqNjZuR3oxb2tUNVRwT1pTeFVQQzYrc2dtYXltcG9HTHBZ?= =?utf-8?B?eDlKaFRZZ3NYQkNreGJMaStxQWc3eXBKTjBlcEl1SWNIRmdXUXRPenFta1JF?= =?utf-8?B?eEVmcDZrT2gwQVdzKysrWk1LNzJnRmNGd0FHN1FIQUFZbWNseExWT0NXdkpu?= =?utf-8?B?RmJ3ZWR6UkVEQ1NPVHNHekMycmlDWkNyWEdWS0ttTG8vVmZoeVJGNVM0YVhI?= =?utf-8?B?M0JWOU9VOStDVWJvbmhmNnphUWU2L1FER0I3YzFBMmFta0ova3pyTjlQcnVZ?= =?utf-8?B?SDVXSjJJRlVtdFl6bkFDQjUrM21pVklySUFZREQzWm1hejBNZ1RiTFA5d1B4?= =?utf-8?B?ajRuVnZjVGZyeXpNYjRPTUZiZG5QYlhQemNqMHdlcHhGRHJQT1phaUY1MUpr?= =?utf-8?B?dVFqMUg2b3krOXNXVXFIODVIcWNuZGYyVC9hN3hLa256MFBCM1EvTFBIN2kr?= =?utf-8?B?a2JRMHdCUnJldzBGZERuM3lHb0ZVTFBCcC93OVc0K0YrQkVnSGpRMWdIWVZK?= =?utf-8?B?LzlNbGNKV1c4Qzc2c253UmdxalMyRGoyaWJIVUpwbExLaHlNK3BvRWtaeGhZ?= =?utf-8?B?NVpRd09sTUtzSndQZnpER2txNHkvSHdvLzYzUmREajNrSjducU1xK1hqbG5a?= =?utf-8?B?RlVEVEpma0VWRlNqbjIzYjZabjhwaFVBSHFzZmUzT0UySTNFTDZ2NUNBMkZh?= =?utf-8?B?TzZsRkx2dFR5R1pHV2wwcFJ0WG9sME0zZmtLR1NFTjJCVm14Q3ZUMmczMVoz?= =?utf-8?B?ZEcwM2ptQ0FQdHF0dHlBcC9qQlI2WVAwempuUThUN3lJcXRvVzk0WW5tRjlX?= =?utf-8?B?bzF5cnNQYVVHQVNhY0RDV1A2Qlpjb2s5ZTBadXZRUHNEODRBdTUrbHgzMWJQ?= =?utf-8?B?VG15blRad2VWNlBUWkNjZ3JuaTlKR2FPc21oZ0FuejFGZUdPaW1zU1YzZ0ll?= =?utf-8?B?Umt4eW1vb2owVHdzOXpvZnd1a3JMd3VaUlJZS0dhYjhxNlFhRXpLUWRXODJn?= =?utf-8?B?TzBUV0VNbFhDSlNPY203SFUvTEY1ZENPazJEVE1CeDRmNGplSnRKZE5pcmwv?= =?utf-8?Q?Iqpe/1mGqfxeeqSs=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a480691-0043-42a1-0cf8-08df102891bf X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8470.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 17:17:34.1025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VYJ0kCjznglOncLyWmW5F1PP+TFdociDCZNH5d7+k3hNCMMGMPJAfqTT8WILv1Key3KxmnfTah3pVYx66W9XarVARfxxhSnGrzCO+9oZ2Bc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI3PR08MB517319 X-OZ-Fwd: true Cc: "Denis V. Lunev" Subject: Re: [Devel] [PATCH vz7] ms/bridge: stp: Fix a potential use-after-free when deleting a bridge X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 9/11/26 18:10, Konstantin Khorenko wrote: > From: Ido Schimmel > > The three STP timers are not supposed to be armed while the bridge is > administratively down. They are synchronously deactivated when the > bridge is put administratively down and the various call sites check for > 'IFF_UP' before arming them. > > This check is missing from br_topology_change_detection() and it is > possible to engineer a situation in which the topology change timer is > armed while the bridge is administratively down, resulting in a > use-after-free [1] when the bridge is deleted. > > Fix by adding the missing check and for good measures synchronously > shutdown the three timers when the bridge is deleted. > > [1] > ODEBUG: free active (active state 0) object: ffff88811662b9b0 object type: timer_list hint: br_topology_change_timer_expired (net/bridge/br_stp_timer.c:120) > WARNING: lib/debugobjects.c:629 at debug_print_object+0x1bc/0x450, CPU#9: ip/359 > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Noam Rathaus > Reported-by: Neil Young > Acked-by: Nikolay Aleksandrov > Signed-off-by: Ido Schimmel > Reviewed-by: Breno Leitao > Link: https://patch.msgid.link/20260629072117.497959-1-idosch@nvidia.com > Signed-off-by: Paolo Abeni > > (cherry picked from commit 2a00517db8de4be7df3d483b215c5544fb30a191) > Changes: > - s/timer_shutdown_sync/del_timer_sync/ > > timer_shutdown_sync() came with ms commit f571faf6e443 ("timers: Provide > timer_shutdown[_sync]()") in v6.2, so it does not exist here. There is no > stable backport to copy from either: 5.15.y and 6.1.y took this patch > unchanged only because that timer API had been backported into them first, > and 5.10.y got neither. > > del_timer_sync() is enough at this call site. Both functions dequeue the > timer and wait for a handler already running on another CPU, so on return > the timer is neither queued nor running and the following free_netdev() no > longer frees a live timer_list. The one thing timer_shutdown_sync() adds > is clearing timer->function, which turns a later re-arm into a no-op, and > nothing can re-arm these timers by the time br_dev_delete() reaches them: > > - del_nbp() has already unregistered the rx handler of every port, so > no BPDU reaches the bridge; > - the remaining arming sites, br_become_root_bridge(), > br_received_config_bpdu(), br_topology_change_detection(), > br_stp_enable_bridge() and br_stp_start(), run either from that rx > path or from ndo_open/ioctl under RTNL, which br_dev_delete() holds; > - the handlers themselves are stopped by del_timer_sync(). > > br_stp_disable_bridge() already uses del_timer_sync() on the same three > timers, on a path where the bridge survives and they can legitimately be > armed again. > > https://virtuozzo.atlassian.net/browse/VSTOR-145092 > > Signed-off-by: Konstantin Khorenko Reviewed-by: Vladimir Riabchun > --- > net/bridge/br_if.c | 3 +++ > net/bridge/br_stp.c | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c > index 494293c999c20..8c9d2f0dd055e 100644 > --- a/net/bridge/br_if.c > +++ b/net/bridge/br_if.c > @@ -311,6 +311,9 @@ void br_dev_delete(struct net_device *dev, struct list_head *head) > > br_fdb_delete_by_port(br, NULL, 0, 1); > > + del_timer_sync(&br->hello_timer); > + del_timer_sync(&br->topology_change_timer); > + del_timer_sync(&br->tcn_timer); > cancel_delayed_work_sync(&br->gc_work); > > br_sysfs_delbr(br->dev); > diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c > index 8f56c2d1f1a70..65b10d3c968b6 100644 > --- a/net/bridge/br_stp.c > +++ b/net/bridge/br_stp.c > @@ -337,7 +337,8 @@ void br_topology_change_detection(struct net_bridge *br) > { > int isroot = br_is_root_bridge(br); > > - if (br->stp_enabled != BR_KERNEL_STP) > + if (br->stp_enabled != BR_KERNEL_STP || > + !(br->dev->flags & IFF_UP)) > return; > > br_info(br, "topology change detected, %s\n", -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel