From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 97E24802A5 for ; Thu, 8 Oct 2026 10:43:37 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698AgBB0022872; Thu, 8 Oct 2026 13:42:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698AgBB0022872 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="usABUuAX" Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698Ag96t022868 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 8 Oct 2026 13:42:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698Ag96t022868 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-8ace1d95f5eso69774007b3.2 for ; Thu, 08 Oct 2026 03:42:10 -0700 (PDT) X-Gm-Message-State: AFq9FYKJlctZVKhIMnM0DvhgGLyH3FtiiqRiE9rWo1cwHGbn9mYd86D4 RIC70AaHG2Z8DKRD/3YDafwiImSEGwL9dM3MiZE/r1VkyBnCYrLv2UsFHLmp7py2LX2WsX2KUV4 WF3xb1glLlR3cCLebJtQ2QSsnA3Dd0ooBMwKaLi9gSa466r3iOUaHvA== X-Gm-Gg: AYBFou2ab3FviJGxwbZgyTdQ9C02sWxZN4fLjy16xUYkOvL4CbXCjjNUDuaZAB0SqbZ M2bt6kIQFrEcAuKL+ZEz5n6xhlJTwaYS//S3UQ+ZFIeYGD08uTuDSWOSeLGJobQUJ10JnqjXil7 UC32AU7Yi+4xakoZxcbEx2o1o1jdOB6u1fckKvhyMDYln5qT3/sMwBlFpZQiYWmdpWvM+F/SXyN u3LMkWTB2/nMIM4atqXxqxKN0YaZP6gExjq2vKq+XBUjKVek/eHQ+vppG7cp4EzMYhVL5ALsWBH 0yHquDQuQMOCWaePUaxo6MjBeB5SyY7LV5EG3+acJ936IaepNyoRcZKryhIqrKl+L6hMEtRYF9q L02WtIddX8XjlOdd2phmgXXjCz/BQRD5eTwP5iPAzkQrO/Fla9K3nPQ+pEyF9DQsjRVETDA7Ndp cP+sP5yx9eUHd53lHxBQAvfC0LbY5KFs8= X-Received: by 2002:a05:690e:12c8:b0:677:ca67:9937 with SMTP id 956f58d0204a3-6790a0038e0mr2737861d50.37.1791456129122; Thu, 08 Oct 2026 03:42:09 -0700 (PDT) X-Received: by 2002:a05:690e:12c8:b0:677:ca67:9937 with SMTP id 956f58d0204a3-6790a0038e0mr2737856d50.37.1791456128542; Thu, 08 Oct 2026 03:42:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791456128; cv=pass; d=google.com; s=arc-20260327; b=NMA2oCosLzXc/bhfjnZNZpJiB45Ho3PFjN9JqCM60DhrUKp5iAFoo+6K8WPr6y4I1l 994dzCNAiqInHe3Ppt56KvOQg2z//K0M624OhwhQyKcyf6tnWfjo5RFZhM3msEdBHt0C pl6jB8wPKDUs9iL1Y0b1hzZDTwGMUzby9cWcUHCvRORwR5OiBU6RRhUerMwXEN7NF8Z3 ygGRvtxJfL2gkaa3jUwJWUgHcBjEZVkuX05nMt+lMdHweGQ8VSp59QxZCoQSi1pfeZEQ +jkoGZcOoFeHArSR2x8a1WlIzB55l/ZcqmVQOVlZC4uPcSiJ2aMIDSm2gh9sOuP15mAU XCUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:content-language :references:cc:to:from:subject:user-agent:date:message-id :dkim-signature; bh=nxKyUyAoISYdhIEhsyEX4P7xpKLStlKAVHQCJDCHT1I=; fh=tMEsLKuDQ09qqpmC2pLav8OyMwzw4kazC9GBASug5RM=; b=IIHy3hy9v6Zb0z807XF/TOP9rg9VQa75qEHTazmQYGICnfWE/KGTcliYvpXww1tb9Q hOIqNkHvDO9CnaGc5eo8vzVbsznTAdOJk9iGcQrLzb6hmwR57+5W/8h1vuW0PnLlwRvn BjuiYA7sFnx2xoPomwFlmSqluSdRs4G+Hflws2XjvyuiLDZ4Xr0tGKEbVuU78j36AOVv CzG9AnMPsGHJcx7IgN5D+Gdv0E8q1BuWV8Q0afRmR5sEo8JSeF2ngb2U6vrCMjbCB0Su 12O2vehqGRF0Wi10ZDo4X4+ai8YszFMhc1hJPlFMdUQT/rqg+fJ3rWMfdpM8j0b23S2Z 4PSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=usABUuAX; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id 00721157ae682-8b05ab52546si19061087b3.30.2026.10.08.03.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=usABUuAX; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RgaQhgn7V3QPlq3KMEqph1RvrqadjGRF8d9j7BINNdxtjoWfUtmr8tfcRaHrYlB0nnwGXtiIBgC9XOQ1zuVducfrnvo7uHWod8dDdsPQJQbspJkBpJeirCznyutDFc0OnmxV54mxbrbqJ/2yGnOyI80m9pR7ufI9n1ItvibMiY2KhmScCEyDtAieEmjCyUE1LHzTZoiTu8KFYQHtzqHb/VHYWBHWEgf1OZ4/piOx+RZLzkEgZrcB40Lf7KumV3TBP0ED7efYA675fKEwblZc9+83bDsh+AGjVXWqCx7c0GtRYTeCVzzjfIPClcNeNRGKk6JZjBSTA/lb0Qpp+MpiLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nxKyUyAoISYdhIEhsyEX4P7xpKLStlKAVHQCJDCHT1I=; b=jfx9wBTeKMauQEOqxp+6Sg1NdchpV2n4RhO7q/U1pB+NiTmuCL5JLcg5078i6l1PxYbpTLRPtjwtTPuhRENUMmAmxSNr3enP5NUGBuA2fmg47riPt3YUsYN1jp8juWZpqdFvIh6PzBuvUEbz8ajXKMOZCQLa4g0ivdnfjO5RPG/AbFuLBb8Cn6JpgAW6hjLGxWxgfcWlIeRUPKTns3DczcDUimCvJWIMd1mjqtVkOPKC7P6jJYA/dNAnEtC7QiQO5QasQLLYVFLoGwGCtXUNLMwdLipnnS/nwyhrmr+d7nUiuSpVYcMV/uXn0K++n2jUJLlZqYyldddayo+UvFkIng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nxKyUyAoISYdhIEhsyEX4P7xpKLStlKAVHQCJDCHT1I=; b=usABUuAX/dMSDm4RdoedrjNFttwpWPikTRnn1nKfbFjL1Mwc4BD1poTOcWhyfkb6XzuztN6Vl2OHfiGfCBy2U2zWOaxBEd4c46lh0rsic+17JwwbS66PxRiYB6Rj2Tt5lBjuHlV2KbRHLl2LAP0hyB5DjV1VP6FEyM7MdJV4tRYdKU+SQ+e5ekOUPNYSGx80i410teSsW+pHuPTbMtm7ICLNZJHR7l57rcFmQSlE3thUDdevduQ8G3ocmCt4SCPzSOWFRZojFpxxD8Z1WlD5mzy73bfKJl+uah+o3kRxlo34mggncqg3YypKz+XEQyiYXdHyOZFamiKB0J5/Tf8u2Q== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by GV2PR08MB075028.eurprd08.prod.outlook.com (2603:10a6:150:381::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.5; Thu, 8 Oct 2026 10:42:03 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0522.002; Thu, 8 Oct 2026 10:42:03 +0000 Message-ID: <07a6265e-5674-42f8-a360-0ea4e8df0cc6@virtuozzo.com> Date: Thu, 8 Oct 2026 12:42:01 +0200 User-Agent: Mozilla Thunderbird From: Alexander Ivanov To: den@openvz.org References: <20261008073837.510678-1-alexander.ivanov@virtuozzo.com> <20261008073837.510678-4-alexander.ivanov@virtuozzo.com> Content-Language: en-US In-Reply-To: <20261008073837.510678-4-alexander.ivanov@virtuozzo.com> X-ClientProxiedBy: ZR1PEPF000077D3.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::410) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|GV2PR08MB075028:EE_ X-MS-Office365-Filtering-Correlation-Id: 67dab426-02bb-4f8b-2221-08df2528ca18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|366016|376014|56012099006|5023799004|4143699003|22082099003|10067099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: CyQIXZKYwJixw1zSHWa1TDdEo7vaiS2nR61YoeNC1cGfMMmdO5JKuVwf5G79PD6hrufsQXhUpTWTtfU1C3fCvVHriGH8eHr/dghsyp3n2nEaPSZ2M9L302IQOUpJ5Lyx3ulGAZU/2xA7YtNgaV/6fClbMBqXedcuOpTHXO5LKYCo8NQ8ufFXrVjvHbxdKqXKwk+3ZUM1UznKWZ3i0ZPf8Fd6WaOkQjRSLp23DbRz9qcQiYSHmBbtP1E5E06OF6BeQmtCQeWCkUZR3J76NVoJ9r0aEQ4+f/2L5MFesZxZpDoP9v1oEPiLENkakbDKY9TMWPnugvRsZqp4Q/dBHvSLlp70tv2NT0RFCa0pIVSxEiQ4Cw0VfDEflwJQZhFsJtmI+bzaPz09k/BSkoDZ/3D+iL1PP0DP5yfgJdVn++mKDh+hJnnBRypJRX+YAfjpHY46It4l8suJFUM4GGk2mOmNrBtLyDf5VneLdyyc/L8kbgEl4yY+1dkvDiiVV9NIjTQsWIMxtRRdYIhux5x9jTn78g1GpxniuGimIK6rnK7xTbqWMX4gWlabBkjqWHZVIsiokKAlpRKAv8TA00opxdRrsbxrTh5DXjt1AABXB5sRM5TuFBAvoYNQMygj//lPfQ8tUDHsYDBtPWYgi55PFzS/IMtrYQDQO+CwIqWLZMmH/Fo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(56012099006)(5023799004)(4143699003)(22082099003)(10067099003)(18002099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wi9sbFA3WDNNUDNtSHVVWjArMFlmRXEzZStEZUN3QkVpclR4dWFvTFpRMUUr?= =?utf-8?B?N3V0eFBndmpJcnY0MlVXTHhiSWlzY2c0TGI2Ti9oOW1mbDVJa2FQVHVlWnBU?= =?utf-8?B?TzJkRFN4WG5DdXYxOTV1dlhscWRXQ2NlNG9hMVFZRzF3S0xrSFNESnRPbHB2?= =?utf-8?B?VHZNd0szTy9iYVpWZjR3Y3lCTDVvUHhjUEtEU0ZyUUFaRnB4ZzNON3hqQkR0?= =?utf-8?B?TmlzcTN2RW5kQytXbWs3NmJXZEZIajJIdXBISEwyUW96NlRzQXVLOGxZTWxV?= =?utf-8?B?SFdNZEdaS2haVEVBdktyNFNXQVZQZFlXbnU0UStoNXhiSGtPMHpvQ09TUGVY?= =?utf-8?B?N1hGWHRKR1U2aVgzSGtJQzBoL1ZMRm5IaUhucEpWVWRsaHYybkpnVkNMWlRq?= =?utf-8?B?d2ErYmhNS1R1TEJoaC9TSVBUenN4bk4xTDl2aGhyUlZRVHY1bU9BV0VoRFEw?= =?utf-8?B?Z2gzQTZaVWRTSFMyVGJIdDhFWDNJZy9WZDRpUjFsY0pLTkdOc1ltblFwMDRm?= =?utf-8?B?aVZKci9LWVZwN1Yyb2ExdG9Ibjh3UDhhZTQxUnVNSXJ5cFE4MExxZFZzTjJT?= =?utf-8?B?TFRNQjRQM1hudmdKa3AyTklVeUhrRWt3ZlBFTDFRY0g3WXkranVaZEFJMksw?= =?utf-8?B?UFMxMzI1dFZOU210ajdMQ3YrVklJNFlZbHdvU2FYd2g0b29ZdjgvWEp0YXZl?= =?utf-8?B?MTZ3Z1d0U1Y4S2xSa3JzU1FtekRoZXY3TzM3NEI1Q2hkelZQQ1ExQ0M4Qkg2?= =?utf-8?B?d2s4Y0NuMHJZc0h3dUdJYVI5MWhRUTU2ajRITzViS0xyand3aU5jUFpNSGJ0?= =?utf-8?B?U0RkQnhpUlVWOFdhUHQxWDR1ZVpSYnBGNEJrV1BwbjJ5SSthRmxZTUpOS0tk?= =?utf-8?B?Um1GOG83RVV3cVdBRHA2WGY0c1lDQS9WUFRZdGRGeEl1NWYxWGk1RUhqeWFN?= =?utf-8?B?RjRGQTdYQjdqamNSODdhcFRrNjVtWDJYSzVIWXBYZXFoMzJkMXBHS2ZNZXFJ?= =?utf-8?B?Tlh3b01PRWZqb1pTTWpBUXJieDd4ME13SE1DS3N0NHY0MDIyMGdRaHEwZG1Y?= =?utf-8?B?bkhTczJmVHc0UTY4NlBXckp1TzVEdG1EeXVwTTFaMGlQOXJSZ05ram5lcmJs?= =?utf-8?B?QnF6SllWREJCQ3lwZitOU2lwa3JKOVZoeWNiRDFWbkdSWHdSWXB4cy9HTEtZ?= =?utf-8?B?U1FEQ1ZJaEZ6d0FkM25uWVMxNHVIajVuOG9PdTNRZ0VDTlV1QzgvTFQxZW5I?= =?utf-8?B?NFRWN0pFN3dMblFQcG5OaWF1aVI2WjlheWJiRGtzUjQ4dHlCWjFPNE1MQWdR?= =?utf-8?B?YkRGNVJ3MW15NmU1enFtNDNrK1kreTNxekdhMkdFWTNRNkc1cGpjcklZaTlh?= =?utf-8?B?bUlVUjFyS0E0MTFkYjdpc2YxTlhxQ3ZmSG9IS2RHb285M0lrTXdmRHJkTld6?= =?utf-8?B?SHc1UWdSVkNPd3h3elE0Mk5wV1J0cElFS2NEMHZ2ejZHZkpqcy9tZ1R4dEha?= =?utf-8?B?WkZxS0h0SVZFbCtzL1FBVkp4dWVNcTVHK2dnZFFJeGZXUVdpYjJLdVJvcm5B?= =?utf-8?B?YU1wNG9hS2VndlNKTkNBTHd5NXc3NE5XRU9RTElyeFVRckFtTmw1MGdQY0RV?= =?utf-8?B?Zi9vS0pJWDgrZ3RXbUR6dWlsZWZhc0JrNWY4OWdyYXd6N1NaaWtWcTJJWU5i?= =?utf-8?B?cEpRby9zaldxTkVsZmhKM0RFdi9XTUJ0SWlzaW5xU2ZRZ083SFZMazBqYlZE?= =?utf-8?B?SDBNejFuOUExWEFLVFpqdmtMbVEra21NaWtBUEFxcWN2UjdwY0VxZ1I3TUtr?= =?utf-8?B?U1IrbExUYmkrM2JTVVpQRUxNOEt6eko4bjFWSnZ1amRhMzU4c0IwL3JrU0p6?= =?utf-8?B?ZjQ3ZWYzMmx6L1BFOEhBNlc1aWZpczVvRDR3V1Q3RkVjRkcxVjloZnA3MVlw?= =?utf-8?B?S3V2enR1QmNKQyt6eDFCZWxna05UNEI1TDRZYjJyOXJnUDdDTWpybk94aGM2?= =?utf-8?B?dENNdlNyYjU3NFdNLys3czRuWE40WEpDd25BRDZMMHBXOCtYZTBUd054ZHNB?= =?utf-8?B?UVFrUTJZT3V3Yng3TVgxVm9qTkxqNlhESjFuenZZZS9aOUNoL1MyUndQbEdF?= =?utf-8?B?QkFTd2o5N0FiN2QzT2NaN2FFeFdrR3hBbW1MZ1U0YXBYdFZFb2xzUk9ZK0V4?= =?utf-8?B?YUdMRlJSODBkZ2dLdVNMUHFYZDJ0djdSeG1DOXdBQytSUUErTjdFL3V3UDk5?= =?utf-8?B?aW5WU0UyNS9ONDhlT3R3cUsrUXc0K2xoUmVibzg4c1BhczhKeEZlWEVjODNy?= =?utf-8?B?dzJvdUZLdlVSSXB4RWx2cEN0SzQyVGdNTDNHQ1U1UFRja1pKb3VQNjdPNVVR?= =?utf-8?Q?HuddX+DetJAyQKUs=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67dab426-02bb-4f8b-2221-08df2528ca18 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2026 10:42:03.1254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nUPlZf9IHUNEzdBozeJZ9i+WHbowZDr8Rpl9E0w/wiG/JxSoVHc+THMqHVs8gCU9XpPNOvyYsG5azJNVlFNJ2UCgSUiLdfGPgHKs0n7Hgts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB075028 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/6] dm-ploop: set delta is_raw before applying its mappings X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > [Severity: Low] > With this change the raw branch of ploop_apply_delta_mappings() becomes > reachable, and it looks like it can misbehave for a zero-length raw base > delta. > > For a raw delta, nr_be comes straight from the file size: > > ploop_add_delta() > nr_be = POS_TO_CLU(ploop, file_size); > > ploop_check_delta_length() only rejects sizes that are not cluster > aligned, so a size of 0 passes. The check against deltas[level + 1].nr_be > cannot fail for 0 either. > > Then, with nr_be == 0, init_be_iter() computes: > > u32 rem, last_page = ploop_bat_clu_to_page_nr(nr_be - 1); > > nr_be - 1 is 0xFFFFFFFF, and the u32 wrap in ploop_bat_clu_to_page_nr() > gives last_page = 0. Page 0 then gets start=16 and end=15 and is > skipped, while every other page iterates in full. > > In ploop_apply_delta_mappings() the stop condition can never trigger: > > if (clu == nr_be - 1) > stop = true; > ... > dst_clu = clu; > > so can identity mappings be written at the raw level for every > unpopulated slot on pages above 0, past EOF of the raw file, including > tail slots of the last page beyond nr_bat_entries? > > Should ploop_add_delta() reject nr_be == 0 for a raw delta (or should > init_be_iter() handle it)? > > The BAT arrays do not appear to be overrun since the loop stays within > each md page. Reads of those clusters would hit EOF on the raw file and > likely return zeros, like a hole. I did not trace the write/COW path for > these mappings. Reaching this requires a table load with an empty > "raw@fd" base, so it needs CAP_SYS_ADMIN and is an unusual > misconfiguration. I did not find a check for this in later patches of > the series. Fixed by putting ploop_apply_delta_mappings() call under if (nr_be) condition. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel