From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id CA8E1802A5 for ; Mon, 5 Oct 2026 10:03:40 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 695A2Pd4007221; Mon, 5 Oct 2026 13:02:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 695A2Pd4007221 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="zyUyOW9L" Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 695A2NDe007216 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 5 Oct 2026 13:02:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 695A2NDe007216 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc795ad1f5aso1038360a12.2 for ; Mon, 05 Oct 2026 03:02:24 -0700 (PDT) X-Gm-Message-State: AFuF++lJzIBAz3lIo/5bH5b4S9iUhbOXWbsEtspi+J7ZnEQsqrs1SDjl CBCzaNww38z/w0Zjoni1WyNr2rUPwCfsxqHACxupeKXvMtgCfkF1v+gFrQRYPuUEzzzDR4D1yPd 75t8c4r5g3tErEB1fvVef9WDVxsdiKotdlDXm+/XsuxdklBqQDT2B0w== X-Gm-Gg: AYBFou3TfFb6MjCPB+YFyArOcZzaeApcjU8n1MuhpSL6yi4SfNV9LxSrC8Ew6fUG/Dj YOHghYBtic/P5+QXbYl1N5SJwti11cHmpkz+bkCFo5jxWoEpbTzyraCtyS50YzGsPxIIbKIfMkd EFVifonUeFuR2LOEzHjKD2OeKmHo9Lfi9tsl362vbmgj04FqQjbiGd2vFuSsjjYO+0eQH1IlzsU 40cm/MEkcnRw3CI4FQQgjoh1lbjiZOziuFEy5rkJvEKFtxbBo+h2uHLCcQgfwA9Q80EqN7E56UK 5rBTBuwz0gkZAJ79RUJOLmZlXyO7ESJqeJ3O6NrfXXYIHeyZZPLfhJKq1dkFYVmwiTB3/aMsMFd 5ihTj4cCKZgHArPfy2Om5rKjc1ZhAfgvj/k79JLrzwADwLpAcuOsRFALEK6yO8hWaWJ9+ottZVm YCXA27WcdcAVn1lqIu3UMnV/3ECvHGgn+4Qg== X-Received: by 2002:a05:6a21:4ead:b0:3dd:a006:ed9a with SMTP id adf61e73a8af0-3e0bd16cba1mr10142629637.48.1791194542616; Mon, 05 Oct 2026 03:02:22 -0700 (PDT) X-Received: by 2002:a05:6a21:4ead:b0:3dd:a006:ed9a with SMTP id adf61e73a8af0-3e0bd16cba1mr10142579637.48.1791194541797; Mon, 05 Oct 2026 03:02:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791194541; cv=pass; d=google.com; s=arc-20260327; b=kxjIhqj6yjDgJuTJ44o6SqbnFJ4Lk9WDBpo+jXFnjuon9gjRxFE014CmBkE4DQ1J1g TZokMcw8eX85Y7JNc8N89qT55LMLw3hWdhREkszUs51Q8esTQAacqNJHmehA8ltM46P8 745ep/xigu6MUPWQ85qoz3Q3MltMRTHpG4UMOEVBCDwwlWdcBUfux5IUReOV3TDV2h3x VGTcBtdxsVdo8/ByOLEKPnQgtAZduv8UyuMfdumXkMRv5q0surw3FLuYq7mbG5CWiQl6 sMoRcbpXlKTmh7chXMKq2Ivt55MA1diwXe11EcI9n6/Dh9wvqERemKpUpSDlxexxn9qK zv+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=ggCD/OTgezMJFHO+IbGWZWlUmLVZWSNDvMp7hcRRN8g=; fh=A7R+PbrUHauVvppXKl0MrUrmlodzEiz0O3zRHlzVAvI=; b=kQ1Hqay3IH/YzD/x8zQ0kGpNSytaFQYndhhPU2cR7ZWnAvzsluEmxy839VznEWlt+o JHszBPv7qCuied9GufTFW7ciJgotu/bcURqXGGQG0F7uQAlKgrYdxKXFgZiPRsJu7Z3B Cxz8lYoDlXliz2DId+5kx+dJ+YjIVcQlb8wU0Gpdo9ThTipKqWpGR9PNJOoLbCvd/QaR 14tpjrbJ/4Kx19igDIO+5Jmj4DyqPEnJXiuf1ODYxCx4LLeC0zKtJoH5IKdaWhPsrCHC V0f6cr/g7LjGc8pgO218mMdtlz0Z7M3I2FYd6IZ4bOSarpsVMWrOZRtHlLFH3IAShFyM uIcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=zyUyOW9L; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-ccb75dac7a9si10653038a12.182.2026.10.05.03.02.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 03:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=zyUyOW9L; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NvnXVmHVqShPP9mVq2qpW/pch2Hz6AcvxikwPBe6HTuMLnzWPTakvRpjoPMgd7njJ0pcI9ApQU7AhJoROhilEgJYAA2rEQbjRHbnyl9GA1+Kye3SFmIE4B4u0JowduMc0uC/DO7UaJ1E21R8f0IsxGmx8i1MtnTuTrn5rE3jKBhtwbudFn1o7fnKR0VEwOwh7ODAHxwMqllpNmB+w5zRSKCUQfXTC1Q4WVDgAVR98UtDYKHurekjhtYHKHVfJ0xgd9+KKab+HaunDi+hU2RW+OP9UPeHL5m8mdnHMBFyvOQvpevqNhZyDZ6b95upbX83mzom7pLQZMHwKz0B+MZJCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ggCD/OTgezMJFHO+IbGWZWlUmLVZWSNDvMp7hcRRN8g=; b=qWOt8G7Z3I1vjjObzCMl1VDWE2GsW1RfTI9Vb1RwnYyjpxxoC+egVkfZPGMPGcANX00AQk4VhSHtZqBUj8VY/hEjRQqLqRt6l7srRaDM0lByzB6hvBMi11w4eRFCuhR5RuBsNWIHk3NS7YamwgM8giT/WDG5fYX4M9X4vT/3x5gYDQtvYQ71Uu8jrTyNDS/LuebTJ7vq6SBM9Vi/IBheKe7z7yUXn2lZCj3Q3svoqoRSuObCySNH1cLro2xh9bPsw9YjMJqfDYj2A0e4M0RJx8uisMjeTqf0tRMEygCSkmjK68ge3HHOV3voG+NVSnF4OWRuXuu0Mx3xP0cAAuh0Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ggCD/OTgezMJFHO+IbGWZWlUmLVZWSNDvMp7hcRRN8g=; b=zyUyOW9Lk4Knbz6P8NM9MeJtAYr3TnMsdjpS1tuJq2TR3MN7CI1Z10JV20xSwtzrfWBY9EeK1+tbufVNmX9dEkOCTcNowX7J/Jbd26Kdc7EhOsg69i1szu4KpVxGkXNZoPCQ0QdvEUzCTKI7wFSf3CzlQO/juTaDeeahkD3uGijfQwHwAaPI36Bl8lw4kAkSWOtD8D69AatTNxzQk5jaoctNN9k0jrfBFJ/t2EqnLa8sggdWfpKLzIc+T8f1zbZvSwA+H0YiOipOMSF91QRfx5fDfdBgZBBNWvPGB+HzuhtD3zcUiGOBFVagi5z7TODXzwJs08w7S/A9aswG+dBICA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by VI1PR08MB9959.eurprd08.prod.outlook.com (2603:10a6:800:1c1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.14; Mon, 5 Oct 2026 10:02:17 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0496.010; Mon, 5 Oct 2026 10:02:17 +0000 Message-ID: <0999f90b-078c-4e56-8d5f-d55504b428c3@virtuozzo.com> Date: Mon, 5 Oct 2026 12:02:15 +0200 User-Agent: Mozilla Thunderbird To: vasileios.almpanis@virtuozzo.com, Konstantin Khorenko References: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> <20261002-ve-printk-irq-v1-6-cb55896d455c@virtuozzo.com> <010701a0fe8f637b-df90f451-71f5-45ce-829d-6c7574c8cd6d-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a0fe8f637b-df90f451-71f5-45ce-829d-6c7574c8cd6d-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|VI1PR08MB9959:EE_ X-MS-Office365-Filtering-Correlation-Id: da6d4690-0996-411a-94ed-08df22c7bcb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|6133799003|18002099003|22082099003|10067099003|3023799007|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: lhdxaS5nWljcH3lsWVsW5U0vdFGXCUjKLLHf0yHXCWsi4oDmQ1cHo4v5FYHGh1AFhzQIdQ1uEHLpsUynwcZXFC3Pn1kG4BH0pPNjcXg7HpjXH5OJpHC5dXQHZAllQTx3QDu8TF1TuyDCpRcG6q4kjLf9coQ+ioajew4K4/Z+yMqdjLRhkdRpfYi3L581FoSGkUPlbIjwmSQnsk4j85fdyRPFJHB9dWQkLGBc41V9ouVoIP3XZ5Epv5Q/YxGMdRMMK7bszUz2I3eWkTs6fmLD1wkZqmGhaNX/NKsd/QrYjP2SvBluQ7EAxQR0ZKP7Fq1E9Jgml80el4VhArJlrFikF9chleHoINwx+MJoWIFC9e5qzsRmzxARLrCtPHo/n8mQ1/zuVsPJeuweeWue6GXa9//IEzb3hrtcddKDrDxqVsczjxJdPh0RRwqGNQN1SFWVLBbdNRpBp3WXHRajU8GIfi0zfLmB4XGmUrMqOG4cRrEPytTSoeBrmDggzfnh2Ah0yolfOI0R/WOeIkF99Mo9SPLSuyi5ImD1+32WJTvYduYAGrZSvvFCN2Xaruray7K5ci/8E8V13B5qz6ur0gHVcEtJB0bZ0m9Kb35LoHqqtKI4n9vXxruKYuRS1zbqvBF2TNEJ/q/3rrGHDEZAx2P0OfG+mzYktXCiYRZv3YdhT90= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(6133799003)(18002099003)(22082099003)(10067099003)(3023799007)(4143699003)(56012099006); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vkd4aXJGMWdRa1VOQmxOZnMzVTR3bE5RdE9tWDBDL0ZJanR6MDRJdHhMNUEz?= =?utf-8?B?V1NlRGw0L3RrbFBPQ3VCbUpHSTBPeXdTZ3ArS3RFVGp6TnJtV1ZSNUZzTWg3?= =?utf-8?B?N0VLcUYzVlVWQjBUWFk1WDdsQXBnOTVUVERFUEdHVEJNRVhxdk5OcnpyVWtD?= =?utf-8?B?SWZJbjF1Z2Znek44Nm5qUlAyZk9OOVkzODlNNFZ6OGREL2Y0cHIwR2xwSktv?= =?utf-8?B?WVpLWDRuNXFuUWo1V3ZXT2NTR1NOOTgwdEkybHptRHViUFRaWklCejVVc2hr?= =?utf-8?B?U0pTeVBaMmoxUE5jU2wzUnpyMW9OMXRpQ3FQMnhBVDJDOVdEc3J3OStYeWE3?= =?utf-8?B?SFRGM3hTZGJPcGZtTFNZdGVvVVBpbVVqenMrc24rMWtFNnMwL2pyV0dvMkVR?= =?utf-8?B?RTdEUm1UREUrQ1ppSy8rOFhZWFB6K2s4alVRQVlRSWtDL1BmZEJhOFJyVFBU?= =?utf-8?B?NXZOOTU1RFNkWWIxTk1RU3ZZVTJpeXFYT0xzS21YRFh2ZXUxUDUxdXBEeVdN?= =?utf-8?B?NjFxcUVGeWc1ZVpFUzI3d2xOdE9zcEVyd2k3NUJ1VVAvWDlRakxqNFNDR1pZ?= =?utf-8?B?Sm5wK1FxZWtvdXlYa1RpNEZIS3MzN1J6cnpNdStZbHNXN1pNQXpvY2RsV3Na?= =?utf-8?B?VVJBQWlvaVU5ZUNXaUJnVEU1cWEzK1p0VDdKLzJzdmJxSjRTbHpSeEFnQmFa?= =?utf-8?B?alNSNHBCaE1mb2dnYWRaeXhzVWdyeW9LZG9LV3VpQkNHa3gvWWM5d3Rmcmxp?= =?utf-8?B?QmszTXFTYVVpdmJrQ2J1L3IydERVcHJYcEFMWE9jOThSSndRTlA5Y20xNWJ0?= =?utf-8?B?cW9RckNKMXlTbGVwSGFEaldZZXB5aVg4Wmx5ckw1RXZST3dldUh3UzNjTmll?= =?utf-8?B?ZmRQQ3ZmNHV6aTFmSWFJelV4Q2YwOEZYeXJvTjZ6bFNnYUZlVTh0Ulo0bE4r?= =?utf-8?B?UWpNUE1zVU5tK3pTZnN5Nm9xZEVWMHRkTVdRRnlGWXlaTXFmczlrbFZVWTlk?= =?utf-8?B?Uk1oR2k0TStUdDMzbG1tQ1ZmdUVkY2FtS1EvSUp6cXhDRVhQRk9BcGEyRHAv?= =?utf-8?B?blpwVzdmTHZxVFRDTzdvb2lXUXRVeXVVTDlkV0sxMGMwWjMyUEVjd3l1Tisv?= =?utf-8?B?enlMR2FKeWpZQVE5a0t0bFBlY2JzcWphWGxncjQ5RFhwYzlOdHhPNlh0OXVR?= =?utf-8?B?TWtxQUJxWW04Q3RJaXFrRGVMV1pZelZpZEw0N2QwVGdON25BYldmM0Z2U1Fs?= =?utf-8?B?Mk9QUTFmZUNtWHJLdXcwbVRxeWpWMXBCNlNqNmI0YlVYZHBrLy8xZXVhY3lU?= =?utf-8?B?NFpQanZ5SkFaSnZPMktVVUpsZ2VvZGZMZ3FmRHRJWWJ1MDRJN3c2czBLOXg2?= =?utf-8?B?dVk2dzRaOHNmeTVLRy9rWElidXh3Q3dYMjlHZmhKRHpKVjR4TWV0NE9yWjkz?= =?utf-8?B?U1NvblIxcnRubnFIK2puNVRWelI4cFJaam5GYWhvRndEYUgyTXJlUHJ4NlY2?= =?utf-8?B?ejl6dUZaYmF4cHRnMVdxdE5uK0FXcjV3UEZweTBtU1hZbzZHcDJoVytETzN3?= =?utf-8?B?clNrTEszQXZjRmFEY05DQ2VzSzRaeFZmUkxjcDB0MmYrQ2J1ZjBVdUtjRkE3?= =?utf-8?B?T2RaVGU3OWZCdnJpQk1SUGhsaytINngyd1pwQ3orSTVnYWxLVXBxU3FPZTl4?= =?utf-8?B?dGxORDRBdWM1elRmWHhUZkFYY3dNNTdMbFVXT05mSzhGSDZqanhvOFplQkZK?= =?utf-8?B?S0FVdnVIQXlqNk9zTFYyV29OUE8wTWhWdWZPREx3WnBXZy9IK2pFanYwY216?= =?utf-8?B?YXR1amdWczdySUZFSUZLc1pwUTNFb05mcmpXcWx1MDBFMDJnWDBhWmNuL3NZ?= =?utf-8?B?Ty81NTA5RU9DZFJjeVdVUDlOaWJhR2RKUSs4VHJJWGxUNFc0eVJiTms3b0lr?= =?utf-8?B?T3U4c1dTVS93WW1VeW1sY29yZ00vS2g4VHVIL05PM0hJeEZIb2ozUTZ3TjRD?= =?utf-8?B?Z3RCWCtuTkRkZDc3Y2s3SGJXdHU3MTFzYzAycEY5RzVFbklPZG92VitxbEdY?= =?utf-8?B?bkdhVFlvakJGZ28rcTV4TWdHa1lpYi9LQzljbVFqMUJKU1ViQW1GTk5DcEVa?= =?utf-8?B?bXpuZjdjREgxSTVuTzk2SmxRdlRMS29PU0d4MUxnOEVRUktUTWlMbndYdkQx?= =?utf-8?B?QTkxY3d6Y3ZjOElrYUdHdG5kNDhyM21SMCtyRXd0R2FCQmJsdDA3Q0xVd2Zz?= =?utf-8?B?TW5RSU5Dd2FKRFFmN0hENzFOVDZ3eHFLUmdtMGJoTjhsN2tPT3JzTHhXRnhE?= =?utf-8?B?ZU1DZTdVMStqZWY5ZkJFaTlyaWUwUVFMUGVIQ3F6UFV4NjIydVBwdU5NL0di?= =?utf-8?Q?IlvKStH/24o1Vgj0=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: da6d4690-0996-411a-94ed-08df22c7bcb1 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2026 10:02:17.0556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HrDxLO5L04LfczceYdJTwlJYb3zJbnpap3Fn0SG5R4Qxpvic3llpOtTSnT7U3k8dfQyVLqzJYB5LqyQKzRt3xPX27zpCopeWxyDkXOr1M94= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB9959 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 6/6] ve: add neigh_tbl failcounter X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/2/26 23:40, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] net: neigh_alloc() drops table-specific overflow log; ARP and ND share one failcount > -- > > commit 83435d15f32b1a7fcb7f3aac09fb30774f63d147 > Author: Vladimir Riabchun > > ve: add neigh_tbl failcounter > > This commit adds a per-VE neigh_tbl_failcount and exposes it in > ve.failcount. In neigh_alloc(), the "neighbor table overflow!" message > is replaced by a call to ve_failcount_inc() when the table limit is hit. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-135520 > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c >> --- a/kernel/ve/ve.c >> +++ b/kernel/ve/ve.c > > [ ... ] > >> @@ -834,6 +835,7 @@ static struct cgroup_subsys_state *ve_create(struct cgroup_subsys_state *parent_ >> >> atomic_set(&ve->arp_neigh_nr, 0); >> atomic_set(&ve->nd_neigh_nr, 0); >> + atomic_set(&ve->neigh_tbl_failcount, 0); > > [Severity: Medium] > ARP and ND have separate per-VE counters and limits (arp_neigh_nr and > nd_neigh_nr, selected by get_perve_tbl_entries_counter()), but both now > feed the single neigh_tbl_failcount. This is true, but IMO it won't add much value. I'll return net_info_ratelimited message with table id and ve name for debugging purposes. It will go to the host only. > > Can the ve.failcount output tell an operator whether the ARP table or the > ND table hit its limit? > > [ ... ] > >> diff --git a/net/core/neighbour.c b/net/core/neighbour.c >> --- a/net/core/neighbour.c >> +++ b/net/core/neighbour.c > > [ ... ] > >> @@ -520,8 +520,7 @@ static struct neighbour *neigh_alloc(struct neigh_table *tbl, >> (glob_entries >= READ_ONCE(tbl->gc_thresh2) && >> time_after(now, READ_ONCE(tbl->last_flush) + 5 * HZ))) { >> if (!neigh_forced_gc(tbl, ve) && entries >= gc_thresh3) { >> - net_info_ratelimited("%s: neighbor table overflow!\n", >> - tbl->id); >> + ve_failcount_inc(ve, neigh_tbl); >> NEIGH_CACHE_STAT_INC(tbl, table_fulls); >> goto out_entries; >> } > > [Severity: Medium] > The removed net_info_ratelimited() message named the table through > tbl->id. The replacement message from ve_failcount_inc() is fixed text > and has no table or family information: > > "CT: hits the neigh_tbl limit, see the 'neigh_tbl' counter in > ve.failcount of the container's ve cgroup" > > Is it intended to drop the arp_tbl versus nd_tbl distinction and the > host-level overflow message? The commit message does not mention that the > original message is being removed. > > Also, this path runs for ve0 as well. Would the host then log "CT0: hits > the neigh_tbl limit ... of the container's ve cgroup", which seems > misleading wording for the host? > > Finally, the ratelimit state in ve_failcount_inc() comes from > __ve_pr_warn_ratelimited(), which is a single static state at the macro > call site. Is it a concern that all VEs share it, so one container that > overflows its table often could suppress the message for other containers? > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel