From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B6CC48017D for ; Thu, 29 Oct 2026 07:29:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69T7RkND029135; Thu, 29 Oct 2026 10:27:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69T7RkND029135 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="kwtAPYHS" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69T7RhtC029131 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 10:27:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69T7RhtC029131 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-679c17e5084so2397291d50.3 for ; Thu, 29 Oct 2026 00:27:44 -0700 (PDT) X-Gm-Message-State: AFq9FYJZ9ARf8QpKmVKMv3knsdg55ELJZXMVSI3k0CY84gVEdbb+lB2G Fy+0+qdaVAp6sb4VYec1Z+L6zi70zugFc8u+vrnzy7hsCYHGkOHxF29VCMQk9s80xHTAlrMZFd2 7yPxrE/ssrHIDe3lumPB9ll2Nnfl84RomAWf2VE6GCQKJEHL94zzvSQ== X-Gm-Gg: AYBFou1KAnYynNEsjAI4WKlVM81YrH6GIG5aurgWl0pX/ffRntHtr/WxiLxcN69Wb0m jhUuHMQQz2/HYlmAwVZCwEqel/M0zGPrEphXjSfDmyvSmyxpyT6AsI1ueheOX4mJla/7RftDLuA 6jO0qxdUrDPeeoOMUOhz+EzELrdzEq310hUg7+yyxO8+BkoQLxhuc2IpSv6vnGv9JfFqSyjSYeY sEdYeJ0jZG6ns+h1iXJ1Y5iwDwI10+LJw26+Mxe1ZQ6zQGXL1ZnxH+nIpKfEdESSH6SkXHj1a1b NeUqcPGvtuFg+YXEZjY+iOmJAiNze/Ivi/X0IiTxlY5Ql/JHPep8v1AjRyVSocKq0QOM3fRvjwL dpeT/aoQGwHoo9ETMKzVH6IOYbvVxuf4h9GChdYiKcPqv9HupXqbKhG2FZvctdm3hc6xnz57T5S jF4E4vd4XQoE1iLXOGUpBfYWVlo7GpjHq9hg== X-Received: by 2002:a05:690e:2391:b0:679:a943:7da4 with SMTP id 956f58d0204a3-67a7bd552admr2352869d50.85.1793258862907; Thu, 29 Oct 2026 00:27:42 -0700 (PDT) X-Received: by 2002:a05:690e:2391:b0:679:a943:7da4 with SMTP id 956f58d0204a3-67a7bd552admr2352865d50.85.1793258862430; Thu, 29 Oct 2026 00:27:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793258862; cv=pass; d=google.com; s=arc-20260327; b=gflIPTstSZ2/nDgAylPWDFNz9/atj6QNbT4YBLirKnq59kQ9wawp/8P/wPC6bV4w58 NyuqLfKN/YohWzruxM3IxHUSPHIeAATOOfA4BsZOZo2fw+0uMBsJxBuRdk2r4M/jz0nE yc2Pp8pqBSU/Mwr0hx2gEXQRtectaUQFSqCFSqVvk7u6YGw7eJTumjhhzGjYeJQo4LOF sAngbZsh0o0lA7SG/Ia5rO3y3OLhJeuQNX3R208CBFq9h2BHUoOVnMES/B29YJaBrtBK n0UjQE0nJAMbKxj85TdCLTizo+RUeIS8+E4NyCp2aJtBn0T9uilWp0BK/c0bJGN+bpLR RT8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=qYBjJhBBenV/z0yVzX/WD3eJHBHFxu/tckC6dsgpw04=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=rzgSVwXNlSKZ7+j346qghuNekMkJL410Z3y+BbXOPx3SqxLKA8Owi8wK1kaHStB1z+ 1XJrGaaTiY+td/4jMPy0MBcQpbdkidFOcip0CIOn+NUzWN+l5Ta422uGUctdqDFbwALA N/4SdWbdeXht42jgL1rC+Rgck5B0BS3o94muA3zaoH1pBFt6FxrLhq4/4GsHC0bIkHNW 6bnme+n5hu4UzcclDVTpix1Z1Uuqw1paD+Senrtn+USS58brzbDKC/vMDB18llLaSJm7 EdMNgybc5d/VexZvpYiax25tGhboHsfY2WJ/mXAEkR9CjBRCzqKqiqfQDiz8IXxpomu1 c19g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kwtAPYHS; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67a7a137c90si4184069d50.222.2026.10.29.00.27.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 00:27:42 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kwtAPYHS; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MP33hqIuYCaxKqMwNKK7DOh0HfYSq8Ns594HcJ3NUHZ+fqofa3V4prt5u8g6v9PGh8iaCysb+fGeaFz6q5GbVfvQwk4AuLwVaPg86pflThTuG4UQEad9WBg8yeNJAWnvjElzmgs8NaqvT9zEwMrkmcFTlvrkL/0eZkqw009rKfoJZMxadBWLrDegMNyPmhUWYtPwGJ6KnV+IJYZs6ixpQEqWI+MAZFNSzJbpiXOwYAM88zucEQPgy63XX8p7FvDkBHmND48BzutGL1r0kheNCdz1bOIksTY21R0C1D0gu1h6tYlF83IVDnTuvHG5ANI+fKmGS4yz+vuZMsBLn25aHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qYBjJhBBenV/z0yVzX/WD3eJHBHFxu/tckC6dsgpw04=; b=ZWN9/UqdMRRHoFT9q13FyNgSNbKnJLH3OMt+tbx1aUKsVFekcD6522TP8IBCgBl6y3kL0+snE9FI3ZTFVFQFymlZs0lrZ74xOGIuQ++/pji09Pub7tr0y4jDCooHSct9k7je3rY5ruciqnvWcspmdHW0MmB323pYxjm+6VU/IFr7xJAw/uQEvMKIPK7FHnIzL0eEmVvKSoeoLDOnwLFjmWkc1Pu6Xdt7xZF1fBcVLhDWtwAI7Eu2V1j6kS9rR6RDUNEo5MGUOvnC5W0kfsBt4WFNQGtQTQSr7MVj8/hAMUAwcbHmYI8yJ2os7fiP2QU6Kztsq3samSQd4G7zNO50wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYBjJhBBenV/z0yVzX/WD3eJHBHFxu/tckC6dsgpw04=; b=kwtAPYHSwT6QplJVb9G247vDV/L78dehQaER9xo2dmuzjJcxUBQhAFxYY+GRP6ISJdnlHpxpOClHJv2uZdwh741tXWWzHLkLRIYOPAKWFyX7y/8M99CLnGOh8MJ+TWdZZS9m8jU6xSxHCOgUljTXRpvBCLC9xb4Ai2SW5e1Wg7msrR8gX63q7ChmBUAKdBkLhFCcmGt4SCRjs9vzV1nVTHiA4nDFVD8lGl0e9V7gIT9NKNIvgu5oLeuyMJlrGaUAB58RreRBWawdIpetMteoLHipparDb0ZhNF3bgWecS9Ajali1umfvvpSCFpUcfxF8a9RbEAr+t/LIEkHitGTOXA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by VI3PR08MB217650.eurprd08.prod.outlook.com (2603:10a6:800:37a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Thu, 29 Oct 2026 07:27:38 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Thu, 29 Oct 2026 07:27:38 +0000 Message-ID: <10bbb79c-8cf2-48d6-952f-c3462fbef8e4@virtuozzo.com> Date: Thu, 29 Oct 2026 08:27:37 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-10-alexander.ivanov@virtuozzo.com> <010701a183184cc2-36f3ab2b-1d9f-4720-9419-033e3d93b05c-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a183184cc2-36f3ab2b-1d9f-4720-9419-033e3d93b05c-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR0P281CA0224.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::10) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|VI3PR08MB217650:EE_ X-MS-Office365-Filtering-Correlation-Id: 3568364f-fc9f-4493-4230-08df358e1c4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|23010399003|4143699003|18002099003|56012099006|6133799003|22082099003|10067099003|261021121427099003|261022075727099003|261022105027099003|261026121527099003|261028144727099003|261022115727099003|261026140227099003; X-Microsoft-Antispam-Message-Info: HUn7RBBtsXCLZ4bcxFHE9gFMO2R+MjOEMgKQ+PdH/6FwUnJhQ0JtHefjmUcTMbp9cWk1FvDUqIqH2VI8hRRD0DYODF7BHdWkatNQpm+ElmuKaXVKIFDJ/ZDv3WLtqt2cwUQUF2Vbviam2twWnRdfRCMtlPqAqw4I3NX3Sb9V4VrJdSJn92i89LdiaWIxh4yUrGUs/EqrnyGcNLfQ2yHbMSYk/NFBk5IlLCgkX3aogG4XvTOmkUpJVHhgx0GhAjKvIn7qm49sMmwBty81SyvmcpkgO7TKxj+DnVo9yzXKTkUb/j28vG+cwqcffyn60LRnz0lN6+eL6dYuIqcUERys3tTjmslgKhXJmQBPSMZWca6cD83vArn701Kq38hOg8Ivb5jH+QgVdrtAcPvFR8+0QhIcy1wpFRXoCuP/HeM44AVPNe/4tPr/a6t/mzXnMZztENHgf8CgvRUUsgCgc3ssVoM8hXaSSJOYngvkkRFISK88Bu4BReisFllQNgAqLhzPF9BTUuf5Zsx/Pb3+N+Byo9UFyhwgBk/Npim9s+pH68s1wnsMqsVd3/IQaCaT/KlZPZfX1VFfIFmbhXVc5f5vjREAFRwWyyyv6hJWG1AIpWJ1BusWOijiVVmII6VYy+6BEXh7n+30nxKUgXGagSfgOwgI+MX+TWUzdxVsQiNo+Rs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(4143699003)(18002099003)(56012099006)(6133799003)(22082099003)(10067099003)(261021121427099003)(261022075727099003)(261022105027099003)(261026121527099003)(261028144727099003)(261022115727099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk0xeUZOOW1yTXNFTjRXU0Zic2VvMFJERlQvR1Nva0NFcWxPTVIrRmtqS2FV?= =?utf-8?B?cUx6UHJhL2lWdUlBYUNIblFkL3kzLzVsQlMxYUtzYnlNSW5vZEFtb295TjVQ?= =?utf-8?B?eW12RktHRHYxUXJrZFFNOUE2ZzRHN1hFODE3UTlhZ2oyQjA0M29sUXVtNEps?= =?utf-8?B?OW1TY0JpbWRRWCtjRi93Z21oSFdmZkZSd3VQSHJtZGliZkgvS1JQcU4xajZ3?= =?utf-8?B?N0VTNlFab0xBeHBpQ1NZUGVPU0s0SWJoN09CNDE0V2d5MjVFL1l3VDRlQ2xJ?= =?utf-8?B?akprcHNIOWFGNEY3ek1hUFljMnJOeHgrSGFPVEVFeGpxckY0NDg4Y3NxbUxy?= =?utf-8?B?aUFMckU0OUd2Z1FpL1ZFanNQL2xjdEgvdFFSeC9qOXgybTJEeEFuVklPdGs3?= =?utf-8?B?ZllzRmpkU1Z5b1VHazRDc2cyOFlLZXZTMGZhY2poK0p0c2s5cXhObVZMbzBY?= =?utf-8?B?dWNqMW5QNlNIRzUyTXlSRDJtWXliUEo2YzFwaFhnRkYyT1B5WGlKQXAwdkJO?= =?utf-8?B?YzllVkZOd1NZMWJ0dUptNFU3L3IrVHQ4SGlYUnBqdEFNQUk1VG90ajRHRjJE?= =?utf-8?B?OVQwa0JZUTJYYy9JYnVMOHI3c01IZ1pWMVNZcDltek1EVUVqM0tzTlpJaTd4?= =?utf-8?B?VjRLcnZ3cGFzTFZ2Z1AwaEVvaVNhRy9SRDRmanBpNzBJVEJVZXhqaDBuY09n?= =?utf-8?B?aEpDZXMvaTlHcy9USEQvR1ZDZnFiOVN3K0UxeDJiNktjNWFSYlFjTHk0cHFo?= =?utf-8?B?czlPZUpSaUUvWmFpNG9acWpUSExrbENuYUZMaDJkN3cxV1JNYTJIVnR5TWcx?= =?utf-8?B?Rm91RG5hQkgxOVhKUitzSWxsdDBDTE5RWEY4ZHdyZ1BXd1FHbEJoa2w0eUhw?= =?utf-8?B?SHF5VURxckE3NVRiekJwWFFhWm52ZVoxN0tqbEZGaEtKa01ERVdyMTlkTlF5?= =?utf-8?B?cjdCRERBTnNOZGRNcUxCTmpDYzc1YkRIOWFyaDBJa0VPd3RpVDVVQ1BpeWxk?= =?utf-8?B?Q01IVG5KK2RzbXVJTEJaR2pmelRhOEIxTHJ1OVgwYis1bUdUMm1xRExhTDlR?= =?utf-8?B?dk5ycmFWeXdRZjRPL0NrOTVWZ3FrVGdyd0N3ZU1PSXMyVHVvc0JTS3RsSmdh?= =?utf-8?B?YmhlaHlYQktBU3k4aURoT2xJK2s4NS9aK3R0NzBOeUh6TzJ6RTJPRmh3VUxB?= =?utf-8?B?OFVCTHdzU2ZyVmI1cGhIR2pKeTk4MG1sZ0hSRzhTVXplWk5NTWRMdHJLQTZI?= =?utf-8?B?VEJjWXZTT3NiNDFhWVhFbGEvSEVob1ViQnhyTUpSUnQ0cmhLc2ptb0dVdk9S?= =?utf-8?B?clllaDZGRWU4WkdJaXNXMWp1b2hwQ0o2WWNXZUliUlFJelBMSUdONWthVnpW?= =?utf-8?B?VTIzakhkd21MbHVXRC8xbjBUY2RuZnJ3TlZMNGpickRuTnJ2SElCeWZoMitS?= =?utf-8?B?N3V1WnZVWkJ3OFdqbVA1VkdBOG0xQS8zVFYyb0lNR3B4KzZaeUJYMFN5RklR?= =?utf-8?B?Qy9xdDhrK0NyV1NEcVpDZUt3TUc1cXhzY1oxRm8wVzhDRkxyaWh2cFMyeit6?= =?utf-8?B?UVRieVJkYUJzZHRjUFU3MEJVSGlEY3pCVjBkV21kaDljWUxhRlRyNlpTeWpM?= =?utf-8?B?bHhkejZrV29KY1gvWHNWYkxRbGM1RGZPcDhHN3pndng1ck5KYTJNZnB1Z0ly?= =?utf-8?B?azIrNGMyMnpLSElTRnhTNmJRM2cxUHN5MTNWN2RrK0pUbnRPQ3VqZlhidnBO?= =?utf-8?B?emJiSnplQUF4SWVMZE1mWFV4MUxHSk5rRnVINVJCSjdENGVkWjZFYWdsSHd5?= =?utf-8?B?bHI4dzVyWmN5OVAvMWVnYzhrVFp1elVMWXFNRmk0M3ArRDlubUt3czl4ZXhj?= =?utf-8?B?YVcxeEhUUFFrOXNIZ0xZak9NQVc0RjRTMmdDbTFFY2VNODJPdFZUUHZvVmYy?= =?utf-8?B?aDN6bEVjaFoyb0xtL0hNQzlxc3d1RkN1UEJyWW9wZ0hGbGE4cTNua0JyVEdy?= =?utf-8?B?dEh1ZTRaQmFYM1Y0cDN6RFQrSnpCbzg5aGhZL3EwekJ0T0hlWmhGWmhFNmEv?= =?utf-8?B?VGluOXJjN2JvSzVIOFE2UFhQNnh4ZmZlRksvV3U3UHd2NmVjQnZlRTlQT1BS?= =?utf-8?B?V1ZyeTBrNHY5MjR3OVUxd3FzT0ZsU0NCTkJJcW5nVmw2ck1MZnlHa0V3dVhy?= =?utf-8?B?OGo4Y2JwNTV1eFBVNTNWOHRqbDdRT0duS3FnYzE1STdXV1F0cjZMUk5DT1Y1?= =?utf-8?B?TDZNbW1NZXp6cFhwMjBmSVFhR2FJcGNzd051U1g1QTlJcm1aSVpubXRzVDRI?= =?utf-8?B?ampzRFQ0RXd5VTNrNXVRRXh3dks1R1FQVzZwZDBLOWZrQmdIQ2FCM0FzRXFx?= =?utf-8?Q?C+ATxljLp5q0Wx/0=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3568364f-fc9f-4493-4230-08df358e1c4c X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 07:27:38.8009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3aelSBC2XFVD/Pi5tuFD2b8SQsWD/xEAQSr2atIFLEM/e6V/SrK5xbApShTdIFZa8x+n9gs0ac7k122hAubDnXXFeoAEjF8JPeV7Prf3ps8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI3PR08MB217650 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 09/10] dm-qcow2: flag the image for check after a reverted L1/L2 writeback X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -1362,6 +1362,7 @@ static void revert_l_entries_update(struct qcow2 *qcow2, struct wb_desc *wbd) >> if (cleared) >> continue; /* no cluster was allocated */ >> >> + wbd->md->status |= MD_LX_REVERTED; >> spin_unlock(&qcow2->md_pages_lock); >> pos &= ~LX_REFCOUNT_EXACTLY_ONE; >> > [Severity: Medium] > Can the lock be left unheld on the WARN path in this loop? > > The loop body in revert_l_entries_update() continues like this after the > quoted lines: > > ret = qcow2_handle_r1r2_maps(qcow2, pos, NULL, &r1, &r2, false); > if (WARN_ON_ONCE(ret <= 0)) > continue; > > mark_cluster_unused(qcow2, r2.md, r2.index_in_page, pos); > spin_lock(&qcow2->md_pages_lock); > > The lock is dropped just above, but the continue skips the closing > spin_lock(). The next iteration then reads wbd->md->page, calls > set_u64_to_be_page(), and executes the new store to wbd->md->status > without md_pages_lock. It may also reach spin_unlock() a second time on a > lock that is not held. > > The caller does not expect this: > > complete_wbd() { > spin_lock_irqsave(&qcow2->md_pages_lock, flags); > revert_l_entries_update(qcow2, wbd); > clear_writeback_status(qcow2, wbd->md, wbd->ret, > &wait_list, &end_list); > spin_unlock_irqrestore(&qcow2->md_pages_lock, flags); > ... > } > > If the lock is not re-acquired, clear_writeback_status() and > spin_unlock_irqrestore() run on a lock that is no longer owned. That can > corrupt the spinlock and IRQ state, and it races with other users of > md_pages_lock. > > qcow2_handle_r1r2_maps() can return a value <= 0 in several cases. It > returns -ENOENT when the R1 entry is zero, and -EIO on an invalid R1 entry > or when the refcount sanity check fails (entry > 1 with no snapshots). It > returns 0 when an R1/R2 page is not cached. > > The comment says R1/R2 "should be cached", but I could not show that none > of these returns can happen. For example, a failed md read or a failed > relocate_refcount_table() can erase a cached page. > > The unlock/relock imbalance is not new, but this patch adds an > unlocked-path store to md->status in the same loop. The later patch in the > series, "dm-qcow2: truncate unused tail of image on suspend", does not > change this handling. > > Could the WARN path re-take md_pages_lock before continuing, or could the > loop be restructured so the lock state is the same on every path? The lock imbalance on the WARN path has been there since the driver was introduced, and this patch doesn't make it worse: the new MD_LX_REVERTED store sits before spin_unlock(), so like the existing set_u64_to_be_page() it only runs unlocked after that path has already been taken, which is why the fix belongs in a separate patch. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel