From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F1D558017D for ; Sun, 11 Oct 2026 22:46:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BMjSsj009287; Mon, 12 Oct 2026 01:45:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BMjSsj009287 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="aObOmREw" Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BMjRjj009283 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 12 Oct 2026 01:45:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BMjRjj009283 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-837aaa9a3f6so13778947b3.0 for ; Sun, 11 Oct 2026 15:45:27 -0700 (PDT) X-Gm-Message-State: AFq9FYJ1YKsAOk8B9sYECJdSpwksaH173zi5ijfcAM60R9nb5Xxj07te mD35xK0layTyJYZShDPQTYYHDH5npk66H7osrUu7jt+cslYtaWHrLOEqnaIHnqi4KBCg8RQkOTl 2K+Cym1ol9gwIp7GU13yFcHLkIXizSjbK4OO4V+v0x4TD+FAZgXoMvA== X-Gm-Gg: AYBFou310F+W9nMhA9yvFJn//hhzwH2gt/olU2b9JOOYKAkMCvaSYtw7IcpMu60/yxC wN4MDVymKXwkfGTWJ2843oz8NXrlGV7M1ZXe0cYHGU2ZFB9nUBKvdcdj1XAOh9gGqe1uoQ2+S/K gjdArTR1RFDcjb9tzYGoKxBcYIZZ1/GtdiGr227SgDtUoet5WDsyFZ8f7C+SjtfyELuiZkoNX3W TlJfVTsYo2DSZMhM3ZDBlT7XNL4tVJ2rAft9D7kGxAFHLvkRb10L29DxjBd18RqiOJAgtCTI+IX 9KlZatBCQaOPbr08Fxg47mMCDQgkdzH/7E7Po7D/9U0Khvj/xy3TwaAE5csc8wFVWpqR0sYDNJV PM53gR5bU9F38yKCH4I0BbhiQdArPVWxUzx8Ty3kdZCPByA2ZIJF9QAHTtDvfNoerdwTtFbx/RL wR7rRh56ItZ+9vtBn7GcRIKddRkuWB8viE X-Received: by 2002:a05:690c:348a:b0:873:5c7b:c132 with SMTP id 00721157ae682-8b07d4567b8mr24233507b3.26.1791758726804; Sun, 11 Oct 2026 15:45:26 -0700 (PDT) X-Received: by 2002:a05:690c:348a:b0:873:5c7b:c132 with SMTP id 00721157ae682-8b07d4567b8mr24233467b3.26.1791758726291; Sun, 11 Oct 2026 15:45:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791758726; cv=pass; d=google.com; s=arc-20260327; b=qS4ReIsoGwfCruPUg2UBKrxoI3G0XxxBAyoviWVutvCRP2LE8v75xKh817zTwA3C6e smzOqpUtjySTaSIF8p3mlYVG80W0bWWb1aVTYH7wE5Rl/BToPfAxYfzMEkelqfSm2WOX siJ8SlseKaQGzOPHVS5zM9kXFl1QCe7ecBPpOkPXA7tkjNBoCVVOkApsBNK8enyjzsLh ujsjjKjO+8W+wyM3dgbPqbzfAifp1M9ki0pr0XQs38ZL6gN65W+7/WKxHv0ymaqcw6pr IdDGBB+nyUH5VhZJ6Ygm+GDnmfVxXPFY+39YjYATpo5hdXJos5NarCr8mSL7Zol27fu+ tCsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=9GR3OLGwaaICuDyyYSWPfBAkSaATpf+YXsIubB0xuQc=; fh=x+sEwlPrYjdnvyPJZgDx54RG2HGIpQh28bviCAKous0=; b=VvbX0NwuynPeO/P2qWOVHpE2xfXmifFyu2zlbq/ixhyEKr5FquubKISVp48PLQnCIg NlLBsSP0AOTE3DSpHISAieHYKhM3TGewzvr2yfuUQ3vGsdlX8GSBnWfL2vXImSIkRMoy Nl5HpOtXMDLLAoFZyRfSnjNAxtmE0mqUBQjRlniXC8QH91T505en+rE7dK/LD85W3hou pihJG1LNzGv80nibI/n/wWXi0yyT1M6QtTaT7ylORiL+CZCuuXv9QfZ06aa7ViU8Zdrq MLgZDQACZjC1t0ZpM7Gy5SmbhprZ8jgA8Ik6DCXJRcM60zlA3/rO6XgjdbJEFZf2YHiN 3qLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=aObOmREw; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id 00721157ae682-8b07f25d21fsi25401357b3.157.2026.10.11.15.45.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 15:45:26 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=aObOmREw; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rfmi9S+y6hRuF0+/Pmj8zmhzGQHVzyIb39tOVu1ut5BcH8NrFxB40CudYID3dNkGnyUvXtXebEOV7yfMLAIKjgmGsMkeHX/XxSaNjdmDQ6mRGcuts1hBPbgxVV/WDn8rEmDuqnLng0jBTkh0b1jVpUJUGhk82cBscB145vEsx+VN1c856ZGnp8/3omUgvFQ3BWvGcZLZVT8TmnYGTlEcFWMMYX5/ZK0AdfIJctteZEH/zmKk6vQsH54yciV69dio/gGYCxbgw4OmeW7p+rzvfspxvjPIinm41sNpRuWxDWe9M53JXh9ls76oEN3h4gDedwTXB9IW973BbNeorjTaDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9GR3OLGwaaICuDyyYSWPfBAkSaATpf+YXsIubB0xuQc=; b=JaOWcNWUO0izTLWfokUGA1laX51JSbbRhd2NgytbycAu05wXBrHZSGvwsSW6LY/95Sb5Fq7ilqXs1tplWVDrCl1rGC1843j7M+Nk0jXeqSO2/yb9mCenzLLCtqwCUAWKV9xEUBOhfL6poVNYA+Lkikh4QT9S4/Tf4OYQJK6uv374YoX9xXODw/AG05aD+xkFyCsTGqZ34EfO+sJW0L5TqHhgR6TP9zkip8MTtVQJu0XkSihsXxdcyZrnBm5AKWzl2eKIc+j7k5dIY0g/WtY/n+0+sulUvK+gYNqtz4KBXeMSYCROeqQRdPGq65WahL62PXNCGwAjtbnK5rkCh8OmzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9GR3OLGwaaICuDyyYSWPfBAkSaATpf+YXsIubB0xuQc=; b=aObOmREwmpj5+qzj0RoYtj4i9BckwLcTVx868QhNWeu8jb9ydljJGjoQeQlfWO2rlTQeHI938jqA+MkCMKm3JZQa9Hi/nrp7His7iwsT5jWupd/m/dI5yu4VPhyUg0HMmxhgWo/9pU6+FYBq497jIldnVSlrxGDrJzdaSfH3cufDeZRT/4ZXJB661IQTRqvDPYBW+Pz2nrGN1L/1Ytp7crLE3ZBfv+SbqOH3sRBfK+xyRRA/p00f5h2Im5dE41aETYfNpxmb40oJY2IW3huv1Lr/XxWOwwE075OQEYMfe2oAfOIdjmRIznacVt0PhA43T8x22pyVDoltZEPtjFn20Q== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by GV1PR08MB8329.eurprd08.prod.outlook.com (2603:10a6:150:84::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.11; Sun, 11 Oct 2026 22:45:21 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0496.010; Sun, 11 Oct 2026 22:45:21 +0000 Message-ID: <162e0afa-445a-4744-af3c-f992601de5b6@virtuozzo.com> Date: Mon, 12 Oct 2026 00:45:18 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com References: <20261006-ve-printk-irq-v2-0-db1dc4f6ed07@virtuozzo.com> <20261006-ve-printk-irq-v2-6-db1dc4f6ed07@virtuozzo.com> <010701a11340fdbb-79863520-ba9a-4f9e-b022-175bd113ff2b-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a11340fdbb-79863520-ba9a-4f9e-b022-175bd113ff2b-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR1PEPF000077D0.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::407) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|GV1PR08MB8329:EE_ X-MS-Office365-Filtering-Correlation-Id: b9d8ba28-1025-4739-a84e-08df27e954b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|1800799024|366016|56012099006|4143699003|261009223027099003|260925021311599003|260925021911599003|260925022911599003|10067099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: uGdWu7v3ekiA2rZ3ifgSCR+0z+N3ddfzzHIyAnGjTFl3Jotz57w12qlIblkSrWtmANFEk3EJMUaWt+F4G/Pg5lpXvqjxLuYy3pJI7ZoP9ZOBB8rcLsWlHEZi8HnaPHnvuGoJYKKSqdCZ6plIVZfzhm2rhGQAve7CviGU0fYlLFIb5CoHDAopve087UA4i/ypaJGvCIVKv6IzARqKhNSTdqVgZSbpXEDIb1k48AEjQs47MLx6EKz4ZRq6HgskvfMc7q4DTw9zIuoS75q2LFqkl7uQ/OR85XvD5MPVIz6kb6ewdr7zKap4dzDFei//13Ktjb5HoFKayKhhBdMfkDmgJLlue2iwPfjdyNexIgcvSFpexE/kH8H9/VkoXROoUxDZh0L2/76ss2brw/P4uO9oPy563v57tDFicCALt9OaaJdZ1k2Sl3U/YhAtU9MH0ctJlrIMVDVYbM7YguNLAhd8fjQUrDo4CDr6jH//HZp4OGnIhluEhKwO2S8Oqpn9pF5AEOHhP9KTcMLG7gX/9O+jh4kvReLYA+3uMqA9mTlycQqMcF06EBHUlAG13w4t0PPy7rOFZ7GnJNcsW1cbX/e17T4fOrOgtdwmMWvuIeCXcbFHAN/0RDCPxawse08epe85pQ4S0nmGm9MOR2VMQWom7rimW4/vdNYf2ay995RMcw8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(56012099006)(4143699003)(261009223027099003)(260925021311599003)(260925021911599003)(260925022911599003)(10067099003)(18002099003)(22082099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnRYR2dGYmJEQ3JESXJ0SDUySTViZ0lJbmR2bjdlckVuN1FWZkVjbDgzL05t?= =?utf-8?B?VXYyNzJHU2FxeHJxU0NUVEF5WnRHbC9BQ1dhQUVxWmV0aGM3aFdGdi9hblRO?= =?utf-8?B?L29yUnQzeXhyYU1HQXZBVmloRVNURmpNL0VGODNTWFE5WU0vRlVCa0szR3E2?= =?utf-8?B?RjRYUVlOWFl2Y2xQTFpoWUl5YVM3QWo4VzFUUHFIOHhNeXhzeVVmN3BEbWFQ?= =?utf-8?B?TlpoMml5TkYvWWlIWmJqUzFLdWcrUmxQdHYwSDZ3WlV4OE82bzFrYTJ2Sm0z?= =?utf-8?B?bDh4bFJsTzF0RHFUOEZHNmxYdWJBUlFHM2FYeXM1UldkNnlCN2dKNFB6SWRW?= =?utf-8?B?TnpXRUVUYjVNRVo2YUFRWG52U2dHRk5MMEt5QXV3N3FBamVmWERvK0lSVlR2?= =?utf-8?B?RTY2VTNhRWczc0NlSjBQaFhmb2Yzb3lzSG5CUUZsWEZmSU9IVHEwUUYvYXEw?= =?utf-8?B?bkw0WDhKaGdlTnN0cENpSE9STHRCcHZuTFJ6R1dkRWwrWE5BRnRxbGtWZUY3?= =?utf-8?B?Nm8zYlY0ZVp6bG5QNWV2NEdkbUZTRkpYZGFCV3ZmZVp0dHpBdGRIYVNRRExD?= =?utf-8?B?NUFaNEJjekJPZWMvU09aZ0wvMFVQbDE4N2tibjY5VVoyT1BuRWRjTkY2K3ZC?= =?utf-8?B?MFc1UmdzL24xSEFiR0xndGlxRVFzS1E4Uy8xeEJCR0dCaXJTQVdwMnlXSmdK?= =?utf-8?B?NHJJOC9lMU1EZFgrUmJEQktwNmRwdlpKeElnZm16RVF4MXRyekZORWNLSFJj?= =?utf-8?B?L2w5ZGR1SWVqY3NpdXVJUnJnQnVnL0dhK2g5SVd6SlRCcjloeU9RT2xZWHoz?= =?utf-8?B?cjBNTjlNbVlLQyswQ0dtZGQ0eHU4Sy9xdlhxR2Y5V0huTm5vNjRqS2VzVzJj?= =?utf-8?B?dDJVWEtTV1oyMUpJcyswL0kxYmV1M3RKNm5TQmxiWVJhT1NLb3VZS2M5ckov?= =?utf-8?B?K3pJblc1dzhvQm5pbkgxZEI5UVA0TmZLcWtQVlZJK2pPSGppZmpYc0lReFZu?= =?utf-8?B?MlJFSzJETnlid2QrS29ZTkVXSm1mend0K2ozandTOUhTTk1oZE1zZkVUbnVC?= =?utf-8?B?ZlR6dW0rVHhQLzlVTVRrT0I3VE5YZHArK0RpQnZ1VjhqVjFNcUxJdkdWbWhU?= =?utf-8?B?Rjd0dlJvdnFnM0FsZUZYcWRuc3JVM21mTXBvbGE1enZmQlEvcFZDWlpRMDNl?= =?utf-8?B?M1Y0NHR1WDUvUG83Uit4K3pvOXcwYWJBSHUwdEtKSXRibVFSTUVBeWlhMUtB?= =?utf-8?B?MU5NWURqZ25PQWhnc0FuSmo5c2UzMlhvQWtLT1FxUXpaM21SS3lUS0NZSS9P?= =?utf-8?B?VE1VMEkrQVhlc2Eydk45NHRhOEtFdlhiaVh4ckx4dVJkcmlIMlBwUFRkZXU3?= =?utf-8?B?dlp6bVVwLzZXVGxpSU1jOFF2aEZWRXpNK3IzT3BveGI1VHVPSmF0R0diOERK?= =?utf-8?B?eXNncUNsMzJJYk9Dei8rTW9NZjNwNGtRS2MzSXJMK3lySWsrdFVkVWpmS04x?= =?utf-8?B?MWdBYVFFWXovbWFhdlB5dHZISG5SL0pKNlI5QitFT01UZ3NON0FtRE91eXBD?= =?utf-8?B?SDZiUmNlWldGTG9HUld4S0ZacTU4V08raU1XQk05bjZFRExIamx2VFNlWUM2?= =?utf-8?B?b1AzNkxkcXJvTitVZnVZQVREazNjcVhxMlRHc1lPajZadW9RczJrMXNHeXhq?= =?utf-8?B?dmlCY1hVdnhLSzNjT0s1SDZ4WXNORTB5ODVCcGNRNDRCMUlBdkZudHRvanly?= =?utf-8?B?QnFBNXpRZ1JHNFI5MThReGVqbzJBWXlabURnMVpPWGd6cVBqeVNMSW5NT0Vz?= =?utf-8?B?UmFtWEtJRTRidVh1Nk5Td05YcjFYUktKRGtPdVo2NllTbG9BVmxMVzhEYkxx?= =?utf-8?B?ekR4MGEwK3FlRUIzWStuYVJUVExuTjFBbHFQMDJGOWdqT1RROUUxdGVmejVF?= =?utf-8?B?SUdhUEVJbXpMM2o1eVpMWklJTUlzV0xMODczaXVoRXJkaWFKRy9DNytVMGZn?= =?utf-8?B?REhvY1ZyK29HdTkzZVVrWnUxOXJQV2ptVzlmYnB5c0ZpMHZKSFpGUE1ldEZW?= =?utf-8?B?REEyYkhtS2RXcDB5V3BtbFZFc2l5ZWVucDNZNnVML1pQdWluRmtscUEyemFv?= =?utf-8?B?UUdIME5paGp4b3V5NnM5UDh2OXBkWHhIWExKVm84NzRTQjV3WTZjMWxWV2xk?= =?utf-8?B?WGprTldSc0Q0eVppd2RMZW80QWFxbm5jQXNqRTYzZXFqZEJCQnE2YXc0cDc1?= =?utf-8?B?NEdmd20weDBibWJGZTZuek5hL0NHbTZjQ0JPZVNxMitIUXVzYjk1Z0lkQmZu?= =?utf-8?B?VU15R2Q0UGhUd0c3bHM5NjBKcjd2ZVpwV2JNU2hsNk52bTJDMzFFT05Ma09w?= =?utf-8?Q?Lj8OCcoRCMWq/ahQ=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9d8ba28-1025-4739-a84e-08df27e954b7 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2026 22:45:21.3363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w8zkMYukUzyssnEL2haQo3wZmb3jFvLRInLtOeaKOsrpDjtFc23pQW9ojKZwAiddzUw1PBW4x6gRts10oVlGu1fUad9aoheZrZseO2gPguo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8329 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 6/6] ve: add neigh_tbl failcounter X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/7/26 00:06, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > - [Low] net: neigh_alloc() logs one overflow twice and rewords the old message > - [Low] net: neigh_tbl failcount is charged to the VE for global-limit overflows > - [Low] ve: failcount warning shares one static ratelimit state across all containers > -- > > commit 50b4fd033875ffa61097427a5f8a1d5372007065 > Author: Vladimir Riabchun > > ve: add neigh_tbl failcounter > > This commit adds a per-VE neigh_tbl_failcount counter, exposes it in > ve.failcount, and increments it from neigh_alloc() when the neighbour > table overflows. It also changes the existing overflow message to include > the VE name. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-135520 > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/net/core/neighbour.c b/net/core/neighbour.c >> --- a/net/core/neighbour.c >> +++ b/net/core/neighbour.c > > [ ... ] > >> @@ -520,8 +520,9 @@ static struct neighbour *neigh_alloc(struct neigh_table *tbl, >> (glob_entries >= READ_ONCE(tbl->gc_thresh2) && >> time_after(now, READ_ONCE(tbl->last_flush) + 5 * HZ))) { >> if (!neigh_forced_gc(tbl, ve) && entries >= gc_thresh3) { >> - net_info_ratelimited("%s: neighbor table overflow!\n", >> - tbl->id); >> + net_info_ratelimited("%s: neighbor table overflow for ve %s!\n", >> + tbl->id, ve_name(ve)); >> + ve_failcount_inc(ve, neigh_tbl); > > [Severity: Low] > Is the reworded net_info_ratelimited() message still needed here? > > ve_failcount_inc() already expands to __ve_pr_warn_ratelimited(VE_LOG_BOTH, > ...), which prints "CT%s: hits the neigh_tbl limit, see the 'neigh_tbl' > counter in ve.failcount ..." to both the host log and the VE log. > > A single overflow in neigh_alloc() therefore produces two log lines from > two separate ratelimit states. > > The commit message also does not mention that the existing "neighbor table > overflow!" text was changed to add the VE name. Kept old message to print table id. You asked in v1. > > [Severity: Low] > Is the failcount charged correctly when no per-VE counter exists? > > get_perve_tbl_entries_counter() returns a per-VE counter only for AF_INET > and AF_INET6: > > switch (tbl->family) { > case AF_INET: > return &ve->arp_neigh_nr; > case AF_INET6: > return &ve->nd_neigh_nr; > } > return NULL; > > For any other family, cnt is NULL in neigh_alloc(), so entries is set to > glob_entries and the entries >= gc_thresh3 test compares the global > tbl->gc_entries against the global threshold. > > ve_failcount_inc(ve, neigh_tbl) is still called unconditionally in that > branch, so the VE owning the device is charged for a table-wide overflow. > > The commit message says it counts "hits of the per-VE neigh_tbl limit". > Should the increment be limited to the case where cnt is non-NULL? As said in v1 reply, limit is global and doesn't depend on the type. The code there is already ugly, no point in making it more complex. > > [Severity: Low] > Can one container suppress the warning for other containers here? > > A container can fill its own neighbour table, for example by flooding > ARP/ND entries on its own netns, and reach this overflow branch in > neigh_alloc(). ve_failcount_inc() then calls __ve_printk_ratelimited(), > which declares one static ratelimit state per call site: > > static DEFINE_RATELIMIT_STATE(_rs, > DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > if (ve_ratelimit(dst, ve, &_rs)) > > Because the state is shared by all VEs, a busy container could use up the > burst budget and hide the warning for other containers. The atomic > failcount itself stays correct. > >> NEIGH_CACHE_STAT_INC(tbl, table_fulls); >> goto out_entries; >> } Yes, it can. We don't have per-container ratelimits, they won't work. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel