Re: [QEMU HCI-8.0 PATCH 1/5] blk: factor out validation

[Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>]

Nit: "blk:" is never used as a prefix, better be "block:".

> Preparational patch. This helper will be used in the next patches
> to validate vhost-blk block parameters.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-143437
> Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
>
> diff --git a/hw/block/block.c b/hw/block/block.c
> index 47897ca5d3c..6f135b7e2f9 100644
> --- a/hw/block/block.c
> +++ b/hw/block/block.c
> @@ -162,6 +162,11 @@ bool blkconf_blocksizes(BlockConf *conf, Error **errp)
>          }
>      }
>  
> +    return blkconf_validate_blocksizes(conf, errp);
> +}
> +
> +bool blkconf_validate_blocksizes(BlockConf *conf, Error **errp)
> +{

When calling blkconf_blocksizes() -> blkconf_validate_blocksizes(), we
have conf->logical_block_size preset.  But since we turn
blkconf_validate_blocksizes() into a separate helper, this precondition
isn't true in general.  And we do further:

    conf->min_io_size / conf->logical_block_size

- potential division by zero.

Andrey

-- 
Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>