From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020083.outbound.protection.outlook.com [52.101.84.83]) by lore.virtuozzo.com (Postfix) with ESMTPS id C92BE8015C for ; Tue, 8 Sep 2026 11:11:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eVgGB6yL4TtZ7C53G/YnFdyCwyUOzndFJAuQonBoSo6GOGDbBEf+AlseltAinKWycTeCuJi3V0/dPV/ra7ITdZ5cKZg1am/ySWRANpTrjHrGgoWrLStD+GKSBEodH3+20SXrLDe9PiVZCGX/fP1YDp4YFKIM2Bh2dIzX6dd4XH09udL65RnTDJp+QUIP+5EA4iUKCOAbV+gnEsr/jeLzUemaHwHNpfS9N/oZLsgfYDNwKGVO0DSZzE3QADroMYpwAWCyDiFmvSuLN7DwQAbnZlfHXH4BRVTuFKpDzZOa9fKu9W4jM6m9yzO512DnKPwcRreRszgETRpA4D5MpTKogA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MpWmwLTh3MFLOFZW2ldfYeL1zTyubNdZdYefw1FBqWo=; b=LxVmoE7dOQuG7XS8rkmsd/c7MSGP2s6WgkCcpoOTOpLoek7bgefvU0hud3bws+61JEaNMGZRnX7v/B17kiO7ogXFYENsXIK3lZhTLo//CbKpvqNbMDi9mvVX75ZH4x1LXT2LvFaxKL2/Qi5eD0FU672uDKmUAAxBoipJknCfe3G5Kn4cPW3Y0jdIIFipSUG3do2cVLfL4baLgWtj4DOCkQYHZ+loRK5BdDiz0FN9tFCvmkA2yFHyLGc9yBg33Pfxm9Po7EE6Vz81jVGVw/nff8KWyE8MpsiCquZD1Lrgo01jPB1VW4UaOueZTwKeU2zC/Mk37Y5V7O/yHu5Mj7mxVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MpWmwLTh3MFLOFZW2ldfYeL1zTyubNdZdYefw1FBqWo=; b=jxuZsDf+q66m0WbUswSkLDuewS0jrpt/bIBGo4VW4Gywlo2hjfQjC7kY8sYv79zy2yPPaOK3NzDHMrL3qMncvOvaa/dXqjBYXiAoEZi2djyQe2rraoJ4Qjh3oewrmMaCj6aPGZj0w/C+dzPDmfTeC3v79HjEWbxKP1fdZ4LJhQirlQGe6U3/2u13c2yrLUrZq6zwZATQbbpwxeZoS5+ofarCZdHUZRu5z1l1b8FBN7smmUNgmgKO6gOZFnlpERoE9AqxGCs8dDptyRL1tIof59I4Xg2qMJF8/NZMzQucbKuPwsFGoX4v68KkbtzPJvcxnRBAlQKOyUbYyVHO7tLp4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by AM8PR08MB5777.eurprd08.prod.outlook.com (2603:10a6:20b:1c5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.6; Tue, 8 Sep 2026 11:11:44 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0406.005; Tue, 8 Sep 2026 11:11:43 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [QEMU HCI-8.0 PATCH v3 1/5] vhost-blk: improve vhost_blk_device_realize cleanup From: Andrey Drobyshev To: Andrey Zhadchenko Cc: svt-core@virtuozzo.com, den@openvz.org, andrey.drobyshev@virtuozzo.com In-Reply-To: <20260908010455.249679-2-andrey.zhadchenko@virtuozzo.com> References: <20260908010455.249679-1-andrey.zhadchenko@virtuozzo.com> <20260908010455.249679-2-andrey.zhadchenko@virtuozzo.com> Date: Tue, 08 Sep 2026 14:11:39 +0300 Message-Id: <178886589978.877345.15303369513435454437.b4-review@b4> X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIVP296CA0065.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:35a::17) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|AM8PR08MB5777:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d10ad8a-735e-4bce-848a-08df0d99f6d1 List-Id: svt-core@virtuozzo.com X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|52116014|10067099003|56012099006|4143699003|5113699003|18002099003|22082099003|38350700014; X-Microsoft-Antispam-Message-Info: Yg2GDSuwIom2xZLL4IhvtssBI5Cy1irs/fUSm50wURpy03vhcaTAegP0Ssid+1JNxHL3dXy14rbgzkNT8gAjM3M1JlViw8Q+zV1Krcxw2o63HXHIzVNEoITWSk9kn3SB0JNoPEZT1vpLTAqBZ6yLzwcrFlsM/q/UnDix3SpDpIXpsE5vTuIzsk/IZiD0KC4XbyPYrhHii4djfkhVTWW/zIpWeunC1oH0zLGor7L2EKwcl9q1lJKMkQyCBy8kqWUfUT3RmRXbA36TOAyyzbrLupudMTYwzDbsiXUyTLWm8/L0ZymTZgbBBprG/VNpS74YKUYza3q3tP36B0KQIVDrn4OeyypOCGASgfgc4UwNjVFb3hcY1jspqKoiNxmaNpEkg79MN7QcHcK4mndf08+/COs40uuJ2/LcGLYghoZs+H7hEicPTOkrhHYks2xVmEHvqXDbQUqaoV+utNQ//NvFbHO1x+/CxwzWuNDUoVTy55DyphX2dZ92yhyxu/FjKISL7Y5K1YWVQmdn4ggqMLpqDZKVsuJNZoZC2ZC/LbES6fsIKtqrgrWjztkuY4hOHKJeypml9nIgeRYkQdgNpn3XlKavtPd0jPmC93c9GjWBN9U5xrKw/PTKShdPnEXD6NU/NMXzkbDiphg2/CQ9q15RkcdDfoG7duRlVimV9CHKHwLSZ0TZFpZD9UDnpJfdXD6vq3Ao4DhhVlu8PUKiMLb1XIW2JizlSJTRjGCqVg5u15Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(52116014)(10067099003)(56012099006)(4143699003)(5113699003)(18002099003)(22082099003)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDh1b3ZTblN5NkVqMzZDUmErRGl0bWFhVXFlUEtCQVoyNUE2MDFwbGk3Q1Nu?= =?utf-8?B?NDhSaEJYTmpZV0RlMmhBZ29WV0lNS0JuSHBiNFRnVUJSZFRoN25QZWl6QkpE?= =?utf-8?B?dmZ6d0o0WVlsWlptU0JWVjYyQitQU0xqVE02TjJNL0txRFVsYXBFOHdGdzE4?= =?utf-8?B?b1hVTTA1RWVxYVovTnluYkNqMGNublB5d2dLOXp4TkZvbFlsMXhGUmUzUEdQ?= =?utf-8?B?L1pCeEprTlpKUCtoTGY4VWZuVUJmbWtaTFRBRHI3THNHcUVYQk03MU1TQjRV?= =?utf-8?B?aGlWaVhIY0VEdlM1dm9vTnZ3UzR3SW80U0hnTVlpQ2VxTFhDWCszRko2UWJQ?= =?utf-8?B?T2lyVHIyRFhCZVhiSHFEMnRWUmNlZW1WcUtQSU1RV0VnTjNybmJKNjhFck9q?= =?utf-8?B?Q2d0MEZMNWJ0K01rVlpsamdFbG9SODYwTzZmWlJGMm4vQysrTGtaTmp3bjl2?= =?utf-8?B?QmNpbzZUajByaXAxTlRrMXF4Ujd5ZHRnQ1ZSZVZEWEZRQ0JncWltcGVrWkRr?= =?utf-8?B?Q2E5bVA2SytQK0JaajJjUDduVHFVRjQ2WUtyaXZTbmgwNEUvcFpGMThxR0o3?= =?utf-8?B?Sy9nNGxGWGdzbXRjV3d3Zk9hL295YWhOQnZPRWhrYXh3b1lzQ0NyUFFZbjJG?= =?utf-8?B?TUk1UW82Y2ZFNTVpVWwwWWJEZmxnYk5iTU52Vm5Ba3JIQm9pak9yWncxNHg1?= =?utf-8?B?OWlJUjQxb1FWdEdBQ1pScGg2M0dNWnRXRFc5OUtPMTVPTnNsQzJWYmwrSmI0?= =?utf-8?B?ak5XdHh5anBVUTdwUTMwNkY3V1dzK2lpL2t1ZE5ud1d5VTZIWU1TekV1U212?= =?utf-8?B?ckF4eGZTWG8yNCs2T0NlNzNZNTRuQ0kyNG5XajV3T1pDTHV0K2lHaDA3KzFE?= =?utf-8?B?U1RPWEhGc0VLWnE2UHZOd2dzWVRoQ3ZhQXpXL1I4WS9mUzFFUUF2SFJROEcr?= =?utf-8?B?aVlTWTgxOU5ZV3UzVHpvOGNiZlBCUHVxSG9WZU04UHdpUyt2ZXd0em1IOXph?= =?utf-8?B?VUVnN2MrVy9YVjBFVHRRZ2xXTm9td2hvWFFnRm1PZ0w1WE5yaGV2Y0xrVXlh?= =?utf-8?B?dzB1V0FOUXkvbWx2U2JFUEx4Z3phaTdjbHFRMS9uNWdLMnFPTFFzb2pscTY0?= =?utf-8?B?YnZqbW5SWk9BZWxtRmJiRVZDK1kvT1kyUHJmNTNISlRtNmVrSG1uZDZqL0RP?= =?utf-8?B?REc1WTlBNVVlVlBhQ1FKNGlYdSt4ejlWaTNmTGVFdWxiUjExZ3U0TGpUQTFO?= =?utf-8?B?N1pWbHNBUGt6MFkrejhnUVB2UmcvM1Q3dUpqY09HenNoV1ZIVXBTajBnbDEw?= =?utf-8?B?bXNkanZQZEduRy9RcllqZ3BSY0pmTE1xbExyTEJtVUxuNzBNTU9NYmVCYWIx?= =?utf-8?B?MHZOaUdvU3RWaC9EQjY2cm11cHVyVk5PelhMMVN5dXJpWFJ4NGI5UkczVEI5?= =?utf-8?B?cDg5SVp3V2ZNeE9NU1ovVGdvektOVDN5bG40OGVzdW9ON2srUSsrS28vcm5H?= =?utf-8?B?cjRMMk40YkkzaFhFTTFLYlhtY212ellvUGFldjAzSzIyUGJCQnlHNG5tNlYx?= =?utf-8?B?SGFJNStxYllKeCszQm8zcWxKTkRnMTZ5NXJUVnlWWTBLRlMzaDRMdGtQTmZ0?= =?utf-8?B?M1IyQnN6dGJabmpYcnhnZzZhNEI4WHZTTFI1QzlVRzI4aW5ESi9DR1o1UC94?= =?utf-8?B?bTdNdzVkQ0hZYUxiWURvQWlRWXppZUFBWEZaLytGWm02RXgwMXVtZHlaRWl4?= =?utf-8?B?bm9GNVdMNXlXcUJxbHd0RG5QcG03dy9vWGxSdVA1RnowOHJGWlExeEZiekZo?= =?utf-8?B?ZEkvK29SeHFEbEhuSjZTZG9tWkhZQ2FBWWVKM3l1d1V1emQyL3hzR2p6bzlQ?= =?utf-8?B?d3hWMC8wcDljeTNVK2VLdXpndzNhUmtQY1NQa000Z1ArcFNDY2Mzb0JvUzlU?= =?utf-8?B?bnA0MUlVTGRUSmRTdGE1Y2hJY3NNVS9hQmNGMldFVktpUGxMd3AvVFBSVkwx?= =?utf-8?B?QkxYRzJDK1BRckdNYTZrSk5kRy9oOGsvOW1DalUvTUs3d3JDSXhpNVZ1VjhB?= =?utf-8?B?djUxR3dVSjZ1MER5ajJjTU5xUkNaUFBadFJER2ZkQWZ4ZmJXSWsxZmxqaFRo?= =?utf-8?B?VFprNVZsMjhDOTBlcC9lNVU1L2U0M3VnVlIvdGc1Qk1DbDQ0Z1hMeEV1dGEw?= =?utf-8?B?bXo5dFF4a0pvbE1wdlFpY3doSnBMTUJINHNaTkpQOStRdE9YTmVZK0Mzd2tW?= =?utf-8?B?ZEFFRXd2ZXN0VXBqMnMwZW1XOFJXbS9MOElmMXNoN2hDY1J3SVRIMUhCaUVL?= =?utf-8?B?Zkdjc0ExWGxYNCtXelc4V0pGem5HN3FqQmRsUFBpN1FtNFNxVE1VYk9UTThr?= =?utf-8?Q?NM+M2+fx8jfPBlOc=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d10ad8a-735e-4bce-848a-08df0d99f6d1 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 11:11:43.5644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0sL72PDu/laUHbeLYOvAy5bVdQ/8IzmSKUr3hFTxLAq9HM6UgVDFi+ofJ6Q2nJWibCyG8UKxL8TMGZwjhzo/+OQaKE/53Sg8cmatdyLxSbY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5777 On Tue, 08 Sep 2026 04:04:51 +0300, Andrey Zhadchenko wrote: > vhost_dev_init() does a lot of unexpected things: > - closes the backend fd on failure > - memsets dev as 0 (thus clearing dev->vqs) > > Cleanup properly: don't double-close vhostfd, factor out vqs > so we do not leak it during cleanup. > > [...] Reviewed-by: Andrey Drobyshev -- Andrey Drobyshev