From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021116.outbound.protection.outlook.com [52.101.65.116]) by lore.virtuozzo.com (Postfix) with ESMTPS id D4D2180182 for ; Tue, 8 Sep 2026 13:35:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cDobNdEvWezLbDkQUanQmXaIYDYJ+V2vdoi+yL50eXnZcMNe9TreCy9/l5OUvU6xQcOS4kxpGScDIi7cFswL3HXk/YuyputbcJVZINiRqCcViphhIYVC8U0huDN+rojI2f6TsdITbfIDJVmgz/1FKrUjH2MPDFH7DwU8crAE9fl/6zFxVC7FIHrY3Oj8nJpiIhyp2tRNPJMf+aIwLU/85kgtyKoV6nJnaThDC7KxBLtUsBlEM77RpglrxoALpVP94gtJodz+/eFqPKqdPqhPUF6n0ounGtXlSyJhyw5QQZ+qfBpAv7xwFRgSrBnHFspUgXncYOueNSWKuQmUK2KsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RNcRijObkPJ5Qfu1Q7mHw0+wcviyqkr3JTtCwOpUJjM=; b=Kr47eTKe1FCCLXCPQWdTCFpySOPW6mSY1aE7qHymffSKtG/xc8TVZuZ48/VnNEBqwHMFRIVnDYOb4tSk9cjptvpAcf55efwLZ0xxAePkIQdRcAt/ubmymIvqjuvCWIR4TTbLDocZTHvD6RqLJ8sKXWaHHOZWrtaAKGZG6/UC5CLH9eXpzoSh3aqMKtOBplLLoJOGsajm+iGx20fwEGYxu9BW/VMUhWKMUc9jVrHht7wD5lh0lgEtrc+u7aLEvYY6OFumqoF0HkYFfifYZf+LzG0ECuWnAtS9Y0Qa1xNCarxE++rUhm3FB4l+9M+UOMY9jO+mgidJ816VPKL7mmjVAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RNcRijObkPJ5Qfu1Q7mHw0+wcviyqkr3JTtCwOpUJjM=; b=snYvzZhf+2MPBPBTYqAn1Nmk3Ozny7BY0UXB35DzV4gv8em34UgQpFB9Tem7wIorssgthcnDstzbHaNkCKUWIuQKguZHLIKI0NCtKGH6o5MCy1QknJBYjz8NzLB8FFThzlrHjS/vwXR0jqdTSNQ+6v4wqaaGlX2V4kKiMRaVzODaMWYxUqHj4uixtdl254GtScfk1KtPtvVo/mWLYeCig90kxwnXS4/kHtWHAiTU2NtpnvF9khWqSu35Hh1OkBtHwjkx2NbWWVm794yf5pzPi3xf55O4RDCaaeY5X3+qeB6SsZCfeQdNgE9DFDbPvnly39ClxR1AUUJw3GHLUef7eA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DBAPR08MB5832.eurprd08.prod.outlook.com (2603:10a6:10:1a5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 13:35:04 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0406.005; Tue, 8 Sep 2026 13:35:04 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [QEMU HCI-8.0 PATCH v4 2/5] vhost-blk: change backend setup From: Andrey Drobyshev To: Andrey Zhadchenko Cc: svt-core@virtuozzo.com, den@openvz.org, andrey.drobyshev@virtuozzo.com In-Reply-To: <20260908125208.278402-3-andrey.zhadchenko@virtuozzo.com> References: <20260908125208.278402-1-andrey.zhadchenko@virtuozzo.com> <20260908125208.278402-3-andrey.zhadchenko@virtuozzo.com> Date: Tue, 08 Sep 2026 16:34:59 +0300 Message-Id: <178887449993.896596.8316397670956345495.b4-review@b4> X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIVP296CA0130.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:359::11) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DBAPR08MB5832:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a8591f8-6861-44f0-d004-08df0dadfced List-Id: svt-core@virtuozzo.com X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|23010399003|38350700014|5113699003|18002099003|22082099003|56012099006|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: bprZCqgR0U/LQHpKKPGxbG/3In72LWZn9wi7iyTfmnwGH4iY+/B17c1Z2vPxXLHqrtyUiZRH3eO4pVsMRxFZY3b43VhkKXhy+ak6GnF5gfH+IkfBl3MLhMX44TabA9dgjk/x70jMnH01xxojx4T2SIqdOlC1K47KWkcrFKJCvlJpLu3q3TL9vQvxcyAysBtdZ8tBlottBD2dH6gdCXtR58DdRUCaXc7jZmDx8HTp9Roy9H3kNvikZ4rtoCfy9OpduDoVsboEnD84LhSRDrLXIaOrcWI6l3aPWD8GXTbOCN7tSdvaYulkUotrXToFeRXZurlRM7D29g0XUtFmK+4n87+RlHhsTG3yBQmJLCKu2uvTyGJPQ5MnBzO8sS/z5vH2U7o52J2DIKQGiJPHRz9EazhvybwdaQk3PxvXb7yriMdfe8sBGjqx7jcD8b3ksxUouDBa2H51cB5HQY9bHLMd6amvTnyvM1/xZJGA+wuM5sniZXUhwsXEDpHl2k/PHVRE30G7Qag+uiglgIktsKk+1jia6nc1iWe36HhmyBAWbif3sxZ8tFsFLw9fGFdCqZidTeYdbEpa536FHaRtDbqDWRC97k5Qozi94TvlgMIeQRhfPVRTe5pJk54QJf4jifHUzOvGxrN2oc6425SVAOb9a/DlmD6tQICWSIfUjRgrHUlj+Z0VqCELzlGJHVbpilR2r0zP48fJr6BqlhM1SFHH0sroHQBzA26tStDItm9zLzQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(23010399003)(38350700014)(5113699003)(18002099003)(22082099003)(56012099006)(4143699003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkx6TWRBM1EwalVKSmdQQXUxYXkyU1VHYjY4dkRLUUdmNy9Yc0dieGVFQ01G?= =?utf-8?B?SnRXS05oVE5ITlFqRUxIWTFFWlM0MmZ0bG8vYTREck8zVUJwbmViMS9nMm9L?= =?utf-8?B?Q01ESHhybjZGbXFYc2RzeEtTaHBzTC9FMDVQV1BaN0E0Ykp6L3ViZ2s4YWQv?= =?utf-8?B?c1o3TVdOaUFGdGRWZm5LTENoc21aSGFRNVp4VVM5NS82eXhvRlRnU3BKbG1V?= =?utf-8?B?SjFWOGw3WjRZNGNCMitaZEQ2eFZhQ0JoNlR4bDhwaDd6dFE1NE1uZmFuREcw?= =?utf-8?B?aHZyVUw3RmVjWHBwWmFjZU1VSTcxZDhXbDRrcjl0R0tSTno2MDg2UXoxdEtH?= =?utf-8?B?RjF0VWZCdGNUbFJ4TWhwditoTkdIQmJEVlE3SExabTNTL3drT05jVi91ZW43?= =?utf-8?B?SmJscW4rUC9EMUtBR0hVVWpEbFRpVkZWK0FPZ0JZNitvM1lSbVlRWVRpZUZI?= =?utf-8?B?SzBJZTJ0aWtodWdqWkhzbnNUMFdHMituVTd5NzhFeERXMXNYVExEUCs3SU9C?= =?utf-8?B?NjlxUElUS2JLN3Q1UTlHYjNqbGIwdFNCeERLaCtwZVB6Y2k4S045eExINFNv?= =?utf-8?B?Ukw4V3RRZ2g1UW13dy96V0YrNTlpMFhtWXdiaU8weGZqeXMyQXdsbUxJUXZQ?= =?utf-8?B?amdLR0pWbE9ZZklpY0tzSHdCN2U5Z2VUZWVmSkhuU0VMaFYxUWxUSHJyS3Vi?= =?utf-8?B?VFExUHFuTWlzZUNUb3QwOTBhaEVIZmVzL1VlTWQyMW1Mc01MQTNpMzhhTVQz?= =?utf-8?B?dmxmT2h0cUh6bFFuRTRhK0ZLaWJNZmVldG13eUVOcXpuOGt3R2cwL1VlNnlS?= =?utf-8?B?dWZVK0RGQ3ZiU3lzVjFoVUQvYnc4RGI1bnZFb255Z29COStHeW9QczVhakhn?= =?utf-8?B?L2NhTkUveUlEM0pSY0RKb0RJK25XaElmKzZYYzJYRkJkenh4eUZobXUzT0hp?= =?utf-8?B?TDJ1M3RZc3pDQWFZNm91UTB2SXRTTTNLbkVhZVUrTTN3Q3lwVy9ROTN0dSta?= =?utf-8?B?b3VQbnYvNldYdWRjc3VaR3dqVEM5WmJBSDBXbXZ0bkRnV2REWWw0NDJUbDRp?= =?utf-8?B?eVlEYTM2VENlVm1jZ1FjOVBIZWMrZWlSUklCTVlOZld4ck9xY3RQS3VwaTlP?= =?utf-8?B?OVlBWUtjTkNFRFZvWGVpdWxjSWY5VVVnZVpXdHBIVWlRVVRoazZGZFhDODN2?= =?utf-8?B?UEFKMCtFOUUvdjVLQzF2akI1OXgvTHo3ODkyZ2FNYm9QY2twdldJV2tIQTg0?= =?utf-8?B?WUh5RGFDODV4bTJYUzMvT0VpNnRxbURXZkhkQ290SVZNTmFGRUY3VjUrdWZV?= =?utf-8?B?WUxtT21VS0JTNjRxL0ZVQVA2Y1YxaGk1aUJIWHBMWXBxSHpNUUJTTnlWb09s?= =?utf-8?B?a2I4MW15ay9SNVoza0pvcURiUW1hc05heXREZnRnajAyVzlwU0RVY1BPSUVI?= =?utf-8?B?NmRtK0xsMDB5SlNER01GSmNmRDV5Y0NqY041TkQ5TVBtWDc5UU45aEV0dW0w?= =?utf-8?B?UkxJTlR6eHZxblllTXRuUE40aDU5M212WXJFZUZLVVdIRDNCZU4xRTU5Ylla?= =?utf-8?B?SkZyVjg4VGx0VVk3WHRSK1phNStTSVhhQk96c3NydmFRUkNTUXFKU0NRVmhQ?= =?utf-8?B?OGtraSttSHV2VUNBb2w2NW9TOFl0S2hjUkxtZjhlQ2RLQzhuQUw5V1FJTGIz?= =?utf-8?B?OUM0SWJUL2dlRkdpR2pvdExlbVFKQysvQkc1UlFHcGQ0Nzl5QnpuRmdDUm5C?= =?utf-8?B?U3lIWjJvcmp4aWE0VWc5STcxeDk1WmxZaWpYWWo0NUFkMHU1STh0d1ZVcTdH?= =?utf-8?B?VVJZdGlqT2pWcVhreVYvUGRRNEQreFpaaTAwSUR4ZkVMTWp5S29BR2NEb3dF?= =?utf-8?B?ZmtXM0JYN0k1WEdkOEUwRkl0dCs2UklLNUprb3FsUGJWMnZ0WDRSb3BaYmhN?= =?utf-8?B?Z1hHeFdyQ2tYcVlITlpMK1JYRGlYMkQzWkhVT2xwelB2U2FFV2NPNEpiY1c0?= =?utf-8?B?MmNGZTYxSnVZbDBIa2NOWE5LancrWm5PTnVaRWVyOExtRzg1eVQzY0FLSkd2?= =?utf-8?B?K1lHdUtzSWlVdG1EbVhNRG9uTE9YTDBuU2xsSzVZY29ycWladzZXTElCOG1s?= =?utf-8?B?aTRBVG9yUEFLVzFQcGhGMkFPZTFGdWpuY2ZnL2FTb3VLNlQwL2pRanlHTDU2?= =?utf-8?B?dEFPOFdrTFdzeC90OGZmTWxWaFdKbkI5SHRmREtZMHB3MUFmM3dpb2c1c1Zo?= =?utf-8?B?SGlWQTVsUldZOWdtRkp5VmZRay8wdEg4YmRWVTBRZkxXci9PcnkrZjhvbUYv?= =?utf-8?B?Z3hhQUZXNG9TTlY0d2RsejJNRUJLS2V2elY4azd2RXpVR0xpWE1MbldtYTNY?= =?utf-8?Q?l4AkxMpzDI5bbzUI=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8591f8-6861-44f0-d004-08df0dadfced X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 13:35:03.5005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5UTngaQIJsMxvHUbkjSfPbRVASfvMZXF/UvzSYQW2sxD3EaYDL3/omACTfO2/nVtJpCBa6gii3wJ18WPSZDjQmg8Qy9m1gPh74PAVO4ts5U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5832 On Tue, 08 Sep 2026 15:52:05 +0300, Andrey Zhadchenko wrote: > Previously we used very ugly and incapsulation-breaking assignment > fd = blk_bs(s->conf.conf.blk)->file->bs->opaque; > It is wrong in a many ways, so let's rework this. > > Patch changes default `drive` to new `devpath` option so device fd > is managed by vhost-blk itself. Unfortunately this way we need a > bit more preparational work: finding out disk length, etc. Don't > be too broad and just do the minimal work. > Also drop generic block device properties along with the block > node: the kernel module does all IO in terms of 512 sectors, so > simply report 512 byte logical/physical block size to the guest. > Existing vhost-blk setups will break, but it is expected. > > [...] Reviewed-by: Andrey Drobyshev -- Andrey Drobyshev