From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E23C18015C for ; Mon, 14 Sep 2026 08:15:58 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68E8EbgB027969; Mon, 14 Sep 2026 11:14:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68E8EbgB027969 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="GElRBnyf" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68E8EaOP027965 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 14 Sep 2026 11:14:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68E8EaOP027965 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48589603501so1596691f8f.3 for ; Mon, 14 Sep 2026 01:14:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzgeX9INi8GNEiNRnk3Jt5J55r14Izl3m2XAsxQ/RKZQO950/EfGQ58zTLVsZTr301S2J480Q==@openvz.org X-Gm-Message-State: AFuF++kZ4LlggCS6GI7hKu6eAGMjLzxSJFr6vpa56A+QUGIlUTimcP8v MCGqlwkELET07Qv6JspEMvXT+LMJ9NDzAPalWVhOLW2N5toUkT/5p0WrPtYlR0szxupjrMb5wuA jgIs7CLJDHYiW9B1SCimGwLvgDIvlQxcbCrVw3HQK/NfsglW5j+n/qg== X-Gm-Gg: AYBFou1kP7ImsXneOLnU0vi+wbfO/LOwK+gp05/rlG6jcwcNk1UxeZ4WwU9df/fI4m3 witko5JkhDn9m6PP4m4zUlKJJ5GtIHYkJkbE4QUHtdSTFedkPURRBizrWog0MuKO2V/NaDOrAU9 7+ivpFcxZdmUboodMLdyYLdiwOQCqDC/M81EHQXBGN4oKRCTpERGpdK+DN/t3eqCQW3xzmiLArn YLOi48P5Sfe9dB1jfQMEXhMw1NujHlCOTNb+cX4Xbaa02Kp8+sKjrBAGqbSIGomaywMq/tYwMR+ u9FVOWG5NC1I962j1h+xLIVpbSoAthDn9+RQD5DCI79zY0xTRMHWTVcKzwKtwMzv2kZAtUhSwyL FIcZZNgYkuqDSxd1FIkLWGmxQpYp2Caw= X-Received: by 2002:a05:6000:4a17:b0:485:8fb2:b8cd with SMTP id ffacd0b85a97d-48702ab8bbemr1446436f8f.6.1789373676592; Mon, 14 Sep 2026 01:14:36 -0700 (PDT) X-Received: by 2002:a05:6000:4a17:b0:485:8fb2:b8cd with SMTP id ffacd0b85a97d-48702ab8bbemr1446393f8f.6.1789373676080; Mon, 14 Sep 2026 01:14:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789373676; cv=none; d=google.com; s=arc-20260327; b=QEb+zytRYt3kDgLv0a5gRyHiY2C5fEVtNmZc/wR+r1F6zO0sMnRXmfffmBs5yPVp8t gdmEL+ET2mf35jTMtG3VDyoW8mxy/OpBaRaHJSZtJvsjTuuu1QdSJDnejbx/Pxe3dHlZ Mq1qlJ+waqRKQFiE+rA6vTwak6YHqfeDeOa9maSrGPQipDoBAoovlS4JjuopOWHVjZlk CXfldsLMG4A6VAzJxrEnEcUZ4pBuuzlhDFWd5UOrqfJpVwX0m5nbmRUVN+66V6v+ZnNq Eezc26+Pnjej2jwsrjZX1aF/Yu/qRq+wxz9xp2SYpLm5pr5I1ZHli2jHdELtVLOHEfaf moWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=fOmnIuhGzCF9EnGLfdFr0Ue3eGTSE5VqPli7IkF/MCA=; fh=aWiT/A9MyJ0Njuv4hgRfSyPSUcI5MQ4W3cxOu7FMyYg=; b=pADi0krlN1/s+NSjh0rd9KF5KuZrcvmOudAKiQhT87MshqXjxogHRSqV7Ak+O/XcE3 Z0t7hZflES1qKpeUy0wBG1XY5WuB15038W2J+mQ39pYdqPrxH3CfFOyqLx/pc1Yjy4bw 3WmXrEtZuFe89BOoMFkoxNjB438WlKAlLBHdNeJFFiOJch0ZYL56vYti64vpuksUBSx8 nxhDm3LTzTkxvhk48lRbMZdnC0MUvuGJIP21FUj7sUSo8AVSpz0gsNYZ/6W4NIV+zX0o WfXXUtrdIkwk+E44aj4ywahKKnMkIvA/QpsgLCx94TfufXrSjupXLJVD9HlesE9pL2CZ T5TQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=GElRBnyf; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-486eba5ecfbsi17111256f8f.320.2026.09.14.01.14.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 01:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=GElRBnyf; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=fOmnIuhGzCF9EnGLfdFr0Ue3eGTSE5VqPli7IkF/MCA=; b=GElRBnyfVUl3 cHp1oQ/2ptloNJDk2zTTy2zTGBfCyRQH3z4keL4/ZkDas5mOokzPbTv5yuY8jb17SYnELCHvq+6sz N6FoC5ohcl4G3iN40Q4Nhs1DyWup8kFmmlEAI96Bq+jKY1FRlL4V4ruHZoqA7uTepwmhcbJ1ZcoF+ Gw086/Sssngdi9bJIDQKk68olpmpUdJmCr1t757IbhAQ4T1Jaw6sJPgco8FoHyIgUwRu5NBR8im0Q juKl24fD7FdpzN+nHpGlNsOFCw07+nZyiyrGYKkovKECy0pLmXxPSyWifAPua+nQSoRJ/ABBDxmn6 +nBh5A5EnSR5StzIdNgtdw==; Received: from [130.117.225.5] (helo=dev010.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x61n2-00DfpG-14; Mon, 14 Sep 2026 10:14:27 +0200 MIME-Version: 1.0 From: Vasileios Almpanis To: Konstantin Khorenko In-Reply-To: <20260911173752.2261924-1-khorenko@virtuozzo.com> References: <20260911173752.2261924-1-khorenko@virtuozzo.com> Date: Mon, 14 Sep 2026 08:14:33 +0000 Message-Id: <178937367342.972158.13011870102539365372.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789373675; l=751; i=vasileios.almpanis@virtuozzo.com; s=20260812; h=from:subject:message-id; bh=+joX4t0VK45WrfciCTkLYEB/XSGcx5GozDZe0YoufdA=; b=RfwrlKO/Qv+/e6LeLGiXlsANaCSuZYSo9PuFf8Nh27RzY29qO8emeqBRiybZ/3QPgy2bHEiL7 +M6VPLOfOmWAYM4Tk0boaxrKLsFzIbzgC4Cd+ANTmXzkn2to04LbnAH X-Developer-Key: i=vasileios.almpanis@virtuozzo.com; a=ed25519; pk=HhuHDXAcPva9A8zccWEMRsb36reu+y4IVbBjXKxNUjw= X-OZ-Fwd: true Cc: "Denis V. Lunev" , OpenVZ devel list Subject: Re: [Devel] [PATCH vz10] bridge: stp: Fix a potential use-after-free when deleting a bridge X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On Fri, 11 Sep 2026 19:37:52 +0200, Konstantin Khorenko wrote: > The three STP timers are not supposed to be armed while the bridge is > administratively down. They are synchronously deactivated when the > bridge is put administratively down and the various call sites check for > 'IFF_UP' before arming them. > > This check is missing from br_topology_change_detection() and it is > possible to engineer a situation in which the topology change timer is > armed while the bridge is administratively down, resulting in a > use-after-free [1] when the bridge is deleted. > > [...] Reviewed-by: Vasileios Almpanis -- Vasileios Almpanis _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel