From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 329AD8015C for ; Tue, 15 Sep 2026 10:13:54 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68FACZOR005192; Tue, 15 Sep 2026 13:12:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68FACZOR005192 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="fxsWjzzh" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68FACXic005188 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 15 Sep 2026 13:12:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68FACXic005188 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49e745d5dabso24568015e9.0 for ; Tue, 15 Sep 2026 03:12:34 -0700 (PDT) X-Gm-Message-State: AFuF++n2W5+ElFraHKhhzACu6LsGyheQRcLMtfiX+85v4jkJRkNLvjoT DgcNols/0Dxb8NME0JSwgVQ7wDsoZbkN8Mp6Cz3DS+s+Iw0j8ivXmcV/oD2v8Yd+m2FdYas3cYF BB/K8V69xTsK8NWWz9y9s3L25OQ/SDsQT1ySA8OxSRc4UcWrakeefRw== X-Gm-Gg: AYBFou1RhKMstO3j7IgOJ8sVA7hntiRLsSN5PAaVTuu2UUbviG59NUM8Xpe+RMBE1su 0MshfE0fozdrXJfMgJoP0YEmZeFZoSegbBLZuLrl2QnbDY3O/7gdftrFcU8k6W6NWSMDWIlajdY 7fWSPyX/e+7AaigYjEAMdpXDiNxlrlFJAiFfEUoCptEoEMcOEzuETzTxLFiJ3CMJIREb04g0UbU cqcYuJJzyM6T8n7yq1lj/PSn7PSHKnmusrlI7IwySxPRVFCUExKdrZQlULep08vRUcsH5tbRos2 3iYt7x9s1LNAVTIzgcGgTsdfRPVb4DnQrWkZsBFLwJoW/jbySEQtUcL24csyj2f9xPOnEpPKxJ5 vIRrATiHNvpIDW+lg X-Received: by 2002:a05:6000:4a17:b0:486:fba1:6f74 with SMTP id ffacd0b85a97d-48702aace76mr15595528f8f.3.1789467153823; Tue, 15 Sep 2026 03:12:33 -0700 (PDT) X-Received: by 2002:a05:6000:4a17:b0:486:fba1:6f74 with SMTP id ffacd0b85a97d-48702aace76mr15595433f8f.3.1789467153258; Tue, 15 Sep 2026 03:12:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789467153; cv=none; d=google.com; s=arc-20260327; b=QOooBJvfXBRERJ0j+hSLDFO6NHnFOF4JVasiTLwUv57auRf77resrjAj9uRbM8/jX1 NnGz/3nUb8hHoinlJDzGgawSDFuvKuQGow5E9wmCTycnponngn20oN3k86hc8z8DkJXl 4RKX8dCVr9bpAvh7Xt6qyTUBLkyOdC3oywZQ3LtM0LQw9dUKNbH+zh6ZTHoPdZ6hWl8H kFAmJf6zR/aTcdrTWunRm+JFyAmDqnlO66NqK33oZScWo2FxuFMnZ00RhHYQ17rELxhr 2jZppxY1aFHihyQExScAlcQgzvt9XuZ2jrJktIlD1uFL/aRB9btxpBF5vML4F3dQtmR+ AuYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=3FK5pMNgt2gBBHKOpde/BDGc27y/LsPMA3wFVFZ9tbY=; fh=IbaWj82zqOZm03F/eoPTlWBn4zwBRsoZlMDBqCRFIUM=; b=Rb0/kw2cFd3dBjGmfc1UyZ0LtCY+quRAG0GtUQKLVZW4E4+uskEV2rTDa0A6+RCL6w 7InQxUGSe9/Y0KYL6ZUVxwqbgfPVt1oDWle7OWfd3UXAfjoauFY4vBst2RMMH20hyd85 Ei/hykel7+6jlDEazEIux1j11M/5n5FFNToUkhx6cO9qNLZNIUoe1rcbFNH+gBDqS7sH k5GE4tXFSFQalVFgW5wIVuXbS6ORO0Yv3NaPM23Cv4yxUmPEPw7rlqKisNGFciGEEU0x cPqF0eBRzD16ELQ+QVSoWjdKqTAhfWpk7F0do+EQPv4L/5SV/Aj771DZkrtWWEybHj6M YbvQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=fxsWjzzh; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-486ebe61394si24437701f8f.440.2026.09.15.03.12.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 03:12:32 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=fxsWjzzh; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=3FK5pMNgt2gBBHKOpde/BDGc27y/LsPMA3wFVFZ9tbY=; b=fxsWjzzhCP06 xqnoLVgvkHeiUKn0yJe3dw1tgvcs5p7mEVxHtoLHQSDteBjeymerbKkeyuds8qX5RtlJgWk3Eq3Sl yg8gocCi52dPx4wbvDZ3UfimuO1rImLd7rUNP7SQQHTg5pcb9dZZ7V2M+MZq+3GsrLfxxkjWyawN8 MDWYRv9GeKjFFSrW2eKVki2oQ+Wsf6fD/+i23+kYs462eXhhEL3uQQlb9RB9DSG/769Cy85hoaIXa asH3lw3CK30eIlFee+jroCGDN5kkKWG/kmjgnITfxzAdm61G6x2/xIT86+eD29zPPbaiqyFEzSTT7 M/GiCrecq3Q1iW+t81IOAw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x6Q6h-008EGK-2K; Tue, 15 Sep 2026 12:12:22 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Liu Kui In-Reply-To: <20260915081612.60313-1-kui.liu@virtuozzo.com> References: <20260915081612.60313-1-kui.liu@virtuozzo.com> Date: Tue, 15 Sep 2026 12:12:29 +0200 Message-Id: <178946714943.2358389.16104120233529296356.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1133; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=wAFNXiUX4KE9oJFLl8F1WyADp/iAfEmkxHADS5KyPd8=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqqRoP6omnFV/SPpXzxlgeKxJswDby7U1907rAI xgTQnAbhKqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaqkaDwAKCRBRlgpH+WFc KoUFD/0bfvReDqZXGTqirGKY9eNUKCQj/EThKgc4l/9LqxtmAGs2E4dix8nUVF97s6SFD4VE1Y2 o9OEqk7mavd5R35j9o/ZGvLCFtH1dKlbgfg5WQzY3dfFvM6RR3ckcFXWPyDE6z67yWk0FGYeFGE GfAyqtkmrLS4/ctO87aCy2BiV04cuKOBKetMz3vhK3DfdCqomEL9fLWH8h2XpSjTR96gjHWEoat XKUAZQ4AmLHgLGCsEoFXFPdLFrsRsBZ9xxJotUAHYoAZABef7fm2Zh2Zz7nwwS9yNmgwVxLUByj xn7lRaPOuL9L6WU4w86H0oqOTh6ND6tZP0yWxQUGw0xAmSW6cGyiYW+RF9QnarKaMiiiQL3GTqE ZWCRLJ1FEOHc1tuTdcxF26EyOM6vMM4d72RinQySCfQDgZKhaBO4b3QSfdRTL8ngRcd6uIwuQpj jbXQMbExZBHxU9sEcp2LPs6EFeTdWpo0BPxRqcW87zlU4w6l4Jjsr4AyISoPAqdvgeo6UUi5rDJ CzXIAhNDISTWhWEp1mLkYdCujxm0iz9uEfES7BkeoqL4ym7cgDqnkxss78eQ8mHjVFweEQZmGDR 19n4mOYBHysEWYJnQyCdduYVqY6V/IShSbmdmHRq/F0Cp7IjEl/pTr8Or0e86B/ANpq2Hu2nZm8 D9blbqMA4i6uBlw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: azaitsev@virtuozzo.com, devel@openvz.org Subject: Re: [Devel] [PATCH VZ10 v2] fs/fuse kio: fix RPC response drop for large messages sent over RDMA X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > @@ -931,6 +928,8 @@ static int rio_handle_rx_read_ack(struct pcs_rdmaio *rio, > > list_for_each_entry(tx, &rio->active_txs, list) > if (tx->xid == rack->xid) { > + rio_msg_sent(rio, NULL, tx->msg, 1); > + tx->msg = NULL; > list_del(&tx->list); > rio_handle_tx(rio, tx, !rack->status); > return 0; i will apply the current version of the patch right now, but i would suggest to reorder the code here in a separate patch, something like this: struct pcs_msg *msg = tx->msg; list_del(&tx->list); tx->msg = NULL; rio_msg_sent(rio, NULL, msg, 1); rio_handle_tx(rio, tx, !rack->status); So you first remove and nullify the tx->msg, and only after that call msg->done(). Yes, right now there is no bug here: pcs_rdma_next_timeout() is the only reader of the active_txs[0]->msg and is called under ep->mutex we hold here, but still it's a good practice. Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel