From: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 2/3] selftests: cgroup: give the O_TMPFILE open in get_temp_fd() a mode
Date: Fri, 18 Sep 2026 10:11:23 +0000 [thread overview]
Message-ID: <178972628345.647140.10820388968116005000.b4-review@b4> (raw)
In-Reply-To: <20260831223631.1637488-2-eva.kurchatova@virtuozzo.com>
On Tue, 01 Sep 2026 01:36:23 +0300, Eva Kurchatova <eva.kurchatova@virtuozzo.com> wrote:
> O_TMPFILE, like O_CREAT, needs the third argument. Without it glibc
> refuses the call at compile time as soon as fortification is on:
>
> In function 'open',
> inlined from 'get_temp_fd' at cgroup_util.c:24:9:
> /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode'
> declared with attribute error: open with O_CREAT or O_TMPFILE in
> second argument needs 3 arguments
>
> [...]
Reviewed-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
--
Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-09-18 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 22:36 [Devel] [PATCH vz10 1/3] ms/KVM: selftests: Forcefully override ARCH from x86_64 to x86 Eva Kurchatova
2026-08-31 22:36 ` [Devel] [PATCH vz10 2/3] selftests: cgroup: give the O_TMPFILE open in get_temp_fd() a mode Eva Kurchatova
2026-09-18 10:11 ` Vasileios Almpanis [this message]
2026-09-22 18:43 ` Konstantin Khorenko
2026-08-31 22:36 ` [Devel] [PATCH vz10 3/3] selftests: kvm: raise the timeout the suite gives each test Eva Kurchatova
2026-09-18 10:11 ` Vasileios Almpanis
2026-09-22 18:43 ` Konstantin Khorenko
2026-09-18 10:11 ` [Devel] [PATCH vz10 1/3] ms/KVM: selftests: Forcefully override ARCH from x86_64 to x86 Vasileios Almpanis
2026-09-22 18:43 ` Konstantin Khorenko
2026-09-22 18:47 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178972628345.647140.10820388968116005000.b4-review@b4 \
--to=vasileios.almpanis@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.