From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 618658015B for ; Fri, 18 Sep 2026 10:51:32 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68IAoBEs032350; Fri, 18 Sep 2026 13:50:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68IAoBEs032350 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="vvSz1oU/" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68IAoA2V032346 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 18 Sep 2026 13:50:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68IAoA2V032346 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4870a0fe60fso289427f8f.2 for ; Fri, 18 Sep 2026 03:50:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzHPJuxu/Ow4O4B8/Hzyk2Ix+qDLSEc+FJDategx6yOCnkN+2+3cln6MhoJt7INe078MMQ8OA==@openvz.org X-Gm-Message-State: AFuF++mM85ZOvjsg7M8zHJb9qJrVuQQFICLnnDWeDxLSljZtQnFqT/9z Fl3IJKwbGUAc5wr+cvUPzshy1lYmfSqT9DGl6e0jpvYtwfg3pxdJB47lfTjXTHksBhjt/0wwa8L StFWdWw/s4uyyx2aMJDfhQuRZoGd0aKkiZ5Gpu/KNdGr+r1n8DrRQsw== X-Gm-Gg: AYBFou35PC0LpYKLI6b8ZdiaSZeP9FlbIHSLEw5of/tuE7word5gmUzpNT00djNwQaJ d7sNBPUj4ha6kbVa72kEzFPrULi79YM2pzaUtFOhLUD3yWGAW109amjKkg3+mLTMOoi+VYJCVKZ bz3oGO4JWMLbYwTYuWRUpcMCCiXv8W+TlhSrKI/qLmATBRM8/IKaaNgAvbNPHtpxR15ROg7WYFK 4c2aS1tVJDAOA2yZA6+0dVHr2AqK6rlKbU2lHkrSnyUY6nsI1Cp9eVxwIui1Cz6jLXhNKXGXqG8 6GaAUuZBr+LxKv024+j/EDHTj1RbDX3d7esKbVBp9AtDKqRPlIvAyZj6gDy2H12r3dQZYOKZveM de911y4tcHS+UwlfXRissFtDSz/+0Uw== X-Received: by 2002:a05:6000:1acb:b0:487:767:b301 with SMTP id ffacd0b85a97d-4871e387052mr2781835f8f.57.1789728610147; Fri, 18 Sep 2026 03:50:10 -0700 (PDT) X-Received: by 2002:a05:6000:1acb:b0:487:767:b301 with SMTP id ffacd0b85a97d-4871e387052mr2781787f8f.57.1789728609559; Fri, 18 Sep 2026 03:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789728609; cv=none; d=google.com; s=arc-20260327; b=JAoEtB2BB1Cm1A17YLzfEIxdOtK0dBc1P+fuwGhqcDLGYoVNgXjbn+PU4CdLtQJcgE 2dI13CNRq/QRF8ZcNVf7kRCIuD/AY1gjk+dbEc3mKXwOo3XcpP9sEGiKimBORaGwlW3N o1sL++23CFXCSMLah6ORl4K4XqOyAzqbgtpmv2sbaYrNae/EZ+FZUuU+mViLhImTn6mN urthJoSu/qR/aU/Mcc8/vwckm3xsWzJQdmjLooE18ohoXLmoX/Ez/uS+s2/v4RnD13bJ wY9ZeX3/jEHJ5a2q59z4WBSi4i/OzkC6roAp6chGyrkw8uUNtSAPomFj9YxpxyKEx1Bp HxWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=JFja6OPmKrWeF1ER1MPhPHnK4sszhVBYOqVaJY9vf7A=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=jP0p4K0OVg6/76PeIlpj++0V49enC6kuIYkoup4qWdy1qFfB5hAj+kW+Neaw8xs8Pw cawswXABnMv1WJZNMzao5JZPN92HYGuFR/Hi6bVkmXopEJJWXAdaMCjczBerXVlEVfi4 cJBkDF5Poy6gFfOSKFhTZMcuGsiyhXTvBe/kOTLXL33VJBDbN93ug5Yncju6EnOae86d cYpiJmvQktenJIflPzj67E0VbqN/j8b6C7LACyIC74lM+/eyZTBVlfWr0KHTrzixlf2Q 8Rf1qyzr/uTD9n6sgdMHl4HeBpjBTn5gstcS0UQwQd1wcDBjMuDryLDQMhgubHV5X+4A 5IOw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="vvSz1oU/"; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-487200a6fd2si2258763f8f.190.2026.09.18.03.50.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 03:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="vvSz1oU/"; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=JFja6OPmKrWeF1ER1MPhPHnK4sszhVBYOqVaJY9vf7A=; b=vvSz1oU/gLT7 JM9rVSIw5lmzDwfiEc51BNGEvrmsEQ2XRlh7zeKCK3gntxL6Adc3v0P8dqbLk8BUhFxQJ76NKwN2n 8CMNKDGRSQqLx/a+xU55/pSs6R6iYEFNIOPFw6eyOrIE9I8E56PP7iCoZJ5I3lKr6tQFyIt+3w7np OQ7eGhT4XIs1w/fhq0nZ/+AXP1OftykfG+aMUeAQkQsdLsvfFU3Zx0y7kIA6hej732h1kKflBrvaF rJEOqitU8H4GIjpW+fZnHqbwH+PWqlpvCdaOkUIAeHQ+KZiAUVBqaF/ZAqAw1CrhCDRYvxNbrU8mA BpgFY+rTYxGtELFsBmsygw==; Received: from [130.117.225.5] (helo=dev010.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x7W7f-003fyP-2Z; Fri, 18 Sep 2026 12:50:05 +0200 MIME-Version: 1.0 From: Vasileios Almpanis To: Eva Kurchatova In-Reply-To: <20260831224850.1642265-1-eva.kurchatova@virtuozzo.com> References: <20260831224850.1642265-1-eva.kurchatova@virtuozzo.com> Date: Fri, 18 Sep 2026 10:50:08 +0000 Message-Id: <178972860866.656887.542761779397137099.b4-reply@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789728608; l=2160; i=vasileios.almpanis@virtuozzo.com; s=20260812; h=from:subject:message-id; bh=Nc2dDFkekoB0zFsgaZMTJjaYO8nMqPKY9SV7aFv+31k=; b=ReDLCFVQeKx89uMKI7HkdM7ER4oNl3HWyKRpUtkrgZXS+soVU7CsVLPB6RfZ+X54G0bC28qIE y9W3woOMhw5BQ14RS1k//saHcAO58quNDKab/VVZX0On0WYc3M9xjIQ X-Developer-Key: i=vasileios.almpanis@virtuozzo.com; a=ed25519; pk=HhuHDXAcPva9A8zccWEMRsb36reu+y4IVbBjXKxNUjw= X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 1/7] ms/vxlan: do not reuse cached ip_hdr() value after skb_tunnel_check_pmtu() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 2026-09-01 01:48 +0300, Eva Kurchatova wrote: > From: Eric Dumazet > > skb_tunnel_check_pmtu() can change skb->head. > > Reusing old_iph afer skb_tunnel_check_pmtu() can cause an UAF. > > Use instead ip_hdr(skb) as done in drivers/net/bareudp.c > and drivers/net/geneve.c. > > Found by Sashiko. > > Fixes: 4cb47a8644cc ("tunnels: PMTU discovery support for directly bridged IP packets") > Signed-off-by: Eric Dumazet > Reviewed-by: Stefano Brivio > Link: https://patch.msgid.link/20260525203642.2389723-1-edumazet@google.com > Signed-off-by: Jakub Kicinski > (cherry picked from commit 7d9ef0cb271555d8cf39fefe6c981e1493b25ecf) > It doesn't apply. Please rebase > https://virtuozzo.atlassian.net/browse/VSTOR-139651 > Feature: fix ms/net > Signed-off-by: Eva Kurchatova > --- > drivers/net/vxlan/vxlan_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c > index 7c9d2450209a..700bee7e7733 100644 > --- a/drivers/net/vxlan/vxlan_core.c > +++ b/drivers/net/vxlan/vxlan_core.c > @@ -2554,7 +2554,7 @@ void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, > goto out_unlock; > } > > - tos = ip_tunnel_ecn_encap(tos, old_iph, skb); > + tos = ip_tunnel_ecn_encap(tos, ip_hdr(skb), skb); > ttl = ttl ? : ip4_dst_hoplimit(&rt->dst); > err = vxlan_build_skb(skb, ndst, sizeof(struct iphdr), > vni, md, flags, udp_sum); > @@ -2623,7 +2623,7 @@ void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, > goto out_unlock; > } > > - tos = ip_tunnel_ecn_encap(tos, old_iph, skb); > + tos = ip_tunnel_ecn_encap(tos, ip_hdr(skb), skb); > ttl = ttl ? : ip6_dst_hoplimit(ndst); > skb_scrub_packet(skb, xnet); > err = vxlan_build_skb(skb, ndst, sizeof(struct ipv6hdr), > -- > 2.55.0 > > _______________________________________________ > Devel mailing list > Devel@openvz.org > https://lists.openvz.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel