From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0C4C080067 for ; Tue, 22 Sep 2026 18:44:50 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68MIhZr0020246; Tue, 22 Sep 2026 21:43:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68MIhZr0020246 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="H3lm64Um" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68MIhQqI020224 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 22 Sep 2026 21:43:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68MIhQqI020224 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49e65f2f1baso656075e9.3 for ; Tue, 22 Sep 2026 11:43:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBykBqSg1+VLg+Oq/qtWknXeVS1Qn3xkVVbIba5VfeLM7LHof0AudIKhd2BCYjj0ZJV//n6GZQ==@openvz.org X-Gm-Message-State: AFuF++lhCEKhjj+xHBrB1FM8sLb+qdhTfiM4OQ9NH43ayy5OUhO2MM3D MmtoigHpxNYbk38QkUV/l8MMAhl1rEn2h3VJsMFoI8NfgBAHdxpq6GJ2juAiRJWiU2e8WknoVZ2 QGpC6xpKqqhKS06cS3OorQgVn3oglumA9oA2FkW+tlGMvXmq64nrRzQ== X-Gm-Gg: AYBFou2W2+4JylnIHNHn7LsM81tk1rhZ2hku9iIG6hQSCjp3Yuj9mJxaEnGmwwuQCvk eJ5U+ZOahnpzIeUgENHTH4r9mQzRHli86cQc9nqVYLGAFlK4Dajp9V5S8HzkMuqs0z2KnnLQYf/ Crhh4sAsmQ1XP/u12SBRJHksRgWf02HvW0LZbaMWaR6klDIgP48TvjVcjNP6lg5QSM1RFxzYMFT SyHEdKsFAoyty4KDQ/sdRPysLRw73iHns8Ts4o9YUcC1mvxQ+vXzQVU1++v5cQ9oSq2iytX35YA ipLxP27roVSoQ1Vp3tg4D8Gu6HdBh+OArUvp24+/Os+V/a2MkEnWeM7bMpt9qPfGAzP5OZiMSkg PcXhzVXZQRqySOizkMRdjJVkH9IHf X-Received: by 2002:a05:600c:a00a:b0:49e:6683:d23c with SMTP id 5b1f17b1804b1-49fdec989a1mr2431895e9.0.1790102606336; Tue, 22 Sep 2026 11:43:26 -0700 (PDT) X-Received: by 2002:a05:600c:a00a:b0:49e:6683:d23c with SMTP id 5b1f17b1804b1-49fdec989a1mr2431315e9.0.1790102605002; Tue, 22 Sep 2026 11:43:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790102604; cv=none; d=google.com; s=arc-20260327; b=LXtblnw1jPspUm7OfA4BR1zY/5KApJSzGvnFT2awp3Fc8pj/85uYU5g/mHoRIvhspL rsocLppSDkaucKVrRbWaXMFr+gYxt4pwEP1rtFf+wetXUqUJk19rJlbB5Ui2jXYRQGVA 9pgEqbCZNL4uXb+AkxuA+rVn9EtpP44p6q55T9/glbGtVwrt405br1Ox0cdXzm8Swqa7 jgVu8Wch9AWkFuSXfwAQ6I+MOM6C5WMqisbss4arlGtcLQdIVsUjulvMWvFZmNeizmqs NuZY2B1rqXB53g9JSjLA7Fe5wkhVDFBXfrhqzrK5I3Az3lO8wP2KQ79sYV3MX6y0cxpF V37Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=Ys+Xq5i33xhY8m0b+Yz+M6ejVi1zSN5ph/A+Hr1tenY=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=cDPCioes3vxCRB3Moxh+hnWEy4qBdejUsvadCb/JCbMMfrLuxkMA+lfYkffj4EEc+L YwIVxW6qnuhVExsA7pWwavlHAA51nqJF+14kxGIrV7TEp6xY2KlGRPZyb302lfkHffqB ljTZPagJ5WzPp4KEs78/UJ2WNGpVr6hlsGDMPWxbkL/MuU80GrJW9PjzHecvWOIVnBHs JTNC4MbYvaULgQxMKu2wpymw7SuJaZ+03skI5cyNpRJ42hAppsByjfv2eLqe/UzMHDB6 sgLanCB9l+1QLxmslCXfQ+yuCAL2Q+ckM0KyjQTW2M49cl8ys9x+DLkQNG7ENcg0NfAz uX4Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=H3lm64Um; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-49fde0e5720si9207545e9.2.2026.09.22.11.43.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 11:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=H3lm64Um; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=Ys+Xq5i33xhY8m0b+Yz+M6ejVi1zSN5ph/A+Hr1tenY=; b=H3lm64Um44GD bFez7ymocOEEUKGQphTSgJylYAWV8bXShu1qlhVdfXD2FjTEn2fBKn0gxsChnypWn4XRYkWalNL50 G28Jrgy2Mfil4AryDkH7UzP4/jHxAWBoFXIxMl7qF8MUJ5UxUHVrTd2nKViQfzOVERfZ696wrH+wj 0ASLxI07QruDFfNvf3roJCRXe+T3hFF3A8fDAaEZH5z9yZ8qWBGH9boXXlPuC9K00uYdbGs1NYqiM m+jtYeF7WHNZnNy31baLiE6UEcRNbx6MxcqnADZLc27ivfIHvEKKwOfRQXA6ePrSEHxeNGlPr8n7d Xh7cJzEwIytKjZ4sCMPcgQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x95Pk-00HWpg-2a; Tue, 22 Sep 2026 20:43:14 +0200 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20260831223631.1637488-2-eva.kurchatova@virtuozzo.com> References: <20260831223631.1637488-1-eva.kurchatova@virtuozzo.com> <20260831223631.1637488-2-eva.kurchatova@virtuozzo.com> Date: Tue, 22 Sep 2026 20:43:18 +0200 Message-Id: <179010259812.3049580.4865880168096064882.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1025; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=kcd/+fBtB8/Z4R+Jeo76f5soL1gcqtPfJx145xaU9Fw=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqssxLc7qCWudQek0qwCDWeIHM1o8mBc8plYHAA B8r8CLB2hSJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCarLMSwAKCRBRlgpH+WFc KmQEEACvaJbniZeg+YwEhPWdInHSfPJqcqcF+gLL2zMZastoI1oVcllIDTilImigEzvU9zqvtmg q/ECXhbjZJ1iopsBR6bwtL7GRY+d6wRKtdX2eWdIXBSPu3FiNbCPDCzJGa5nuvSBP4miXhpAfiM KF+NqpIFRchRuTQ4AY1BJ1zEX+ezEcdsWibZsOa8WHHenuL55g23Z67dUzQcQXCrkuqcI/a/lX4 2jQEF7i8VZzX+OiNtSQs8r430y0FX19XOgdWjG6zmVd3H8C6ZjjofMv/NeBzbuNS/wMGpdQJfpr Gl68vw+ZmfFg3gu8mc33q+5rEno8Cf/Pp03C06ChCd8xL6pyAJD2CS0XW0QTouuS8N5b0y3Xa0h ORfas/6DlWTgTsZ/0wmK6Z6lT9V8Nx3+HDnKTlMLjHKkuNsXGP/+VborXd8vMpj7N6DkJZf4mW2 cYlPsPCAHZvcjDbb3Rxu+MSOIqbDNpnFbG8mrffXp/JzKQnoRZW2DOCLi0Cb4F8jL6wrDiJx6tX 3MHaTztO4KDSI2/K6JzE4ZZfvaYxDHCRZrxPFWWcR39SVnj9jNT2RkG238oNmnDrGXGZggfMKWN YM4UB9qfVAMP2dJPbSMMYG5k3B0wxa1N6dNvINRWmPVdPa5gUxffv8CgJMvMYFQNMWr5dN8WqAC QWa1DOoy14W7+Xw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 2/3] selftests: cgroup: give the O_TMPFILE open in get_temp_fd() a mode X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > O_TMPFILE, like O_CREAT, needs the third argument. Without it glibc > refuses the call at compile time as soon as fortification is on: > > In function 'open', > inlined from 'get_temp_fd' at cgroup_util.c:24:9: > /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' > declared with attribute error: open with O_CREAT or O_TMPFILE in > second argument needs 3 arguments > > cgroup/Makefile builds with "-Wall -pthread" and the fortify checks > take effect only once the compiler optimises, so the cgroup target > builds. kvm includes ../cgroup/lib/libcgroup.mk and does > build with -O2, so the shared object fails there and takes the whole > kvm target with it. Building with -D_FORTIFY_SOURCE=3, as distributions > commonly do, therefore loses every kvm test rather than anything in > cgroup. > > Fixes: 844934d16dbc ("selftests/cgroup: move get_temp_fd() to the shared cgroup lib") commit id from old branch -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel