From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D823681050 for ; Thu, 29 Oct 2026 17:41:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69THefBw003274; Thu, 29 Oct 2026 20:40:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69THefBw003274 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ZIU2VOZ5" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69THebxU003260 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 20:40:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69THebxU003260 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48df5b058ddso1625066f8f.0 for ; Thu, 29 Oct 2026 10:40:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxZy8tvV8NQFiR97g/lgycmsnFvB9Sp8xSt2wV9rCQIjKDlcxg8SDyikSnjkBI1WVLkEAtmug==@openvz.org X-Gm-Message-State: AFq9FYJ3p/dnL1c/x/8nXANPTM6RUALw55BDBDL3FLBN1M+3OPHhNYXA mh62NF28SmvEl6YIx+aSKgSIK3TW64SGFrHYBkLRByTKv7TcZoWDIA1YyDYT2NDk8sXp+HelAR5 w1qKEXGfV+QPkVSpaOI4I4UbuGQkVyJIxX513ArEF5Z6JEZMo+stosg== X-Gm-Gg: AYBFou2TQ8CL5LgBa30tPfn74kToBOGNlMMSu4ywl45FUIUfmdu1logdFyRIKC+h2FP jWiON8UMPYa2Jy90e5guzaSLI/1tv5A+Xb/A0kNeVTezFCShFTbPN7tcP32fzndOHvy07qZJ283 B5jqC1Q0KFci4VmIV0qQZU5LGOMayabymqh1lFKiPQ1uecuqHHLeQ/S77HFnq50gCLsNgfvGH+i hatIfHk9gCODtfX1IccRTKmn+8cMkIbhAAIEHcuH1FD+xspOIHQ/ClnTGIIPwyiX1tYnZhbC0Pf ssM17R57LauIOW2NF1aMjrcxdFHqaehcZ8uMND/KG2rto5TXjrX5EBEKSlGiCs0LRTOZyuCJPaG NzLai8ba+mpUrffjPmg== X-Received: by 2002:a05:6000:402c:b0:48d:f39b:83de with SMTP id ffacd0b85a97d-48e6e2bdf87mr392667f8f.3.1793295637143; Thu, 29 Oct 2026 10:40:37 -0700 (PDT) X-Received: by 2002:a05:6000:402c:b0:48d:f39b:83de with SMTP id ffacd0b85a97d-48e6e2bdf87mr392588f8f.3.1793295636499; Thu, 29 Oct 2026 10:40:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793295636; cv=none; d=google.com; s=arc-20260327; b=g10ByA3RDX6bK2sArBPqXpul/Vbb490lucVfu5Mo6EqZNG6/7Xqm1WJXzsu1DARV3l /uDp0N9VLDvkRFeuuhxl/RYK3sx89HDF9ZF6Ie82kzF5SG1cTkMRfh90n0/VHZ9dYvAo NgqF2tiQTjVtpbMo5HCKx4B4hNVEIWc/yB8IcPNLI8Nz4WYBPLNhU1ebuiTOmcbZ8zl3 yag/PeHa5p9nLFQUbybs9Imy8cHgCg3V2tegTGPdoubmEDCO7TryNipSHVA+9d4748r3 BiGrTuinDH0H95a31XUpwMMrdwqV9rm9hHXssptRlbMpzDtI3v+QkGVcRwN7Gu3lSTx+ WIxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=385WQCZ6I7c7ooC/HdUe0k8fxYrFZgQrHvuIE/0bZkQ=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=iK5gGtWcln4H8bcJzukDnfZz/EJ9u8UizZdm0VfkOELuwefnuTDn05wyV5gB+CLtar Mg5FtUTMLFBQxrwCX0ZP2hgc56hJQ+aqM3gB663GL+wCNWtbAc4DYTemXOP7rRylpdwa TM0C3O8KZuHz4xeXZwLFdjiXhGO2ttPuzHmr0H5UZA8m6+J8Yb1Qx2gB+7UsyKFoPW4j ZgsOhOTx3/cPHVuczckizwi4VMTV0KX3WEBW+cPfUOcO8KifMkc4OM9E8ezsCp60Dss4 OqENT4vGWml6mCbNmFhGuWrtO/0go6sRKjyKpL4jkrbe6ZbDZ6BAVjfLvs+W8h07vcE8 k8sQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZIU2VOZ5; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e6df4f78esi591056f8f.313.2026.10.29.10.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 10:40:36 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZIU2VOZ5; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=385WQCZ6I7c7ooC/HdUe0k8fxYrFZgQrHvuIE/0bZkQ=; b=ZIU2VOZ5ufn9 i9K+CJGEl46feXr1Exu4wubQdha+0vKsH3MMoBWy0FLyXY6T/UoZWMjHQjqat19ln85G3pLfucbDP OsamapoE188Csodn3N7QN55nYYR/sgm/9G2XLKI7jbHukahf//0lpeaneWVAqkR/hyvZDzmyizlJg sWRGf4AVqMMtTwbieiiUZAjgJoJo8EzDjruyGoCXjMz/R/aD9FH3lQGbFLDBlu6YWr1mErfAIF6oN b//VEi4MOGG6jey0HKsSm5HX0uRzkidLWSLlnkJiGnJWQBKCuN5TaT6A/fOgK8Epjvt6coFUmwwlm Wx8sIi0XxBSKiPKq9y8coA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xMU3L-00BOpg-31; Thu, 29 Oct 2026 18:40:33 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261028123130.2828357-3-den@openvz.org> References: <20261028123130.2828357-1-den@openvz.org> <20261028123130.2828357-3-den@openvz.org> Date: Thu, 29 Oct 2026 18:40:32 +0100 Message-Id: <179329563266.1542126.14648562135482005330.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=YaqmID7FQYRgck6id1mRhh4+QopD7W/wfKRELKF+qxU=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq44UTODFay4H1R7VBSo6x6Iv/d3EaGdYOoXpaJ 64aHnAmF+yJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauOFEwAKCRBRlgpH+WFc Kn+LD/0ZZi9dEBbit2Sn6nFKTjrMEml/zjRYcxJDKtGPUl1T4iCY3isKQ7IuUwd/73IfWDtOVT4 Rcm+7mePGAJqZe3vKEJQHTrtB04AsbNTdFMjsoV7YdgJVTYLV4+9vllGBCk5bos9VCIN5XUDFCA VSPDrcQdSE+UjLdfkiGtPeEIGz5e8NwtmIiH+jELC3cIexm/jUNcUkjpkcXjWz4P9sOeiCTplGc 9eTwzn/J1Yn5NeIpEfMXgnAlc97HPYbri7OMlHDIeWihhktGqEGX1MPgbr7Xp6CwYKandmHQCBE mWql2cIat2JrwLLSWrHpO1qmjZ1L7Mmz5zmsRvot/O7PiDQ552odnTPMpimnTl6/gnUjn93GbuN LvxCM+TQ5lG0nMTSgOO8pRk1NePJYoDyzSA1x5XxomF/ubyJ7Jm4duqljvRS4Q3+V88thZEIPyN woycsZ5yhK76FzR1WBBfgOK3Tjsyncx5ZwuNJRm53R8pH0jQA3NBYXjaMg7+P02BlOxQ3f15pBF EL/hGoQdSq+3lg0TGCyJtkcWUueik90c1F7CbQnNU63cfmOl4NtFaKBTTHF9y7zJB/oMNPGsl+E 8ni7x1JTy8GAW9mnuM7HKue2Ipox97s9F9X2GojaPHUxhmKnqhUn306ZUvgwQZnK2NKD/3ey1Y7 p+cvAF0eJ3C75hQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/2] dm-zero-rq: drop flushes, discards and write zeroes instead of failing them X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/28/26 13:31, Denis V. Lunev wrote: > dm-zero-rq: drop flushes, discards and write zeroes instead of failing them Will commit, with three edits to the message only, the code is fine. 1. Subject: "write zeroes" dropped, so dm-zero-rq: complete flushes and discards instead of failing them No table in our tree sets num_write_zeroes_bios (ploop, qcow2, error, zero-rq), so max_write_zeroes_sectors is 0 everywhere and submit_bio_noacct() rejects such a bio before a request exists. The case label is harmless, but no write zeroes request can be queued against a previous table. The old subject was also 75 characters. > table swap therefore fail, a flush with an error returned to the > syncing task and a discard with an I/O error in the log: 2. sync(2) returns void, the error reaches fsync()/syncfs() and the jbd2 commit, which aborts the journal. And a killed flush leaves an I/O error line in the log too, for the PREFLUSH request that waited on it (blk_flush_complete_seq() -> blk_mq_end_request()). So: "a flush with an error returned to fsync and to the journal commit, and both with an I/O error in the log". > num_discard_bios from the constructor: it only matters to bio-based > targets and to targets that pass discards through to a device, and > zero-rq is neither, so "silently drop discards" above it never held. 3. dm_table_supports_discards() also honours a target that sets discards_supported without any device, which is what error, ploop, qcow2 and mainline dm-zero do. The assignment was dead because zero-rq never set discards_supported, not because it is request-based. I will say that instead. Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel