From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0CE5C8017D for ; Tue, 3 Nov 2026 10:12:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3ABAcH003889; Tue, 3 Nov 2026 13:11:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3ABAcH003889 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="s/7QyXUs" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3AB8I7003873 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 13:11:09 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3AB8I7003873 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso36058595e9.2 for ; Tue, 03 Nov 2026 02:11:09 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzYJ2Cimgi12XfcwV7+YcaAejsi2EIBxtDWPOAv0pJXc7Bz5IiJ81v/XOXbQ94vqLrKLfFofQ==@openvz.org X-Gm-Message-State: APuU4Z+Ab0V8qKYjHsk9XfijvJLweCcuaE1SOOoDGGMSoc/x2N4gRlP7 anoWC/i7uMTWcp7LF1q0xOJo0CmlPlRHW/P9PmXwfWoPWWXNidKbtYS1dt/gKyjJ3QjsxZXg1vD MIuDHa83+stkjo1A2lE5S1XXcI/z+j7r7Ft+0KdZOIOfHoMjZsviiHQ== X-Gm-Gg: AYBFou0dQobZpaiQb6qRauhVYdL7Qlwa0OGr4SrHMUIwmN39yCxxcjfuL11EzyeB5Dh d8r6AgnZEeui3VGGUK8CkfCssNTM5hibDlOM6XkwxjwIXY9yysPAMYeR89gdjs84DvNz3UixKXx uCGjUFZLIg/eYCdNyVTXMFZvNQor4JmBn/XZhzG1pQoRtZIOxLYVQOZcQwdrgRrQYgbnueelbBv mFiwTW/dIjvEz5vAHa45mFep/Ad0drOn0VZfUJVJHybiFaGzvi24rC21HZk42ffwGub9j//wnVb C7d+HCv10yXi7Yi1CeGeLJUkcqQqkyqy3LjFRrWHQcHQVUU7djAQaCnTA0ItU8ng8qk5LUda9mj V7DDuTUKHepYwDpo6 X-Received: by 2002:a05:600c:1d16:b0:4a1:fa33:441a with SMTP id 5b1f17b1804b1-4ac151a8fd2mr290439345e9.2.1793700668685; Tue, 03 Nov 2026 02:11:08 -0800 (PST) X-Received: by 2002:a05:600c:1d16:b0:4a1:fa33:441a with SMTP id 5b1f17b1804b1-4ac151a8fd2mr290438675e9.2.1793700668088; Tue, 03 Nov 2026 02:11:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793700668; cv=none; d=google.com; s=arc-20260327; b=o16Fkog3STngGVWwv5l2mYVzjpZnyDEbjR/bdW2RE4kz/tLrZNWU/yCsDconyRrxXz LXoYkIwMDXwsJWH30227IijS//Jv7X/uhl0PbX+0C1enOa96UM4vZ86cBJlhNoMn2CVP s3xs5esxwFDjr7pbV330PawtgaHziavzTEg9z5UstNwTzlbltlJwuH2w5mlQjZLzBR9A H0n6eT/P0frLIZo+YzE8hSffv4Co9VF4uH15m4xaAMehLs4ivZbHqUMlaoAkDig5xKgZ j1PUvFkMliq4ds1fipSm1FpBv75U0OGPJYnOny/vgh0w3cKR/EvB0g4ZBdrS86dLZ2c8 ApQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=/bLTv5qpsXUDibSD90XWL+23+nPeWsHImBghTFrp9Xw=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=bqJFmjGt9oxgcn/mOYtP4YP1EJYIxofliPJ2bclhqVhlJ5tlmvJY4t/YSkq5dX7p2Q wpGxF0IlL+vTV52qVcAXRGFL6VM0RIPMzrcsvp79DkhF31iXwOPgPqo9vhRraFiH1xmX OfgqVUTpsS+tPwTOdbrnukopyNxZzWadVk2LszBpqCI/xbw7RGQJ9RYmQbAuCJLUl/kZ aGmyw4P1ms/t8TGY92a8o1p/zjXSiCr23c1oM/xLoo5Hth/TOa/bIhzoosJT0LoqIBy2 kMx6KNW/k7/u6pRTR6af7i8C0Rv5B98zMvI2YYMpFIvrsOFsukeLrgqv5reMVp+m5D7w Qa6g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="s/7QyXUs"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71baf55bsi32336381f8f.185.2026.11.03.02.11.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 02:11:08 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="s/7QyXUs"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=/bLTv5qpsXUDibSD90XWL+23+nPeWsHImBghTFrp9Xw=; b=s/7QyXUso1uz 9CTCtflUd4r6rKUisBNxvCXDULFDBro9SueoAN+Nh1DBK2swNYhf01kjq/Lx2GfGfaXkLRwAiIep4 gEp4QIeKikrPIKsCyBAhSuEk63+GJ36YKbV6VOQiHZduaREawg8X0yHiVceqLlpvWJJEPKr+owoX6 AGAsGqFB2prlAtWQu0692q7F97Zcws74ZaqogPc7Xiau0TJZ3FC7Ok7JqGqK7TKu+ydGPEMYaEWi8 MHWYcRwsbSjohc7GMAaqhX+9Xcz8Wrg/6smQ9D93Fm+sJErb5wm2QiincBqfHwA6ZaQtD9VjZAjIw Wd0wgoY7wgizGgX1NpVvUw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOBQ0-00BKVK-2P; Tue, 03 Nov 2026 11:10:58 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261103080358.723186-2-andrey.zhadchenko@virtuozzo.com> References: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> <20261103080358.723186-2-andrey.zhadchenko@virtuozzo.com> Date: Tue, 03 Nov 2026 11:11:03 +0100 Message-Id: <179370066311.2382033.12736627067376135427.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1774; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=vXOUPEq3wJzJSMJ5v6xEoHqbkMDdj+j9k+FMh0XpFRM=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6bM4ycHJqQNW0pakpRS4CmrgRz1RXEVvqK474 N+KImvZfEOJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaumzOAAKCRBRlgpH+WFc Kq9zD/4+055R6Y5ZZob/ycAqWpnrkLJca6Ho7R4zHQDzaZQnCl3/aP+tqzUTWr1FC8vR0zEl+tR IdBmNH0hkFLUUP9vc3V6z6y+tkCW6+NE/qs2KkVhhzrFgXHaq2kRyURuQhiCNA13XBg5qf9KPEp V8OCNkOT8eGlGJ7ls1px+FHevgGh5Bto1gQTtum4VHZr4H4kCSNR/RutzvLvCGnz73k1FyIN1Ru zrZfppGHgNFnv2mYjnzSZUyKNlibyQYG7dkT52jrswwlmgA6t8qG3xueuO9SMRE1ptYvaVXGDGs Qz+78BhndEMHKf31/jcCElgjwZHjt24g98VvbAcwUcecMzVXtxoTMC6DGH3FHb26mtuAXzHMyRQ vY+ZAD+uy4KeWKBi7mfU0E46/mm4hHiuFBQHZlaZdil0z+Pgctz5duST3bWvC9D1xHdW0jwf5/g yX1wkoQ0JgA/gaH/MVpGvU8293c93lENfNBEpTKR5/FkKzrpf4NJa2zQQOBgP8Htwqr1VNZIfwV Tf8Z3VRjYVDpdkyC6YenzeQH65OGT8orqMiB5aKKqIokESo2Nq/CtFxvMFVLAcFobWjEOqEaEfm CbTNCZ5RPCBNWI783kGCnqfZmjwhyfCC/zdFwtmcSHE8WT2YNoF5TmgHUJWetPeX9vgCrnTlTwc IRTulRxFhSjtbXQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v4 1/6] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/3/26 11:03, Andrey Zhadchenko wrote: > Allocate pool and htable after lock, waitqueue and deadline > timer init so we are sure that pb_destroy() can be called > from anywhere. Otherwise we risk timer_delete_sync_try on > zeroed timer struct (currently luckily fine). Hi Andrey, The code change is fine. On the message: - "from anywhere" is broader than the patch: it makes pb_destroy() safe on every error path of pb_ctr(). - "luckily fine" holds for release kernels only. Our debug config has CONFIG_DEBUG_OBJECTS_TIMERS=y, and there debug_assert_init() reports the zeroed timer with an ODEBUG warning. > + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, > + pbio_cache); > + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, > + sizeof(struct hlist_head), > + GFP_KERNEL); > + if (!pb->pbio_pool || !pb->pending_htable) > + goto err; Not introduced here, but one more error path of the same function is broken. Further down: ret = dm_get_device(ti, argv[1], dm_table_get_mode(ti->table), &pb->origin_dev); ... pb->wq = alloc_ordered_workqueue("dm-" DM_MSG_PREFIX, WQ_MEM_RECLAIM); if (!pb->wq) { ti->error = "could not create workqueue for metadata object"; goto err; } ret is still 0 from dm_get_device(), so a failed alloc_ordered_workqueue() frees pb and pb_ctr() returns success. The table keeps ti->private pointing to freed memory, and pb_dtr() destroys it a second time. It dates back to 62e07487348e ("dm: Add push backup driver"). Could you set ret = -ENOMEM there, in this patch or a separate one? With the message adjusted: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel