From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 98CB380E7E for ; Tue, 3 Nov 2026 10:12:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3ABbnY003944; Tue, 3 Nov 2026 13:11:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3ABbnY003944 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="u26KtEYO" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3ABAmN003886 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 13:11:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3ABAmN003886 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a1e489f97fso48533205e9.0 for ; Tue, 03 Nov 2026 02:11:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvByz340/DWstarxdCBSbmR0spr79eJVB8MSHEXPtjUvBn48uhn52VP4WPqNU7USEzYDqlwC0Wg==@openvz.org X-Gm-Message-State: APuU4Z//xhdL3H8RTyOajHr/xudFrCwoDFU9A4RUQZMREpP+4Gf4NnGY sMHXskmERXxyJ2Sc+WXR7+6n/OO5JzTOR+iNzOi9pMQQLghnVvcHr72HlMbxKJixOgP5eNVLPqZ OE3M3Xf5QpM9VCajvDKhF3OxClN4aHNxbdCOQnNf4KZyQoNOZNhn0gQ== X-Gm-Gg: AYBFou0+Goi3yhEyjvHup2KAgp9YrPuIBBbOLFvZ5gW5899P+t/B7x/TYc0ooHG7Fj+ J6rj8vw0VfzgfPnCU/3Lf/KV431HJRkDXfLMXzhfnSNOpweD5vw2Nb6OOjjUIiGUmaGnYg15R40 JXBeEGvf0dNMl/kRGOA1WqrgkhdOKv6i8O7aRxRhdwcpfN5+MtwoymVUJZcgH5Dr43QOq2CJVW/ X9r7K5TQROH0+Nux1R0aQdir3aTDBgEaUGt3+zLqtDwjjOIFDpnkar1tKvu0sQ1/xwi/6fuju/e XnKQk69j9JB5ZXF/lQ8Fs0L8DBvo/hy7sP+KKAdlqa83sTLf0k4gp95yq5E9dMuTuqNOu4A7qXO n7mJK7wR7FgiLkHeb X-Received: by 2002:a05:600c:8581:b0:4af:29b9:32d0 with SMTP id 5b1f17b1804b1-4af29b933ddmr151832435e9.32.1793700670189; Tue, 03 Nov 2026 02:11:10 -0800 (PST) X-Received: by 2002:a05:600c:8581:b0:4af:29b9:32d0 with SMTP id 5b1f17b1804b1-4af29b933ddmr151832055e9.32.1793700669525; Tue, 03 Nov 2026 02:11:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793700669; cv=none; d=google.com; s=arc-20260327; b=pswIhj9N40NEI+e1WnHiembkBQyYvy2fNeczMbYOKrxK+2qoxEIrE7hukKK/e1vJkW 7IUJyoWYKpuGnbjRSOVly4CdYo5PoFUBA5O8FF0fZHwScYcti/O6d37OrKTr7MQ/ThQR XPrvhHzdtAsHRt1HIvGF1vwPkFls+MBwtmmkTbFz7KEBkc4bcvpcgxo7iWc/EO6xJ3rC n/zghHFIcn0bVRB4cPvlwXWmyp1xPPUCDdktLYdYdhCfrPLy6fC2CKtwA9ddOid1hnP/ vD6bGCf6Ow/YjEWc09rVndawQg+5L0J8YEgLeiVJ02PEk1diZgYE7VyBfzTyt4ZdeRdj 9PmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=FzAZA/xKk3zFje8nnZ/FxHpgSbZQ3Wb9jjCir0ixbME=; fh=NNIHAR0oQq9xcHtG6fvuNrouibWQy9PtHjAIRR7/XzE=; b=gb0zPORVY2T4guxmMwbj6pgvn99yXsIMzafYio0rnfNjAD7NMKUIDl51nCRXyHFYCy kRWBk1+YpHxrifosbj9+tZdmjy80GMC9snuFPeqZ8Mnk1z5mDqM15zw/VQxY9BI5ZUEP cyrWktK0kOTk+w89PwG8TD7eyOvKyGyBZisjhR92KkSx3Zsc3cEuRfWzqYyWMUmpSNTH S+l6uCLtD6/uvgcrxSgN8ucckPSUNM8y73k9ZoWo5SUrrEpk4nvqZnjZHCtWC+toFAyw 45tj+E+Ky9v+GfUXQSAbcnC6VnCn86qfeymE7Gy4tS9TkQjaB17L9bEG8dcfoPwsqln9 HlRQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=u26KtEYO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4abeb871784si25046335e9.1.2026.11.03.02.11.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 02:11:09 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=u26KtEYO; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=FzAZA/xKk3zFje8nnZ/FxHpgSbZQ3Wb9jjCir0ixbME=; b=u26KtEYO2+Yy Pf98C1GZuv/ajF9/B8GgMeO3DgC8OkdHJNNnbZszYeWyO1fx3BJM8+AXqTfIkq6EZdW6QDqTE6T3O 8l1ngaz4E0Tnw+TleDxt0N+kXiOWF/F3Tat6LbwhLUIxtGCB7vMohF+EVVqbPvw5wpz70LiLATFsZ 0knbpxY0nMnFaAkFCqfX2LvE1VTL8c6s7JLAb1BoDQAlxPBYDEMTVlM+H6zAfDcnJI1AfaOWTr1NR nFxms+TrPTCHnlWzlwTQgoAxZRZNYZ9y/YPIaxQLkbwco1MI2xBJ0ayrqXQ9PgHgVQFvOmq2f+wM+ QBLNGcptPhNdUB5GS1r4yw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOBQ1-00BKVK-38; Tue, 03 Nov 2026 11:10:59 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261103080358.723186-5-andrey.zhadchenko@virtuozzo.com> References: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> <20261103080358.723186-5-andrey.zhadchenko@virtuozzo.com> Date: Tue, 03 Nov 2026 11:11:03 +0100 Message-Id: <179370066312.2382033.7104228156715947118.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1208; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=S3zb8xKdRaCmmzv2SiZZZaJwT4wDaUjs6lgtZbs2PlM=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6bM5N5QR/2870kND6sl2A7DbBT52VXO45YzQR omuEmgVGnOJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaumzOQAKCRBRlgpH+WFc KlCJD/4z9bCaoJnyBUADDUkISpTnxEx9a0JZPRia5OgSizzf3q8I6cHxM8vilaKYy1wwC/71yU1 UMdpNd1/0Jgsv6oZr6mFEa/fUzxnRLj6+je+QUt7K0EfGc0ajhrwwuRQ3G0E1VL1x+iRlYnmcc3 R+Cs52trxRIaFZCe9r0EbwFJKBdvR8Y6mRDf7qIH4achWMke0n4+BEBQ4mwHWQLve4I37F222Zu e39w14WXSJC5f52mSep85264zPWxyylbZpTE7Ny9PNC7Uahhtp+tM9sgT0cc+Y72wtkeKy3Due1 b4KBGhY+gajL1NnzZsTyawnehpAnQfnYQ8rn1zSProYKA9t82yseZJfvn4FZs5EaNo1oPKc+Tye aCZrt5d1Wn8j0AWNqVNQkui+h0amxQGdMftnO9u02TCaYb8WobKI6HlcjtAXvpKSygiFNevkRPo nS4JoqPm9dJOqE+kB+EwI9fsgSbdeHv58R5/FdadblpkpwpAuDGrp5Gy13hZt/ap6zNVrej8gWV ScZEc4qCqrWt1RiRW9paMo5FojLr70NMFjnUlUj74tABoJFRYFfXhr+lsKq8bqE8vIJuc5T0bz4 3cGyLWUw/6W83o5Z6J0N3LHkFYYKwllfaA+MBAPGCTlimbLhExmLLLWylCMKxJenrYIasaN0rkB YvM8rAHg/hAaiPA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v4 4/6] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/3/26 11:03, Andrey Zhadchenko wrote: > mod_timer() takes an absolute jiffies value, but both callers pass a > relative one. After about 5 min uptime this causes the timer to fire > and re-arm on every tick. This has not exploded because we still have > checked pb->deadline_jiffies each time. Hi Andrey, The fix is right, the "5 min" is not. INITIAL_JIFFIES is (unsigned long)(unsigned int)(-300*HZ): on 64-bit jiffies start at about 2^32 - 300*HZ, and after 5 minutes only the low 32 bits wrap, the unsigned long keeps growing. The relative values here are at most 5h*HZ, below the start value, so they are in the past from boot, and the timer fires and re-arms on every tick whenever a write is delayed. The late first expiry before the wrap exists on 32-bit only. Maybe: mod_timer() takes an absolute jiffies value, but both callers pass a relative one, which is always in the past. The timer fires and re-arms on every tick while a write is delayed. It has worked so far because pb_timer_func() checks pb->deadline_jiffies each time. With that: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel