From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 720998017D for ; Tue, 3 Nov 2026 17:09:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3H8A60009149; Tue, 3 Nov 2026 20:08:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3H8A60009149 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="SqKWuBbI" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3H87G6009145 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:08:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3H87G6009145 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e0c896d05so3760001f8f.1 for ; Tue, 03 Nov 2026 09:08:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBywA5tF3MephNngDZkCxBtmqi6nb7e4M5wnD3OrvtwqbZ/BMEXMVHCaHOB1hgkDszNBMH6oJw==@openvz.org X-Gm-Message-State: APuU4Z9pwr2pUvsEk1YQidngjAkH45dyYTwcsGspbgW0wkLseyHbEEap iC6NeVvpFzBXWvDx+pxGT5Ks294Lky3I5nY2I908hUeHHPiVV7gZK5/GLR2DP51WXa4HNQOP45U HO7CbSjuzCl8MQrhI5xXjM1Zcav4tKgExjLQffX9EN+70x2KWMEeFgA== X-Gm-Gg: AYBFou1I5GfCokr/dR35FGFuTc8SPoLeCw96utihivJtVLzNdx5PzDgsmJyEoYlNiMd BFmT0npnqqsA9xgudUw85nB53BaDdoD/Nrkp6Cjw/HsG4o7Ks77oZioKDfo/bU9fKhE/UsL6PVB rzqzq90qVPHQGnZ/RVCBgwtJPlFpH0xN619WvK2XZ5AiN9rcvMtpm/GJ2UO8CR0zise4bBKBOOi rjxlqayGO1YeaQ3mU8xrq6AEBs4aago6KnC1U1u0kFQ3MPmPIBXWevSVNY0lnRySxbgEH41a2rb epIizl6syVGDbr/c1nThjVhGJkQ1nI6WAeqqffHfeSvBVbpsH7tyYYzss6ZInOG0d1O0XaxOi7Q V4wHzToG8Z0tSSh73ew== X-Received: by 2002:a05:6000:2dc5:b0:48d:ef0e:b791 with SMTP id ffacd0b85a97d-48e6e52c720mr30756130f8f.54.1793725687204; Tue, 03 Nov 2026 09:08:07 -0800 (PST) X-Received: by 2002:a05:6000:2dc5:b0:48d:ef0e:b791 with SMTP id ffacd0b85a97d-48e6e52c720mr30756062f8f.54.1793725686642; Tue, 03 Nov 2026 09:08:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793725686; cv=none; d=google.com; s=arc-20260327; b=ngFjOukZausFP6xZ4+7xYA15RSIwT8DGLwYFZN+jv9Cv2Af5Fo6yv9IIc8ILHe+5yw Fbc8G4FCX0cP5FLLHYZjCIWDvcz0CcEHrxbeH/SrRAu/TLoXxickf7vLz//8amZQ8kr9 irRirquCCtIvSnqtWdE/FBZFm2S99T7Fc2myknReGwCo3oTY3kslmf1iBiRVnsGMa7tR yojsruGVhQBl5gsIBZiDoKIYHPZWgd7lE0mpx6EOWrP31Gqxoymj86UkfuCZasVV1ANw Lih8xqEwjgkqecHVQjaLnXXPPY6BNjP/HZPQfPdGtKRp9b5wohLLMWz9jcWh15VZUh/n zCmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=kUXhYkHCHh/adjg8L30kxQx/jgMWGr2w3t9RMK5q5ik=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=mLW//qUKxHS7BU10WgfaijrL378vioy1kdx5EfiQpOaBQf6bnx2JRSOlqyWlNir9BQ eRiL6BA2sldNWUymjeAzJQQV58tqBVtCjU3quU13qOc+Yl+qiqLzRrgwnyF2SrxWexYQ r4/ZVk780uwjvQEsCzqMlWGOaxcHcBrcWci2YnQQKl4A35Tj6K8Q2aFd2ezo+QsuGk9T WqLmU9OPyZiRmIA7RbhbHyutzE+EVcX6uYyCyPY8GGTOjk5MX06XZLvmo16s3f7N4+8K 3qylXrAGsuULP3jW1HcodVBzvT911iCZ4snjFb3AasauMCHx9cFEMtY6pgUaZBxPcSkg a0Qw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SqKWuBbI; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71a55647si25072958f8f.38.2026.11.03.09.08.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:08:06 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SqKWuBbI; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=kUXhYkHCHh/adjg8L30kxQx/jgMWGr2w3t9RMK5q5ik=; b=SqKWuBbIjU0z hd8kBlbWelsAW5jA1tdo66Fm1u+K9T8szKfbRxtcaj8wddaUzgPiKSB+qCCePRdz9a23R3JY36Qjo WqsBop9RrlTVQ3BBfNpToG/dCF9ZLH8qeb2/EYPmU6uOn62XIB+iMQPjozAvuuFi94ggwePMA/Jf8 A6KP6r7iZsQRs7cj0ypTZ0DagTT4IjXwMnO1Xhtc9swEgQy6jP1h0K6y35kyHGnWcmKkfUnbsl+qC WdkpTs7zmEj3D9MMdpSVcRveo8pjhXs/6jeN28kL2MfZPPE161WkxUpKvgk/XNUsoVlAdSSR8YsEc r01w4VU9QgENY7Qssy6H4g==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOHvW-003s5O-25; Tue, 03 Nov 2026 18:07:56 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261029110554.3315693-1-alexander.ivanov@virtuozzo.com> References: <20261029110554.3315693-1-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:08:03 +0100 Message-Id: <179372568398.2524654.7562922233831913007.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1942; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=2yJ80mU36G5S4/n7otsi2YyETtc2rWUvu36H6DU7qNM=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6hT1gSV+w70bI0DPUhaPqtwSXWOTTDUvt3gwd RuOQum9TwCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoU9QAKCRBRlgpH+WFc KtR4EAC5QpiWhp990I/j1VMk5oJpz/IOMlDRyidRH+n4C1ZeQbHhDFEi31JFot0HR2RuXSVZM4a fvA68pCWIbqmO6ajjjXCFvj/pwfiD9UObkbsyeiNlGDSBoxpwbU0zBDiRARFWRg/CvciU2n1s1h hrdsFWDvVYvbmD0HCUWMmAs4+kgYQRZGUFfjFJfJDj3sUB18X4Vcz27hpFdFIMvwooWUifLPACZ 8g0r/MWaNIj0ESNSrKXS+ik1+D8wewy2iJ5F2acLgUUbvYNiMzloXu+5KRUqJ0NJftII+R80gXH P7eBAw7KWAeDMDlqMyrZ9fKpC1dPr0o/lUC+mtiIgkDM47kzfFcToK5IH7YpiFC+USMvGhyk6uw y69LZCewwvAZ7wvEjEQ2SsDS3q0jZJEcST6I6lFtGau3zs1WuxCOsU35sSpyhanhhSiKR81iReI l7wzOGE50xNUN+ktEQYbbWpCVrHEBh+0kQ7Bxym+LqjRo6mqNIpmgk2eG6ctKnFTznG1MDLt/Xy GownnIrboCG6Lpky6WmmDHB7EeT4TT241yAQw99pA4GIt07ZussUhn491PNzhcNrF6pGXxVFZMX q7G05MqLzpTkUuQ9liBA9GXFYYvPGeiW2faC2GZ18mIjyG9vWHXVQBuoBYP59jcnJbB3Wa7pmKB CzlcBg6djr8F3hg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] drivers/vhost/blk: add support for worker ioctls X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On 10/29/26 12:05, Alexander Ivanov wrote: > + case VHOST_NEW_WORKER: > + case VHOST_FREE_WORKER: > + case VHOST_ATTACH_VRING_WORKER: > + case VHOST_GET_VRING_WORKER: > + mutex_lock(&blk->dev.mutex); > + ret = vhost_worker_ioctl(&blk->dev, ioctl, argp); > + mutex_unlock(&blk->dev.mutex); > + return ret; - Put the VHOST_SET_NWORKERS revert (your v1 1/2) in front of this patch again, as one series. - Fix the stranded-completion hang Sashiko found before this patch, in the same series. - Say in the message that VHOST_SET_FORK_FROM_OWNER is needed before every VHOST_SET_OWNER. VHOST_SET_NWORKERS (1491588e71daf) is still in the tree. Its workers are written straight into vq->worker, and their attachment_cnt stays 0. So VHOST_FREE_WORKER frees a worker that a vq still uses, and the next kick or completion writes into freed memory. Before this patch the worker ioctls were not reachable in our kernel at all, CONFIG_VHOST_SCSI is off. And our qemu (hci-dev) still calls VHOST_SET_NWORKERS. In v1 the revert in 1/2 closed this hole, and it got lost in the resend. On the hang: the code path is old, but nobody runs vhost-blk in task mode today, and in kthread mode a kill does not clear vq->worker. This patch makes task mode the required setup, and killing a qemu with I/O in flight is routine, so the fix has to land first, not later. Mainline did the same for vhost-scsi. > VHOST_NEW_WORKER needs the device in vhost_task mode, so userspace has > to issue VHOST_SET_FORK_FROM_OWNER with VHOST_FORK_OWNER_TASK before > VHOST_SET_OWNER: our fork_from_owner_default is kthread. VHOST_RESET_OWNER puts fork_owner back to the default, and qemu resets the owner on every device reset, so this is needed before every VHOST_SET_OWNER, not only the first one. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel