From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 74D888017D for ; Tue, 3 Nov 2026 17:52:23 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HpABe009771; Tue, 3 Nov 2026 20:51:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HpABe009771 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="OsglweXW" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3Hou8G009720 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3Hou8G009720 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4ae2756fa7aso24440005e9.0 for ; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwCb8LraDwCSscgy7p4uG7DeQWPRZINLxiWE6mc7TMk9iCKVXvOUXK5KvcqVC8u3A3EF+MHgg==@openvz.org X-Gm-Message-State: APuU4Z+DPPO5b+NfFiyOw2JVWqTnJMG3hDSOvmEuC+OWqbUS0/3qdYBd QNFN63PLukQ+68Kb4nzsiD/J0Xuf5BIt8O5Vb5j0rWAVJ/dRFFNWvExyQfPTneRUsolvuieU6wa g8wUNuFVgjWY+OTBwPV3YjX+oXCiRBf/oxSAoLZvuLQqclfz+zH6Gxw== X-Gm-Gg: AYBFou1By3XBxSn+dXsQZLovPJH2QMSHkSrK1PDAlfaRZLGsYfXkLhPM6nrOZjjpTem 0AAG7R+Ots92+9JNN73Xy1eCk+lGCHRKg4DkGWuQVAsC14ccAE5U605jhXBjut1g6Pqy6kCOOWW 3ECZePfMKPCP3x5KwCLsZRKvH4aST5ZnRmT4zoZiwliK0iMhmbOiczIBxd9KT9GMstD+Kvq7x1L b5UZYJl6VfUq3iGYWDi4LzSPmdskMDRPjE7dE8q0RQYx3OjDcIx/rGY2wqYar3T7c1JXkeE9S9p mT+qY3kTnA4O/SanXr117QXB+8lrbXqRgJxbLyF4f+b5uQE4j7vLLFK3tfSPJibSZkridy8YH42 aPWwcz5aLVuCZs/IySw== X-Received: by 2002:a05:600c:4e02:b0:4a3:59c9:a758 with SMTP id 5b1f17b1804b1-4ac19705e02mr299961765e9.32.1793728256188; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Received: by 2002:a05:600c:4e02:b0:4a3:59c9:a758 with SMTP id 5b1f17b1804b1-4ac19705e02mr299961265e9.32.1793728255676; Tue, 03 Nov 2026 09:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728255; cv=none; d=google.com; s=arc-20260327; b=eCKAHZIl4ZHWq+mU8UNS3EpBtyu0lV1jOK7uIK2a2toiGxQXlvrMc6nGibHPqn9pJz NTW+v+3OBAs6z9DvgxFlQOT7uasRuFmG9PLR2aHC2PNRc74lH8miAVzav3xclka1NVh0 RVkDlmo9wNpRX0FcWTuD9z4KgONkn7wzmgTNgOeJv2SgkgQD6odUX4/l5hIw06DGnhqK Uy7dGE6dSYv+G1CiXUwaKNPQn7FOKydCUumwXSUOt0XuBUMtpfMSWNbg/qN75CZ3dUJ0 8Nhrs/LxNd6vH2W9eGh2qu8VYX7u0U3OlNu7UxQ9J+Rmr3QV04fjC3QkQoVQ0IdCubmY HRqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=u7TGnmQjgG8ViQbaDqrYKp1fSYRMw41b0ZOB5Zq1Y/c=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=r/qPGzEDd2VGIgjq7nDx3Xm4wN3or9VkChp0f6JXl0rl6g0sATpr017/wvfAZo1fPh sFHuocaAW7qJatniIHLKRYDP+6u5ErFPdEH5UqUdf0eCdMlfjfY/uT+zBYrqenHwSvU9 OIKJ+itAb+HEHFvhu4BFcstDhZcG9eLaK6G79XeVyOKECFElc4H2I+ejwu1PB5zS9ybO ycUnlYVeuEY9UM7k5ROtRZ+h2ulQAffXaExZcrUh3/LOAlpVVLgZ91DTClj7PzLtjDAk SY9CsSm3l3Ba64HyFt7OFzVmfHyF9HGw1FoplqMbcKRz45xYbFxKn6Y+OR2FE/D6Q5hB Jntw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OsglweXW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e7a1d9da0si19470308f8f.69.2026.11.03.09.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:55 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OsglweXW; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=u7TGnmQjgG8ViQbaDqrYKp1fSYRMw41b0ZOB5Zq1Y/c=; b=OsglweXWenbF t2qOwyAnOd37wpLz5cy+SWMEEtjvBuxKJlu+Qpzd4iSZxojl2vxoP8AzGlm6CSp6luK+vSB1trJUi kykjnB+EAU5a8hjxB7WZJR8jHrRVkwNneRhCkx90qyv3KUC9zeuyeHafAaMfs395UhoYPhUx0RgkJ svbmdaqKnVUqz5ymF5EAidUeR6xPlXYYZ/LY7JN3YGVnP+ury6T9pOQs1BkZH/sckYIzCL5sANsg8 LG5LydbvcflNFHnE2oTYeqb3OghYmpAdU2l8RmK2sVLPOxWACkC3gZH4vBDZcjeEmUH3xdKqt3WQO w/Bx+bIXmlAiBSIsEhbIcg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIax-004r4V-2k; Tue, 03 Nov 2026 18:50:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-9-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-9-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824968.2555502.13251629144407705075.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=662; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=J/L34KGaJs/Ks/AfwmcsGeAxURCz331ReIOdHvWHU9c=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6h79wxAdaVUaxmK1UKe4ytAZJ2vzWXaoltxzl 81CBKAY/9GJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoe/QAKCRBRlgpH+WFc KhktEACdsvT/4c8AatUD5QiW1LHQMrbOTRHyyOuABfNlqFZXbgPCveFmVtKaiVsgbvb7GBeaJiO HZ67fDlyFw+vfm+ne55qwMyaVCNz7MVJ1hgn618kolFIIDq4b5asMdy9osttKwq01tGbb3/NMUe LVKNGmKZ1m9gR2mKSPi5LjvQ+ijFaJTb+N+BBmsYq3BPsq5iMYAIeL5agVS5HppNhtKwhxQFB/p BGLWOwqZiRjKy8uwmO9evW/d0huUTa/Md6UvM2EqDFNFSIIP8nUy/kEfW13Oyb/7oc1ogyrysh7 R/zA14qea1gJ/ozq20FTZuvoVx9lGgrHkls8pbBoAWXk3g1ULMKvkLRylh7WV5UrQZVF6BH1gQL +bm4lNagexif/x4hixTMbrHZKX2ujvZIUoV28OhjHCXS/uyPPIPxdUPZF1dvoEALW+Y1Mwjj+jK lwfuhuPfqwq7L1qHCuiW0KC+j2u+096TOCHxtyJ0H4IAmXsYS2yTUpJICu1TYpO8oVUbIOn+dZR Exf73v6kDJHaxiAzXuq+d2nKauzVHUk5/T5jGEIsNzvRLdE2ox4fE96ZvBD1tJ1DCRWk6qSMvlz 4aTFuwULBjUMY44uw2XBVyxiETNXXB37paz8gs+S4DAGJxuJ10sppMMWjii5/ooNzFOfk3fn30R lXypAC3PkYgbMYw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 08/10] dm-qcow2: flag the image for check if reftable relocation fails late X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > +err_hdr_written: > + QC_ERR(qcow2->tgt->ti, "failed to relocate refcount table"); > + qcow2->tgt->md_writeback_error = true; > + return -EIO; - Make the two messages differ and print the error code. You answered that a WARN before every late failure tells the two apart. The header write failure has no WARN, and the late paths use WARN_ON_ONCE. So from the second failure on, both cases print the same single line, and the error of the header write is not printed at all. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel