From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0AAC48017D for ; Tue, 3 Nov 2026 17:52:20 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3Hp7lq009764; Tue, 3 Nov 2026 20:51:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3Hp7lq009764 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="buwTHpfD" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HoupM009718 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HoupM009718 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48e1d839ddaso3155268f8f.3 for ; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzym3buDrwbFApOdQtoz6CkeAG8gkVdflO0/U3wUts+kRC1QJ4OTuV7zKW9ZVHUICDQn/RoJw==@openvz.org X-Gm-Message-State: APuU4Z9G/xfeovqdK2Aj3bp2ro9l9h+Qxt65zbplH0z4Xa0F4fqTQgYj Qqx+9ZiP12ifSskMWKbFCk2dJYxKipQHCvJBu4l8Xul5PLo2gKpCQ0V9VQmqsxb4QuZQXKHUhVz 89jzLH12rV4rYMUsxG2IFei/vSgWX3E997KAJwiTyBgzs61ATKquqQw== X-Gm-Gg: AYBFou3QKLxgRXM0CqsKLHrZC9YtZ4PjePywQd2PyYgwosc8ORVXqHypfQn5bDqOrqC ZxpyQs2FTor/pFgJ2xWXm5+6F9f3X5Kev+kGMReKAblW3PKuo9lTdd0lGetly7+0bIXMTVavsyS CplanujXcQoRM3WSOEydnYfm3Iqq1KcYeOmzQi9NlC6E8qIvbDHboM3OGjhHPPTHb/C9RHNumA1 W+KBRkeX6k8VyPlyOaMo10Col7+YhLLq4AEQVH0tY6eGTVzmhGjDJY4hAbhJyPLmKQZya6puABE 0OJ4aC1Jvu8LlGVZuhhf0Jw106PuEipbkZ6jIqB13nUEBBi4LG59+qfjk6y7yBfV9O9Adf9Wbwh U439DMM7Db7vADDyOIw== X-Received: by 2002:a05:6000:25c3:b0:48d:f3a5:4563 with SMTP id ffacd0b85a97d-48e6e2eb72bmr29350150f8f.20.1793728256005; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Received: by 2002:a05:6000:25c3:b0:48d:f3a5:4563 with SMTP id ffacd0b85a97d-48e6e2eb72bmr29350098f8f.20.1793728255497; Tue, 03 Nov 2026 09:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728255; cv=none; d=google.com; s=arc-20260327; b=i44lXfLpD4rdG0aNGtgbBUJaHh9Ocmp6oPgUoppmn81Yb7whnmiiAMcynlGwHemMaR GgOkBu0jdvQ3tJhb2/xhtClHHaOcayK7g6ZLVwQuZ0OkI7h34UUU95CBVL3BTF7em1qV 9CY+XyzT+EkR0AOw65bdWKEPjfa7urWl+HiKfurOQVXTkzb5x4Rz/Co6glrUlIx2ZkGH PGQ/XIH88KclJf4nV/tEsby+IdktUcVYybRoPHiplZnhZGjoMZWa2P5w3ZA4nZtJaeWq PUbLFtwJXJy0IHXC3wBnBBj3FPQU6yuSU2BfQAUA/71BjZjalY+54/JX233GA5vx7uTK qNPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=RdP7YzMiQTJafEfX9QD0FzUMolRg4jc8Mr1ZJc+VDkM=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=UVXETMXo1mrsI+7f7Okwwetr/+9VOpyHb7WMvqqozp/umDDPH7v5frl/1LpcMRo/08 o+hJZDi35Z70LNJV9m3F42l3aArjHMUguYv8UdvhUxHlbRU21CLNv4CyOh+daGhJnG72 hPA64i85sb2zwhZNRszSvYJE1JJq10VMUHKBoBDvDKIoorYfPsjoWq+hhcR5TaPjvYVa egIxUzUaUEAD3VLSSx+As0R1wrOUPFFgGwXiThPtKBZEOo/kzMcROrALXLp4OYixEdP/ 7UXKTxAimwoyvUMDreys2stqiQci/T9Y5xL8QSBsI6/8F1zlVJhoAqSSKAdNGdvl2Ngd U7aw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=buwTHpfD; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bd1b6dsi26284397f8f.416.2026.11.03.09.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:55 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=buwTHpfD; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=RdP7YzMiQTJafEfX9QD0FzUMolRg4jc8Mr1ZJc+VDkM=; b=buwTHpfDaWG3 OjLiZWtAxoep8EARwaew2YXHzY0b98g8WGA2PXiRElqE2SiaJvvCcgalf1EVnm6sLMmcQqstPcrSc UYBXnKUEuhQ/koPti9Habajul6MkvedooNY7DYT+3cO1LEqQCHeVayWneJkmkLyaXN+M+tCnJJFgq M+kKE4U+Ewtzui+wIl0yZ7RR5zAq2sYm5PZu4QyZYEtgyElkfMjXa+dEgN56CzrLyL/AsxEHOznoE IjaH78wcsj2apLTBDfLz/gzzE/0jgbEtZ7j70WEWquEIMI4tF0578EBX8Uu2hVNRA7hnHZdyUUMxs ZRPITZo24IkFogNnZVxuWg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIax-004r4V-29; Tue, 03 Nov 2026 18:50:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-6-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-6-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824968.2555502.16948569421120815187.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1037; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=F4RU+AtbiRhydH+iMaWpnENFEnBOYZBcgiK+rHjQDxI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6h780PW9XElU5STtIckv8dafzdUHkgIh6lHpy LJuwklG9cqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoe/AAKCRBRlgpH+WFc Kgu4D/9+vdmkgg3RObHSCfU2zFKxWLOMIITx8G+EkAhmZ5FPwEALKR8nefmiCHBLLX3SshvQqY6 5PXwUyCWIRdyBbSC8UdtdZwciBUADE+7Tv9UZ0CLF0Rje+NB4qboEpEGuxkXWhzP6nVZv91+Szk mEHnli+eIRPvI74XG5QDicTf49Yp8fNJMqLWMEwPHniJDPuDnEApVFJQnxPT981F2tHcI4kVO2c itsVodtXjjYzqNeXkgZ8qBB9fxwqVHzxzMQufPTZ3D8Bnk23NKMUeTIXIkjtCV6E6noFVR8DGLM s1XbY0L3n3IZ07K7sEa9WDHTTZYNKOpntHBvvHp/Ok4NpBEAad5NZuj1rDbUbifrBx+0Pn8TTP8 r1T2eXhE1Z/U66JKDxQsCPE+iKZ2Pk3THsGA4kCo0ousOktdrkVNh+oEf6m9ezGObI59rUrvxJv 4PqV5RqbUXdR4n3TrksMTuDSj+XAyGRWKsSiLjkWkDzSMaO0epjcIv2TPxLyRHqbWGuHn9p9xuM dXnPqkXaMDck7DfTR24KjINFExVCKIn0qWjl/iKSj6mFkKPjVfg7bRhN/9ymKQr8FmTeNjKZKYC ScqslBIB701xLpQE8xOLJpJoAugjgPVHpZeZ8QL9bBPFLXVomk9+62MyfOkO9L8quuyudWAUClF UaVEkKsuvFsD7fg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 05/10] dm-qcow2: flush lower metadata before clearing its dirty bit on merge failure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > leaves the lower image marked clean on disk with L2 tables and refblocks > that lag behind the merged data. > > A failed md writeback of the lower image is also missed: > md_writeback_error is set only by qcow2_flush_deferred_activity(), so > the next resume is not refused. - Drop the second paragraph. - Say refblocks only, not "L2 tables and refblocks". - Shorten the subject, it is 77 columns. The next postsuspend flushes the lower image as well: qcow2_flush_deferred_activity_all() walks tgt->top and every ->lower and sets md_writeback_error on a failed write. So that resume is refused already. What the patch adds is the order: the flush now comes before the header write that clears the dirty bit. Merge writes wait for their L2 writeback before they complete, so L2 does not lag. Only the refblocks are in the delayed writeback. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel