From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0733380E7E for ; Tue, 3 Nov 2026 17:52:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3HpFTl009785; Tue, 3 Nov 2026 20:51:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3HpFTl009785 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="G+2kULsv" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3Hou6D009730 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 20:50:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3Hou6D009730 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a1fa972b4fso23567675e9.2 for ; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxFGOjq1MjW0sXC0uEYQNiEZu0iply8Ubpkh6qA6Mw0NkVXsbKJXkcMRsAgz9CF3v1LKaqJwQ==@openvz.org X-Gm-Message-State: APuU4Z+6jRbh4Tt6Lir7Bo9Kd0s6p/BrHPN8wqtNCWJKZdDoxMkZjt9L wI4iA1mpsXcVTpu/2ctZvqtwgqsF9uCd9a1lBV/M86IeSzJ59lxbVqD17xWqgZ+C1KuEgHEn5fo EA7T6jnaEcyekFMql0F63FcMXVqBXnJVZ3iRz/yORVXnFsGss32G1jg== X-Gm-Gg: AYBFou0HEuYeqMZsUAmFYKUuJp/dxrEqaN5bJWWv7b+AlT51QQgZmlxUu2aD78jc+ct ke1JwhTFgB+IGwVtvr53eFlyx6encGryr9Jo+4D/GZf2XZrFZOFml/xsWMJ9JD922X7KOBv1ZVZ R3H4YRLzqpe8em+Co/hLzx7G52M8YA3kN4EJ1ulb9QRPJOQyEGhKyFGTWGD0Zhe9OUoJ7KlYtLN UZJrVa0b5c8LbuEWg9HD+xR/hPA5M48R8yBAMOSFCGJI6IMKmMxjRMf9gFpliKrAE0vN7xC5b9u tXFEliIn2Ed/tzVBqRLynU/kdgbmo/SF8Qg3DPvnJ4Io2STZOKv/PLGYojduzMXgmB0qA3IGssr tA/Ge3dsfdWkICwzD X-Received: by 2002:a05:600d:a:b0:4ac:aae6:6400 with SMTP id 5b1f17b1804b1-4acaae665a6mr240257365e9.13.1793728256512; Tue, 03 Nov 2026 09:50:56 -0800 (PST) X-Received: by 2002:a05:600d:a:b0:4ac:aae6:6400 with SMTP id 5b1f17b1804b1-4acaae665a6mr240257095e9.13.1793728256034; Tue, 03 Nov 2026 09:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793728256; cv=none; d=google.com; s=arc-20260327; b=iEZuXFCgRbMvGUpyDlWZ8ILHPWExh3Cg4KzNK9y6zke0Jscz+47A7HoitxRRuAgbUr WKnv2CL9+0+XJqCpddDoDJn0UgdTSTWKJUTtK2VtqiQ3yQSRNnSB40aO+eWJmH0j6P// BgHhTgtvsc9v13XZdKiuyzzIMg8R4oTVKFJa23kLNp9S7NCEFfVSTCwvQmfZqNtQ/f6P 4rTdJeNQ0glpcHX7O+xJznDg2dneZMUtJXSYrfnaS3mZk/ew9fDys0m6d2cP2j9cpI2p /8Y8CUsCoN9tuwvEzSh8XMXkHVv0PzL96ALpweSlpMA0B31i0vI6AvUo4tsucf79sPYc v3XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=TFeB8TJ4j32PGhLC2ypgOSi+AAem3buLRK/s/HqULmg=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=GNuiy88KgMdNKy1ae5bzftDb7IaY4Uhlsn2YcuAUec/vWSQYs03MBwG3Uf0dDIrcyL ZTrOl4qUaHqcLc4Ghrn6xXygvOUHab2nvSUjCLPPsT02gbh4m8zfiX0xED5k8a0eQMmt xWpup4rTZv/D4846EDkTGNEi4pBoYPtIvWQR0RVz2EHV6a8cYgSPhF+OE4+qUNMrq642 FmJgvsFMTu8qRy8kpIV9y/Fx7mPAAOjm3T78SyWkI3C0YZkaWimRPKYj6gYEUMCe+esM O25AoTYInlDsD2Iwbd3ROEGLuVwS5GkgO4DV4U6Uauab6IPOM55EkyBPuTB8Q75qZbUc HH9Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=G+2kULsv; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bb0cb3si24918958f8f.206.2026.11.03.09.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:56 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=G+2kULsv; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=TFeB8TJ4j32PGhLC2ypgOSi+AAem3buLRK/s/HqULmg=; b=G+2kULsvO7PC ApEhGG723dFqiJ1CzCUpt487K+XDR7AbEOBlTWyYsahx0cdEYRLKmSBcv2abThzWDZzgnI5DxPaao o0fSoK3kozUX3hF4wMPzZdyP0xWXVJspETG9KTrJG8QKEJDGX6TPFWVHmTXhT2qDlC41DP8eINC4/ lQ+2HmuETsFBOsZISUd5jicgKL9+o1OP1YEXbWWdM7TGxJQzf5oQoFK0hu9u4s1T3+hr6cawnBV+3 CSOzqmLPTAZ31IBSrxxRHahTGMTCX8kq0npfuMPQgvEfrxPR6vdqNyTLgUDPyij3oKf8z1b2ypMSx F9cA2i+uN43qIJZlLo/3bA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOIay-004r4V-0d; Tue, 03 Nov 2026 18:50:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261028150645.3222391-11-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-11-alexander.ivanov@virtuozzo.com> Date: Tue, 03 Nov 2026 18:50:49 +0100 Message-Id: <179372824969.2555502.6884475233694873135.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1071; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=XAfmgLDY1GIvEXk4naXl84sI76iVu1mG5AVoeq7qViY=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq6h79nsTRnqsD/FW1VveXpo1YhE7uvSeCJEXqA hP2Fxp+YumJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauoe/QAKCRBRlgpH+WFc KgMCEAC0tJw6c+nrcxQKKEVJRuv9Z2gpY9TKPKm8g66738f2IbgjDg6kp9NMEnqcldCgLBGq/do u3q3jMyuchbDu0VyJ68ItFd95NAj6SOgiUFoQWJmV0yyeUFcqpIGXvCuqxA+9sHeH0mOjgqnPIf HuGgNodMRngwp8XZDBurytSox81Mf1rKv9R727CJ/7Gs3j+Ysp3Ruix94WBj96yckbr4JItD7Y+ EgcCRR4QpwkDKBGiVvLPF8BlVi+53Zv9Ys/vcTOvXx93kdaM4Qnaz4kU4K25+enhfXYxjA4Dh9G qh+DN0NK2ViYkvkR6fmFOqTQfDU2HlqEx5s9GJjWc0JmWoSIsIsuDEbWFrPLoSOvFfvFWq7+iKv BWkJDHOmNiZuJwGMrvgP2QDw+EzSNi7NbNwcM8lJkby1DWagr6V667uEJEI4HeIXCh8NMh62+U9 MmkInOClcze8g9MC5lGALiXM3ku08aYz2JbsQk/64KJ1ifn5L2+S0jeay8sBNM0u8qNnu/TD3/K 7SzFEkb9RjFtE3ulC7X5UI4LtpaZIycvOfz51yM2WicoEiyT7JNHQCR4OtfZnXzIFB0xtwzWt3p 4i6e7PnNBcbcbPLKhNdEdcC1Sx0gVR6jRpqTrTqmCze/GH9IkKb5X1DIIURmLWZgJmThHX9oQX6 m0U03fvbWbjDpOQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 10/10] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v10 with the changes below. On 10/28/26 16:06, Alexander Ivanov wrote: > inconsistent. Userspace checks the image before opening it RW, which > find_unused_cluster() already relies on when it reuses clusters with > zero refcount. - Drop the find_unused_cluster() argument, and say plainly that in the default mode the scan is safe only because userspace checks the image before an RW open. - Say that v2 images are covered only by that check too. - Split the paragraphs longer than four sentences. The allocator reuses a wrongly free cluster only on an allocating write, and it takes the lowest free cluster first, so it reaches the tail last. The scan reads the tail on every RW suspend. After a crash the stale refcounts are exactly at the tail, because L2 goes out with the request and refblocks wait for the slow writeback. So the two do not carry the same risk. A v2 image has no dirty bit, so the opened_dirty guard never applies to it. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel