From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2763D811BB for ; Wed, 4 Nov 2026 17:15:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEPfU025264; Wed, 4 Nov 2026 20:14:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEPfU025264 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Nv6KFrMg" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEOAN025242 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 20:14:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEOAN025242 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4ae2756fa7aso7213155e9.0 for ; Wed, 04 Nov 2026 09:14:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvByTdA84ldEz2OT2NQhFxNXgfELTu0IX1ffToS80rX8NwgPKT59ESfSG2T1Fvi5b9qAE/6iV5Q==@openvz.org X-Gm-Message-State: APuU4Z/o/1a1wKoQPG9E3UMbh80EMcYmMKBzLOAOsxFbIfpasvUycm1K 2eqe5RLJvikggwgd/uIm1IbdIFoc8qcmtjAKQtL/lGSNV0Raz4WjVNRAg+vAugymuIgcP394Fh8 qTY7PO/Pf+p4aMDQ/sjnwqY8h4YF/2rpNQ0pzQGwuTtdy7pDKzP48bA== X-Gm-Gg: AYBFou1E30sauGa5xGOgzaKi+urvTTmryJ+QfqYQBkyNYZBWnT9ZbzTjMkAiE+/DDVI WPaDhPXv0OpDiOl+uI3ZCiweFU2yWdE1xxKAAudzP82mv9ichHkfDFGqo24Xnzb6i0rKb60Qby2 zMV1jgPa1pR3UfL/K3bhdH3Y+jZ/+gMZmOySz1DB+DFSycjmOkwjJtX4xFlK7VcRgGFgJxOzm8+ BEOAqWsAyx6LvT0CjYnCBdTAx+bvA7PIYHhsm0dLwrmETZk1i9wfegcK4uOf1IC1cb8Y6g83Hrv +x/FnNuOITRrii5PmwET3AXQgS/jKmLaPO31ZAYh6btvPx88JZ1Yc2FOr8smXHWYdJZE6uIHneG PFRn7vxUkaDvw3IhD X-Received: by 2002:a05:600c:a00b:b0:4a2:180b:3153 with SMTP id 5b1f17b1804b1-4ac185bcc7dmr389790715e9.14.1793812464150; Wed, 04 Nov 2026 09:14:24 -0800 (PST) X-Received: by 2002:a05:600c:a00b:b0:4a2:180b:3153 with SMTP id 5b1f17b1804b1-4ac185bcc7dmr389790395e9.14.1793812463702; Wed, 04 Nov 2026 09:14:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793812463; cv=none; d=google.com; s=arc-20260327; b=ZBEIkeNTZ3spwnc7CrWxw53uGtbCfmFatFFDD19aVncr1JLkGoj4BodM4GKTCa5kMd 7Jxo1q+gBAjxOwzuW2ioELLOi/Ops+GG2sCOLvoutRnSCq+l7f3pRa9Tr0y+PXUe+gp4 T0KhoPX+7BvvZq1J3h4ZKVL5vqjXdmlKVn0rhrUX9Bo49T3Frbk3krhJOftjNoLT38kg ieODLKs0BELdyD+VTZd31qxS3nPvo8CSJ5ZGXsTRTSP3SUot6xIymtbupKe6h61cPCSv 4ZP2cUcdj7vJBjD36B44gYeey2Rt1McLuHZFEQvaxLcZGg5293oWwIA57VLBgr3hwQwy Gqzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=bPkwTTGCTeIDLZTOn2KdsaMsUrYfq+f78VFrrO2QzOY=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=mYxIxFH6S4v9XGi3WzweRlwD7+OSTOA7ioEXrPnuMXbdfkILWgyjLBdlqx0dPHNXr1 d7PYxDDKHt+4ErVEa64LNEyk+1b/XLHy2vIjpWOljm2by8K8BrisBbw3eF0lR6DuIbTI +G8Pa1+lHXuWD6TxrhoK+CC8gnxxxgh2KYQvhfM9hZP3nnhfd1UxhnUXQS9THo1E5yK+ FYF3y7bHTWFwjcRwmXxso19ixDwF/nQKEDCEw+LeiF+wqfSv7BznXnrwVRPJxMcp08kB UG0kAxajHGJFbzm/rB34vXg5xY4stJMMIhGbBZds4MEHrPNOg6yGRhSu817zVQIW2ZxK Kk4g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Nv6KFrMg; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4b43c36d51dsi71629495e9.6.2026.11.04.09.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 09:14:23 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=Nv6KFrMg; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=bPkwTTGCTeIDLZTOn2KdsaMsUrYfq+f78VFrrO2QzOY=; b=Nv6KFrMgUj17 ouSbsCZbOIPyVlvQ5HDd29e1mdE3oM6v0YhwgTDECWnP+gzAk21FJf9xUBPlPCR73yvkg0sejxfvM qASl+MYpAde5xnfPbAyoY+oPoVF8gXmJKCgH9EgriNUGhLxHTuyX6x1HtreHQRv0E6fEBzdtGwil5 sAlBga7RB88T89TJ9nJbiamzuLADRaW1WXbA0nozN4kNi4d5JGq2kzesh6lysuF5/SW8FW3uftvOq CfLp+zOqO702O2IQTxrj5Bi4Mbx7M1YSBAI+eLKYFNjzUcU1XiO3LZ9pUtL5KPL37Sxxn5ZogBAdP QehBn1/NBLLC4cZRjuHGog==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeV8-00FAiP-0s; Wed, 04 Nov 2026 18:14:22 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103083642.130885-3-den@openvz.org> References: <20261103083642.130885-1-den@openvz.org> <20261103083642.130885-3-den@openvz.org> Date: Wed, 04 Nov 2026 18:14:19 +0100 Message-Id: <179381245947.2686233.1778067243396983116.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=938; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=IdemsW43PRxNnIMVSK5glKP/8LkjdoDaqTsQLmq/QLI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62ftjqCRWe5FC0EKG/QvCMOLKLFbq4duWK57/ 3+Eyui2HmGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautn7QAKCRBRlgpH+WFc KuD7EACE3N00mbXd05Z9abmIvuW+dJYObZ5N/N4ZTZptOqPetKCGu4WJtK5BpdBSAiytWc2Runl GPzA3Uc+r6prDhidK6Wmiw9+EI6h2V+sJjb3koGQrNkd9vF6eAk6onJJYAk9fFdk7UM+fMArUQT Ls9Ky6Wm8iZUSDhMmjAJXKmA099PUWIQiVonlV9J2x5iBAo51xWbOy8nHS9KO9DecBEhcoyCW64 c0YBCQqPj1OqSHj7PBsKOec6y8+40ZX+ODHoeOdLOeegk8+NzHZaEAhDo0ksth3yDVeFRxlbKt0 nT/nhED+FyECDqa7wSTR6slcKdO1kpN1A0g+c22J9up9wKvQ/ExH6Yx4onwZY5FUuWkeukNnrY9 JucKpDu6L7geQk1puJrKSfZ/w9w5de3s2PFSm5ArHU8dg8VYX9qdC7vjKi8Lx/313Uj91oRJUEh 26TKpcN/gFNU9hQPRJKqC5vaKqmJZMh9IQHVvnumbvnoBvARxvPLAyq7AIWY2mFtV1ZL4HScS8Z n1ez5NHau4lqPsr0aS9heb6C+C3QRHPOoYotzfRkCapCa+7IxWES4xAABB4Ll798+bJ5M4OCC/v auZIoF+oikDtIYJwig7fHKFLpWkHI4RDz+m/ShCRVA+5FV+hWjX18TQhrSBNc2MGHhFUmofmnu2 KECLVugCIeiqldA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/4] dm-ploop: fix a lost wakeup of the ploop_allocator() thread X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Tue, 03 Nov 2026 09:36:40 +0100, Denis V. Lunev wrote: > ploop_allocate_cluster() until some later request wakes the thread. The Item 2 of the cover letter reply: drop "until some later request wakes the thread". Why: ploop_req_prealloc() returns without a wakeup when the requested size is already covered by prealloc_size, so later requests in the same range do not wake the thread either. The stall does not end by itself. Item 2 of the cover letter reply: add one sentence that the same reorder fixes a lost kthread_stop() wakeup. Why: the old loop tested kthread_should_stop() and only then set the task state, so a kthread_stop() landing in between was lost the same way and the device removal hung. With that fixed: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel