From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7ED7B8045D for ; Wed, 4 Nov 2026 17:15:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEZKc025278; Wed, 4 Nov 2026 20:14:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEZKc025278 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ldpfmbW7" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEOwW025243 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 20:14:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEOwW025243 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48b01a74792so866397f8f.0 for ; Wed, 04 Nov 2026 09:14:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxraiHQVwkIlh6A9YnPfHJMiNkZaBJlUqOssOjNIQS9Rm0Nx3Bk7suMG6W81N0KKiHektwsuw==@openvz.org X-Gm-Message-State: APuU4Z+oqA3iEA9nPSkabFyyPXac7wejVpevBPF4sBPykMxp7DnoqeR8 R9UFQwo0asmjipJfBBDr8kFivgUaUMtpHWaxD4IGsEjnX56/vNt5TTpS4au3M6K6ZIEAjujk3FJ 19lUV7SZKCf01yoNK+oqXvNX8V+hfJ95wx8gUvvU+7R0cAIecPvBjRg== X-Gm-Gg: AYBFou32eMXjZMYhM8ZsrgEiX1grLPbXYYfxIUwizF6HGDHPfAAJBSJ03ocV0lpywnl Y4rw9/cMCOyHIWgB7lriK2RNbl/3lOZxSODo+9QHqE7tCoXXrBlyNpSfOXRO6QHdRhbU7uV5pox BRVrSK3/pul23UMHa0Rec9+W+2xLnfkudfkhjNgeqqBQGxVxxdXrFFCrtLtFlEcIKPdDj+/XvBW stAP/4kuymSiHZePdlc0oTw6/kE2MZgaXNEzCfkJUkJfw42TA3BVg01EfnhKlAUJUSspaGdQ0Ud oqEaqnsAR/CbkivELzVy4Nm5EKeY/UEwHiZ+f8DUfhErebh0Ht3ClrYNdu1J5uLb28gYXunBCKz ZuMaBFgwXrwVrJGtv X-Received: by 2002:a05:6000:402c:b0:48e:76ab:7906 with SMTP id ffacd0b85a97d-48e76ab7f39mr33881296f8f.9.1793812464121; Wed, 04 Nov 2026 09:14:24 -0800 (PST) X-Received: by 2002:a05:6000:402c:b0:48e:76ab:7906 with SMTP id ffacd0b85a97d-48e76ab7f39mr33881253f8f.9.1793812463639; Wed, 04 Nov 2026 09:14:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793812463; cv=none; d=google.com; s=arc-20260327; b=N+o6wEW+AXBZaR6dEqd29+3eM7iMcGeVYzGm497u8vQttzB91FAgjO4c9wPbt8ihhG C4Cew/wgNN6cIAYtspJZICVluenqMX0l8yzFOQykdwDN4tM046RpAJhHbCEDvNBKenqb n7zmk96EOn2vQrH+Rlsf6mPgXiKEFD2ZgF8J1eJ2EUwdF7wE2F30LVsoksze4/5bx+1p udjBlNwNJFB+Bz2pxfNE3LtPcIAZYo+y+YYLUYyR55LoxwASrM0yWvxVoXrqL64Wrjwo LfN87gBhRYL1uRgdHeXuh+dfSITQBIDLlFCnbV9z7z40QjPK4bqKdIto4qjLbONzmEab stOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=iG/R+9qhIyqSFUkra2eMkPkp4p82NX2YIn8y+frHnFQ=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=K+m7bpme8KYR521V8mCPxM/UsgjZRqp0iP1A6xPHW75mepf9L0Kxx/dUyognh8AcVf h/3GkghScV1qGkDhRoZ7x8ZBE5+SawmpEOxTc/BwFWuJnidx/H6D2dL3fSeAY9ystKaK A40HqS/HgL9JEoY3T3DFaZB96WdrsmwRZn+0mY1Uw7haLaBDi6HhA7Nq+euDETuajosS 5d226snp3mob0Gp9G1s54m5nV0yXJigW6xBULLA/68cnyeQZa3qYYB5RGHaCwk0Y1OMV kgiytj8bLU3/ywZtqYBBIzHhFYo31eCDVD2HXUON5hhsJ1+/WP3LWOJvLee226Odjel+ Xc7w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ldpfmbW7; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fe9ea1e9dsi5000830f8f.27.2026.11.04.09.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 09:14:23 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ldpfmbW7; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=iG/R+9qhIyqSFUkra2eMkPkp4p82NX2YIn8y+frHnFQ=; b=ldpfmbW7BEmx aBYnsoYeJgCbRFYnh46WMKTGrrNApqLSb7uCiC78HjPPDcy3ZOJX/gE+8WPNVNh0TP6SKhxa6lF3B J5EFlAxPjqxonhAQ09sfi1lVQF2wQ0rNjpk6c5T8E4qJTXUOOt0yVgR29BMUXkJ/svpGNIzAsA5hv gdZNVSsj48et7vtcEAbtNPk2Mn+5uc71m8y5EgSHXMkSx9jutg5wjbtzARMPQvI+3EVrL9nmeZPKe Zfp+FDM+myg4PBu42iCsJGjW5uC/0eHPYPNqGz6Bjf3Gd5v+QPN28sSHXqrd1TNr7d+yw2/MiXJVQ XrEw8znHcNPY0il8S+O4eA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeV8-00FAiP-0H; Wed, 04 Nov 2026 18:14:22 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103083642.130885-2-den@openvz.org> References: <20261103083642.130885-1-den@openvz.org> <20261103083642.130885-2-den@openvz.org> Date: Wed, 04 Nov 2026 18:14:19 +0100 Message-Id: <179381245947.2686233.4128969536870407704.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=820; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=pMNXnjtYk7a9j37v3Z4DhvqmqUjUR6Zx0/pibytDo28=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62ftaJEOK6tAnJF8lTvnDQ7DshqYmcqYPonzG 9QZKs901I2JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautn7QAKCRBRlgpH+WFc KjawD/4yY104REgQS6Fx05PHGbfIr6FjrFdD7GhFsizc0HUkp2kA/XmmANhJWPjYBfAYGP2yt09 9YZS6ZEW504xQ1wFz8u16qJRA694gpsrQfHh1eF3pU79ISgFSXHtW8VHR6YPpkDG3geNW1N7nAI 6gNrxsAAdY9fnycozPphw+cgHN2wQkDB0zaNqa7+S7luS8eRl6I3yNvOOehE0CkVzeC1bB32b8g loU9RD/9Jq1W702d/w8tpkD7R8384qY9wBw5dA7gTEkJQn6X6z5OX/p8t/e54tHy2sVqWE99GHN P8mHeba1fX8LFMoYNKdrA/TL953Ylm2N6zRR3kOqCWUXUvaCkvWT4BarxwA56ToEp1gBpULu8Kf xLIiGeohfhG7yeSVL5cRGYC44iHCf8RhZNppbeBkTaYHRFnEZRLvHZMsiMUzgXB0Yi9yuV42Fpk MpskWpGwPhttSwrW5z1Gesvat0F6SYvb1+kfBEA2G6C+xt4DE8S5FlgIUJzY6qnkH5NA3cH7Roz mBs2FyJeRBCPN3YcysVZ7Wd9reeBnsyQ0bPsWxQxGT3WbRah3oYdo18agKWHTEzUIh+Lrg6Tme1 DtTNRC0SeXYaFEyvwt/MlLY/wBycWzFaq8LHEo7IqadREngTGCHgzvM6WJD70lH/8ZgOUuBsR/s yMw3OzNmZZ+UVfg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/4] dm-ploop: fix pio submission racing with the suspend and resume of a cmd X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the change below. On Tue, 03 Nov 2026 09:36:39 +0100, Denis V. Lunev wrote: > - a pio that passed the check before the flag was set takes its ref on > the new index or on the already killed old one. The cmd does not > wait for it, and it runs while a merge, resize or delta index update > rewrites the BAT levels and deltas[]; Item 1 of the cover letter reply: add notify_merged to that list. Why: ploop_delta_clusters_merged() stops submission the same way and renumbers deltas[], so it is hit by the same race. The code is fine, the RCU section and the grace period before the index switch close both races. With that fixed: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel