From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E47BC812AD for ; Wed, 4 Nov 2026 17:15:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEexM025291; Wed, 4 Nov 2026 20:14:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEexM025291 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="LaH+NoqV" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4HEOmb025252 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 20:14:25 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4HEOmb025252 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a1e489f97fso12584135e9.0 for ; Wed, 04 Nov 2026 09:14:25 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzGoxQUPoWDXAQSDEVFXbsmDtLiFhRHxZV9a4bxtYboSabIAx/lGXBJ6sLrSdNA8UNbDDm5bw==@openvz.org X-Gm-Message-State: APuU4Z8Vb5DF3ZqmMEYF5gAeT2Idyf7hPKhTGMHF16apxPYOd6wZBRBu VEcbliO4h9XzWTkqAaowDOq9B0AWcmMVk4uATJkDPok6EOTC4UCm2dczJ07Bo3vPwPp9NzhTYqH fBPYJ/OSYJaO5Uy1ZR8OG/lhMxeJXdKtgTqST8vxC+aJSpDKb3nrtkg== X-Gm-Gg: AYBFou0vynPuYg+5IDXuuBqyFa9/bkO0TYR2lOJew12cSm/Qgb9rRkrdWUFnj6deIvV xeJ77Za+YEwoki8qVoJrpExlRBypELMl/fgFVCX7nogjsPBUrB+ijXIKulnYFb+tZ5pltb+uher SPnXLH5WnN/KmvWJIICYpgxtLvK+DVx/FcHsbYew7sg2x0Xu6ZvQ5A9KBFHtSh09ZkuaF7wed4A mbAs4JhQG5zo9VH7IACCaqxeU/oifgSqvZUGK/IGUoXJBS7PSy224Ykh0/mn0CDR/BTASa2Wl7y a1XPZ6c0wkw2IKdJHFTOht3Ih/y+1iEaUDktFcX5d5747xskExlagql12LO5E31Rx1QeS0oTlWP C9yGNskmKFWUWUEXm7Q== X-Received: by 2002:a05:600c:3b2a:b0:4a1:fae5:f2e2 with SMTP id 5b1f17b1804b1-4ac14fbdd04mr378917695e9.4.1793812464715; Wed, 04 Nov 2026 09:14:24 -0800 (PST) X-Received: by 2002:a05:600c:3b2a:b0:4a1:fae5:f2e2 with SMTP id 5b1f17b1804b1-4ac14fbdd04mr378917365e9.4.1793812464257; Wed, 04 Nov 2026 09:14:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793812464; cv=none; d=google.com; s=arc-20260327; b=pNAh5yXDXZjAvOh8buUBQhkAxjGXPquw+d2cSyiBYvrqCKPTaYPc2g7+q+qcuyq71H tEqjTR10pPvMEInZEIZvqsEwLkqhVSwaGk4BBB3YFYetE+1FWt1m+Cn7xEmLjo7D0UoK CNUK0aPmNu4wnv86DuYaa1O1xDHwkaY6kOBPtIikoJvIEa1E2DEjjLwmf5RzwKQe7szo 1g9STOEgNBd5S5e10MEmNkReQT3OGCJsa4JJjL3penDmIVIroDm8sKfp77rTKBZfw6fj ieCMsxOO5G8Qyt6goXAeIqd2Div1i+eyqxAeKCe4gPpFg04PCpS+p9nNYtDuY8N7vxgQ 9dRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=PmNO7Sab7ynK3sf0djtvvxp3TSCGPlm/GtDyOT6oUiQ=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=Sgfouz/VN/VzEQDhbFSkVM6VMzg5KMGQt5eIVc/xrnw3Bi2SO+7lIWG9zfjbwpKTi3 93ciA2vJw35lG9kTA/qlHgRAEv9LHfLJhfRNPow4KtXMSGzcI/3MKYTPtqY57bcK0NlQ Dyy9v9zhqIS8DWGb6TRwTgz06HxkJemNJJJQg5djklg9A2+vhwT89/bQvOMpCmBkKpH4 KNMUmmpMy+qh6OR5WjUAsgERV1qP88RLl3jvczQLaUDBkULqhBRR32TTWQAvp5wpTtbP XDR72elgDrkB4td3cucRSormtii9pkyvW2zHEdGmIRup4NKzygnfEd2kK8khMFHqSuXJ 8GwA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LaH+NoqV; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fed272bd4si4998413f8f.138.2026.11.04.09.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 09:14:24 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LaH+NoqV; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=PmNO7Sab7ynK3sf0djtvvxp3TSCGPlm/GtDyOT6oUiQ=; b=LaH+NoqVrmcy P4DOo6K/NN468P0yfoIY23gFaeR3Z1tNSH+FZZJakpQNTGHuG90wikp+b99XT+PnHM9yg9yUJk4BP gHcuEWJ9Kcq2zpMObkkvbLhgxjMumGQYmCKFR5XSesvmoNsL1kXL7o7Ir5RIdIlGLYg1D5ASReOS6 1sRSF5hqhGhs5jYTqaM3IfeXG1wbkjUYJmr739zVHni9H6b+NCUdI4OJ2k/yMj+I202UoZaresHRd lqM+uVOwDnSo5hILqB6btC6a9bxld1jEQALpj7K/DvYFKu8PPDqMHn8SMZ8UYMeTNqRgYoYmYeYzI 9HvC9/vVd4ppDeQ1BeuBog==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOeV8-00FAiP-1P; Wed, 04 Nov 2026 18:14:22 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261103083642.130885-4-den@openvz.org> References: <20261103083642.130885-1-den@openvz.org> <20261103083642.130885-4-den@openvz.org> Date: Wed, 04 Nov 2026 18:14:19 +0100 Message-Id: <179381245948.2686233.11614432698632102545.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1469; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=fvle1hZVnucupO7lIMzSc2Ram967GuT/EQtnxwwfw5Q=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq62fuS4IZarKokrFtIr3ROCsBrgOsePCYPf4qd CZQegsZYweJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCautn7gAKCRBRlgpH+WFc KsxiEACZh4z1+sr1iBz2FmjJ4nmIJZvYRrU2w7uem6ZY5BO+Ku5aPZzueGJJ9T3UJB4Nb7va756 bwQUrJIMeWz8Ayt7m947/ZJyiy1HkXaAZmQHzKKDpZqwO0LVImsfG2jG7WU2HzXffdrZl4SyTMi 044NAY/YzC1ZGXJAp2fXs/RH8REtI4DU7FCrTyS4wU75Q3L5PyEW3XIBm+3gEAro0z+wjKPr3IN VV+ULNamMq48FclwbI39FsRPWQGRewKFMuQ00cVh4o0l38c7A1Jtd1Jfrbop/BNAey4ntPoTa33 QzCOiLVgQXDLUf0vTNb9Q2tmk/LYyeuujfUw+k5XzkViJkfyEMrJJV5m4Q3G6CjvkptSVDy5Anu 5dbwsF+UlmKlLqkz5+OUGsScOO1iKx64PRR4oTJeX187cvEvOhJg42rmpO1ZVo3GnUbc3TMIYxp TjZDFVfznICKH+5AVOlT6g7APyZiGgT9PTi55j7Vr3xH5DDv2RPsWXSB/HRGsWy8/wPNhXmFExX Mn7j/n31tPaSlwj3ypll6+tzcEuXVQPV99FmtewnPRY15T4Dodl8pUXY9Zd1YFFj7aSgpLkIH3+ ZP0a7isZvWrAGev1sMHItm8tvT73vKBYnn6s5YAYlFPZvrGQMNQpMQPTPuItnPSulJQmwPwpHhn RkQCbRl8ncep5gA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/4] dm-ploop: wait for the ploop_allocator() thread before changing deltas[] X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Tue, 03 Nov 2026 09:36:41 +0100, Denis V. Lunev wrote: > static void ploop_postsuspend(struct dm_target *ti) > { > + struct ploop *ploop = ti->private; > + > + wait_event(ploop->dispatcher_wq_prealloc, > + ploop_no_pending_prealloc(ploop)); > ploop_set_suspended(ti, true); > } Item 3 of the cover letter reply, code: also wait for ploop_no_pending_prealloc() in ploop_flip_upper_deltas() before process_flip_upper_deltas(), keep this wait. Why: a resize on a dm suspended device re-arms the allocator after this wait. ploop_resize() does not check ->suspended, and the grow allocates through ploop_prepare_reloc_index_wb() and ploop_allocate_cluster(), which requests a preallocation and does not wait when the cluster fits. So suspend, set_noresume 1, resize, flip_upper_deltas still lets the flip swap the slots under a running allocator, which is the truncation this patch fixes. > - merge and notify_merged_backward move the top delta one slot down and > zero the old slot. The allocator then reads a zero file_size from it Item 3 of the cover letter reply, message: "merge and notify_merged". Why: notify_delta_merged() renumbers the slots above @level for forward as well. The code already covers it through ploop_suspend_submitting_pios(), only the message is narrower than the fix. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel