From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2FB938017D for ; Wed, 4 Nov 2026 21:36:37 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4LZFQw027010; Thu, 5 Nov 2026 00:35:16 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4LZFQw027010 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="N0OWNbmR" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4LZE5L026995 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 00:35:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4LZE5L026995 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48dff112136so799811f8f.1 for ; Wed, 04 Nov 2026 13:35:14 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzmTqrFzYseXHmqUho3UzHGvN2d+yPjqA6JQ0hiEO+ktymI2eeuLtaChmQilOnoMjz0JlrSsA==@openvz.org X-Gm-Message-State: APuU4Z/90IdjWf9f8acoRBCD9FhFu4rn7kI7K4B2L6yS+DXFx0yZGPK0 CZIVD0nL8Z8Y8cEARjURQEnwVif4MkUijkbNyIIKRStSbxxr4Adi9/7t1OD2Tw9JECFfTYDeZPB jI6iE1QJqQ9SgLidu1O7ou3QkhOrS5f9JltFaE8r06HVZzSBvV2RMMA== X-Gm-Gg: AYBFou1UOr3PjSkPcWFORVMe3VWyHSgpUySe3aiRQp1PryCpVwbYUcggiyzrGlHQdXb HaRbz9xIBzXmwV3BU+xm4t2t2ynyN6MyZyb1gTMUf78IuYN02Nq3YdBao2rmqYm6dxTifLa2kBg ry6P9a+N021/1CB50Zzn1GeAZSfiILlUSkuyff9oLHboEWmBXnRsT+ZlWIaFXl8b8bwO6dGJNwf qLjTnl1uK2EcqhBYxP70fRufHr31MHUa6sp3zUoNtDhJ72seRbxmpZd0kWEDLBEdml4Gm8W37ia MVYcyNKd3mDFiT4sN90UIQFkOB0PLFltNjl8ipEvrw0g/Br4KpjpmQyzIIYcBVC3ZcSPCIhKLDH PZhVo1Aver0BG1KlZ X-Received: by 2002:a05:6000:41c8:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48e6e2bc714mr38033534f8f.7.1793828114537; Wed, 04 Nov 2026 13:35:14 -0800 (PST) X-Received: by 2002:a05:6000:41c8:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48e6e2bc714mr38033518f8f.7.1793828114114; Wed, 04 Nov 2026 13:35:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793828114; cv=none; d=google.com; s=arc-20260327; b=iCjFhUh1LSihUqtFPOAYp68wbOJ7maKx5olB83Fujz43Wx8/baQLlyfJhXOZTCygX7 JIL161m9urGvbSrZ9bF9uCkU8n0RJGI9NXlgjUBI6h8AfVQ+8o4FX29bv2QoBdudd1cL Hsj89ud2K8S+L9r/gH680BKCqziMvUtfdztcLXlf12mIQTEUsLp6Uj5ieUV5kcWiwAtT KepdOcdlUL6w3klKPj14ug/kx2ZAhiNyXayIQBWZdGWmOwt59AOa4ef9P7iOg6XjgCrr EhGGzp/7kZ3aa5ulLTaR8M2ny1DevRxAeLaQPeERS/+2aM9Kja4FALFDD2qNmjsEXSCM UJ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=Ip+ZFmx/pTM0LbyFlkEj2EO+zebjimL9FfaLNy8B9+w=; fh=wM93IzJ1q6YTmltzeth+TON77Ag69AF1TepZ24u7du4=; b=LrzpfLbVDwDOz+DRImWEiqJvLrs+jbdqmDgUTok/YIKVMkUiWU6yqtm3xYRe8Ouayd jnsUGh5E/Bx+dQVGgPkLriL1L/0gNmernezvOPygLPAWXidvNC272MlwTVFFWuo+0mwR msMeBiDKmLx6ad1tetdvIiPHU9o1prTmjkLMKQaDE9v+ciOK3aa8LRblz0uWUEL4jfZ6 JO7W/r6SW/t7gFuI+fJe+nzXue/rscXK93VOsmdc8PdPLDEfW88YkmrI1yLlSrWchNo8 Ir9XN0rglAawchLmnb9bPWSkkUXNQypGLTPdnohBd4AEwMIZWlLzhjI2u5tlqwsR69mR ijgg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=N0OWNbmR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48ff0a0311asi8952487f8f.489.2026.11.04.13.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 13:35:14 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=N0OWNbmR; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=Ip+ZFmx/pTM0LbyFlkEj2EO+zebjimL9FfaLNy8B9+w=; b=N0OWNbmRWBqo /X8XlPf2l69N4DF3nvh9BMvkQ9pntc/kDWL9ziwsIR+d0jiWki9t3JjLW1cqLzFZWAID8TPj+Y9hH +5apnMZEzXSSyXiqsMlZVZfSqGIgWu1kaWpOnmiojDiITQ1h37yTmLLMM99ffOW+ZZuJYODLG8oxY iBHIiLrqGXmiy0vxPX04u9ZU86FpB7hOSOv97GZwm0E817AWQLkqQaiKa1nQIk6iR3Klxr3YmygNB 8Q8uPAf+hV9/2Fa+T17ZND2c8n131dxGGMlBqyVgE1f/ohnk4Nb5g5LYn6YuTM7Qe7W/zkdsj8XHY n9hwfeqosNeHxwzwOxhSkw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOiZY-00248s-1l; Wed, 04 Nov 2026 22:35:12 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Zhadchenko In-Reply-To: <20261029140346.465768-2-andrey.zhadchenko@virtuozzo.com> References: <20261029140346.465768-1-andrey.zhadchenko@virtuozzo.com> <20261029140346.465768-2-andrey.zhadchenko@virtuozzo.com> Date: Wed, 04 Nov 2026 22:35:09 +0100 Message-Id: <179382810903.2794215.912454250560308768.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=750; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=BIrk6gLZtIIaWd2WI8iHZ7bLWL0qDiHWREtTDUETBpA=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq66UP2bK8LlD9dfUFUobtpDf6MPNUugaYzXFW1 SPdBG89nN+JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauulDwAKCRBRlgpH+WFc KntJD/9dxWE+E3K91TJVmJ7jIyYv2GrE0IA8qaSsSpuokzv9VNtBTYD167usguuwDhe6a/6Kdk9 OZlYk+/sauE3aUfh/sxtlkk57XFXijKuw9CTvooQVQfGEEOxaao5nlOimQMTyaSFacrxFwvs7wd qse7a6+m8BrVU5vj1s9wh2ThwfVi77O7bVvrekGiRA5WsnWTobj4GQmfrKm2SA3HoyMMt1U/XvZ ngItl5isuJxRC54BMpnpafts7UipNosIgSKyE70/4J+s/0OUCs1AZHdDz6QhDulXgpb0kVSTbKy t4UZDekIbGAaZvzm9IgyomC2vN1qVbKe46zvlCnOfVcS/XkbS67DRkdw1W5KsuF2hk/phtQvxJB 8q5298NJm2NTzjrpZEanBVwIyGTcAUlyvHFhVlkvjfYTxHmClXZERsj2zP6KV+3xkSje3cwTxRK obQ+dXzVWuOgmfjn98sigQp7AzetKlKDGFK6BknpC6dRLPTO1RrQpe7s40I18uG8NlHeKfn6fPf 7xFfnQVSn+INN0umTkLFwYj88UoUWZ5Ul4hTilAXDjz5v1s6V/GhiT+1+kZBx+DiXEYsMiiO1pM TyfnFBraJn3jiwcKSJKRkM7fP0JTZuI/beZ4Cid3ZF7FbfkNqqJD5ToD0Ni/lS/lIAhTdaqVfNW OI5daMfMC/X69fQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/7] drivers/md/dm-qcow2: repeat md page lookup if it was inserted in parallel X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Thu, 29 Oct 2026 17:03:40 +0300, Andrey Zhadchenko wrote: > teach __handle_md_page() to work around -EEXIST by retrying. Item 3 of the cover letter reply: say in the message what fails without this patch, and add a Fixes tag for 412d5a4f7bf1b ("dm/dm-qcow2: add llseek_hole"). Why: the race is already there. qcow2_llseek_hole() runs parse_metadata() in process context, in parallel with the main kwork. When both miss the same md page, the one that loses the insert gets -EEXIST: a guest I/O ends with EIO, or lseek returns -EEXIST. So this is a fix on its own, not only a preparation for the fast path. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel