From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 721CF811BB for ; Thu, 5 Nov 2026 12:55:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5CsRZA005010; Thu, 5 Nov 2026 15:54:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5CsRZA005010 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ej7rwGt9" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5CsQSU005002 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 15:54:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5CsQSU005002 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a1f03f2e8aso21480535e9.1 for ; Thu, 05 Nov 2026 04:54:26 -0800 (PST) X-Gm-Message-State: APuU4Z/bkbcrbNhfclFPZuZ5qBAAVbGQ81c0UkqXtCPjx3K/1DuGIfRw +0Kjgz4Yp6B1CW9NinOOgFkTodb7IKSOxpADwa67Mn98CkWzXS1QKaX2lyZCEoWU/yOCgWgsFMO +xMTZIwyKO3vT3jLArSKS5XMpr/YMCXOMdVo8Ki/vV6UKuViKArI+XQ== X-Gm-Gg: AYBFou2AsczRcIONwiZ64Zs2NeDvIfTeRme5c8Z6z9XDT0BvoW0n3M3EegIRkrSrQL8 nsB6hfg/W+MTUSN9Kjc3R/ZdmTdOr2MclwibwmkAwPUHqjmSJVSPKiphNMuuOgybiBSqofHZVEq pXeNlKxNUoYGEkG4G0J21u561P6Z2Etto/bQdFFOMoqnLLhWySEECNtHpJvnUtSPw/SmFK2UMDz lUycgcPjBVV4AP9DH2WWeYcvT8z+SwqTdG+L8r0GwYupZBG+4v457muDFt9T7Njt/oULEXV58a9 ngbTfl4qLb5cMot0vZUwIi5RzDBJZO+7/AEqvsBG/SNWgdN7ztXR66ZxxW/LV2QKSq8TWdPVAVL F2g3CjWBogqNE39RG/Q== X-Received: by 2002:a05:600c:354a:b0:4a3:5aee:2c25 with SMTP id 5b1f17b1804b1-4ac181e759dmr443135445e9.31.1793883265837; Thu, 05 Nov 2026 04:54:25 -0800 (PST) X-Received: by 2002:a05:600c:354a:b0:4a3:5aee:2c25 with SMTP id 5b1f17b1804b1-4ac181e759dmr443135085e9.31.1793883265393; Thu, 05 Nov 2026 04:54:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793883265; cv=none; d=google.com; s=arc-20260327; b=TVHnSpaXbvcpdOcrJOXwVAM9Xsn7ixwdmF0Oq4WyW5EeGXbjDQFF3SL8nQ2DZLj2sA j5sOiD/8qSOmjfsd2Jx8+fEwXLexmZKo+3EWt7W8hl3AAv+HlphYU7Zwd+JtAKsY8pYF ZEfbmAEnW4gXvhVpCiMe9pWnQW6BV4N/mKOTzMsuoQoPrTsrej9s34T+sMF29HvWPSXQ qJ+vf5ewtGvpsA35MAM2rkKYN95II1+gFeRWXTudXJw7gLn+LZTb3WSZ+PG+XVwc0RLP iuVTJ8BBMb6ZuECH48koZmwvRYDG7IfmdqWPm7/DeSKxCqJ2/jmRe7/m2ma/VhfQkDlB 8CVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=Y/r3hDrRLUSCxQ++65DTxw3lAOAZYUahQa4IwJKM+yQ=; fh=5AmFLEo6nHxL6WDW39LXC01IwU+CKjcYMpOuqqVTSIM=; b=rMvhhqMApnfqbNzXX1lkmq3QZE//RJoe1SDYNeWAgvNEmrqh1hXnMVvPr/fdPoKolh pNtfuQiobEksWgThNc19d1axnogpcb8jAb8XcJysq9BB7dPKGbBK6fxoMGgmkVt95R6Z GNk+V7x+LF8aWc12uTwwz3UBCPGEM4WxNcNFq5khr/+DDb1Pz+pMRpqcEO3sN/JvyVm8 fm+E1FngXNjVAHTkOpBQn6Sj8G7g05iGpuUx3AlVCzuQwZFx57AjFLCllZwKc9Iehulq 1W6muXJ5NgS5W8cVvJGGmEVU2zv9Qg5Yo/VGga0MSuzK4eFBYgqvpGBndM0ub0r3apon oZDw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ej7rwGt9; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4b57231ac41si64908945e9.8.2026.11.05.04.54.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 04:54:25 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ej7rwGt9; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=Y/r3hDrRLUSCxQ++65DTxw3lAOAZYUahQa4IwJKM+yQ=; b=ej7rwGt9b4ix Iwvv/rz1fprnjA89r3LpXYQ2ChNsm2kQlvK2hf6axV6+b0TMVfZiIHTdxw5rle+Fxfremxg9h8Rm7 270O3Fx515BxlOLJoZaxLOcuxxOdfSAEc2n5u0GrDlvpO0HqcUF2ombB8VpoCRZh0F5VXwcSq883b POVSvPc15Uv2n7kI9PkVIXTjHlfm52/IM93ZBo+4gl3SJvjZ/+aoIeVo2mwSmuCGmZ87YLK+BsztF 8Bu9TQ426SHVivmdS+4uyLIUgu/Zfn+OQptik8W6OWuG7L6u3v3md5MF/GwjGM4Kg0YnO/wECCCBz 73vcqPSj9oQg9z4sGLmsVw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOwv4-000XtP-1s; Thu, 05 Nov 2026 13:54:22 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Andrey Drobyshev In-Reply-To: <20261105121733.643754-1-andrey.drobyshev@virtuozzo.com> References: <20261105121733.643754-1-andrey.drobyshev@virtuozzo.com> Date: Thu, 05 Nov 2026 13:54:22 +0100 Message-Id: <179388326205.2823727.6822264109965139869.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1770; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=lKGl7GqjVM02j3gmDJYsH6jCQnmZs6QxLsOeHZTZbdo=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq7Hx/ACL9u53wVMXb6tLiDLtWbsfpHRWC1MRii ramI4WljlSJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaux8fwAKCRBRlgpH+WFc KqRID/4jxlyDDUR9vm6EF1e0+Z2i+I8YjK1qjMDHzZwVyLBa3Q+XNQMKfnNrPR9ees3nL19/INf GGoydvIGKHHz2Rm+6iVLcrSO5DWjqB2F/szg1eKE9mgtiyeef2GR5vKZBSpPDdqYoc+aOSlxWya n2cSnSNicJzpOMQrWYlZrPqT2aT5n/86Q6CTN8fFkA2MDEWMYJVg1QLqmfjxQH7r+mxjHjH1dTF Qgj9iu8maSFPDjAv4t4tX+jh6fCQyYWhS7HQulsnPqDmXvNRFPczOEpnvQrVV2WnB95v87CuXQk lDtifLbJggcG2WZ/64xHnIen784+zHJ75ja0VjLv7H8OONK8t7cEZJ9vNvuG7Yntiz+QnXoe2jP L1l/L/r2VxMFnf4RbLcF63mtGxGTzEHCcFIFnH7yLRPQGd9pchTlMNRxbad6uXihhrh75ofA7MQ dKk00Hi3AI4YTf7o0107eMLbPcYMby+L0Y9ZW+JlTOZ5kyuD6yhhcXKsLEI+b0kR87do5V1qyXZ 9jRskB8ngw5SckB8+4T6m86fagTxTw9Hx7RyISjfpw1A6lAh+2KxBoIvfqCEaZkjWuTGSgZNsez 2DPC85GTzNRbGEij+nuttf/qt3JLtjECpO1XzJqFhj7XyHJa2xRNo7RKNXILb1hBkeGf4lAW1TX lKcw8fG/5VgJIvg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 0/2] vfio, KVM: kvm reference leak and debugfs clash on live update X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Thu, 5 Nov 2026 14:17:31 +0200, Andrey Drobyshev wrote: > Patch 1 takes that reference only for the drivers that read > device->kvm. Patch 2 removes the debugfs directory when the VM's fd > is released. Patch 1 is right in the code now, thanks. What to change for v3: 1. Patch 1, code comment and commit message: the three drivers read device->kvm in open_device(), not after it, and vfio_ap reads it only there. Say also that device->kvm stays NULL for a driver without the flag, not only that no reference is taken. 2. Patch 1, commit message: say how you checked that nvidia-vgpu-vfio does not read device->kvm. 3. Patch 2: test patch 1 alone. With it, nothing should keep the old VM alive across cpr-exec on your setup, so the duplicate directory should be gone too. If it is, drop patch 2. If it is not, the message has to name what still holds the VM, since "VFIO keeps a reference" is no longer true for your driver. 4. Patch 2, code, if it stays: rename the directory with debugfs_change_name() to a name that cannot clash, instead of removing it. Removing it opens a use-after-free on powerpc. A rename also keeps STATS_PATH and the vcpu stats, so the "Two things change" paragraph goes away. 5. Both patches: drop "Assisted-by: LLM" from the commits, since 2026-10-22 it goes only into the cover letter, as one line before the sign-off. 6. Cover letter: single space after a period (three places), the Assisted-by line, and the result of item 3. Say what "no mismatches" compares, or drop it. Details are in the replies to the patches. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel