From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7854580E7E for ; Thu, 5 Nov 2026 13:00:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5Cx2CN005073; Thu, 5 Nov 2026 15:59:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5Cx2CN005073 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="SCgDSEUc" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5CwraF005047 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 15:58:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5CwraF005047 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4918bc20249so494079f8f.1 for ; Thu, 05 Nov 2026 04:58:53 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBw6aSjHu60oYYQ+lV+Z4HBCT1KsTXEwEZLI0zb7CFhWykTQr9mPbaihslyzhMpzd7tyXJ5ksA==@openvz.org X-Gm-Message-State: APuU4Z8mFflS0EXb2w5naD2FHOVVCGx+fktzyuMxvk9nkcT8h/JP40EX lg5HV8T36jp7imdpKYzqVF8JhoRCGQ+xzBe1Fi1zy+puLlHbrEKQICu7dQaVxGqQdnVcJ6NBTac hIgCXF5BJcNVakzaJ9dRkbXjv3QpdSWYshm9qKArzJ6+wICYNfVhbVw== X-Gm-Gg: AYBFou3V7yBhLVKPhlldYPTgafnhQ1uaLP6lFtkniULUdN8hpLRx06wg4DjjpTR54rT CDgptsp1AWcPavU+t8TQjYYQXj8vyjKQSN7Y7kamjh0Ocxrl05OugqiJxTOcts/JE8A+w+s5Afh XqrU0od+t9dYhdEEhVVJa515Nfu8Vr6XjfrWe48kDLAFnubuxsbgIjzQulHfpVTeqNzmC/jnSnH F4B17WqRRpkzHTO+b+1aTRN2pJ51Iu9qqkSujR0jj9lTgT3IvetGkdMY8YrqgYdkjaa4mcf7Tfs /LASQWoSMfPbh6tRTVczejwtAaSDDMhndWwSgNUP78jUBmukWrXjEz0v/bCSfjjMyAKyhO1zpFe 1Se6zWX12AcrODza5 X-Received: by 2002:a05:6000:41c8:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48e6e2bc714mr41509180f8f.7.1793883532699; Thu, 05 Nov 2026 04:58:52 -0800 (PST) X-Received: by 2002:a05:6000:41c8:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48e6e2bc714mr41509157f8f.7.1793883532254; Thu, 05 Nov 2026 04:58:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793883532; cv=none; d=google.com; s=arc-20260327; b=gWMPVdyUW8piYfKr9ZqLj1vWB+ioixImhgaMUYI1oyjZqnK4fK4/7jBYUjXmsTH4P8 B4x69taJ8W/M5DGQrACtMsgCwny0/Dkx6+5WcowGhAtHTfPQXPY3sl9ZLOore7RO89fB p3Q2gMsendYA+d9Uuf0ypDEPCp5+jeqT/w1B3D4bxCjC+/a040UErpkYoqrSUf089orw /ixMFZ7XMTJHgp3XqAXdgGqy2iSI95THGU+QHJP+Hb+exF3twVkc5J5oqoDvaH7cjSgz EhbGSMWxTwpjLzJIMfy7Hw5DrkKFNahgrnX6VTel9CM1Qzw+SFyTRU0YEi1LChoO5Xsw rT0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=BQeHVVO6hvEFXIeZfxBLg0sfM75MdQCHg4NZoFmV/cY=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=gEUMHj8frlhyfhoQVkDmMaHAxtP3RCpVD00eCdONp5bMVqj8k31KTN9DdTSof5k5rH YlroOm+4xPHnjwRiRJWVL28qoaYzgo2dKZAribpidtOzF9XqzVIDyPwlww3ZsgD5Qmbv kucGW5zOFd+HD1EpCtNFGKG6Dp6J6RpcZTLtVTVKwVQ6cPjYD2vAVSmIXpSrFmj46UYk 1mnFYuHyO3UFx5J33BbbVfSb0acd5TwrrSPQ5IQeRhWwmOeL76d3JXCMbZhdm57gvvhH DB3q0mmtvrjIE4HaYas7yqIx18u2BwTea+uSAxCL6L8ab9D6Y8NOidYTDHwmAMrvaKOU LgOw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SCgDSEUc; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48ff0256631si10130047f8f.413.2026.11.05.04.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 04:58:52 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=SCgDSEUc; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=BQeHVVO6hvEFXIeZfxBLg0sfM75MdQCHg4NZoFmV/cY=; b=SCgDSEUcCVSs zXrxbM5n9HtUNIG08svyJb3YM7vgtTtwolpEuuQrwFrSnrEbYErNKKuIRETMqli8NQoIG46bGuePM +jwuE/Nt7TaFR7o/x2k1w3GyK0pUWAteK9CNQUBE2eQ/FY4vZ5yyvq/Q6iYYZAiVP6fwmgnuJVsr9 fdhD8DaLKFuAb4MEVslxOTbOt8NNAhmA8x3y1Tvc3AM5HKNwzcH7lSjwunJpeVOeV+h3J9UX+frWY 5u9iUbJEnGQojBeavWJi9Ov06w2TAcLYAKpA8aYZ1X/Tr142K4OHEkNlPClMKStgeoDGy1VBXXVLJ wWArABsNP1h9z8MGKNlu9w==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOwzN-000dV9-1l; Thu, 05 Nov 2026 13:58:49 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261104214635.2063009-1-den@openvz.org> References: <20261104214635.2063009-1-den@openvz.org> Date: Thu, 05 Nov 2026 13:58:48 +0100 Message-Id: <179388352808.2823727.5128052268835879184.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2292; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=XmEJKJ0HSlwRgyMqpwq2LU7bZsLVtPGJzYzUyhj1nBg=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq7H2K+vNyiFQVNkkSbnGdxkmHZcpxc3bloFVD+ s5aDvSbB0mJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaux9igAKCRBRlgpH+WFc KqAvD/9UoZAMojj+DWUOozRkBurRbX8ZmJwUt9t99aTZ9puvR8xYgqq6IRSjkFh8EgoVEI8TRV3 uN1lh0bL2HrAC3/x9Ikysnzhr01BHGNUlsK8v/BCijo5IzidXbdQEfzUVSegVfrRSbMOk2lMqaH KfgqeXkD1AKe02BKHFZwfLzr9ASxvjrHUPM806Gk4fiCinLGKyaLprPAa57FbSJ6RghzxDcZt3c i74zthv6jIXPigHlb342vVcq8ea3eTB9CEOauPj+avcw5BIB4YOEmGm0RGJH8+aoc5nxCnWxH2p qsQA4pMmr2D5hw1eljo0Egzr8SHrR8K5JnVrRzrs/z3QRiVmM58cyU/7dNBOM47hpTflsZrUJT8 m95a3KxjExhYxXBZr6kWYNEELFl8Z+3tQHLr/MTt8PBiKaNhZLi9Xv51QIY+4cGr8Ka5V4MBxGY 30Z3HuF5wT9AtMmEkKu+dUABBpiAw0+QyNUXakar1ded6DEHyyTcN/AoqofWrHsZZ2o65mZviT7 wrsnjfiU/jcP+61CNYVFdSloidOBDYnBilhfnvR8Lbc6sUyVOT+VbdjRpHmwa1ll1CLiId/+DvP KLs3HDai2l+mhzuFUmUiZ3B/Z3Qu0xaRp6YXhnJu6logcYMq3ZGS1RztL5aoV1zjJdFT+wa6USa 0Pmo22BP+Wa8DWA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/2] dm-ploop: fix flip_upper_deltas panicking the host in its pre-flip check X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Wed, 04 Nov 2026 22:46:33 +0100, Denis V. Lunev wrote: > Denis V. Lunev (2): > dm-ploop: fix flip_upper_deltas returning with two md_locks held > dm-ploop: fix flip_upper_deltas walking past the BAT of the lower > delta What to change for v2: 1. Patch 1 and the cover letter, message only: drop the read-only and EACCES argument for the library. The code of patch 1 stays as is. 2. Patch 2, code: refuse the flip when the lower delta covers fewer BAT entries than the device. Keep the `end` fix. A separate patch placed before 2/2 is fine too. 3. Patch 2, message: "the stop never matches" is not exact, and the first paragraph needs splitting. 4. Cover letter: redo the grow test with writes past the old size after the flip. Details on items 1-3 are in the replies to the patches. Below are the details on items 1 and 4. > Neither is reached through the ploop library. Its reverse merge, the > only sender of the flip, grows the lower delta to the size of the top > and clears the clusters both deltas map before it flips, and a device it > mounted has the lower delta read-only, which the flip refuses with > EACCES before the check. Both take a flip of a table built with the > lower delta read-write, so VSTOR-153445 has no RK for 8.0. This is the Item 1. reverse_merge_online() reloads the table with PLOOP_RELOAD_RW2 right before it suspends and flips, so every library flip passes the EACCES check and runs ploop_check_delta_before_flip(). The library is safe only because it grows the lower delta and zeroes the shared clusters with the device suspended. The "no RK" conclusion holds, the reason given for it does not. > - set_noresume, suspend, a grow to 2T and flip_upper_deltas: the stock > module oopses at ploop_check_delta_before_flip+0x86, with the series > the flip completes and the images keep their data; Item 4. With patch 2 alone this flip completes with a new top smaller than the device, and the first BAT writeback after resume damages it (see the reply to patch 2). The test checked the data right after the flip, before any write reached the new top. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel