From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2064980E7E for ; Thu, 5 Nov 2026 13:00:15 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5CwwD9005066; Thu, 5 Nov 2026 15:58:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5CwwD9005066 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="JR//M0oC" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5CwrGX005049 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 15:58:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5CwrGX005049 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a77c1cbd15so21819365e9.0 for ; Thu, 05 Nov 2026 04:58:53 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxeb/S3DwIMS9nwuAk4hZo9FyWDMKsrlQoDHN31Wyvn1QCipjYxrQ6B2dXC/GY3UaNXROeRbQ==@openvz.org X-Gm-Message-State: APuU4Z+BwoVRsVGeSbC74iFGbIubxWe7VQLUd5VNWqpD6kK2KN1dzqxD PHN4MgG7YKYdlwt7yG+IlKwlIJC7slojWcdq5kJ2d6pN1aYRDE7qPSTH5iDq/ryoHEYsnDFI9+O Di8wrgeBPIV09vZ+SvtyUj8dkF3IpJadvztozC6cPeHw4/r0Y7wiEwA== X-Gm-Gg: AYBFou3dTqiy0F3NeL5SaNj4SF9niHYRyPxmWDC+qBuIx3EDYZyJCN8VyJEgc9hbujf maZb5FZzvMVaWhwwhwCzRteIrjoc4QUCnoFZiJl6ouCnA4T50gOYAYnydfCtZNYQiaud0Sgl6Qr 4praVGioN9Co9UdBhzMmTSalDZUgvN+ol+UIyrGwKpW/SXSa2wUIN1cX+C+NInMqjZeAMDII6Ng 0RBpBHU6ci5NKPzEpDnvH39F+6/BaAbKOYO/RmP7JTqGiiwgJclDiKgcLwm0s5wGE8wzE1MdDdA PfdIKgH1eYr+gIGg+i5d3HyZ2CxkXHJAPTPsquIFyYPGtFwQfDQF9k+WdGQ20quiuKgwJQV5x/Q Uq7sfvJg7T/uNlkMT X-Received: by 2002:a05:600c:c088:b0:4ac:da92:2bd4 with SMTP id 5b1f17b1804b1-4acda922e24mr305406785e9.1.1793883532919; Thu, 05 Nov 2026 04:58:52 -0800 (PST) X-Received: by 2002:a05:600c:c088:b0:4ac:da92:2bd4 with SMTP id 5b1f17b1804b1-4acda922e24mr305406585e9.1.1793883532443; Thu, 05 Nov 2026 04:58:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793883532; cv=none; d=google.com; s=arc-20260327; b=DOPdb2XWHiguRAg0cH89rw8y5YpBrdH8a7yhQtY3/S0JGpLponV7qz42Ku/vhQNnsT 75JWdj4MMIpUDFDngJTI5qbpM+WeTp475Ok6AQuyCYCPiJXjipPGWeyA+MUebU3wZsDZ LqaYwUfFNTerdL2OjfCx+3ZVIiF34s+auYuti0dhKott7MmBoVzYttJZKVslRPFhTghT pIBiihsKG9eK5N83IX7yR+lEjy/y3IHrgUMUN2nJ5LDiIzAraIgKw0uIliw7+DMvLP5J Af9lKLa5QzrktCEDSkn3h1RXeO3GMeSBhbCLyGbQhW23H18HjyF/bYBpbhn3TuaUoNAn Mq3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=bO9CmTIuxodP6YAWwn2v8cgHPU3a5SxSPs1Z29iVH8Q=; fh=wjIBJwS4A72E5Ce5VjfhniUGUVdfOyxDI2ywJwwowhw=; b=sV3oG75Jx7HhtwBgVzs+SWRB2cUtqhul5EckRDWM4e4fjrh677sAnQppmw/wK55RcU OJEbObihDtBXtJ8p23xjyI/u2zasWduVU9trXYUtvmmyv6He8TGnI5yedEjfzXqfL1KK DVvnFOrR824wi/tnrizmxq5XNrg6frqZb/rbodtNqsxJXGizG8ArHv7tLKNldsI6WWc8 Vpd3jspazrDSySmf/VJEO6x0Dza1gjcknmRIQeuD48rZ3Do4hDs/7YJvVbLSxbZHK3Ub Kf8ji3QbMRWZk3SBiuA12t1UUWI7EMYjGvNJ+cB+Wyv8Zt2NSqFQU0WsdI3mRfWwOMKj +WUg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="JR//M0oC"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49077c53dfcsi7936654f8f.314.2026.11.05.04.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 04:58:52 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="JR//M0oC"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=bO9CmTIuxodP6YAWwn2v8cgHPU3a5SxSPs1Z29iVH8Q=; b=JR//M0oC4KwB udXPzjOYI7HjvHcj4DEh4sDwmxtV23PSWM6B4asHS1TJ6i45hFf506kPVcQjSbKoORVsvpaT/JOqN 5QyP/efNihhWjzqTfrevrnE9beQzVgzKrsjblO5cXj0X70/jNhxR4vHMyo5AYYdO9olbvuGn/qqLZ OApyVEQaNhw37tXy/W8EIvpUjhGnHSXdKzx8O/SMnG8Ab9yf/yIuKD6qDHE3glY6pEq1rXp+O7cSV dwDI9PbU3GzsD4gn34aBxBpJSaoUUhrMMOjDDyesHSJNuNZMipWn4/i8D5IFKJU0U5l3MPi6MbXvK 0CF6WRM3No0ZfzYs4BVoNw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOwzN-000dV9-2I; Thu, 05 Nov 2026 13:58:49 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261104214635.2063009-2-den@openvz.org> References: <20261104214635.2063009-1-den@openvz.org> <20261104214635.2063009-2-den@openvz.org> Date: Thu, 05 Nov 2026 13:58:48 +0100 Message-Id: <179388352808.2823727.6444206565446181314.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=897; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=vcG+uI25Sw3pspwOBWocXfv3KR0hb3PwFeXLQTD+7/k=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq7H2LPm7gwRW3JsnkEfGkZscS0CL5cMt8fMcbt IJdoIiUhGyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaux9iwAKCRBRlgpH+WFc Kii5D/wM9wtQYUGMyhyeSgOkw2Dq7HGluGbsuwuEjxLzBblgKwyosnUa8PRZU93bSgVWhH3kh2Y hkbomGDJcFitrhbkHuuTVp+OG90TqoBYunz6EBq8GsLyEognPtIZ6pfSzldtTezD21H5K1V3LFx I6a5T3lygsXAW28DGn2C2sKHSaLgRbk8xRl9spcOumXA8InwQMWQjyeweAK2N5Xu8LQL1zEQhZJ 5y6PBzr7aX83FgR/Rkso1uJgiqJmSNim06x4tBDYvIipht5zP0K70rhG6CVwOoGVkwmgK6NzK0K ARhX0q3X+548pu1tymyrTHxxldCxQt17gc3KFlbEmzI4YD41sKNZxCxTRG2bwI38ztbe8lBtJfY maJyXSxJ8wJFTuBTz+vQxkzdp+aJG7Fq/C2WqzTBMPvzCugpXIhaIs+M024qJe0PpeQ9C2i0ddU TXQdHCQlwpHUyp3Gks08sMcb8Zx5IE7CWT8Tp5hURRLgQqHjJJ8mBrYzcw1aWbazvPVN6VB5llH LfypHkycubBXNVBwpsGmTTNb9iOjCp/VC1eDy/B/HvM4hDi2ERZVubFTdnxtu2iLJkheo8LUFai q7nJ0hQQ+tAr124/0KFHKTl9wdVnoPxCIN7KD1Gj7pRG3HenEjmL0k6YUIA/jNIJU7yPCb5d+py NREUhRN8OUtWFAA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/2] dm-ploop: fix flip_upper_deltas returning with two md_locks held X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Wed, 04 Nov 2026 22:46:34 +0100, Denis V. Lunev wrote: > there. The ploop library does not: its reverse merge clears those > entries in the lower delta before it flips, and a device it mounted has > the lower delta read-only, which the flip refuses before the check. - drop "and a device it mounted has the lower delta read-only, which the flip refuses before the check". Item 1 of the cover letter reply. The library reloads the table with PLOOP_RELOAD_RW2 before the flip, so the lower delta is read-write and the check runs on every library flip. Clearing the shared entries with the device suspended is what keeps the library away from this path. The code is fine. With that fixed: Reviewed-by: Konstantin Khorenko -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel