From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7FD058017D for ; Thu, 5 Nov 2026 13:06:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5D5ZNI005113; Thu, 5 Nov 2026 16:05:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5D5ZNI005113 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="bM/aABW/" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5D5X0a005109 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 16:05:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5D5X0a005109 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4918bc20249so499528f8f.1 for ; Thu, 05 Nov 2026 05:05:33 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzCBifqovGdj4BQ7EnEWe0MrXoyiDx25M4qyl70ercdA8HJoAExee8lKB7n2TuIV3ouGU2IRg==@openvz.org X-Gm-Message-State: APuU4Z/m/ueqPkhTkvjRUUAeRUQxAlAUCZsb8coweb4MbXxEfEkyq/+Z Qypo2O+rPOU+0u9SOqK8dkr36eVc7omzZJS7uxb5LvUQ3ZnFmvAEh3IXe/ZI38zSo+t+jXT+nox 85zbJr/fLug583JUPfOBjRdL00JOOT5TyNXsMO6hv+gAJZ6hdSnbmxQ== X-Gm-Gg: AYBFou0oC/XZNG9+Y/L4trrQjstHKb/aj9FniTkQGPUqDjIt5M6nB/5kvtDrlzodakr L1rqEDvz9CML9uncPLAp+59DzrLV9/MKvFyQC14Ouc0b9rmbSfLj64eVAQE+rYL7XeITVc57CDR l/QI2SEmy250lr+tteAHRQwqdrk+VnAcfKzQw/0IZyUbLYxKPbll9zBbKrSoqyNMryUKDpZr57r /tAGr1+z/ANmC/xiMKDOac+20B9ZB/T1v4dHGxH53ukhyQuqsaPR8LCcNbgJhMovjewl1XxMLjG epZzcL3IyIWjnlAgnJzYk5P2A0SUS3fGs1yn6h28dE3ZNodG7a2cJ3AJkXhTVW5d3jd2GRYu7bD wiQCC8IC5HMCcF8ng X-Received: by 2002:a05:600c:858b:b0:4af:9cae:df63 with SMTP id 5b1f17b1804b1-4af9caedf69mr237018925e9.31.1793883932879; Thu, 05 Nov 2026 05:05:32 -0800 (PST) X-Received: by 2002:a05:600c:858b:b0:4af:9cae:df63 with SMTP id 5b1f17b1804b1-4af9caedf69mr237018305e9.31.1793883932157; Thu, 05 Nov 2026 05:05:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793883932; cv=none; d=google.com; s=arc-20260327; b=V/scfu5j8hhaTtMR01JTow4BO/hiSRN19KQmCwgDsv7Fm5k7aIXy3xCVhTDKZH3w4o U5o9u/OhoM6Of/KvQ6gZV3CNOWWidCfkB1u0cC9ac9uoORyNfNy9V81MnTg1Q5xH25D7 0cLbrSqW17a/OEwulEEBNxn/rMtSQIP6dobhcmCwTW6EUIRVdpPphW3RD5wu22m9KTLZ BkEWcFgJDfhefIUXpr3htPRNDYUiLM4QXNT5Rxs+PuvC/wOEkWoGYXSOepSypx15cvGe JE+e+HVsv8wRlU8S0dyZuSpEOmkKAd7TbTn5GbcMVNeMOqa1lFWH8xTKMO0100fCejQS ouuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=ToICCs6R8grFcy3lmS4rdK7sB0k3zcIoWrPLzOeLrlo=; fh=8+L1GLzK3OTQKnTfH5/my9NmwzU+1/k679YBeB1tMzs=; b=st2MvXhThTPVY7bm5xrfPX8aSsU7CQDBspTLmS8RYryR7opV0iqYeW/Rz8NzA5f/M6 mbHST5L2zWUv4AXvSteo5RVbHnIeKiWyaSXREo7qRLnesqCzS4UeyHIoRtmyQNCFOyPl aYrOHiF8mIlGVpX57YZUwgVhaePzqTkKtJDgCJ2XEpzmfnWgxz1UpQiAgn8+/6qGaVpH 66WqSqCXVnjMDNkc1yP7VldhDQhPZOxxeOjrZv7RH3c+MFwuC25pFZVnaI0jPVQYgwy9 hlQN+HM0BK8Qh8mlDXZD6d/yCWAEMqE0hjTc5i9GAgJZoTDOTTiqjup8XGy/34p2niU1 8ADA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="bM/aABW/"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48ff034c172si9761444f8f.432.2026.11.05.05.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 05:05:32 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="bM/aABW/"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=ToICCs6R8grFcy3lmS4rdK7sB0k3zcIoWrPLzOeLrlo=; b=bM/aABW/UVi+ E+Nzs159kGxmFO9Ex3np7dWKL/XbvQfteCUWOgAO+0iyDxr0AEJy9YGUZEsnHzv0NaxzyIHqvblwl eCi8/EGZp7mByXG2qrhPWn3V4JfMaTVDYdCxM/84SdszCrgQkQ3u+8c52UYDgiSp99fBWL1klTZSg tRhHiukVsisK7WqmPgaQecHsBJT72hS1S+mRIy8czS/TR6BIUrD9x7Dg+9sJ/BleyGTQBEZ9xf9pM Iwr213uu/te9up9y6j/whJe1I/aj7tnnleuzKVrnyEpCOe0tgF9S3erj22d0dEhqwZTRmC+YmJsDP 8rWzx3YEvlrF6H2zUV6txA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOx5p-000lYg-05; Thu, 05 Nov 2026 14:05:29 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: "Denis V. Lunev" In-Reply-To: <20261104200755.1956316-1-den@openvz.org> References: <20261104200755.1956316-1-den@openvz.org> Date: Thu, 05 Nov 2026 14:05:28 +0100 Message-Id: <179388392864.2823727.6720156248130473834.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1186; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=Nrc69chS0oPIv4BSl3GnSklmnl64wCfX++9S2ZjlcV4=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq7H8ayg9BDjoYqrfERrn8scyOh1eyxwHZucnIV DXZqZgetaWJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCaux/GgAKCRBRlgpH+WFc KsK8D/0ayQpVE6hzkZUfUw+chCW90sIdZQsLpdjTUn/DWShDGl4J3KdHIny2CPRUgjHP5OQdHvN 1qvg20WDoHFLrFYBeXLhOTArlGDlF+K5M+ppAFTtRfLRbVYZmMIxwN0WuyoGurkhszp+VaYAWBk 4E+u+ASEAe7qCckJH+ivEIbmJ3IU4JNlSLkKIwHLYHuj37OUkLZENGSPfA1YVmE+LBPBiDhwu7x LQ/R8HmlNrhcJZJs+VWr28nIaAh+wXXbzVNqLv9yhTdeqRWTfUtjHtflHdZEv5WCJzEfsvsaOb+ ait5EohdAT3JMeSicJVpRoHxJLAnHkecAw0X1B1gOF678k4s5IZHZpAiYoT3jKH3nIQTsZZrD4I YW6Kel2E9RV3/4UYJDeYTo7jzfLv3kRPCOqMD296a9P2D7zBvjlNFfYMUAC+evVJ9yiJlPfQliM ifNE+KX2nFaW6QujwOxFrh/k4GOVD5w8JHGsPECKcxl8eX0xUAsTHRKlFGeedWXmtwjHV4KmKYr 6XIN0xtwZK4WC63j06E7cEXzGBwDEcEnVtQV0NcfqwfEnGExa5JiYSr9rMgNfjRV8KywhNxDXFH MENgwnZd7KQqrPx73mWU0L+n3VyD7D5UetpZ8niA1NGoyEUth727JdOfViS64DuAMGl0AFUB36a fkTknGS9h11Rkiw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] net/ip6_gre: fix a host panic adding ip6gre in a CT without ipgre X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying as is. On Wed, 4 Nov 2026 21:07:55 +0100, Denis V. Lunev wrote: > - ip6gre_netlink_parms(data, &nt->parms); > ign = net_generic(net, ip6gre_net_id); > +#ifdef CONFIG_VE > + if (!ign) /* no VE_FEATURE_IPGRE */ > + return -EACCES; > +#endif - Please send a separate patch for ip6gre_dellink(), it has the same NULL ign. I have already created a task for it: https://virtuozzo.atlassian.net/browse/VSTOR-153615 ip6gre_dellink() takes ign from dev_net(dev), not from t->net as changelink, uninit and the ioctl path do. Only the fallback device is netns_immutable, and moving a device into another netns does not check VE_FEATURE_IPGRE. So the host can do ip link add t6 type ip6gre local A remote B ip link set t6 netns and then "ip link del t6" in the CT, or just stopping the CT, reads ign->fb_tunnel_dev through a NULL ign and oopses the node. Only kind ip6gre has ->dellink, ip6gretap and ip6erspan are fine. Taking ign from t->net there is enough, mainline did the same in b7c0d393e108a ("ip6_gre: Unlink ip6gre_tunnel_unlink() from ->dellink()."). -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel