From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9024881377 for ; Mon, 9 Nov 2026 15:44:00 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9FgjTK000947; Mon, 9 Nov 2026 18:42:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9FgjTK000947 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lZtw09iF" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9FgiR9000927 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 18:42:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9FgiR9000927 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490d2ac331bso908403f8f.0 for ; Mon, 09 Nov 2026 07:42:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGv+GamRfw1diC8dIx7FVsrIhVdxg5zgXEO6CAuaCi4UKZQgrnZEkt0ZasdIH1jaKN6Kg0Qew==@openvz.org X-Gm-Message-State: APuU4Z8X6jp9fI1qQ6lXU4t3sPMbqSHHJ94OaHrzUAqSPeqs4F2Ws0rw Idt05hW++XZBeKiaejQsBSFwHtVoaBXv00ijDx9J6wuumrvFKWn5duZ3yKW176Q21VXKuiglUOp 8eoJlRG3AAzxYEo/HwhmEnn5rRtYATAvk9ZhAKJrOBUctQh9Ri1sOkg== X-Gm-Gg: AYBFou3Xh8meOADffK6ZU0xVTfCNaLI7KQRd7RenIlGFPBWE+PsiCl+9vZMS88hOSBf RUqEzT8hv/SzgQcmaiQn2nDuwvxceDJTHyyBjzbytifV5np/tR71DUPR7hrpncbo2wf5peqqlSy Qz4JnRTlbQ6ms/eyuj15+rIRqlhs1ngX1oSHIvtWD7tXOPOWIRMJY7raNjSy1VqNwv4tKuv2rXo OPsRwVM08+bIAuGbj+rISKSuL1zdrlfwEmnKyJDiR0kxFRjR1w64EIohkIdQX7ANDSLUD4AxKTW GOnvnagMZpM4DtuCK9THekOKJaDZR+NDRIrgktUfv7J1a/kUZyq5/kOB62sucjCPck03WlNVyfS P7B90dOhhk0m4lg3P X-Received: by 2002:a05:600c:8b8c:b0:4b3:9540:47a6 with SMTP id 5b1f17b1804b1-4b963c9b6e2mr80998485e9.28.1794238964055; Mon, 09 Nov 2026 07:42:44 -0800 (PST) X-Received: by 2002:a05:600c:8b8c:b0:4b3:9540:47a6 with SMTP id 5b1f17b1804b1-4b963c9b6e2mr80998155e9.28.1794238963572; Mon, 09 Nov 2026 07:42:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794238963; cv=none; d=google.com; s=arc-20260327; b=kn2VjsUcOMv/I3zIqKg7TnyEX4tDyoiWrsbm743/b/KbThO0uZmmFWzP/yZQ4jDZ+m CQvgcTbJ94JXGR+kPJmkupO/ijVWN5el1MPLXMzfLs3a9jecE9HylZfQ5xTEiovGQiJi 1KlhCYxIfIhcTjK/q1Ekxc3t3KP6RXh+6RG63c6mh4wJt74nh5kIu3DnQSUE/z98m3p/ xaY+q66a3PinBylnv0tvHtqwSNAxuxte2wb7+d3DzhCTUOBGferjva3xMbwS+F5vZvG3 mlpjvbjuUIrOmQMp+3fYTyMMc8/R9Jmj8GvHfF+PS2ZYMrIeAZATar3tk+H03TkEZQXN 0Vew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=o/b9I+pq/AbQ2lqPPvLlH4W8KPuBh2Vb/pdWMlh+gn4=; fh=AXaEMap9UVXDT/x707nN5u9hAuW2OOlHA2h2MmC//Kg=; b=dd9iVF97GN/qy5rguR0NTeJq5skyoYZQ9VcZIe9A7B9MBXdEwvyZOcpv5E25Kd/XF3 OsfItKfRlZlWo/2YKNU+1dqqEFK0PBErj3qvOGkvAVjGLXQzhWdGhGYKtl0Kg8YUzUt7 PWmqQC+uCtCETpddOw0j0+3S+WM2jQ3k4TXOhgTjNAcAH7g+72QpHivcZg7kmaJItVuY vGpsIO8VQM9B4hcMBwg89W5SqXaO+HdFkNXmfsU+cV+vQOjbReRq8a8GV5us1eTqLtzy gGNRzynjU7AP8sjN02wG1bZWU5FnrMrxEbfCD9hEL9TPz1hjL+kwSDr4KLhxwj/WpjLB S/kg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lZtw09iF; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-496cbcb1663si4632582f8f.244.2026.11.09.07.42.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 07:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lZtw09iF; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=o/b9I+pq/AbQ2lqPPvLlH4W8KPuBh2Vb/pdWMlh+gn4=; b=lZtw09iFRJyf Aav9hSWfLF3JB9GOEaZMrfPSbRlLuUDhp7T9fcOaV2rHq9uc0N7XiXU3lqnl+pSI4bxcLapAirLKu kLizX2BpBwR+jFd2t4kXF85nJ0mBGdLHQ8u9LFNXZvXSHcnd5pskiH5tXlhBaXU1ZvqvZ7LdQrQ4F uDeGCQNmyNhBsx1gyatyYkVUlV4+oQSk7Qud6mF8MeZysiFnG8fRxCoTsAUQVLUoa+frNRQpi9iV6 aGwyLRzn4Svl35J6+pWLGf9+KkFsuXt1+470vTZgf8zBSt3L2+D12AgGLvY3omt4ROkNeUSlHKVFD ifL67ZW10NsHCFQ7iwJBIw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQRS2-007qJT-2V; Mon, 09 Nov 2026 16:42:34 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> Date: Mon, 09 Nov 2026 16:42:38 +0100 Message-Id: <179423895898.3398823.4144864009513938243.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2227; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=u0m6HBDvMr97Y9aKU3iSRrKXFkFzGfQFSYaa+rbx2h4=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq8enxCVItfXFkgnmJS+KrT9zz2BO8LotxOKjI9 aightG0xiCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavHp8QAKCRBRlgpH+WFc KkJRD/sG8J7k+CEQql20sAQOwNeb6Gr9lj5D/e3mhlcVsBcFA+QIobK2M0uAJakJDgJdQAPRYdQ HiHGfIrgGIOlSEUO1badXekmm0WAekcl//HJjo7yfGPbmgXfPZU9mEzx4WmaILV9oAqRWhfOq5p 8rr9DcqgAhcIrqgWnIdGvzCQYK/lQf/evP3LGTUUBCKNekxmKNfEe+ErCa1jlbU/3rFjjvSsIqG U3QdfDCD2G2ymhChvhyfgcOiUqVN1vhYnREKDIOEW4GrxWDAfD+vIUkcbRwd7Grl8M8kSDi9nK5 T53f0Zd9wg/+qNbVdoe2SgGERX4O7DhR8R4IOJ2JrU7HhldYVV5BmAs7a+cL4rC6jXRd36j7mhJ VL1H3r10VLkMp3Zil12qwUp13shyp20uarSQQOzltb4FdTKPEHh4+B/r2UkxQnDzhsZS5QB5AJn 8Rjsi1pbVtN7GE0jy2cT3oENEdVE1UvrxXeBMC3o2+Wtl6oSKXk/PTL16T4+MHr43U7J/opgKLO U8urSv6Nez+MKlUecZ5+F9oCDwf7PEYc6MZTIfDPWAinEX4hBx0730wBtWGycSttUbiVk6pmrHu I/4XJNxziv5jIziwt/Le6l9UBVv9LdezXg2KZjW4ixoEWrWMifTgdj+vHX8yqu3O2vu3Z/1QWC7 j/Yornnhf33MIeA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v11 00/10] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v12 with the changes below. On 11/9/26 15:01, Alexander Ivanov wrote: > Alexander Ivanov (10): > dm-qcow2: add qcow2_md_page_read_sync() helper > dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages > dm-qcow2: extend the file for a new refblock in allocate_cluster() > dm-qcow2: complete wbd before ending the data qio > dm-qcow2: flush lower md before clearing dirty bit on merge failure > dm-qcow2: keep the dirty bit of an image that needs check > dm-qcow2: flag the image for check if reftable relocation fails late > dm-qcow2: leak clusters allocated for a failed L1/L2 writeback > dm-qcow2: retry R1/R2 writeback that failed with ENOSPC > dm-qcow2: truncate unused tail of image on suspend What to change for v12: 1. Patch 8, code: in prepare_l1l2_allocation(), queue the qio that allocates an L2-table cluster for an L1 update on l1.md->wbd->dependent_list instead of l1.md->wait_list, so a failed L1 writeback ends it with the error instead of sending it back to allocate another cluster. The new loop in complete_wbd() then has to skip a qio without ext. 2. Patch 8, commit message: say what is leaked: one cluster per failed L1/L2 write of a request. 3. Patch 9, comment and commit message: a page that failed before the flush gets up to two attempts during it, not "once" or "one more try". MD_DIRTY is dropped when the write is submitted, not by the failure. 4. Patch 9, commit message: say that with patch 8 a request whose L2 write keeps failing with ENOSPC leaks one data cluster on every resubmission, until the space is back. 5. Patch 10, commit message: the scan is skipped on md_writeback_error, which a late reftable relocation failure (patch 7) sets too, not only a failed R1/R2 writeback. 6. Cover letter: the patch 9 line of the changelog says "once" as well, fix it as in item 3. Separate patches, not needed for v12: 1. A REQ_OP_FLUSH whose fsync fails with ENOSPC ends with BLK_STS_NOSPC, and qrq_endio() hits WARN_ON_ONCE(!op_is_write()) for it. This is older than the series. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel